4b3eba968b
update EntryParticipantLoader rating to return correct boolean
...
flag=react_discussions_post
fixes VICE-2328
When DiscussionEntryParticipant has a 0,1 for rating in the db,
it gets evaluated as true and false for nil.
This update correctly matches 0 and nil to false.
Thus the likes will toggle properly.
Test Plan:
1) go to anonymous (or non anonymous) discussion.
2) toggle the like button.
3) notice the button color and count toggle properly.
Change-Id: I70e9c093f431848c8b32dc026e890e1b295c551a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280528
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
2021-12-08 00:19:42 +00:00
c2cba46851
RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
...
[skip-stages=Flakey]
auto-corrected
Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
7e7bc924b7
RuboCop: Lint/MissingSuper
...
all manual
Change-Id: Ibc71a5265c81359925c7819ea694f3cb7cc3e542
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277540
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-08 14:15:35 +00:00
65d54bc7a8
Add report_type to DiscussionEntryParticipant query
...
fixes VICE-2072
flag=none
test plan:
- Specs pass
qa risk: low
Change-Id: Ie9d08e16d1c4996054ed6dd2d6e6a64d23973aa1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275762
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-10-15 13:09:24 +00:00
5e3e922307
RuboCop: Layout app
...
Change-Id: I4cf9600c9636a66509f1ab183b936381ea0aefb4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-22 19:35:01 +00:00
6a624356ea
update frontend to use new discussion entry participant type
...
closes VICE-1975
flag=none
test plan:
- No changes on Isolated view behavior
qa risk: low
Change-Id: I0691b523b688c679f1319bab0f662da28fe8c3d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273081
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-09-09 16:15:31 +00:00
be4cd3bb55
create discussion entry participant loader
...
closes VICE-1974
flag=none
test plan:
- Spec should pass
qa risk: low
Change-Id: I35b534bbf9edb9d4757878842c8d57d55b92697c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272409
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-09-03 14:01:58 +00:00
Chawn Neal