it's really just OpenStruct, which needs to be removed because it has
abysmal performance, and is being removed from Ruby 3.4
Change-Id: I9b692bfefaee7649cf117d846047e531a7e09309
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345718
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
flag=none
closes EVAL-3763
test plan:
- Create a course that contains a user with the student role, and a user
observing the student.
- Create an assignment, ensure Peer Reviews are enabled. Submit to
it as the student.
- View the assignment submission as the Observer, note that the
comment sidebar does not contain "As a peer reviewing student, you will
only see comments written by you.”
Change-Id: I2981e24a97f4f2f766bf2aa2dabcfb0bf54b6275
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334636
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
We no longer use fullstory, remove anything related to full story and
the empty privacy tab in settings. And now you know the rest of the
story... good day!
flag=none
test plan:
- specs pass
- confirm canvas loads in a browser
- comfirm account settings page loads in a browser
Change-Id: I0529bc7b0075e93c9766ac8a4a0c79197c988cf1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341147
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Jody Sailor
flag=assignment_edit_placement_not_on_announcements
closes INTEROP-8430
why: The assignment_edit placement displays content on gradeable content
types (assignments, discussions, quizzes). It looks like it is currently
displaying on the create/edit announcement page and it should be removed.
test plan:
- create an announcement in a course
- with flag on, assignment_edit placement is not displayed (check
edit page as well)
- with flag off, assignment_edit placement is displayed (check
edit page as well)
Change-Id: Ie46b12f1cf93f2f27cf3b6ef220b940187298fd9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340289
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LF-1093
flag=none
Test plan
- Test with g/336629
- Create a user
- Set up an admin
- Delete the user and verify you can search
for the user in the admin users area with
the checkbox selected
- Verify you can access the user
- Verify you can't access deleted users
from other accounts on the same shard
- Verify you can't access delete_me_frd users
- If possible, test without MRA and verify
this doesn't crash
Change-Id: If6bae7f94c83fab484820bd9554bd60f3baa2483
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335180
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Closes FOO-4165
flag=none
Test Plan:
Add a login to a user and see the extra fields are available
if the user has the right permissions (manage_sis).
Change-Id: I5526608ea2e16bbad5f08b5853b9534ef320d109
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335542
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
QA-Review: Jason Perry <jason.perry@instructure.com>
Product-Review: Jason Perry <jason.perry@instructure.com>
closes LF-699
flag=differentiated_modules
test plan:
- have the flag on and a course with some quizzes in it
- go to one of the quizzes, the Assign To button should
be there as per the design in the ticket
- click on the Assign To button. Expect the tray to open and
close properly, and to have the same functionality as it
does when opened from the modules page
- if the quiz has overrides, expect them to appear in
the tray
- ensure button does not show in student view or if the flag
is off
Change-Id: Iee1b33122f29ce7e067a97fb60a916e21b29b42d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/336340
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
When the observer_appointment_groups feature flag is enabled, add
a checkbox to account settings. This setting is inheritable but
not lockable (lower accounts inherit but can change a parent's
setting). When enabled, it will add a checkbox to the appointment
group creation workflow. If this is selected, observers in the course
can reserve an appointment slot. If the appointment group belongs to
multiple contexts, all the contexts' accounts must allow observers
to reserve appointment groups. If an account later disables the
setting, existing appointment groups that support observer reservation
are unaffected, but teachers cannot create new appointment groups for
observers. However, if an appointment group that supports observer
sign-up is amended to include a context that does not allow observer
sign-up, then observers will no longer be able to make reservations
on that group (existing reservations are unaffected).
closes LF-588
flag = observer_appointment_groups
[fsc-max-nodes=30]
[fsc-timeout=60]
Test plan:
With the observer_appointment_groups flag disabled:
- Before enabling the feature flag, validate that the existing
appointment group creation and reservation workflow still works
- Expect to not see the "Allow observers to sign-up..." setting in
account settings
- Expect to not see the "Allow observers to sign-up" checkbox when
creating an appointment group
With the observer_appointment_groups flag enabled:
- Go to root account settings
- Enable the "Allow observers to sign-up..." setting and save
- Expect the setting to be persisted
- Go to a subaccount's settings
- Expect the setting to be enabled
- Uncheck the setting and save
- Go to the calendar as a teacher
- Create an appointment group
- When selecting only contexts that have the setting enabled,
expect to see the "Allow observers to sign-up" checkbox
- When selecting any context that doesn't have the setting enabled,
or if group sign-up is enabled, expect to not see the observer
checkbox
- Save the appointment group
- Click the appointment group in the calendar and select "Group
Details"
- Expect that changing contexts here affects the observer sign-up
checkbox in the same way as above
- Go to the calendar as an observer
- If the observer is enrolled in a course with an appointment
group with observer sign-up enabled, expect for the observer
to see the "Find Appointment" button
- Expect for the observer to be able to reserve only appointment
groups with observer sign-up enabled
- Disable the account setting
- Expect observers to be able to sign up for existing appointment
groups with observer sign-up enabled
- Expect teachers to not see the observer sign-up checkbox anymore
Change-Id: I26c9e2f4f9139558be477eabc3a1357ec97b3738
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335115
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This is an attempt to ensure that each tool can only submit
the tool form for itself, not some other LTI tool that happens
to also be on the page.
Although theoretically they should not be able to do that
since they are in an iframe and shouldn't be able to "see"
elements outside of their own iframe, it does appear to happen
sometimes.
fixes INTEROP-8134
flag = lti_unique_tool_form_ids
test plan:
- enable the lti_unique_tool_form_ids feature flag
- verify that tool launches work in:
- assignments (including with a tool in the description
and as the assignment itself)
- wiki pages (including with multiple on a page)
- on a wiki page with multiple tools embedded in it, check out that
each one has a unique #tool_form_random_number_here id
- modules
- global nav placements
- disable the lti_unique_tool_form_ids
- verify that tool launches still work
- in the network tab, check that the response for the
/retrieve endpoint has the lti form and its id is
just tool_form.
Change-Id: I020b3355f0306d2ec27d81d4487458d4518086de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328258
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
this commits adds spec for module_student_view_peer_reviews
fixes EVAL-2920
flag=none
test plan:
- create a modules within a course
- add an assignment to the module
- add a peer review to the assignment
- publish the module
- as a student, view the module
- verify that the peer review is visible
Change-Id: Ib2cca45af1bf57810602b676bcd40d34111278bd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330694
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
this commit changes the modules page to use
the same react component/ui as the assignments page
fixes EVAL-2920
flag=none
test plan:
- create a modules within a course
- add an assignment to the module
- add a peer review to the assignment
- publish the module
- as a student, view the module
- verify that the peer review is visible
Change-Id: Ieaf50451beafeb589ab21b2664649b570fa02fce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328715
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Samuel Lee <samuel.lee@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Changes the display of letter grades (e.g. "A-") to use the unicode
minus character (U+2212) instead of en-dash, so that screenreaders properly
read the grade (e.g. "A minus" instead of "A (pause)").
flag=none
closes EVAL-3344
Test Plan:
- On the following pages, verify displayed minus letter grades use the
unicode minus character and are announced by screenreaders as
"<the grade> minus":
- global student grades page (/grades when a student is enrolled in more
than one course)
- student grades page
- new student grades page (student_grade_summary_upgrade FF enabled)
- A2 assignment page
- SpeedGrader
- Default Gradebook
- Enhanced Individual Gradebook (individual_gradebook_enhancements
enabled)
- On pages where letter grades can be input to grade a student (e.g.
Gradebook + SpeedGrader), verify both types of input are accepted:
- "<the grade><en-dash>" e.g. "B-"
- "<the grade><minus>" e.g. "B−"
Change-Id: I3b8c4b48f198966d492900edbe6265cd98f311f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327945
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Fixes FOO-3791
flag=none
Test Plan:
- Have course templates enabled
- Go to a sub account's settings page
- In the drop down for course templates, there should be no
option for "Unnamed Course"
Change-Id: I6ea3d4b0241d56ea3992678f5728e6ee4c8a10b2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328837
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jason Perry <jason.perry@instructure.com>
QA-Review: Jason Perry <jason.perry@instructure.com>
this commit adds all availability dates should be shown
on the assignment details page like what is seen with
Classic Quizzes to maintain parity.
fixes EVAL-3113
flag=none
test plan:
- Create a new assignment with the available dates in
the future a due date, and an until date
- Create a new quiz with the available dates in
the future a due date, and an until date
- As a student navigate to the future assignment and
future quiz
- It should show assignment "This assignment is locked until..."
and should look like the quiz's show page
Change-Id: Id6037c6aeb38c2add1309d97346ff37386bca22a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325809
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
since they're on in production, they need to be turned on
for local development and jenkins to avoid sneaking bugs
into production
I intend to actually _remove_ the feature flags
and associated permission blocks in a subsequent commit
flag=none
closes FOO-3874
Change-Id: I98f7c043ae93cb1c0b4aef46999417af43684e55
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308815
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes LF-618
flag=none
Test plan:
- Access a page you have no access to
- Check that the unauthorized message
appears with the usual H1 (only one
in the page).
- Access a page which you do have acces
to, with a media you don't.
- Check that the unauthorized message
inside the iframe uses an H3 and not
an H1.
Change-Id: I0fc9bebf786eaef9f93b9d3dc73b18d8211c315c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326323
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
closes EVAL-3386
flag=gradebook_show_first_last_names
Test Plan:
- create a sub-account of the root account
- set the siteadmin gradebook_show_first_last_names flag to true
- enable the allow_gradebook_show_first_last_names account setting in
the root account
- ensure the sub account has the setting enabled as well
- disable the allow_gradebook_show_first_last_names account setting in
the root account
- ensure the sub account has the setting disabled as well
- ensure the sub account can enable the setting to differ from the root
account and that it is saved
- ensure the setting is now available in the a course gradebook within
the sub account
Change-Id: I9be1d9f4bcf0c1aacae541725328c076c98fdfd5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325102
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Samuel Lee <samuel.lee@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Fixes support week bug ticket where libertyuniversity had 500-ish terms
which was producing 504 gateway time-out error on beta. Adding
paging to the terms page to fix this issue.
Changes of note:
- terms displayed per page: 20
- search terms input added at top of page
- search terms query looks at name of term only (e.g. “term 22”)
- “Add New Term” button moved to top of page
- terms pagination shows at bottom of terms results list
- term_name query string add to terms API controller
refs FOO-3630
flag=none
test plan:
- log in as admin and visit admin > terms:
1. confirm that there are no pagination links at bottom of terms list
2. confirm that there is a single “Default Term” (can not be deleted)
3. confirm that “Add New Term” button is displayed at top-right
4. add a total 20 terms (including the default term)
- refresh the page
1. confirm that there are no pagination links at bottom of terms list
2. add 1 more term
- refresh page:
1. confirm that pagination links are displayed at bottom of terms list
2. confirm that the “previous” link is DISABLED
3. confirm that the current page number “1” is DISABLED
4. confirm that the next page number “2” is ENABLED
5. confirm that the “next” link is ENABLED
- click “next” link to go to second page of terms:
1. confirm that the “next” link is DISABLED
2. confirm that the current page number “2” is DISABLED
3. confirm that the previous page number “1” is ENABLED
4. confirm that the “previous” link is ENABLED
- search for an EXISTING term (yielding 1 result):
1. confirm that the search term is displayed in the terms list
2. confirm that the pagination links are NOT displayed
3. confirm that ”View all terms” is next to the search button
4. confirm that search input contains the search query terms
5. click the “View all terms” link
6. confirm that the page returns to the first page of terms
- search for a NON-EXISTING term (yielding 0 results):
1. confirm that a no-results message appears
- search for an EXISTING set of terms (yielding 21+ results):
1. confirm that the pagination links are displayed
- see FOO-3630 for more details
Change-Id: Ib36d4ed843dddb74a704678f80a59b732a9de361
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/322825
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
[fsc-timeout=60]
flag=restrict_quantitative_data
fixes VICE-3570
fixes VICE-3575
test plan:
- turn rqd ff ON
- turn rqd course setting on
- go to account permission settings
- verify the restrict quantitative data permission is gone
- verify quantitative data is restricted for students and observers
- verify quantitative data is restricted to admins, teachers, tas, designers
unless the code asks to check for extra permissions
Change-Id: I8d0f1f47fd1d8a16869b6ad7f6cba3e7d773cb21
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320642
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Allison Pittler <allison.pittler@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
closes LF-290
flag = none
Test plan:
(Requires a NQ connection to test)
- Go to a course's modules page
- Click '+' to add content to a module
- Select each content type in the dropdown, and expect to see
'[Create Assignment]', not '[New Assignment]' (or quiz, page, etc)
- Select Quiz
- Expect to be able to choose between NQ and CQ
- Create a NQ and then a CQ
- Open each quiz
- Expect the quizzing engine to match the selected engine
Change-Id: I8a54874a78aace2c6a97250f704ecc0d6d61cb77
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/318759
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LF-285
flag = none
Test plan:
- have an assignment with a rubric that uses
free-form comments
- as a student, submit the assignment
- as a teacher, grade the assignment while leaving
comments in the rubric in speedgrader
- as a student, click the dashboard notification about
the graded assignment to go to the submission details
page
- there should be an unread indicator next to the
"Show Rubric" link
- click "Show Rubric" and that indicator should go away
- refresh the page and the indicator should still be gone
Change-Id: I382b6e580e46a780e246d58f572387c0ad0f2c14
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/318541
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=restrict_quantitative_data
fixes VICE-3498
test plan:
- have a student be graded on a
points assignment, a percentage assignment,
a letter-grade assignment, and a complete-incomplete
assignment
- make sure that student is quantitative data restricted
- as the student visit your home page
- verify that recent feedback on the right
converts points and percent grades to letter-grade,
while leaving complete-incomplete and letter-grade grades
alone
Change-Id: Ic8961976c89bcb112dd65575c6e235f80be19baf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317789
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Allison Pittler <allison.pittler@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Constants in an AR model get loaded when the model is loaded, including
translated strings. If the user switches languages, the cached string
might be stale. Thus, use a lambda in the constant that calculates the
translated setting name instead of storing the translated value. An
alternative would have been to make this entire constant a method
instead of a constant, but this is a less intrusive solution since it
has a number of usages.
flag = none
closes LS-3947
Test plan:
- Change user's language to something else (in the UI)
- Go to course settings
- Scroll down to visibility
- Check "customize"
- Expect "syllabus" and "files" to appear in the currently selected
language
Change-Id: Ifcfb95476f1e8d4f97007bfad1ccea9b0e55aa07
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316412
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
The url to access submissions from the dashboard's recent feedback
sidebar was generating the subissions url with the observer's user
id, which does not work because the observer doesn't have a submission
in the course. Instead, construct the url with the id of the student
whom the observer is currently observing.
closes LS-3934
flag = none
Test plan:
- Create an assignment in a course with a due date and online
submission type
- As a student, submit the assignment
- As a teacher, leave a submission comment
- As an observer (observing the student), open the dashboard and
click the link to the comment in the recent feedback sidebar
- Expect to be taken to the student's submission and see the comment
Change-Id: I52c16f4fc2efc885e4adc298b60a1140ac191b1d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316066
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Rendering external_tools/helpers/icon includes the new lines and spaces
that are present in the partial. Calling #squish on the output of that
partial in this helper will remove all the new lines and spaces but this
removes the html_safe flag on the out. Wrapping that entire thing in
the icon correctly and without spaces.
fixes LS-3926
flag=none
test plan:
- Create an LTI in a course with an icon
- Go to the course settings and verify the LTI is rendered with the icon
- Hover over the button and verify there isn't an extra space before
the label
- Inspect the HTML and verify there isn't an extra space or new line
between the icon and label
Change-Id: I954b65d5a6e2d2e2a6354235679d12023f15240c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316073
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Launching duplicating/failed_to_duplicate new quizzes assignments
provides no value as the assignments do not yet exist, and is actually
destructive as it will create a blank assignment on the new quizzes
side with no connection to its parent assignment.
closes QUIZ-10828
flag=none
Test Plan:
- Create a BP parent course with a new quizzes assignment.
- ADD THE NQ ASSIGNMENT TO A MODULE.
- Create a child course.
- Ensure your live events are turned off and/or quiz lti is turned off.
- In the canvas rails console run this:
Setting.set("quizzes_next_timeout_minutes", "1")
- Run a BPS.
- Check the child course.
1. The Assignments/Quizzes list should have a spinner for the quiz.
2. The modules list should have no entries.
- Wait 1 minute, then in the Canvas rails console run:
Assignment.clean_up_duplicating_assignments
- Check the child course.
1. The assignments/quizzes list should have an 'Oops!' entry for the quiz.
2. The modules list should have no entries.
- Turn on quiz lti and your canvas live event streams.
- Run another BPS.
- Check the child course.
1. The assignments/quizzes list should have a valid entry for the quiz.
2. The modules list should have a valid entry for the quiz.
Change-Id: I971173ebca77e9ecfb152677092bd7f48f789d2b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311411
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Marissa Pio Roda <marissa.pioroda@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
User login sso-icons were not showing in login information of the
user page. This was due to the lookup code for the svg not working,
when the view is checking if the svg exists. In my testing, the old
lookup code works for erb files but not svg files. This code change
will correctly check if the svg file exists.
fixes FOO-3368
flag=none
test plan:
- Import user with authentication_provider_id set to canvas
- Confirm login information of user shows canvas icon on user page
Change-Id: I09736471b5c317ce1b73a5f44439095c5547de2a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/312704
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Ajmal Esa <ajmal.esa@instructure.com>
Product-Review: Ajmal Esa <ajmal.esa@instructure.com>
currently when a student has unread grades in their grade
summary, the blue unread dots appear for 5 seconds then disappear.
the blue dots will display if reloaded and only permanently disappear
if the student clicks into the submission. new change will make it
so that when a student goes to summary page, the blue dots stay on
the screen but a bulk api call is made to mark all the unread
submissions as read. next time user loads the page the blue dots will
not be there.
fixes EVAL-2775
flag=visibility_feedback_student_grades_page
flag=assignments_2_student
test plan:
- as teacher, make 3 changes to student's grade for 3 different
assignments
- as the student, view the grade summary page
- notice that the unread grade blue dots appear next to those 3
assignments and do not disappear
- notice that the content participation count next to grades tab is
correct with a count of 3
- as the student, refresh the grade summary page
- notice that the unread blue dots are no longer there and the content
participation count should now be 0.
Change-Id: Ief3bbe12fafe5cb4b022126b2a3bcddedd220cd2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308109
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
refs OUT-1718
closes FOO-3281
flag = none
The ordering is the same for both views (and is working per the
docs linked above) with the exception that the “Recent Submissions”
filters out submissions belonging to assignments and their
respective context (i.e Course) that is not currently published.
It seems like we just missed the “Course Submission” view when
making that addition.
test plan:
- create a course
- create an assignment and publish it
- create another assignment and do not publish it
- create a quiz that has at least one text only
question (such as an essay)
- add a student to the course
- as the student, create an ePortfolio (found under
the 'account' submenu on the left-hand side)
- ensure that the unpublished assignment
is not seen under "Recent Submissions"
- as the student, submit to the publushed assignment
- the eportfolio should now show that assignment
- as the student, take the quiz
- the quiz should still not show in the portfolio
- as the teacher, grade the assignment submission
- the submission should still show for the student
in the portfolio
- as the teacher, grade the text only questions of
the quiz
- the quiz should now show in the portfolio
Change-Id: I1e3383b14acb8e3323c4fd7c9de78621297db086
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308514
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
QA-Review: August Thornton <august@instructure.com>
closes EVAL-2685
closes EVAL-2686
closes EVAL-2687
closes EVAL-2688
flag=proxy_file_uploads
test plan:
- turn on proxy_file_uploads siteAdmin FF
- grant Teachers permission with proxy_assignment_submission
- create an assigment on a course with file_upload submissions
- as a teacher, navigate to that assignment in gradebook
- notice 'Submit for Student' button on the submission tray
- upload a file and see that it saves to the student's folder
- click 'submit' to save the submission
- notice that the proxy submitter is saved on the submission
- verify proxy upload indicator appears in the following places
- gradebook submission tray
- SubmissionTray.tsx
- speedgrader
- submissions_dropdown.handlebars
- A2 student views
- SubmissionWorkflowTracker.js
- A1 student views
- submission_sidebar.html.erb
- views/submissions/show.html.erb
Change-Id: I2b9a7b8a5d1bd7c31bd2fe0c15b3316ce8b7e4bc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304943
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Christopher Soto <christopher.soto@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
With feedback visibility flag we combined the out of and score
columns. This change adds the out of total for all special classes
which are total and group grades
fixes EVAL-2785
flag=visibility_feedback_student_grades_page
test plan:
- have a course with students and assignments/groups
- grade some of the assignments for some of the students
- verify that next to the Assignments row, any group rows,
and the Total score row, that you can see the out of values
or 0.00/0.00 if the score is N/A
Change-Id: I0df604faca6e53721baff1e3eae304f666604dfa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/307522
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
closes: EVAL-2763
flag=none
Test Plan:
- have a published course.
- have a course with a teacher and a student.
- have an assignment created.
- as the teacher using the speedgrader or gradebook
grade the student.
- as the student go to the grade summary page.
- hover over the values of the grade column.
- ensure only "Click to test a different score"
custom tooltip is present.
Change-Id: I2cac720d658de301ff6bd14393da7dd5cc0a0d0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/306559
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
fix issue where when assignment enhancements flag
is on, when trying to print grades from student
grade page, it shows the speed grader url
fixes EVAL-2679
flag=assignments_2_student
test plan:
- have a course with a text assignment that is due
- with assignments_2_student flag on, navigate to
individual student grade page as a teacher
- for the text assignment, verify the url of the
assignment title navigates to speed grader page
- from the student grade page, right click and go
to print the page
- verify in the pdf preview that the url for the
assignment doesn't exist
- before the fix, the url would be displayed
Change-Id: I1bd3e059cc7f73dab932ecc2d32e3d58bb654d73
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/305548
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Test Plan:
1. Validate that a non-admin user can modify their name, profile links,
bio and communication channels
2. Disable the respective settings in the Account settings tab
3. Validate that the non-admin user can no longer edit the listed items
4. Validate that the API does not allow these changes either
flag=none
refs PFS-20887
Change-Id: I0d852613a64ee763c6de1bca8797f226c74f5f43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304025
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Vaughn Hepworth <vhepworth@instructure.com>
QA-Review: Douglas Rist <douglas.rist@instructure.com>
- Blue dot styling refactor
- Add specs for unread grade, comment and rubric on grade summary
- Doesn't show the blue dot if submission is not posted
- Remove unread grade blue dot after 5 seconds
- Fix blue dot position if a RTL lang is selected
closes EVAL-2542
flag=assignments_2_student
flag=visibility_feedback_student_grades_page
Test Plan:
- Enable the "Assignment Enhancements - Student" feature flag
- Enable the "Improve Feedback on Students Grade Page" feature flag
- Have a course with at least two students
- Have a published assignment (post grades - automatically)
- As a student submit the assignment
- As a teacher grade the student
- As a student, when landing on the grades page the blue dot
shows up on the grade
- That blue dot should disappear after 5 seconds
- If the page is reloaded the blue dot should be gone because
the grade is marked as read when the user views the grade
- And if the teacher changes the grade the blue dot should
appear again.
- Have a published assignment (post grades - manually)
- As a student submit the assignment
- As a teacher grade the student
- As a student, when landing on the grades page, you
should see no blue dot on the grade
Change-Id: I7f40137049ca00bb69cd0b50129b13f6cc6af19c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302822
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
Cody Cutrer