Commit Graph

21 Commits

Author SHA1 Message Date
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer 06a2c9df42 spec: remove manual requires of spec_helper
[skip-stages=Flakey]

Change-Id: Id65c835b72e1c0a4bb825b58490ce0ff7c8d9873
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276829
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-10-26 20:38:27 +00:00
Cody Cutrer 81d0bbc465 add # frozen_string_literal: true for specs
Change-Id: Id508bec1817937b1c24c29f1db7221e09cb9c2ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251157
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2020-10-27 20:48:35 +00:00
James Williams a6e6fd0670 split built-in role rows by root account
test plan:
* a multi-tenant shard should still work
 creating enrollments and account admins before and after
 running postdeploy migrations
* the postdeploy should successfully run a datafixup
 to split up build-in role rows and reassign the role_id on
 other tables (account_notification_roles, account_users,
 enrollments, and role_overrides) accordingly

closes #INTEROP-6045

Change-Id: I8325acb635397ac1b008b9d09788595da597cec7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243906
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
2020-09-01 19:21:27 +00:00
Omar Khan 0536054715 Skip tests that require plugin unless plugin installed
fixes CNVS-36355

Test plan:

- docker-compose build --pull
- docker-compose run --rm web bundle exec rspec \
  spec/{apis,controllers,helpers,initializers,integration,lib,message,\
  middleware,migrations,models,observers,presenters,serializers,views}\
  /**/*_spec.rb

Change-Id: I4220a314dbc2e343dae26e6e522806f4f2666f85
Reviewed-on: https://gerrit.instructure.com/120671
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-07-28 19:30:52 +00:00
Landon Wilkins 193a87afc0 da licença part 60
add consistent license headers to all source files

Change-Id: Ibaf8cf457ad92c6a1108e9254786d1f5f18b5662
Reviewed-on: https://gerrit.instructure.com/110311
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-05-01 21:20:40 +00:00
Cody Cutrer 9a7a66af60 just assume switchman is present for specs
fixes gh-892

Change-Id: Ib4ed6565343be7569282a5e243d0026f2b95f6a9
Reviewed-on: https://gerrit.instructure.com/90903
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-09-20 22:36:34 +00:00
Jon Jensen 83cd066437 spec: ensure each shard always has built-in roles, refs SD-857
when setting up sharding beforehand via sql import (versus migrations), the
roles table won't be populated in the other shards. additionally the initial
call to truncate_all_tables generally won't populate it, since the shards
table will be empty.

Change-Id: Ia0565164da0bf3d904a1c45385e97ac564c0810e
Reviewed-on: https://gerrit.instructure.com/73231
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
2016-02-29 19:31:26 +00:00
Cody Cutrer 2ae694d968 use actual switchman names for sharding spec helper
Change-Id: I96657f3fefd615ae24c3cd80bc4dcb3d7e1d9273
Reviewed-on: https://gerrit.instructure.com/51774
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-08 19:14:13 +00:00
Cody Cutrer 63faa87f67 fix sharding skip for rspec 3
fixes CNVS-16812

Change-Id: If638a2cc3d9a72746af5b66fa86411a5e7b0c22b
Reviewed-on: https://gerrit.instructure.com/44200
Product-Review: Rob Orton <rob@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
2014-11-11 18:55:35 +00:00
James Williams 81558f728c remove rails 2 support
closes #CNVS-14261

Change-Id: I1b0e8a4438ab659ecd1ac8462bc3559d810989b3
Reviewed-on: https://gerrit.instructure.com/38744
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
2014-08-06 18:16:19 +00:00
James Williams c2a31b9101 spec: don't override base_transactions in onceler noop
Change-Id: I195885e7f56bdfc8c10f454f6660261854a2277d
Reviewed-on: https://gerrit.instructure.com/37970
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2014-07-22 19:19:17 +00:00
James Williams a55d538aa6 spec: don't run shard :once hooks if sharding not enabled
Change-Id: I4b554dc78e3dbeb697d3dc35e5949176917650ed
Reviewed-on: https://gerrit.instructure.com/37821
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2014-07-21 14:59:08 +00:00
James Williams e9a007d01c spec: don't destroy defaultshard
Change-Id: I723874c16219a25fe9a14b851f60cd2d3cce9435
Reviewed-on: https://gerrit.instructure.com/37685
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2014-07-15 20:08:21 +00:00
James Williams 6e9c7aa63b spec: reset default shard before running
Change-Id: Ia2f6e58d1fcbf00054e86d3da2aa4e2f6364aa77
Reviewed-on: https://gerrit.instructure.com/37662
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2014-07-15 12:52:23 +00:00
Jon Jensen b5ac86752d spec: once-ler, now with sharding support
revisit some already once-ler'd specs, reduce runtime of modified files
by ~20% (5:20 -> 4:10 locally)

Change-Id: I60ee5cb1cd1491d8c3c9acc2a7d990303529cb96
Reviewed-on: https://gerrit.instructure.com/37607
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2014-07-14 16:09:27 +00:00
James Williams 3c11a4cb1e pend specs_require_sharding in rails 3
closes #CNVS-13847

Change-Id: I10ec77968a4462eece3e199ad2bd0ae5d506899f
Reviewed-on: https://gerrit.instructure.com/37441
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2014-07-11 15:23:20 +00:00
James Williams 3d949b9080 integrate sharding_spec_helper with switchman for rails 3
Change-Id: Id2205c4c375c569e88857bb3f24a7f11a9d184af
Reviewed-on: https://gerrit.instructure.com/27960
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
2013-12-31 20:09:46 +00:00
Brian Palmer 88d271609b spec: remove shared_examples_for "sharding"
everything has transitioned to specs_require_sharding now

Change-Id: Ieab7e6c75bf0351d170e1aa3574453f25730324f
Reviewed-on: https://gerrit.instructure.com/19207
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
2013-04-10 16:48:07 +00:00
Brian Palmer f5b017a259 spec: fix sharding it_should_behave_like for rspec 2
Apparently the fact that a shared example group added its before/after
filters to the outer context was a bug, and it's been fixed in rspec 2.
So we can't use a shared example group to setup or mark pending sharding
specs anymore.

test plan: specs

Change-Id: I92b022e2e7125214e6bad38bf0a23da547fca984
Reviewed-on: https://gerrit.instructure.com/19182
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
2013-04-01 15:26:44 +00:00
Cody Cutrer d102d750f4 stubs for sharding specs
test plan: n/a

Change-Id: I4ae3f7cff199e1afe8daf58877e6d6edfe03ddcd
Reviewed-on: https://gerrit.instructure.com/8057
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
2012-01-16 11:05:57 -07:00