[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
refs VICE-1799
flag=none
TEST PLAN
1) Specs work.
Change-Id: I4dd5c7f9af4f56bbe3f9f7d8addcb37ff50a21b7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272167
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes VICE-1799
flag=none
Ruby returned a datetime in non ISO format,
which broke in the JS.
see > BouncedEmailsView component and
> FriendlyDatetime component
the fix is to return a datetime in ISO
TEST PLAN:
1) Specs pass.
SETUP
1) First run:
RAILS_LOAD_ALL_LOCALES=1 bundle exec rake canvas:compile_assets
(
You can ignore or remove afterwards by running:
bundle exec rake canvas:compile_assets
)
2) Then Start your server with:
RAILS_LOAD_ALL_LOCALES=1 bundle exec rails server
3) Go to http://localhost:3000/accounts/2/settings
a) Set your language to English Australia
4) Create a bounced email. The easiest method,
open a rails console and copy the command in the ticket's
comment section.
5) goto http://localhost:3000/accounts/2/admin_tools
your account user admin tools.
6) click bounced emails
7) for address set *@*
8) you should see your bounced email.
9) To see the original error:
replace:
value_generator.to_proc.call(cc)&.to_time&.iso8601
with:
value_generator.to_proc.call(cc)
then:
preform the search a again.
you will have a broken ui.
Change-Id: Icb2f4517bc070f7717a076a300633e76ef21a52d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271825
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
test plan:
- simulate bounced emails in the Rails console. do this for a handful
of users, putting different details in each:
cc = User.find(x).communication_channel
cc.bounce_count = 1
cc.last_bounce_at = 10.days.ago
cc.last_bounce_details = {'bouncedRecipients' => [{'diagnosticCode' => '550 some error'}]}
- ensure the "bounced emails" admin tool appears if the feature
("Bounced Emails Admin Tool") is enabled and the user has
the requisite permissions, which include both :read_roster
("Users - view list") and either :view_notifications on the
root account level ("Notifications - view"), which requires the
"Admins can view notifications" account setting to be enabled,
or :read_messages ("View notifications sent to users") on the
site admin level
- click the button without entering a search term and the most
recent addresses appear (let's be real: they all appear,
because you don't have 1000 of them)
- enter a search term and click the button, and matching
addresses appear
- the date filtering should work
flag = bounced_emails_admin_tool
closes LS-1587
Change-Id: I38174d5422f6c4417d7c5e6856256061a8bfc2be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251572
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Change-Id: I7f40ed058b50882121da69f0cb05966854b8e920
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250924
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Change-Id: I70825be7ec7e24458afe0c63dc48c5a76158f520
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251150
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan
- specs should pass
Change-Id: Iafc7c9b8ca64f32568e658b600e19c2e6f9045ca
Reviewed-on: https://gerrit.instructure.com/138026
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Fixes CNVS-28150
Test plan:
- Add an unconfirmed communication channel
- Hit /api/v1/accounts/.../unconfirmed_communication_channels.csv
and ensure the channel shows up
- Post to
/api/v1/accounts/.../unconfirmed_communication_channels/confirm
- Ensure the channel is now confirmed
- Add an unconfirmed channel with an email address that doesn't
contain an "@" sign
- Hit /api/v1/accounts/...unconfirmed_communication_channels.csv
and ensure the channel does not show up
- Hit the above URL with ?with_invalid_paths=true appended and
ensure the channel now shows up
Change-Id: Id7c3844e06e3fe997aed8baa363b5a9deababe97
Reviewed-on: https://gerrit.instructure.com/74926
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Jacob Burroughs