Commit Graph

4 Commits

Author SHA1 Message Date
Aaron Shafovaloff af8f9af5bc correct some references in package.json files
also: use separate .d.ts declaration files in
  defer-promise and html-escape

test plan:
  - existing tests pass

flag=none

Change-Id: Idd4d2b7b3fc2f0f1e8a10d6a456ba7b7b1442758
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323760
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
2023-07-28 00:05:23 +00:00
Aaron Shafovaloff 402bf325c5 Moves data loading some methods to Gradebook.utils
Also:

- Reduces TypeScript errors in Gradebook
- Initializes appliedFilters before filter API call

Test plan:

- As a teacher
  - ensure Gradebook filters still load
  - open the submission tray for a submission

flag=none

Refs EVAL-2645
Refs EVAL-1934

Change-Id: I4e1beabcae316bfa45bd936300cc2e54aead822b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303048
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
2022-10-12 22:54:27 +00:00
Aaron Shafovaloff ef40b94fbd Stop using jQuery for Deferred in Gradebook
Test plan:
  - Gradebook still loads

flag=none

Refs EVAL-2665

Change-Id: Iaf4ae79f38b016509a4f1b7d3c5901a2ae88851b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301756
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Eduardo Escobar <eduardo.escobar@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
2022-09-30 16:57:31 +00:00
Ahmad Amireh 4243097b21 rename some things
fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-04-06 01:12:49 +00:00