Commit Graph

10 Commits

Author SHA1 Message Date
Dustin Cowles 5a2b0be6ca retain modules for quizzes migrated during course copy
closes QUIZ-12654
flag=quizzes_next
flag=new_quizzes_migration

Test plan:
- Specs Pass
- PreReqs:
  - A course with multiple modules
- Create several Classic Quizzes
  - Some should be in modules and some not
  - Be sure to keep track of which modules quizzes were in
- Copy the course with quiz migration enabled
- Verify migrated quiz module placements are retained

Change-Id: I556f2630447082fdbe0ef51d00b3b6f4638debbb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333097
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Marissa Pio Roda <marissa.pioroda@instructure.com>
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
2023-11-28 22:39:25 +00:00
Adrian Diaz 98a0ae0ae4 import surveys as new quizzes
closes: QUIZ-9599

flag=new_quizzes_migration
flag=migrate_to_new_quizzes_by_default
flag=require_migration_to_new_quizzes
flag=newquizzes_on_quiz_page
flag=new_quizzes_third_party_imports
flag=quizzes_next
flag=new_quizzes_account_course_level_item_banks
flag=new_quizzes_assignment_build_button
flag=new_quizzes_bank_migrations
flag=new_quizzes_skip_to_build_module_button
flag=new_quizzes_modules_support
flag=new_quizzes_migration
flag=migrate_to_new_quizzes_by_default
flag=require_migration_to_new_quizzes
flag=newquizzes_on_quiz_page
flag=new_quizzes_third_party_imports

Test Plan:

- Create Course A with a survey with a single question
- Create Course B and import from Course A (Copy a
  Canvas Course)
  - Keep marked "Import existing quizzes as new
    Quizzes"
- You should see the survey imported as New Quiz
- Export Course A content as a QTI FIle
- Create Course C and import QTI .zip file
  - Keep marked "Import existing quizzes as new
    Quizzes"
- You should see the survey imported as New Quiz

Change-Id: Iefc5ba3d0c369653fd3bb8a83b94ca2fe79ade1f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296062
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Marissa Pio Roda <marissa.pioroda@instructure.com>
Reviewed-by: James Logan <james.logan@instructure.com>
2022-09-19 16:46:35 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer f5cdb0d986 RuboCop: Layout app/models
Change-Id: Ieae2904fb81739476d806b01bd7b4ff98c5ee35c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-22 19:32:32 +00:00
Cody Cutrer f299f76b75 add # frozen_string_literal: true for models
Change-Id: I70825be7ec7e24458afe0c63dc48c5a76158f520
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251150
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2020-10-28 22:08:12 +00:00
James Williams 7ab106b188 fix callback loop in quizzes_next importer
unsetting the quiz association will let the assignment
save on its own - the quiz is getting destroyed anyway

refs #ADMIN-1370

Change-Id: I420d016892aaf8d5baaeb72e7f011fadd15f0d96
Reviewed-on: https://gerrit.instructure.com/161966
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2018-08-24 15:48:15 +00:00
Han Yan 85de8344ce create a Q.N assigment for each of assignment quizzes imported
closes QUIZ-5049

test plan:
- case 1: import blackboard CC package attached in QUIZ-5049
  - all quizzes should be imported as Q.N quizzes
- case 2: import a CC package with practice quizzes
  - after import completes, practice quizzes should be imported to Q.N
  - edit the assignment from Canvas
    - points_possible should be 0 and
    - `Do not count this assignment towards the final grade` should be
      checked

Change-Id: I0c2e6170943e77e01cfd47cb63562075979ef8f6
Reviewed-on: https://gerrit.instructure.com/160549
Reviewed-by: Steve Kacsmark <skacsmark@instructure.com>
Tested-by: Jenkins
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
2018-08-14 16:18:40 +00:00
Han Yan 753c155b67 fix a potential race condition bug for Q.N importing
closes QUIZ-4898

test plan:
- a regression run on old Canvas CC/Qti imports
- try to import a Q.N import (without running Q.N) in Canvas
- from rails console, workflow_state should be `imported` for the migration
- from Canvas Api, we should be able to see values for the following key
    audit_info/migration_settings/imported_assets/lti_assignment_quiz_set

Change-Id: Ib4c13e59023578431afa502a3590bbc5e081eaf1
Reviewed-on: https://gerrit.instructure.com/156348
Reviewed-by: Steve Kacsmark <skacsmark@instructure.com>
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
2018-07-10 15:23:37 +00:00
Han Yan 485e219d42 add content_migration settings for Q.N CC import
closes QUIZ-4809

test plan:
- make a Q.N CC import
- Check Canvas api endpoint:
    http://canvas.docker/api/v1/courses/<course_id>/content_migrations/<your_id>
- make sure imported_assets/lti_assginment_quiz_set appears, and
  format is like [[xxx, xxx],[xxx, xxx]...]

Change-Id: Id174ee7742dc34b76c7e7f4afedbaaed0062ea4d
Reviewed-on: https://gerrit.instructure.com/155273
Reviewed-by: Steve Kacsmark <skacsmark@instructure.com>
Tested-by: Jenkins
QA-Review: Steve Kacsmark <skacsmark@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
2018-06-28 16:24:23 +00:00
Han Yan f9676125bb Qti import from Canvas to Quizzes.Next
refs QUIZ-4415

test plan:
- cr
- Quiz.Next CC import is not ready for test with only this patch
- regression on `Import Content`, to make sure:
  1) `Qti .zip file` import works
  2) `Common Catridge 1.x Package` import works

Change-Id: Iba2818a2b864020b6c59ef55e02f122b996e4c40
Reviewed-on: https://gerrit.instructure.com/149978
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Han Yan <hyan@instructure.com>
2018-05-31 16:57:32 +00:00