Also:
- Remove some unnecessary use of @instructure/ui-themeable
- Remove use of TsMigrationAny
- Remove some instui-related module declarations
(no longer needed)
- Remove old upgrade-instructure-ui script
- Upgrade typescript and babel-plugin-typescript-to-proptypes in RCE
Test plan:
- Build passes
flag=none
Change-Id: I734183ed8bdf68422e4eb46285909c30bc31ee33
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334667
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Closes MAT-131
flag=none
Test Plan
- Navigate to a root account and verify the RCE
Autosave feature has been removed
- Navigate to a cousre and verify the RCE Autosave
feature has been removed
- Open a few RCEs in a course and verify the autosave
feature is working
Change-Id: I10f88b35501ae5499f6d066e539f953055d43b52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280794
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes MAT-133
flag=none
test plan:
- Verify that there is no rce_pretty_html_editor
feature flag (site admin).
- Navigate to an RCE instance.
- Verify that pretty html editor is enabled by default.
Change-Id: Ibe76738577d0716e30f06815c9a072f41ca48103
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275197
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
refs LS-2655
flag=none
- this updates the files under ./ui, a few ancillary files and specs.
- Sadly the commit hook ran prettier and
fiddled with the formatting of a handful of files too.
- Also made a few changes to quiet lint errors
- Also updated OutcomeManagement.test.js. I don't understand why,
but 'renders ManagementHeader with lhsGroupId if selected a group in lhs'
started failing with this change, even though nothing obviously related
changed. The problem is that the modal isn't getting attached to the
document being tested. The spec changed to test that the modal contained
what it's supposed to contain.
test plan: jenkins passes and the RCE works
Change-Id: I48d85077bdbf7563cb07510d3e71d2b448c55e49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275301
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes MAT-65
flag=none
- The update to package.json corrects a typo in the command line,
line, plus adds a directory needed to load brandable_css
- The instui babel presets in the new .babelrc.json file are needed
if you want an RCE in storybook
- The change to ENV in preview.js is needed if you want an RCE in
storybook
test plan:
- storybook builds and everything still works
- components are rendered using the Lato font family
Change-Id: I04c45e4dc6bd853c3513ff689d63f6388d874ec1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/263291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
refs FOO-1265
some of the stories were left out because they never show up as part of
the graph, also, its webpack config is now up to date
test plan: you can run "yarn storybook" as you did before
Change-Id: Ie204809c3e535d810b1e58ab64e12ff591f46168
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
closes OUT-4236
flag=improved_outcomes_management
Test plan:
- In the Acccount create an outcome with description
- Go to Account > Settings > Feature Options
- Enable Improved Outcomes Management FF
- Turn RCE Enhancedments FF to OFF
- Go to Account > Outcomes
- Select the outcome and click on kebab menu -> Edit
- Edit Outcome modal should open and form fields should
be populated with outcome data
- Verify that Save button is enabled
- Verify that the description is displayed within RCE
- Edit description and click on Save button -> modal should
close and after a moment you should see a flash message:
"This outcome was successfully updated."
- Reload the page and confirm that description is updated
- Go to Account > Settings > Feature Options
- Turn RCE Enhancedments FF to ON
- Repeat the above tests; now you should see the enhanced
RCE when editing description within the Edit Outcome modal
- Start storybook and confirm that the Outcome Edit Modal
stories display with RCE
Change-Id: I2e611e9a5fdbe895069e43061080e6986c851ae6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
flag=none
closes OUT-4256
Test-plan: - Enable lolcalize in the toolbar (happyface icon)
- Refresh page
- Look at outcomes stories, verify that lolcalize translation
occurs where expected in stories
- Disable lolcalize in the toolbar
- Refresh page
- Verify that translations are gone
Change-Id: Ia84a8464ff7df565abc22ce89c542736f7caaa00
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258660
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
closes OUT-4252
flag=none
Test-plan: - Click user icon in global toolbar
- Switch between 'canvas' and 'canvas-high-contrast'
- Verify that components display in expected contrast
- Verify that all stories are rendering as expected and that
'canvas' theme option displays stories as they were before
this PS
Change-Id: I0d139e228ee01f2c3bc45d6b20e69acce88cfae1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258545
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Manoel Quirino <manoel.quirino@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Chrystal Langston <chrystal.langston@instructure.com>
Product-Review: Jody Sailor
This story contains work to move Canvas Inbox and Storybook to `app/jsx` inside our Monolith. Storybook should now be enabled for all of `app/jsx` and works with our existing I18n code after updating webpack to load translations correctly.
Test Plan
1. Install node modules with `yarn`
2. At Canvas-LMS root, run `yarn storybook`
3. Storybook should open, test that Canvas Inbox components work as expected
Change-Id: Iccd2b103164a2da4e37b5746f4d9d2b5faf5f29d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253024
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
Aaron Shafovaloff