Commit Graph

9 Commits

Author SHA1 Message Date
Jacob Burroughs 15541fdd7a Update krecord to support nginx-rtmp
fixes COMMS-1731

Test plan:
- Test media recorder against FMS: it should work
- Test media recorder against nginx-rtmp: it should work
- Make sure audio-only and video work
- Make sure recordings > 1min work
- Maks sure seeking, stopping, and playing the recording multiple times works

Change-Id: Icaa5897e23c7330f49623fecdef6e05935e2a0c0
Reviewed-on: https://gerrit.instructure.com/170842
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2018-11-06 18:49:58 +00:00
Brian Palmer dc142ca33f switch to the speex codec for the flash recording widget
fixes CNVS-19888

The most recent version of Flash has a critical bug that causes the default
NellyMoser codec to play back at high speed
https://bugbase.adobe.com/index.cfm?event=selectBug&CFGRIDKEY=3970924

I wasn't able to fix the issue by changing NellyMoser sample rate. Switching to
the (more modern) Speex codec fixes the issue. There might be a slight decrease
in sound quality, since Speex sampling is 16khz, vs the 22khz we were using for
NellyMoser. On the other hand, the Speex codec is more optimized for speech,
which is what most of our recorded video is.

This also pulls in a new build of our KRecord.swf widget which enables
soundcodec and soundrate options.

test plan: without this commit, recording webcam video/audio will play back the
preview at high speed. with this commit, it should play back at the correct
speed. the video/audio should also save and play back later as expected.

Change-Id: Ie16a3ca04e836da9c5fc3bdbcf1b699e9dccf193
Reviewed-on: https://gerrit.instructure.com/52615
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
2015-04-23 16:36:30 +00:00
Brian Palmer 5d27722e9c promote the "alt" kaltura recorder widget to primary
refs CNVS-19888

All accounts now have the alt recorder enabled, so I've deleted the old recorder
and made the "alt" the only recorder. In other words, I renamed KRecord_alt.swf
to KRecord.swf and removed the setting.

test plan:

The "use alternative flash recording widget" kaltura plugin setting should be gone.

All accounts should now use the new, standard recording widget. the easiest
way to test this is to have multiple cameras plugged in, and check that the
recording widget shows a UI for selecting which camera to use.

Note that right now the preview when you record will play back at a higher speed
than expected. This isn't related to this change, it's a Flash Player bug that
CNVS-19888 is working toward addressing. Once you save the video, playback
should work at normal speed.

Change-Id: I899ff0e7eee887f442fe3d74a64764e43e293cf8
Reviewed-on: https://gerrit.instructure.com/52586
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
2015-04-23 16:36:10 +00:00
Paul Hinze 765917e27c address XSS issues in KRecord swf files
refs CNVS-16682

test plan:

 - enter valid kaltura plugin settings
 - with "Use alternative flash recording widget" UNCHECKED
   - verify that media recording works properly
   - verify that steps listen in CNVS-16682 do not result in JS
     execution
 - with "Use alternative flash recording widget" CHECKED
   - verify that media recording works properly
   - verify that steps listed in CNVS-16682 do not result in JS
     execution

Change-Id: Ice6034da633de988eea3d58b9a13cab3ef288ae9
Reviewed-on: https://gerrit.instructure.com/45746
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
2014-12-15 21:51:27 +00:00
Bracken Mosbacker 7c13f06310 add an alternate video recording widget for testing
We fixed some problems in the video recording widget that
we want to test in a real production environment. So the
updated widget is behind a flag in the plugin settings

Test Plan:
 * Enable the "Use alternative flash recording widget"
   checkbox under kaltura plugin settings
 * You can tell it's the new widget if when it loads, and
   you have 2 cameras, it'll present with an option to choose

closes CNVS-12037

Change-Id: Iaf360874c5c3078ae421dfce1977579fedf1f19c
Reviewed-on: https://gerrit.instructure.com/32417
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
2014-03-27 16:33:33 +00:00
Zach Wily 67749626c7 audio/video recorders in one swf file
We've made modifications to Kaltura's swf recorder that will
allow it to record either just audio or audio and video, with
both options now available from the same swf file.  I've also
made some additional tweaks to the UI to help clean things up
in this interface.

Also included a fix for enabling storing to Kaltura over SSL.

Change-Id: Ia30b407ea1f0b049f7553d11195fceee75f23e7a
Reviewed-on: https://gerrit.instructure.com/3404
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2011-05-08 10:30:27 -06:00
Zach Wily 8178f69165 revert "disable autopreview; switch to open source video widget"
We're keeping the rtmphost though. Turns out that you just need red5 0.7.0 for
this to work. (Newer versions are broken).

This reverts commit f58bfcd4d4.

Change-Id: I002c0e8633b91fce8539b3b5d5156419f8a3eff4
Reviewed-on: https://gerrit.instructure.com/3405
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
2011-04-30 23:30:00 -06:00
Zach Wily f58bfcd4d4 kaltura: specify rtmp url; disable autopreview; switch to open source video widget
Previewing seems to be broken against open source kaltura installations, so
it's being made not-automatic until we can fix it. This required switching to
the open source widget, since the one we were using didn't honor the
autopreview flag.

Change-Id: I12a248c1f467ddc5cf5ce2b29e7008109e0fa1ba
Reviewed-on: https://gerrit.instructure.com/3365
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-04-29 10:18:20 -06:00
Brian Whitmer 3e7997d8a8 new kaltura recorder
This turns on the new kaltura video/audio recording
dialog.  The dimensions for the video recorder were
off, so we changed the dimensions for both recorders
to match and be larger.

We also renamed media_test folder to media_record,
and added support for https thumbnails

fixes #3212

Change-Id: Ie2f89383639e676a541dad7237db0742c798af15
Reviewed-on: https://gerrit.instructure.com/2454
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2011-04-14 21:44:02 -06:00