This commit also picks up a few files that were missed and
not in directories
This was achieved by turning the prettier rule on in .eslintrc.js
then running:
./node_modules/eslint app/jsx/<folder_name>/**/*.js
on each folder from the start directory to the end directory listed
above.
Test Plan:
- Automated tests pass
refs COREFE-347
flag = none
Change-Id: If39d147101b3b84b80157f7b04e46e2e7787b196
Reviewed-on: https://gerrit.instructure.com/212327
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: COREFE-285
calling I18n.t takes longer than you'd think. long term, we should fix
that but this will at least make it so these things are not i18n.t'ed on
every page just on code initialization and instead only when that code
path is actually executed
test plan:
* these things should be translated the same as they always have
Change-Id: I199527acb7c418b694178ea963231f8e93779c7f
Reviewed-on: https://gerrit.instructure.com/208785
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes: CNVS-34727
this will make webpack faster because it cuts down
the number of files it has to look for when
it looks a module up. right now, every time
someone asked for a app/jsx/whatever.jsx file
it had to do a stat for app/jsx/whatever.js first
and then look for app/jsx/whatever.jsx. it also
slows every lookup for handlebars/coffescript files
since it has to look for the jsx first
this was just the result of running this command:
find . -type f -name "*.jsx" | while read FNAME; do git mv "$FNAME" "${FNAME//.jsx/.js}"; done
test plan:
* automated specs should pass
* webpack build should run faster than the patchset
before this one
Change-Id: Ia15ded6dc2b09c10c4f9070edcee9305b5b429ad
Reviewed-on: https://gerrit.instructure.com/101005
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Closes: CNVS-34602
This makes it so we can use Jest to start testing things
as well as moves us forward to where everything will
use es2015 module syntax.
Webpack can handle import/export syntax natively.
Part of this was done by an automatic conversion tool
by running:
npm install ryankshaw/amd-to-es6
amdtoes6 --dir app/jsx --out app/jsx
but some of it had to be converted by hand since that tool
doesn't handle some es6 stuff like:
`...`, `static` or `import x {y, z} from 'foo'`
Test plan:
* webpack & selenium builds should all pass
* click around a couple pages to make sure things work
Change-Id: Id1b2bd55b4b7f27238754ceee720a77beca1df2b
Reviewed-on: https://gerrit.instructure.com/100536
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-33948
Test Plan:
- Using the global nav, navigate to an option within Account,
Admin, Courses, and Groups
- Where previously the screenreader text for the hamburger
menu in the upper left read out "Hide courses menu" for any
context, it should now specify which navigation menu you
are hiding/showing.
- For example, within Admin, the screenreader should now
read "Show/Hide Admin Navigation Menu". Within Account
the screenreader should now read "Show/Hide Account
Navigation Menu", etc.
https://www.screencast.com/t/6HDnFcewL0jz
Change-Id: Iee5e2313635a7472aa81992df4973c7d5c374bed
Reviewed-on: https://gerrit.instructure.com/98837
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Kyle Follett <kfollett@instructure.com>
Clay Diffrient