closes EVAL-1129
flag=none
Test Plan:
Prerequisite: Have a course created with at least 1 student enrollment
and one assignment created.
1. Access the gradebook.
2. Click on a student's grade cell and open the students grade details
tray via the arrow on the right side of the cell.
3. Click on the student's name in the grade details tray, and verify it
takes you to the student's grade page.
Change-Id: I11162d660b48d4e11ad53ac2ecbf1ac776d94504
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246123
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
closes OUT-3752
flag=none
FSC_REPEAT_FACTOR='1'
Test-plan:
-tests pass, verify new tests run
Change-Id: Iccf54743d4a6206c5b593bc94523544cb4dc3480
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242528
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
Adds a label like 'page' or 'assignment' after the link in recent
history tray. Needed to give context to sr-users for what the item
is.
fixes LS-1338
flag = recent_history
Test plan:
- Enable page views & enable recent history FF
- Open the tray in the global nav
- Use VO and browse the items
- Expect to hear items like listed in ticket
- Repeat with NVDA, JAWS
Change-Id: Ifbbad89729da63931afc4cb6c920ee03dd720cb3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245908
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
test plan:
* specs
closes #LS-1396
Change-Id: Iad7c7791eb5f4f3866a869840f17f92a99e99c12
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246128
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Previously, whenever a tool used the $com.instructure.Assignment.lti.id
custom variable, the field would not populate during the assignments
creation, but would only do so after the assignment was actually created.
This is in contrast to LTI 1.1 tools that used the ext_lti_assignment_id
field, which was already populated before an assignment was saved in
the Canvas database. Now though, the feature set should be the same,
with LTI 1.3 tools having access to an assignment's lti_context_id
during the assignment's creation.
closes INTEROP-5982
flag=none
test-plan:
* Install an LTI 1.3 tool and add the $com.instructure.Assignment.lti.id
custom variable to it. Make sure it's installed to act in a
assignment_selection and homework_submission capacity.
* Create a new assignment in a course and launch the tool.
* Verify that the variable gets substituted with a unique UUID.
* Save the assignment, and use a rails console to determine if
the assignment's lti_context_id column matches what was previously
populated.
Change-Id: Iaf8f448c467dfe1babdbb41e6b449c737564e8aa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
closes FOO-738
Change-Id: Ie6313ed2955443627fae793a041369277f1b49ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243581
Tested-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
closes LS-1377
flag = immersive_reader_wiki_pages
Test Plan:
- Enable immersive reader.
- Because there doesn't seem to be a way to run this locally
(without consul), I had to temporarily modify the
immersive_reader_controller.rb and added
prod creds to get this to test. see me for more details
Change-Id: Ifaa7edfa94ff29856ae6b474548e0f450b9d4c6c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245869
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
test plan:
* current specs exercise both queries
Change-Id: I61d9f3bb6e6758fcc895332ccd9687a13b40b894
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245975
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
flag = conditional_release
Closes LS-1310
Test Plan: passes jenkins
Change-Id: I931210a72db755a2e59f65dc554ae867c7ee1a1a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246112
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
In the call to API.paginate we were always passing in the
user media url, so it was generating the wrong Links header
for subsequent pages.
closes LS-1397
flag=none
test plan:
- test the canvas api
- GET /api/v1/media_objects?per_page=n
> expect the first n user media objects back
- GET /api/v1/media_objects?per_page=n&page=2
> expect the next n user media objects
- repeat for /api/vi/courses/:course_id/media_objects
- test the RCS
- you can either have > 50 course and user media object in your
canvas database, or change
const DEFAULT_CANVAS_PER_PAGE_ARG = 50;
to a small number in canvas-rce-api/app/api/wrapCanvas.js
- go for Course Media
> expect the first n listed in the tray
> expect a Load More button
- click Load More
> expect the next n
- repeat until you got them all
> expect no Load More button
- repeat for User Media
Change-Id: I85ba8406de5a0fa6ae4a91dcf873bf6674c01b80
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246124
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs DE-226
move_to will move to the center of the body, which may not always be visible. This would previously prevent the local storage from being cleared after a test has run. Fix this by always moving to (0, 0) instead, and harden the clear_local_storage call against future errors that might occur in the other clean-up steps.
Test Plan
docker-compose run --rm web bundle exec rspec './spec/selenium/assignments/assignments_spec.rb[1:1:5,1:1:10]' --seed 12782 --format documentation
Change-Id: Ia78c1e8867b32ca6b8303abd01467e14d39daf6d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246106
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
closes FOO-899
flag=none
test plan: (specs should cover)
- have two users on two different shards
- have both users "favorite" the same course on one of the shards
- merge them
- it should work
Change-Id: I444b89467dd12933f480a9fface3497914220c9b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
and fix style inconsistencies and get rid of layout tables
test plan:
- the "More Options" page when creating or editing
a calendar event should:
* scale gracefully down to 320px in width
(test with Chrome devtools device toolbox)
* not look like crap
* still work (smoke test stuff, because some of the code
depended on the table markup specifically)
* be sure to test:
+ course events with per-section dates (PLEASE NOTE that the
dates no longer move to the bottom of the dialog when that
box is checked, because this didn't make sense to me)
+ event duplication (the implementation of this is kind
of hokey so before deciding it's broken, see how it works
in production right now)
+ enable the site admin feature to create conferences on the
calendar page and ensure that still works too
fixes LS-1125
Change-Id: If5e298ecdd4fdf2c20531780192ff6a3aa67ead4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245022
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
fixes QO-660
flag = none
test plan:
- create a quiz and take it as 2 students
- edit the quiz to be assigned to only one of the students
- go to "Moderate this quiz"
- attempt to "Update Scores" for both students
- you should be able to for the student still assigned
- you should not be able to for the unassigned student
Change-Id: I846b1473a21b2f6da5642834e5c45a157f132e66
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245929
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Matthew Goodwin <mattg@instructure.com>
closes OUT-3844
flag=bulk_delete_pages
Test-plan:
- Ensure bulk delete FF is enabled
- Within a course, create many pages:
> c = Course.find() # course to find
- import wiki_page_factory code
> 50.times do wiki_page_model({course: c}) end
- Open the course's page tab
- ensure checking a box for deletion and sorting the page
maintains the checkbox and allows you to delete the
previously selected page
- ensure the behavior works as expected in these scenarios:
- clicking a single page for deletion then
deleting it via the dropdown
- marking a page as a front page should remove the checkbox
(and disable the bulk delete button)
Change-Id: I7c3830e33efc3c43d1131b1f4e6da5a5f9f0e28f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245602
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Jody Sailor
This makes it easier to tell which course is which
and recognize when a course has been added to
the list because the search text matches the
course code.
Test Plan:
Make sure you have the Direct Share flag on
Create a page or something
Click the kebab on the page listing
Choose "Copy To..."
Click the 'Select a Course' dropdown. Some
options should appear. Underneath the course
name, the course code should be listed in smaller
text.
Fixes LS-1272
flag=direct_share
Change-Id: I2792046cae4f33fb9cbab27fcee45df4b002189f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes EVAL-538
flag = none
test plan:
- have a course with one student and one assignment
- go to the individual gradebook
- select the student and assignment
- set the screen size to 320px
- ensure the screen does not zoom out and elements don't overflow
- ensure the table in the student information section scrolls
horizontally (or doesn't need to)
- ensure the table in the assignment information section scrolls
horizontally (or doesn't need to)
- check these things for 767px, 768px, and 1200px
Change-Id: Iaef94ebbea8cef462f64417b68ddf3858a4c9360
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244972
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
The fallback font sans-serif was included in the rce config with a
space, i.e. 'sans- serif', which caused issues with the Architect's
Daughter and Balsamiq Sans fonts. If these fonts were used in the
rce, the styling was stipped from the element on save.
Fixes LS-1383
flag = rce_enhancements
Test plan:
- In RCE, write some text and change font to Architect's Daughter
- Save the page
- Font should appear correctly in rendered text
- Repeat for Balsamiq Sans
Change-Id: Id39415c5744247cb4153c549f941c7fefe4c3aa7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245990
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=none
closes EVAL-1128
Test plan:
- Migrations on Cassandra run successfully
- Grade changes save the grading_period_id of the associated submission
in both Cassandra and AR
Change-Id: I7ae0ff54093b9bf1eaea43106d4788f22c6c920e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245734
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Jody Sailor
Fixes FOO-896
flag=granular_permissions_wiki_pages
There was a bug involving updating roles in which the updated
role did not get the group roles added to it. This caused an
explosion in the UI when the expected group role no longer
existed in the newly-updated role. This was made worse because
the selenium test for the permissions page did not enable the
feature flag and so was blind to this error.
This fixes the bug and also makes the selenium test with the FF
on (it's soon to be removed anyway) sensitive to this case.
Test plan:
* Have a custom role
* Go into the permissions page and edit the role by updating
its name
* That should work and not explode once the name change happens
Change-Id: Ic601772a9decf2cb1431afd90923b0ad66f72ffb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246077
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
This adds the ability for course groups to be auto created based on
number of members. If the total number of users don't divide cleanly
into the given group size, the users will be distributed evenly across
all groups.
Test Plan:
In a course with multiple students
- Navigate to the People page
- Click '+ Group Set'
- Enter a group set name
- Select the radio option for 'Split students into groups with __
students per group'
- Enter a number
- Save
- Verify that the groups are automatically created and students are
assigned
- Some example expected inputs and outputs:
-- 15 students, groups of 5 -> 3 groups of 5 students
-- 11 students, groups of 3 -> 3 groups of 3, 1 group of 2
-- 11 students, groups of 5 -> 2 groups of 4, 1 group of 3
closes VICE-696
closes VICE-697
Change-Id: I56af7c2ca9f06a0eb5829d63c39f672251126375
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245447
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ben Nelson <bnelson@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
- gets rid of container_name, as this explicit name breaks from the
pattern used in the rest of the codebase.
- gets rid of env vars for AWS creds as they're unnecessary, and could
potentially interfere with other aws libs besides dynammodb.
- removes `links` as its deprecated and redundant with `depends_on`
- adds "VIRTUAL_{HOST,PORT}" for dinghy
also fixes a typo in an old data fixup
Change-Id: Ie5953d1ee89d9e40779fe8f3e6c56731f77684d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246061
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
test plan
- specs should pass
refs FOO-894
flag=none
Change-Id: I3b8b94d52a87977502c82d0235ff8644840eca68
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245938
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Nelson <bnelson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
when merging a user if done from the source shard the target user.id is
global, but from target shard is is local and the update call will fail
and update the record to a local id. This could potentially be a user
that should not be associated to that record
test plan
- specs should pass
- merge users with observation links from target shard
fixes VICE-734
flag=none
Change-Id: Iad6007bfb4bc596f21a69a59555d5622f08d4721
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Nelson <bnelson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs FOO-519
flag = none
|
| TEST PLAN
| ---- ----
none, the actual support for the language will come in a different patch
Change-Id: Icb3383d83447f13fd579bc5011f38fafa5513e7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245531
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
right now it fails cause MRA is not creating proper errors for bulk
insert. This allows the errors to stay consistent and still function
for finding the root_account
test plan
- run import with invalid root_account_id
- it should not fail import but should have a valid error
- it should skip line
fixes VICE-686
flag=none
Change-Id: I5b17507045dfe23666f6dd29f347d61b102bc5e0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244313
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
refs OUT-3836
flag=account_level_mastery_scales
Add top-level query node support for outcome proficiencies
and outcome calculation methods. See "Node interface" in
"app/graphql/types/HOWTO Add Types.md" for more details.
test plan:
- create outcome proficiency and outcome calculation method
on an account
- query proficiency to get relay-style id:
query MyQuery {
outcomeProficiency(id: "<id>") {
id
}
}
- query via node and confirm the legacy id comes back:
query MyQuery {
node(id: "<relay-style-id>") {
... on OutcomeProficiency {
_id
}
}
}
- query calculation method to get relay-style id:
query MyQuery {
outcomeCalculationMethod(id: "<id>") {
id
}
}
- query via node and confirm the legacy id comes back:
query MyQuery {
node(id: "<relay-style-id>") {
... on OutcomeCalculationMethod {
_id
}
}
}
Change-Id: Ibf8ebf4e2e7001481ff6450158e02b43747ba5c4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Evan Francis <efrancis@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
While fixing this I stumbled on the fact that fullscreen in the
video upload modal wasn't sizing the player correctly, so that's
fixed too.
closes LS-1348
flag=rce_enhncements
test plan:
- in safari, open any page with a video added via the new rce
> expect the fullscreen button to be available
- click it
> expect the video to go fullscreen and resize to fill the screen
(if the video is portrait, or short-and-squat, expect it to be
letterboxed)
- click the exit fullscreen button or click esc
> expect it to return to its original size
- in any browser, including safari:
- open an edit page with the RCE
- open Upload/Record Media dialog
- select a video
- click the fullscreen button in the preview
> expect it to size the player to fill the screen (letterboxed
if necessary)
- click exit fullscreen (or click esc)
> expect to return to its original size
Change-Id: I3a4080f06cb132902bde98d2dfd86170a2a394cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245846
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
LS-1146 added code to delete empty links from the RCE. Unfortunately, it
didn't take into account links with no text content, like a linked
image. This fixes that.
closes LS-1350
flag=rce_enhancements
test plan:
- Create a Page - upload and embed an image on the page
- Using the hyperlink tool, link the image to either an
external link or a course link
- click the image and click 'link options'
- Change the target url (or don't)
- Click Done
> expect the link to be updated and not deleted.
- create another link with just text
- delete the text
> expect the link to be deleted from the DOM in this case
Change-Id: I8c95364a48fba95abdc2525ede600c5a11e278f8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245980
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes VICE-739
flag=none
See https://instructure.slack.com/archives/CGC0YJJDS/p1598370828002100
for context. tl;dr random strings can sometimes result
in vulgarity. This commit has us pick a new random
string if the previous was deemed vulgar
test plan:
- :noideadog:
qa risk: low
Change-Id: Iddd4d0c944c44f85af9cf32352611acafd44f734
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246010
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
When a column is too small, contents in a cell can be hidden from the
user's eye. This helps in the scenarios where an assignment's grades
are displayed as percentages by removing an empty html element.
fixes EVAL-677
flag=none
Test Plan
- Create an assignment that displays as percentage.
- On master, note how small a column can be before the flyout button for
the Submission Tray is starting to become hidden out of view.
- With this commit, verify that at the same size, the flyout button is
more visible.
Change-Id: I74e600a9ae7019778b0b0bc8037cddff62601d64
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245600
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Fixes FOO-661
Refs FOO-873
flag=none
When updating a permission via the API, even though the change
is properly persisted, the stale (pre-update) value may get
returned in the API response. This is because although the
RoleOverride model clears the caches after a save, the update
of the Redis caches may happen asynchronously and thus may not
be complete by the time the response is built.
The fix is to add a new argument to RoleOverride.permissions_for
which causes it to bypass all the caches and always hit the AR
model itself. Then the role_json method in lib/api/v1 can use
that to force permissions_for to skip any cached entries.
Fixing this plus adding the spinners to the permissions buttons
should make the whole workflow of editing permissions settings
way more clear to the user.
Test plan:
* Play around with the permissions settings page
* Your changes should always be reflected properly after the
API call completes, and should stay that way
Change-Id: I5b0fc1a242f886a4b2d2940e61d2e6d65c1d43d8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245905
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
this fix should cover all of our student, parent, teacher
signup dialog forms.
fixes FOO-33
flag = none
test plan:
- using chrome dev tools and responsive view
- navigate to /register_from_website
- click through each dialog form
- verify focus point is set on the first visible
navigable item (in this case it's the Close X button)
Change-Id: If04bde10558381c07f6265eab6454ada1649f57e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245699
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: August Thornton <august@instructure.com>
test plan:
* have a course set to begin in the future with
users restricted to participate between course dates
* enroll an observer in the future course
* /api/v1/users/self/enrollments?state[]=current_and_future
should return the future enrollment
closes #LS-1384
Change-Id: I261f78b4f49efbf406aeb450b55c29b1825b3a99
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245911
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
When creating a new student from the course enrollment view clicking the
"Click to add a name" link would fail.
fixes VICE-736
flag=none
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- create a course
- navigate to /courses/<id>/users
- click to add people
- enter a bogus email address, login id, or SIS id and click next
- click the "Click to add a name" link
- It should work
Change-Id: Ib3549943510bf206e525589d6961cfbe8fbc7c7e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245914
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes FOO-891
flag = none
0o test plan o.O
- send a message to a user and verify it works
- look at the job runner output and verify the UPDATE queries are
targeting "messages_2020_35" etc and not "messages"
- you can try this in the console using Message.last.{recycle,deliver}
Change-Id: I5e4ffaf1680ccc40fef9c4c2f19683d29a5e21c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/245877
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Cody Cutrer <cody@instructure.com>
Ethan Vizitei