in order to serve the css for handlebars files
from a CDN this needs to be set.
Test Plan:
load a page that has handlebars css on it
see that it works
Change-Id: Ie9fec018e2d9fc95e1bb5c1a61b504797fb535a0
Reviewed-on: https://gerrit.instructure.com/60344
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
sshepherd,panda,1
Test Plan:
- Run specs
Change-Id: I7da45c0d3297136d68894172162d4197da87c02c
Reviewed-on: https://gerrit.instructure.com/60336
Reviewed-by: Adrian Foong <afoong@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-22400
test plan:
- run followin in JS console
m = require('moment')
m()
- a Moment object is returned
Change-Id: I424001d75d54c53fbf46a820875a10802e8a3902
Reviewed-on: https://gerrit.instructure.com/60308
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
- reasoning: this group contains set-up and teardown,
it does not include 'it' blocks
Change-Id: I1803420a5c7f59246f3af211e42ced808a994c3f
Reviewed-on: https://gerrit.instructure.com/60329
Tested-by: Jenkins
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
test plan:
* add an assignment to the course
* add two sections to a course
* add a due date override for each of the sections
* delete one of the sections
* delete the remaining override
* query the sis assignments api for the course
/api/sis/courses/:course_id/assignments
* the deleted section and override should not be returned
fixes CNVS-22210
Change-Id: I259dec9448bc5c0880fd46171d1f6c09384ba08f
Reviewed-on: https://gerrit.instructure.com/60101
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
test plan:
- in a wiki page, use the wiki sidebar to create links to the
Modules List and to a specific module
- save the page
- inspect the page source and you should find data-api-endpoint
and data-api-returntype attributes on these links
as documented at /doc/api/file.endpoint_attributes.html
fixes CNVS-22381
Change-Id: If805689a3974f6e101d5c640521da53b19db585d
Reviewed-on: https://gerrit.instructure.com/60235
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* create an auth provider
* do an sis import without auth provider; it should still work
* specify the auth provider by name in the import; it should work
* specify the auth provider by id in the import; it should work
Change-Id: I71f381a1bc140c3992cac6eb45bb077e5bd26baa
Reviewed-on: https://gerrit.instructure.com/59558
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
* import the package referenced in the ticket
* the wiki page should show a media comment
(and not a blank file link)
closes #CNVS-22294
Change-Id: I51f22ac4c4230dbb8b876ac7f799377ae4e79aed
Reviewed-on: https://gerrit.instructure.com/59814
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-21574
test plan:
- Do the following commands in a JS console
tz = require('timezone');
tz.changeLocale('fr_FR');
tz.moment('mercredi 1 juillet 2015 15:00', 'LLLL');
- it works and returns an object with a french locale
Change-Id: I73d14ef5ed6fb343e2a05eaf8178a4b4d8d8a840
Reviewed-on: https://gerrit.instructure.com/59987
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
sshepherd,panda,6
Test Plan:
- Run specs
Change-Id: If934b92bc94e178d5d2a8975c735367e29d32e39
Reviewed-on: https://gerrit.instructure.com/60174
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Assignment page now indicates for all submission types that the
assignment has been excused. Because of this, students will now
properly see that excused No Submission and On Paper assignments have been
excused.
fixes CNVS-22110
test plan:
- Create two assignments, one with No Submission and one On Paper
- Excuse the assignments and view the assignment pages as a student.
- Observe that the assignment says 'Excused!' in the submission details.
Change-Id: I31114e84566ea5a0121aed50760997d9284cc797
Reviewed-on: https://gerrit.instructure.com/60077
Reviewed-by: Cody Poll <cpoll@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
gradebook importer now handles all case variations of 'EX' as excused. Because
of this, case variations are not considered changes to grades on import.
fixes CNVS-21909
test plan:
- Go to Gradebook.
- Excuse a few assignments
- Export Grades.
- Change an 'EX' grade to a different case, i.e. 'ex', 'eX', 'Ex', then import
the same CSV file.
- Note that 'no changes made' page is displayed
Change-Id: I97bf28d2c9a333cd38f9890b10df1d41a6db322e
Reviewed-on: https://gerrit.instructure.com/59920
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
Option 'Clone Group Set' added in the group set cog wheel.
When modifying group membership on a group that has submitted an
assignment, teacher is alerted and given option of cloning group set
or changing groups.
fixes CNVS-19746
test plan:
- as a teacher
- navigate to a course
- select 'People' and go to 'Groups'
- create a new group set with groups and memberships
- create a group assignment for that group set
- as a student who is a member of a group of that group set
- submit the assignment for their group
- as a teacher
- modify the memberships for that group set
- for groups that have submissions
- drag and drop a student
- out of group into another group
- out of group into 'Unassigned Students'
- into group from another group
- into group from 'Unassigned Students'
- remove student using 'Remove' option in cog wheel
- move student using 'Move To...' option in cog wheel
- add student from 'Unassigned Students' using '+' option
- when 'Clone Group Set' modal is displayed
- select 'New Group Set'
- memberships in original group set should not change
- within cloned group set
- should contain all groups, group leader, memberships,
and membership limits from original group set
- group membership modification should function as normal
- selecting 'Change Groups'
- group membership changes
- delete assignment created for group set
- group membership modification should function as normal
- select 'Clone Group Set' option from group set cog wheel
- should follow same expectations when 'New Group Set' is
selected from alert
- significant UI changes were made and should be tested
- accessibility has been considered and should be tested
- regression test on group
Change-Id: I59276eca93f86d370f8658f5bdd0e9464f3fa061
Reviewed-on: https://gerrit.instructure.com/58753
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Andraia Allsop <aallsop@instructure.com>
refs #CNVS-21596
Change-Id: If144ea4e42fd632ef80339b450cda9c20b3fb555
Reviewed-on: https://gerrit.instructure.com/60149
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-22366
Test Plan:
1) Add a module with the "must complete all" requirements option.
2) For one of the requirements, have an assignment with a "score at least"
3) As a student, submit the assignment
4) Ensure that the yellow warning sign is now showing in the module header
Change-Id: Idf7067ae7ee9f9361abb44a1d91bb554d164b462
Reviewed-on: https://gerrit.instructure.com/60043
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>
fixes CNVS-22168
Test Plan:
* Create a course and multiple grading schemes
* Attempt to change the course's grading scheme via API (course[grading_standard_id]) as an account user with "Edit Grades" permission disabled
* You should receive a HTTP 401 (Unauthorized) response
* If "Edit Grades" permissions is enabled, the grading scheme should change without issue.
Change-Id: I685166062636170b69906457c0c46a74ee6d9500
Reviewed-on: https://gerrit.instructure.com/59933
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-21391
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS updates CC::WebResources#add_course_files to pass a user
instance to the ContentZipper instance it uses to zip up a course's
files, so that the ContentZipper can determine if the user has the
correct permissions to see the files.
Also, we update ContentZipper so that a user can be provided via
attr_writter.
test plan:
- Regression test for content export tool files functionality.
Change-Id: Ic5edecef28d60d9517ce3a67bc8aef5c5dade9cc
Reviewed-on: https://gerrit.instructure.com/59440
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-21394
The content export tool is being updated so that it consders the
provided user's rights, so that the CC export can be used for the new
epub generation tool.
This PS employs DiscussionTopic::ScopedToUser to make sure that the user
only gets the discussion topics that they have the right to view.
test plan:
- Regression test for content export tool discussion topic functionality.
Change-Id: Id67bf1ed69c4b2066ff9d81678a5d61d52702978
Reviewed-on: https://gerrit.instructure.com/59365
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
jyetukuri,panda,1
Change-Id: I2c102404ec4c712bfee834f9cfb2c94681ced07d
Reviewed-on: https://gerrit.instructure.com/60163
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Pedro Fajardo <pfajardo@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
fixes CNVS-22165
test plan:
* go to /accounts/self/authentication_providers
* create at least two ldap configs
* ensure the radio buttons work independently
per ldap configuration
* ensure radio button selections save properly
* default ldap config should check
"No TLS" by default
Change-Id: Ibb1702b0d732a91856191b054d33c389a5c0dbab
Reviewed-on: https://gerrit.instructure.com/60089
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: August Thornton <august@instructure.com>
- removes the Conferences and Collaborations tests
about Public Courses
Change-Id: Ic70e6c0b072f53d24bebe9e13468c1a2b574446d
Reviewed-on: https://gerrit.instructure.com/60151
Tested-by: Jenkins
Reviewed-by: Heath Hales <hhales@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes PLAT-957
Test Plan:
- Make sure a 'message_handler_id' column is added to the 'lti_resource_placements' table after migration
- Use the master branch of https://github.com/westonkd/lti_tool_provider_example and make sure
placements work as expected in Lti2Launch
- use the 'placements_to_message' branch of https://github.com/westonkd/lti_tool_provider_example and
make sure placements work as expected in Lti2Launch
Change-Id: I2d681eb8efb2a1c25e0250a89c09bb5d0c8ad797
Reviewed-on: https://gerrit.instructure.com/58654
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
- public_courses_spec was a shared example that was only
used within itself.
- since no team clearly owns public courses, each spec was sent
to the page it was being tested in
- creates a shared_context for public courses instead
- the tests for collaborations and conferences were not
given an id since these are testing broken behavior
(these might have to be completely removed in
the future)
Change-Id: Ibd6464e229402ba2aaa005a33c7f82badf007b1a
Reviewed-on: https://gerrit.instructure.com/60123
Tested-by: Jenkins
Reviewed-by: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Ryan Shaw