twilson, panda, 4
- added shared examples for iCanvas and SpeedGrader landing page
- minor changes to appium environment setup, school_domain now
defined in selenium.yml file
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ica180895f167e007cab14cadfe79e554a44f25da
Reviewed-on: https://gerrit.instructure.com/61118
Reviewed-by: Heath Hales <hhales@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Product-Review: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
When using SpeedGrader on an external URL page, the teacher is
presented with the URL as a link that opens in the frame and a second
instance of the link with the text "(View in a new tab.)" Because of
this, teachers have the option to choose to view inline or in a
seperate tab.
fixes CNVS-22370
test plan:
- In a published course with students...
- Add a URL submission assignment and publish it.
- As a student submit http://placekitten.com as the assignment
submission.
- As a teacher view the submission in speedgrader, and click the
submission links in the left frame.
- Confirm that the URL link opens in the iFrame and the "View in a new
tab" link opens in a new tab or window.
Change-Id: I4991db9cd12101f0cfdd719aed3e77acf0ce7a61
Reviewed-on: https://gerrit.instructure.com/60517
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
Entering any invalid character—e.g. &, }}, {{+, or space—as an initial
grade in either the Gradebook or SpeedGrader causes the grade to be
set to null and the workflow_state to remain in unsubmitted. Because
of this, results in SpeedGrader do not show the student as needing to
be graded.
fixes CNVS-20823
test plan:
- Create a course with multiple students and an assignment of any type.
- Enter any non-grade in either Gradebook or SpeedGrader (characters
like &, ?, +, etc…), and press 'Enter'
- Note that the character is removed as the field updates
- View the submission in SpeedGrader and note that the student shows
as unsubmitted by the lack of orange dot nor green checkmark next to
their name
Change-Id: Idae8c025739fdb051ca7c8089f3cc25fe1424690
Reviewed-on: https://gerrit.instructure.com/60851
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
The File Attachment and Media Comment buttons in the teacher comment
attachment area in the SpeedGrader Add a Comment area now navigates
and reads properly in screenreaders. As a result, navigation and
intention is now communicated clearer to users with accessibility
needs.
fixes CNVS-13135
test plan:
- Create a text entry assignment and have a student submit something
to be graded
- As a teacher, go into speedgrader for that assignment
- With a screenreader activated, select the Add a Comment text area
and navigate using tab over the following buttons: Submit Comment,
File Attachment, Media Comment
- Observe that after the Submit Comment button, the File Attachment and the
Media Comment buttons are read as "File Attachment Button" and "Media Comment
Button"
Change-Id: I05e45ada0f083e7bf1ae20433065909f55be133c
Reviewed-on: https://gerrit.instructure.com/60298
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
refs #CNVS-21317
Change-Id: Id9bbb04a92abd835af69ba5ec0c21ef758a8a324
Reviewed-on: https://gerrit.instructure.com/61146
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
hhales,panda,1
Change-Id: I5dae7af8288cba7a30f3f32e8b8f75bf9f66b41e
Reviewed-on: https://gerrit.instructure.com/61100
Tested-by: Jenkins
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-22555
test plan
- db:migrate should work
Change-Id: I6259abacf508195cbaca04e06bfed7ec202f5c8b
Reviewed-on: https://gerrit.instructure.com/61133
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Had to split up the n mastery and decaying average int
validation into two functions. There was an issue with
two error boxes being present on the page.
Above range and below range now each have their own tests.
Change-Id: I99954c3c75c2131eb31f3e40ca7c0589dbda761e
Reviewed-on: https://gerrit.instructure.com/61117
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
refs CNVS-22335
Test Plan:
- Search for a file that doesn't exist in files
- A message should appear saying that no results were found
Change-Id: Iba07fc829e612205417921f4618f29a9141d01dd
Reviewed-on: https://gerrit.instructure.com/61022
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
sshepherd,panda,6
Test Plan:
- Run specs
Change-Id: I6c62dc36b912edfcaf14bfeec59edcb5b6896627
Reviewed-on: https://gerrit.instructure.com/61112
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
added these files included by timezone_core recently; apparently they
need to be whitelisted
Change-Id: I529975dc7da25a9e2cb5c3a9d095796e30d0f6c7
test-plan: `grunt test` works for canvas_quizzes
Reviewed-on: https://gerrit.instructure.com/61094
Reviewed-by: Kacey Roberts <kroberts@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
test plan: N/A
Change-Id: I6b21021bc61cebc9d80990ee14b5c69cdc75164b
Reviewed-on: https://gerrit.instructure.com/59792
Tested-by: Jenkins
Reviewed-by: Christina Wuest <cwuest@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan: N/A
Change-Id: I6baddd64b542fc4fb8c8388a718b9456db01e0a6
Reviewed-on: https://gerrit.instructure.com/59785
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
this avoids repetive queries for site admin
Change-Id: I6c7ac3c49f47385167007b92b8e589257250c41f
Reviewed-on: https://gerrit.instructure.com/61016
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
also get rid of the :nil nonsense in caching - it's not needed in Rails 3
Change-Id: Ie2879f91e59898981ad2566a63a6b99350313165
Reviewed-on: https://gerrit.instructure.com/61017
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
that was only needed in rails 2
Change-Id: I1e2a00f65237d45ac82daa19eaecf5c589171718
Reviewed-on: https://gerrit.instructure.com/61025
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
apparently they are the exception to the asset_type
is class name rule
test plan:
* create an announcement
* it should count as a separate type of stream item in the
activity stream summary
refs #CNVS-22424
Change-Id: I4eefaab180e1dc8f441c9b23d0a2a237dac627c9
Reviewed-on: https://gerrit.instructure.com/61001
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-22536
Test Plan:
- New UI only
- When you open the "Admin" nav panel by clicking
the Admin link in the primary navigation, you
should now see an All Accounts link at the bottom
of the list of accounts
- Clicking on this link should take you to the Canvas
page where you can view all the accounts/subaccounts
you manage.
Change-Id: Ieeb38674f3c593c40105f79069bfef01673e3965
Reviewed-on: https://gerrit.instructure.com/61007
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
fixes CNVS-21569
Test plan:
1. Log into a course
2. Navigate to course settings (in the left column)
3. Select the Course Details tab
4. Scroll down to the Grading Scheme section and select set
grading scheme.
5. Confirm the grading schemes and the done button are
fully visible.
Change-Id: I72aa23056a4875f7d5a1aa1123d6f7315352f01d
Reviewed-on: https://gerrit.instructure.com/60461
Tested-by: Jenkins
Reviewed-by: Derek Bender <dbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-22312
Test plan
* Uploading images form fields should make sense and be navigable in screen readers
* Uploading JS/CSS files should make sense and be navigable in screen readers
* The 'Select Image' button should have a focus state when navigated to via keyboard
Changes
* Added an alt attribute to preview images
* Added a heading element for image names
* Added aria-hidden attribute to duplicate labels for image upload inputs
* Changed accessible label for image upload inputs to include the name of the image
* Removed duplicate label text (for screen readers) for JS/CSS upload inputs
* Added accessible button label for Reset button for JS/CSS uploads
* Added aria-hidden attributes to icons for JS/CSS uploads
* Added focus state for 'Select Image' "button"
Change-Id: I0763aaf26315660a9f2eb6f29d616abfec60f3a8
Reviewed-on: https://gerrit.instructure.com/60390
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
fixes the calendar modal being cut off when the browser
window is really small.
fixes CNVS-21755
test plan:
- From within the calendar create a new calendar event via the "+" icon
- Under the edit event field select the "more options" button
- Give the event a title and under the content editor add 20 lines (can be single character, just hit 'enter' after each one)
- Select "Update Event"
- Click the newly created event.
- Note that the top of popover (and the 'X' to close it) is positioned onscreen
- Enlarge and shrink the window notice x and title stay on screen
Change-Id: I37700ac74742ecd3ad27692a6e5393c21f7bf83a
Reviewed-on: https://gerrit.instructure.com/60328
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
- reason: the tests have been skipped for a very long
time due to waiting for an undefined refactor
Change-Id: I192689fe56063cd87d1cd7e68fe94b1d74c578c2
Reviewed-on: https://gerrit.instructure.com/60936
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
fixes PLAT-1174
Test Plan
~ make sure resource_handler_id from the lti_resource_placements table
~ make sure installing a tool via lti tool registration URL works correctly as
well as any other task that uses the Lti::ResourcePlacement model.
Change-Id: I058ae01cb43366342754e3fa9cdabf1c408cce0e
Reviewed-on: https://gerrit.instructure.com/60494
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
fixes CNVS-22216
test plan:
- with k12 feature flag off
- go to theme editor
- it doesnt show k12 brand config
- turn flag on
- go back to theme editor
- it does show k12 brand conifg
- turn flag off and check that it goes away
(note: it may take a little bit for the
change to kick in)
Change-Id: Ic4ab4557d5330426128d26890d739ee6feb98a7b
Reviewed-on: https://gerrit.instructure.com/60783
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-21898
test plan
- canvas should load with armenian
- date pickers should work
Change-Id: I45ad840fdbe711cb82337bd91ba4009496b19ff1
Reviewed-on: https://gerrit.instructure.com/60960
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
twilson, panda, 5
- refactor to support mobile SpeedGrader and mobile
Canvas apps for both Android and iOS
- landing_page_common moved to shared context to be
used with SpeedGrader and mobile Canvas
- to test: comment/uncomment appium init and skip
statements in mobile_common, spin up Appium server,
and run specs
Change-Id: I4862f69874549e972488f44b65c5aeac6b47bf4a
Reviewed-on: https://gerrit.instructure.com/60538
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Ben Bolton <bbolton@instructure.com>
QA-Review: Ben Bolton <bbolton@instructure.com>
test plan:
- enable new styles in the root account
- on a course files page, when the window is shrunk to where
the course nav doesn't fit, a hamburger menu should appear
to toggle it
- on a user files page, the hamburger menu should not be there
(because there is no course nav to toggle; currently it is
toggling an empty space)
fixes CNVS-21105
Change-Id: I229e308ead615f6790002aee3d17de436655f727
Reviewed-on: https://gerrit.instructure.com/60803
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-22217
Test Plan:
- In the NUI, open Theme Editor
- Make some change, and click preview in
the center of the screen
- The progress bar should now fit exactly
inside its container.
- instead of this
http://screencast.com/t/gqzsUkHGn
you should see this
http://www.screencast.com/t/DoalArPiaCjj
Change-Id: I8a1ca6011cffe66e9e870ef82ca3ae5d277f9fca
Reviewed-on: https://gerrit.instructure.com/60646
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
fixes CNVS-21535
For now this can just be a plain feature flag because feature
flags implement the "cascading state" functionality we want for
this setting. We can change the UI on this or convert it to a
new type of setting later if we think that's important enough.
test plan:
- Anonymous grading feature flag exists as a feature currently
under development (only visible to site admins until it is
turned on). Nothing else should be affected by this
flag's setting yet.
Change-Id: I5136265cd46af47ea48482b2ab5015112e079557
Reviewed-on: https://gerrit.instructure.com/60871
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-21581, CNVS-21582
test-plan:
- regression around all datepicker elements
- for each, when it loads with prepopulated data, that data should be
localized
- the prepopulated localized data should be valid to the datepicker
Change-Id: I633034967c70066e337dc22d9b9ad0cd84793834
Reviewed-on: https://gerrit.instructure.com/60229
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Mike Nomitch <mnomitch@instructure.com>
- reason: this spec does not contain any example blocks.
its methods are not used anywhere
Change-Id: Ia285e2a00cc230b0abc2efce5387bf739ac67f3e
Reviewed-on: https://gerrit.instructure.com/60926
Reviewed-by: Adrian Foong <afoong@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes CNVS-22516
test plan:
* explicitly link a login to a SAML provider
* view the users page for the user
* it should not error
Change-Id: I6a2b746f19963b2d9aa20808244a96353102b827
Reviewed-on: https://gerrit.instructure.com/60900
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Jahnavi Yetukuri