fixes CNVS-21995
Change-Id: I0e30cbf1508fdbe2a06e3b75f52146ea22c4234a
Reviewed-on: https://gerrit.instructure.com/61058
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-22604
test plan:
- create a new user and see they are required to accept terms.
- in a rails console, change the `account_terms_required`
setting for the account:
account = Account.find(<the account id here>)
account.settings[:account_terms_required] = false
account.save!
- create a new user and make sure they now don't have to accept terms.
Change-Id: I8a616aa314bb6c7a82bd0ae93f965c3a1c85ff36
Reviewed-on: https://gerrit.instructure.com/61333
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
- cache folder locked status
- don't load html content unnecessarily for
index page api calls
- preload enrollment terms for menu
refs #CNVS-21317
Change-Id: I43f7915edc8cb33049723a80970f7cc23df679ef
Reviewed-on: https://gerrit.instructure.com/61198
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
don't initialize AR records just to get asset_strings
refs #CNVS-21317
Change-Id: If6afb664807926936d6957cac6aed24cfadc74b4
Reviewed-on: https://gerrit.instructure.com/61251
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
should rescue from StaleObjectErrors (see #evaluate!)
closes #CNVS-22434
Change-Id: Ibd137fe0b5c5a18be25d865eddf357a4798cd85f
Reviewed-on: https://gerrit.instructure.com/60618
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a user in a course on another shard
* activity_stream/summary should still include
stream items from the other shard
closes #CNVS-22424
Change-Id: I37405a292ea28e76d9e559dd67fe82f8061e400f
Reviewed-on: https://gerrit.instructure.com/61300
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
index provisional grades by scorer instead, which simplifies
creation of multiple provisional grades in speedgrader
test plan: specs pass
refs CNVS-22010
Change-Id: I5ee3dd65174549cd251ad6e3c137d89780024043
Reviewed-on: https://gerrit.instructure.com/61279
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* create a course
* give it an integration id through the api
* reset the course content from the settings page
* should work
closes #CNVS-17370
Change-Id: I66d935e4688e9854a6f47604e33e358d7a0308fa
Reviewed-on: https://gerrit.instructure.com/61003
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-22552
Test Plan
1. In Safari with VoiceOver enabled, navigate to the Modules page of a course
2. Using ctrl+option+left/right arrows, move to the cog next to the module name
3. Select the Edit option
4. Move to the "Add requirement" option and press ctrl+option+space to click
5. Ensure that the focus is returned to the radio button so the user is aware
that the radio buttons appeared
Change-Id: Icd6a76447c46ffc25b709a361edb05a8a4e9b5db
Reviewed-on: https://gerrit.instructure.com/61288
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
ataniuchi,panda,1
Change-Id: I776266796918028d050d121277e5c2f7cb3a2178
Reviewed-on: https://gerrit.instructure.com/61207
Tested-by: Jenkins
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
ataniuchi,panda,2
Change-Id: I60e4b7a44faa23552a704a47d292addd07d86a11
Reviewed-on: https://gerrit.instructure.com/61314
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
test plan:
* go to a subaccount in site admin
* you should not see courses, statistics, outcomes, rubrics, grading,
question banks, or admin tools
Change-Id: I11e66273a07b29b3349da7e4dd680b7632485591
Reviewed-on: https://gerrit.instructure.com/61261
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
build query that search for overrides but delegates to assignment if none exist
fixes CNVS-20435
Change-Id: I0b88ccb78027e43a7d82c392a11b9980fff52174
Reviewed-on: https://gerrit.instructure.com/57176
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-22349
Test plan
0. In a course with sections navigate to the gradebook.
1. Confirm that there is a sections dropdown on the right.
2. Confirm there is NOT a sections dropdown on the left.
Change-Id: Ib0419fbf7cfd78be87277b487a9b1080ab22329f
Reviewed-on: https://gerrit.instructure.com/60656
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-22557
Test Plan:
- create a user and register them with google docs
- then try to register them with google drive
- notice you can change what email you want to register with
google drive
Change-Id: Id5894cd7fddf152491a27c2cadb17f5a93109b1b
Reviewed-on: https://gerrit.instructure.com/61293
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes CNVS-20609
Test Plan:
- Go to /accounts/XX/permissions
- Using the keyboard navigate to one of the permission buttons
- You should be able to open the menu with the Enter key
- You should be able to navigate up and down in the menu and
select a new permission
- Pressing Enter or Spacebar should select the new permission
Change-Id: I6ec2aa5a90e6f4a183816744e531fa0889cd5013
Reviewed-on: https://gerrit.instructure.com/60917
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
twilson, panda, 2
- added shared examples for Candroid and SpeedGrader for
login view and credentials
- minor simplification of iOS specs
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ia984a79bac51104dba232cf348a77fdc6a656c8b
Reviewed-on: https://gerrit.instructure.com/61280
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Dev keys with an account id will no longer be able to auth with users
outside their account.
Fixes PLAT-1202
Test Plan:
Create a dev key for one account
try to auth it with a user on another account
Change-Id: I16edb6abc4af59c7e903eaf9287cc081b610967f
Reviewed-on: https://gerrit.instructure.com/60561
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
- this is in preparation for separating the appium tests
from the selenium tests
- Test Plan:
make sure it passes Jenkins
make sure all the Appium Tests still work
Change-Id: Ie2810c489ed8672f4c3a99392927444b317618d4
Reviewed-on: https://gerrit.instructure.com/61263
Reviewed-by: Taylor Wilson <twilson@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
test plan:
* image files and thumbnail creation should work as before
closes #CNVS-22544
Change-Id: I5631b392a4f4371d6fba2065608b8ce65175dcd5
Reviewed-on: https://gerrit.instructure.com/61078
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
twilson, panda, 7
- added shared examples for iCanvas and SpeedGrader for
login view and credentials
- to test: comment/uncomment appium init and skip statements in
mobile_common, spin up Appium server, create and edit yml file,
and run specs
Change-Id: Ie32900026028ea36568343b85b275c4e00d33fa3
Reviewed-on: https://gerrit.instructure.com/61224
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure all test_ids match up to an existing test case in TestRails
mhargiss,panda,11
Change-Id: I347834d5be266aa8b422c1623f676fc374ebf7dc
Reviewed-on: https://gerrit.instructure.com/59274
Tested-by: Jenkins
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: Taylor Wilson <twilson@instructure.com>
otherwise it will ovewrite logger.level with the default
(:info on production)
refs #CNVS-21596
Change-Id: I18352300b769d141de7a83959568e627f6a519b4
Reviewed-on: https://gerrit.instructure.com/61257
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
avoid even going to redis for two common cases that are likely
already cached in-process, or for repeated calls to the same
method
Change-Id: Ia90dbe25d83ab69ba62f26c966884a041ff61f3d
Reviewed-on: https://gerrit.instructure.com/61093
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* query the sis assignments api for an account/course
* /api/sis/accounts/:account_id/assignments
* /api/sis/courses/:course_id/assignments
* the description field should not be returned for any assignment
fixes CNVS-22513
Change-Id: I2d679a3b7eedf4f4892ef5e7d1b93007e7500c7a
Reviewed-on: https://gerrit.instructure.com/60861
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
fixes CNVS-22506
test plan
- regression test google doc collaborations
Change-Id: I696562d74e317b465b1679513fa7f5ff913a1c99
Reviewed-on: https://gerrit.instructure.com/60923
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
We now pull the account from the developer key
Fixes PLAT-1200
Test Plan:
Run the tests?
not much really changed
none of is really exposed/used
Change-Id: I88b3b9b907ae7b15145ac8e2e6fc1a18527b40d5
Reviewed-on: https://gerrit.instructure.com/60544
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
don't stuff them in the fake js_env and join the data there
just return them with the rest of the speedgrader data
also don't do unnecessary permissions checks on every rubric
assessment
test plan:
* regression test speedgrader rubric assessments
closes #CNVS-22522
Change-Id: I31a025c8f23b054857823f411a229780c27cb94f
Reviewed-on: https://gerrit.instructure.com/60963
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
loading AccountServies.allowable_services shouldn't calculate
"expose_to_ui" when unnecessary
Change-Id: I86c6bebb88c372932283b063054a5f9e5fb947e1
Reviewed-on: https://gerrit.instructure.com/61186
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
sshepherd,panda,9
Test Plan:
- Run specs
Change-Id: I34630c52b3fcd8b3076b2c1ea6ed52bcfd24021a
Reviewed-on: https://gerrit.instructure.com/61231
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Slight structural change to post grades button to make style more
uniform. Test plan from original ticket where button was added is
pasted below for ease of testing. Verify that change works for old and
new canvas styles.
Test Plan:
* configure powerschool grade posting by enabling sis feature flag
* /accounts/:id/settings
* "post grades to sis" -> on
* /courses/:id/settings
* SIS ID -> random number
* add an assignment, make sure that "post grades to sis" is checked
* navigate to gradebook, verify that "post grades" button is visible
* verify that "post grades" button is not visible when no assignments
are present
* click on button and verify that current powerschool modal launches
* add sisapp lti launch
* get local sisapp running
* /accounts/1/settings/configurations
* add app, by url http://<local sisapp>/post_grades/config.xml
* navigate to gradebook, verify that both powerschool post and new
lti post are available in drop down menu
closes CNVS-22119
Change-Id: Id57bed25774e4bff2208eb8a7ec1f318a276f1c5
Reviewed-on: https://gerrit.instructure.com/60378
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
Matthew Berns