closes ADV-104
flag=top_navigation_placement
Test plan:
- NOTE: You must restart the web container after running Setting.set
- PreReqs:
- A tool with the `top_navigation` placement
- On a Canvas page with the Top Navigation, check the following
- Without the tool in the allow list
- ENV does not have key `top_navigation_tools`
- No tool buttons show up in the navigation bar
- With the tool in the allow list by dev key
Setting.set("top_navigation_allowed_dev_keys", "global-dev-key-id")
- ENV.top_navigation_tools is populated with the tool config
- The tool menu button shows up in the top navigation bar
- The tool is listed in the menu and can be launched in drawer
- Adjust the page to mobile width
- Ensure the tool menu shows up in mobile header and can be launched
- The tool should open in a tray that overlays the content
- Repeat with the tool only in the domain list
Setting.set("top_navigation_allowed_dev_keys", "")
Setting.set("top_navigation_allowed_launch_domains", "tool-launch-domain")
- With the tool in either allow list, add it to the pinned keys list
Setting.set("top_navigation_pinned_dev_keys", "global-dev-key-id")
- Ensure the tool has a dedicated button in top nav and the tool menu
is not rendered.
- Repeate with the tool only in the allowd domains list
Setting.set("top_navigation_pinned_dev_keys", "")
Setting.set("top_navigation_pinned_launch_domains", "tool-launch-domain")
- With the tool in the pinned list but not the allowed list, ensure it
is not rendered in the top navigation menu and is not in ENV.
Change-Id: I267b78316e54dab7f811e3a7d8eaa752668ac5db
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347352
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Dustin Cowles <dustin.cowles@instructure.com>
closes OUT-6339 OUT-6346
flag=none
Test Plan:
- There are many cases that are handled by the automated and unit
tests. The following steps are to ensure the page loads
and behaves properly:
- Open the User Courses page (/courses)
- Observe that each column now has a sorting icon next to the
column name
- Observe that the Published column is default sorted in
ascending order
- Click through the different columns and observe that sorting
by those columns and in descending order works as expected
Change-Id: Ie522e17f161f2a4d0ed8c35f62c5006162de9bd5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346737
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Yosifov <martin.yosifov@instructure.com>
QA-Review: Martin Yosifov <martin.yosifov@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Add AnalyticsHub as a remote module through webpacks module federation
plugin and create/modify the needed files to show it on the menu.
https://instructure.atlassian.net/browse/EAX-698
flag=analytics_hub
refs EAX-698
test plan:
- enable feature flag then check if Analytics Hub menu is presented in the sidebar
- Analytics Hub menu should show the remote module
Change-Id: I1f6cf0ed0ce6feb244d9cc961875884f3ad2a92f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345475
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
added a warning modal on course copy process
to advise the user the grading scheme
should not be copy because is archived.
fixes EVAL-3918
flag=archived_grading_schemes
test plan:
- Go to database and set for one of grading standards
the workflow_state to archived
- change a course to use this archived grading scheme
setting the field grading_standard_id
- go to this course copy UI
- a modal with a warning should be displayed saying
the grading standard should be not copy
- Validate the modal can be closed and the copy process
works without problems
Change-Id: Ica85ff261776ef39b0743c08021addebad320201
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339117
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
This commit adds a scaffolded FE for the LTI extensions page in Canvas
test plan:
Go to Admin -> Extensions and click between Manage/Discover to make sure
the routing works and reload pages to make sure the nested urls work.
Turn the lti_registrations_discover_page feature flag off to make sure
the page the discover page is not accessible, and then turn the
lti_registrations_page off to make sure the whole extensions view is
not accessible.
fixes: INTEROP-8515
flag=lti_registrations_page
Change-Id: I7d34b387d03a4bce66325a4791645c6502784b12
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341783
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Steve Mcgee <steve.mcgee@instructure.com>
QA-Review: Steve Mcgee <steve.mcgee@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
closes LF-1331
flag=instui_header
test plan:
- go to the modules page
- test with a course with no modules
- test with a course with modules
- button expand/collapse should not appear when no modules
Change-Id: I43410c6978d6fbc4156b4154a0e092dff52678f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341790
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Alvaro Talavera <alvaro.talavera@instructure.com>
closes LF-1221
flag=instui_header
test plan:
- goto modules page for a course
- check that new header match specifications
Change-Id: Idd77b2fb01778d337207c4dedb4aeefb18ac5d45
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341101
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Alvaro Talavera <alvaro.talavera@instructure.com>
When the feature flag is enabled, and when the param platform_sg is
passed in the URL, launch the platform speedgrader instead of default
speedgrader. This will allow for easily testing between classic
speedgrader and platform speedgrader.
flag=platform_service_speedgrader
test plan:
- Have a course with some students and an assignment
- Enable the feature flag
- Either have a local module federation server running or supply a URL
to dynamic configuration for the launch url
- Go to the assignment and click on speedgrader
- Note that classic sg loads
- add "&platform_sg=true" to the URL and refresh
- Note the new hotness
Change-Id: I6341406f563256c54cc009589a22b93019600373
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340885
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
refs LF-1199
flag = none
Test plan:
- Make sure the deprecate_faculty_journal flag is disabled
- Go to the following pages and expect an alert to appear at the top
of the page indicating that FJ is deprecated on June 15:
- /accounts/:id/user_notes
- /courses/:id/user_notes
- /users/:id/user_notes
Change-Id: I4b57f7dead5d2a9960f1943a4da947c736e671bd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340752
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=block_editor
This is an initial commit for the block editor work. It adds Editor.js,
a storybook example, and implements an editor change for wiki pages to
use the new component.
test plan:
- Access the Block Editor component in Storybook.
- Verify it renders and works correctly.
- Turn the block editor flag on for an account.
- Edit a wiki page
- Verify the block editor is shown and works.
Change-Id: Icc57e7939b70fa141c2be4dde6cf34784ae995c6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331823
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Migration-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
better for static analysis of the frontend
also helps gives visibility to what we need to move to
ui/boot/initializers/router.tsx
test plan:
- tests pass
flag=none
Change-Id: I8ff04a7449293abcb54379ce4d5a51fcbe312ae3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335975
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Josh Wilson <josh.wilson@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Dustin Cowles