flag=none
fixes RCX-1960
Test Plan:
- Change user language
- Go to each of the changed areas
* Verify they translate properly
Change-Id: I97cc434093f666b2ac4720899912af498f95820e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349165
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
PS 28 changes ParagraphBlock to TextBlock.
closes RCX-1979
flag=block_editor
test plan: some day, but this is a prototype demo
Change-Id: I00427567382c7c8b1dfdc6677df63b07dba16af0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347253
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes RCX-1946
flag=file_verifiers_for_quiz_links
Test plan
- Build with quizzes and ensure any course
file links you create in quizzes have file
verifiers
- Turn off the feature flag and ensure that
file links do not get verifiers added
Change-Id: Iafa86afce339182afa728581a7c4c7a7c8e38cc6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348782
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
flag=rce_find_replace
fixes RCX-1929
Test Plan:
- Have rce_find_replace FF on
- Change user language
- Go to RCE and open find and replace tray
* Verify text is now translated
Change-Id: I800167de4ff4743f4ee2385a80293c5e18bbaf04
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349160
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
The learning materials team has been defunct since ~May 2023
Change-Id: I10796d3da8f438c5fe9f97f30ed739797386ac1a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349058
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jake Oeding <jake.oeding@instructure.com>
flag=none
fixes RCX-1836
Test Plan:
- Copy RCE changes into NQ
- In NQ, open an RCE, open a11y checker
- Click off RCE so it collapses
- Re-open RCE and a11y checker
- Click off RCE so it collapses
- Close the a11y checker
* Verify it closes
Change-Id: Icb78b6924f8228c5fb2a9da9d0a2f1248b731f88
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348486
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
refs RCX-1946
Test plan
- Specs pass
- Maybe run these specs specifically because
I'm not sure Jenkins is doing it
Change-Id: I8104f37e151a8781714d3d8585c21717b708098f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348784
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
refs LF-1528
flag=none
Test Plan:
- specs pass
- all specs addressed in LF-1528
Change-Id: If057a856b3192ab7bf38e6731a52146e112df7b5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347535
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Tamas Barna <tamas.barna@instructure.com>
Test plan:
- Create course with 50 students and 10 assignments
- In Gradebook, use both scrollbars
- Neither should interfere with content
Fixes EVAL-4172
Change-Id: I8cbefc111770b27e177e731e1987bcad3f2f6ec4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347826
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LF-1410
flag=none
Test Plan:
- Verify in Pages that SR works normally for RCE
- Preview a NQ and verify that SR can navigate to essay question
Change-Id: Ic43c4bafe082d9d3b088a3e652b549e97c3fa3fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347337
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
Closes CFA-60
flag=none
Another stop on the way to zero tsc errors in the codebase.
Test plan:
* tsc no longer generates errors in this bundle
* build passes
Change-Id: I8f28beaa436dfcf9946b4d246d361f19fc1429b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347057
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
flag=none
fixes ADV-93
test plan:
- Create a single Canvas Wiki page using the RCE with some content
- Configure an ordinary LTI tool with editor_button placement (one
which does not have the custom scope
'https://canvas.instructure.com/lti/replace_editor_contents')
- Observe whether the tool works as before (just inserting at the
caret or replacing selection in the RCE)
- Configure an editor_button LTI tool which has the custom scope
'https://canvas.instructure.com/lti/replace_editor_contents'
configured
- One example of such LTI tool is available at
'https://content-assist-tool-pdx.research.inscloudgate.net' with
the LTI configuration JSON available at the same URL under
the path '/lti/config'
- Observe whether it can replace the whole content in the RCE
Change-Id: I7ff9a265b996a325bc2bb035efd8f8ee7f29d0d8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/343639
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Attila Toth <attila.toth@instructure.com>
Product-Review: Attila Toth <attila.toth@instructure.com>
flag=rce_find_replace
Test Plan: Jenkins
Change-Id: I942ff12f6c7e7e06d886dabe64249740e1037c89
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346673
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
Closes LF-1507
Test Plan:
1. set language to ES or something besides english
2. set up a page or assignment and in the RCE upload a file and set to
Preview Inline. Save the page
3. on the Show page for that page, click on the file you just added.
There should be a Minimize File Preview underneath plus a preview
box. The Minimize File Preview should be in the language you chose.
Change-Id: Ic6b128dc22721b947e8a1171a3ab283b8954fd34
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346497
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
flag=rce_find_replace
Test Plan: Jenkins
Change-Id: Id68353b98d86dd7b6113fccfe26380901369bf87
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346449
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
flag=rce_find_replace
fixes LF-1474
Test Plan:
- Have flag on, go to RCE with content
- With screenreader on, open find replace tray
- Search for text / scroll through results / replace text
* Screenreader should read out text surrounding the current result
Change-Id: I34155135a5c172bfc83aab513aec70fd8c6a4ab8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346097
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
closes EVAL-3896
flag=none
Test Plan:
- Create a points based grading scheme with a range of
A: 15 <= 13
B: < 13 <= 10
C: < 10 <= 7
D: < 7 <= 0
- Set a letter graded assignment ot that scheme and ensure a 13 is an A
and a 12.999 is a B and a 10 is a B and a 9.999 is a C and a 7 is a C
- Ensure this works for all places grades are displayed like:
-gradebook
-individual gradebook
-student grades page
-etc
Change-Id: Icdf901c42c8c9ce45abe2943e6a073045fca56db
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/343681
QA-Review: Rohan Chugh <rohan.chugh@instructure.com>
Product-Review: Melissa Kruger <melissa.kruger@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=rce_find_replace
fixes LF-1475
Test Plan:
- Go to RCE
- Open find replace tray
- Replace text
* Message is read out about replaced text
- Replace all text
* Message is read out about replacing all text
Change-Id: I7a0ed3362a0c3d66a2bce9151056a56e176de951
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345623
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
closes LF-1472
flag=rce_find_replace
Test Plan:
- Have flag enabled
- Go to an RCE with content
- Open find replace tray
- Search for text with multiple results
- Have text in the replace text input
- With screenreader on, tab to each button
* Next button reads "Next {findText}"
* Previous button reads "Previous {findText}"
* Replace All button reads "Replace all {findText} with {replaceText}"
* Replace button reads "Replace {findText} with {replaceText}"
Change-Id: I9a010a90df53d0754ee86a433eeb7b9b67d23ddd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345185
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
closes LF-1470
flag=rce_find_replace
Test Plan:
- Have flag enabled
- Go to an RCE
- Open find and replace
* Next and previous buttons are under the find input
* Search buttons and replace buttons have same styling
* All other functionality/UI is unchanged
Change-Id: I4a795a8f6d32648c92c873b220acdb9175dfbbf0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345182
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
Jacob DeWar