ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
59,374 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

7 Commits

Author SHA1 Message Date
Aaron Shafovaloff 82f5544f62 Simplify grading-utils package 
Test plan:
  - build passes

Change-Id: I7947fb068b308879ea87d5559b911c33ea2336f7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335259
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2024-01-02 20:42:19 +00:00
Aaron Shafovaloff 8b50a205ee Resolve final circular package dependencies 
Refs CFA-27

flag=none

Change-Id: I9787633a7deef3206f1462e8f65936dc51f1af3d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335951
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2023-12-24 19:37:09 +00:00
Aaron Shafovaloff 627ed1ac74 move outcome-content-view into outcomes 
Change-Id: Id3c7d3fbd3a2686a29e198f025210b85199d53ca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335680
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2023-12-19 23:46:23 +00:00
Aaron Shafovaloff d6b0d0818a upgrade vitest 
also:
 - more tests passing in vitests
 - specifies which folders are left to resolve in the vitest config

test plan:
  - build passes

Change-Id: I34fee1a8b44101fec4b801fa6f67b9562df0425c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335009
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2023-12-11 19:09:35 +00:00
Aaron Shafovaloff abd4f77040 Localize jest-fetch-mock usage 
Removes global use of jest-fetch-mock, which inhibits
migration to vitest.

Also:
  - TypeScriptify Confetti
  - more properly tests confetti with testing-library
  - removes needless setTimeout on confetti SR-only flashAlert

Test plan
  - Submit assignment as student
  - Confetti should still show

flag=none

Change-Id: I70fdc23dbc6d18a37487abeaa7625c441cc64d77
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333193
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2023-11-20 17:42:32 +00:00
Aaron Shafovaloff dd69a65cb0 Improve Vitest coverage 
test plan:
  - build passes

flag=none

Change-Id: Id35a39d300e7c74dbb0ff5758490b85c23f283ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333167
Reviewed-by: Paul Gray <paul.gray@instructure.com>
Reviewed-by: Gustavo Bernardes <gustavo.bernardes@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2023-11-17 22:16:01 +00:00
Aaron Shafovaloff e1384057d1 Install Vitest 
This does not yet change our build process

Demo:
  - yarn run test:vitest:watch ui/features/theme_editor/

Test plan:
  - build passes

Closes CFA-17

flag=none

Change-Id: I6eac4684af62525829e36f5dd0c64bb80c638ca3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333130
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Ochoa <martin.ochoa@instructure.com>
Reviewed-by: Gustavo Bernardes <gustavo.bernardes@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2023-11-17 14:19:22 +00:00