ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
62,032 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

14 Commits

Author SHA1 Message Date
Aaron Ogata 33c90aa925 stop loading webpack-builder image twice before running JS specs 
refs DE-1345

saves ~90s when running JS stages

Change-Id: I3cdb97193e8b420e7eed3f63eecedf7a12a5d907
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298579
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
 2022-08-17 13:45:40 +00:00
Aaron Ogata d4ee7b314c use selenium grid for karma tests 
refs DE-1334

Change-Id: I61e78a60498b9fd64ea9d5333504c4db10c8c03f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298285
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2022-08-11 18:31:34 +00:00
Andrea Cirulli 796257539e fix linter rules 
Fix following linter issues:
- ParameterName
- CouldBeSwitchStatement
- UnusedMethodParameter

refs DE-690
flag = none

test-plan:
- Build passes
- QA build that triggers FSC and executes the spec changed

Change-Id: I11baf5094e96d33bc6be7f5f03d680f34cc1d026
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265266
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
 2021-05-19 15:43:33 +00:00
Andrea Cirulli ae53d74676 skip UnnecessaryPackageReference linter issue 
refs DE-643
flag = none

test-plan:
- build passes

Change-Id: I2b10d6da84975cb0fb1862fea8c7dd0b788448a1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264831
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-12 21:27:17 +00:00
Andrea Cirulli 5868948b6a skip invertedifelse linter rule 
refs DE-643
flag = none

test-plan:
- Build passes

Change-Id: I5fae5eb3d25bbefad02c9033124f2ab54c996bb8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264721
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-05-11 21:11:39 +00:00
Andrea Cirulli be291f6c02 skip UnnecessaryObjectReferences linter rule 
refs DE-643
flag = none

test-plan:
- linter error does not appear

Change-Id: I3c197044e7c7f9d26f476d11e36de3cd11f0480f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264664
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-11 15:03:37 +00:00
Andrea Cirulli 47846eb323 skip throw exception linter rule 
refs DE-643
flag = none

test-plan:
- build passes

Change-Id: I321dac92e8b2458e152177389349dce15e3b657e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264520
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-10 15:27:24 +00:00
Andrea Cirulli f650b95f9a fix VariableName linter issues 
Fix the linter issues and restore the previous behaviour of codeNarc
for final variables

  refs DE-643
  flag = none

  test-plan:
  - build passes

Change-Id: I16f5e388e32fe0aec6789f1f87b0da03b1eacc83
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264362
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-06 20:17:43 +00:00
Andrea Cirulli 3de0dbb728 skip linter rules 
skip the following linter rules:
- ClassJavadoc
- CompileStatic
- FactoryMethodName
- PropertyName
- UnnecessarySetter
- BuilderMethodWithSideEffects
- Instanceof
- EmptyCatchBlock

refs DE-643
flag = none

Change-Id: I9bf3667b2e875730a48de9d57ac3568b1afbf478
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264181
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-04 18:54:47 +00:00
Andrea Cirulli 4d9162d5ea skip linter rules 
Skip the following linter rules:
- MethodName
- LineLength
- UnnecessaryGetter
- FieldTypeRequired

refs DE-643
flag=none

test-plan:
- build passes

Change-Id: Ibcdaa50826b2243768691888e78d98b6ec94e7c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264113
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-03 21:51:31 +00:00
Andrea Cirulli a958b636fd skip JUnitStyleAssertions linter rule 
refs DE-643
flag = none

test-plan:
- build passes

Change-Id: I46a92b3b1020444f9a3b83373ff2428d3eb31bbf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264105
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-03 21:03:30 +00:00
Kyle Rosenbaum 20084f7fe7 skip groovylinter rules 
refs DE-643 DE-662

skipping linter rules due to noise and difficulty of
fixing the issue.

Change-Id: Ic1a46538783a3fa0b849a1f765d6f6fd79c0db97
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264069
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
 2021-05-03 17:46:08 +00:00
Aaron Ogata e108e64784 apply formatting.ClassStartsWithBlankLine to linter 
refs DE-643

Change-Id: I27c696a4c34a3109247b9da3c0158d19f44252c3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264053
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2021-05-03 14:29:15 +00:00
Aaron Ogata 70b06aaa0b apply autoformatter to all files 
refs DE-643

Change-Id: I9482afa27e6b8734640741fca784f971f782af26
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264050
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-05-03 14:07:45 +00:00