fixes: CNVS-29208
as part of https://gerrit.instructure.com/77427
we created a remove_brand_dir! method but in code
review decided it would be better to call it
remove_scss_dir! but did not catch renaming
this one spot where didn't change it
test plan:
go to theme editor
make change and preview 3 different times
it should not have a page error
Change-Id: Ifca9eaa03477414925a0e5427568d1754af352f9
Reviewed-on: https://gerrit.instructure.com/79016
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Previous to this change if the callback only contained
'$' or '_' as variables to hold the required dependency,
it was not detected and qunit was not injected properly
fixes CNVS-29207
Test Plan:
- Automated tests pass that contain only $
- Normal automated tests pass
Change-Id: I22d9cb390bfc1f0b579577dc7bec2de40fd5dc3f
Reviewed-on: https://gerrit.instructure.com/79017
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
- enable "submissions folder" feature
- submit a file to an assignment if you have not done so
previously, so you have submissions folder(s)
- use the folders API to list user folders
- ensure "for_submissions" is returned correctly
("true" for submissions folders, "false" otherwise)
- ensure the API docs explain this field
refs CNVS-28394
Change-Id: I3cb940316a61d0138a3848d82d5288955d15f921
Reviewed-on: https://gerrit.instructure.com/78935
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-24815
test plan:
- Create two sections one in the past and one in the future
- Create an assignment and assign the past section first to a valid
date
- Assign the future section to a date withing the future section
range but not within the past section
- ensure that no error is displayed
Change-Id: I59ebe6345184a5f7d8876a32a9fef02eec4b51a9
Reviewed-on: https://gerrit.instructure.com/71087
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Tested-by: Jenkins
Product-Review: Davis McClellan <dmcclellan@instructure.com>
test plan:
* import the package referenced in the ticket
* it should have assignments instead of plain html files
closes #CNVS-29203
Change-Id: Ibf77b940d4c0d1fc1a6bd6a8bb2a7d9187eb1590
Reviewed-on: https://gerrit.instructure.com/78996
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-28841
test plan:
- as a user with the new ui
- click the "account" link from the left nav
- from the sub-nav click "files"
- if you do not have any items uploaded - do so
in order to click an item and see the action
buttons groupset... a few tweaks have been
made to bring it inline with products design
example: http://screencast.com/t/QA6E3u5u
- next click into a course and from the course
sub-nav click "files" - the tweaks from above
should be viewable on this page as well
example: http://screencast.com/t/85IoRnYwlpiE
note:
- a comment has been left on the jira regarding
the odd course sub-nav placement for files
within a course *** wil need to be addressed
on a new ticket/commit
Change-Id: I49cae6c4057e44076ce9cae0489f02c065927f85
Reviewed-on: https://gerrit.instructure.com/77893
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-28943
test plan
- account reports should run
Change-Id: Id4369a18be011248d42688c0ca1af0d5bc35c7b2
Reviewed-on: https://gerrit.instructure.com/77944
Reviewed-by: Tyson Brown <tbrown@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fixes CNVS-29026
Test Plan:
- In Safari with VoiceOver on, navigate to the Settings page of a course
- Click on the Student View button in the right column
- Navigate to first div in page letting you know you are masquerading
- Move to another page in the course
- Navigate to first div in page letting you know you are masquerading
Change-Id: If774dd2bdbd0bf736f465a9e8b50d1f2c3e16789
Reviewed-on: https://gerrit.instructure.com/78795
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
test plan:
1. run canvas w/ LOLCALIZE=true
2. there should be lols
Change-Id: I5e557518c29d0c024c0ffdfb0155e9efc7523b30
Reviewed-on: https://gerrit.instructure.com/78997
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
fixes CNVS-27519
test plan
- ensure that observers observing students who would normally
receive the following notifications receive them also:
- appointment reserved by user
- appointment cancelled by user
- appointment group published
- appointment group updated
- appointment group deleted
Change-Id: I344fbafc425bbd523511950193b295aa28ff469e
Reviewed-on: https://gerrit.instructure.com/75344
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
add alt text and fix css issue causing top of avatar to be cut off
test plan:
- navigate to courses search page
- note that teacher avatars are round and the top is not cut off
fixes CNVS-28770
Change-Id: Iac4e3cd8eebb86e0290d335d2b9daa5165f94c0c
Reviewed-on: https://gerrit.instructure.com/77256
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
refs: CNVS-28781
...and remove fancy conditional comment
thing that adds the .ie & .ie9 classes to the page.
And now that we know that IE9 will never be using
the site, remove some css that specifically targeted it
test plan:
* try go to to canvas in ie9,
* it should redirect you to a "not supported" page
Change-Id: Ia4e020afeebe13bad730d7591736fd4e141bf387
Reviewed-on: https://gerrit.instructure.com/77318
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Tested-by: Jenkins
fixes CNVS-28602
Test Plan:
- Register an SMS endpoint
- Ensure text in modal for character validation
is translated and looks good.
- Ensure the modal matches what blake posted
on the ticket.
Change-Id: Ia4da0cff2e3b8b05a12b4f549b787764aa1d2f77
Reviewed-on: https://gerrit.instructure.com/78944
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes CNVS-29197
Fixes `NameError: uninitialized constant Canvas` error caused when
calling `BrandableCSS.save_default_json!`, because it is expecting
`Canvas::Cdn` to be auto loaded.
Since this task invokes brand_configs:write, which loads the
environment, generate_and_upload_all may as well extend :environment
too. Problem solved!
Change-Id: I03d6c789cff850d984832b27f05fb4163c5b0368
Reviewed-on: https://gerrit.instructure.com/78960
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Change-Id: I8f233a319d65edeabf6d5bd4720a36d7f074e231
Reviewed-on: https://gerrit.instructure.com/78878
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Fixes CNVS-28388
Test plan:
- Set up Canvadocs
- Upload a file whose name ends with .txt to a course's files
- Make a wiki page
- Include a link to the file in the page
- View the page
- Click on the link
- On the page you're taken to, click the "Download ..." link at
the top
- Verify the file gets downloaded instead of simply opened in a
new tab
Change-Id: Ib357f7edcc70a320f66707091209e43defbcd8c7
Reviewed-on: https://gerrit.instructure.com/76593
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
test plan:
- create and start a conference (wimba or bbb)
- as a teacher, click the conference name in the
conference invitation at the top of a course page
(not the "join" button).
it should take you to the conference edit page.
- as a student, click the conference name in the
invitation. it should take you to the conferences
page and scroll the selected conference into view.
fixes CNVS-29134
Change-Id: I3fd5bc5312c6253d58597272fe7367567c957ba7
Reviewed-on: https://gerrit.instructure.com/78879
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-28708
Test plan:
- New UI only
- Go to any page featuring the primary navigation,
using IE11/Win7 and 10
- There should be no more space between the text
and the Help icon (see the JIRA ticket for
a screenshot of the bug)
Change-Id: I7c05b7b8aaf12b455963e1231e18e23dac523702
Reviewed-on: https://gerrit.instructure.com/78481
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-29027
Test Plan:
In Firefox with NVDA active, navigate to a Files page
Move NVDA focus to the Search field
Note that there is a label to notify the user
Change-Id: I48ecb027d9299b4a3a9a0e59627779713e939594
Reviewed-on: https://gerrit.instructure.com/78839
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Change-Id: I9608189765981ac667208fdb6216ff66a181bfc4
Reviewed-on: https://gerrit.instructure.com/78924
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* import the package referenced in the ticket
* the quiz should have a description and a
text only question introduction
closes #CNVS-28984
Change-Id: I273ffd58fffce98b46ccb8dc6fa9422cffb818ca
Reviewed-on: https://gerrit.instructure.com/78231
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes: CNVS-26493
For some pages like Syllabus, in legacy the right side would stick to
the bottom of the page as you scroll large content. In new ui, we
disable this, and the sidebar sticks to the top, no matter its content
height.
Test Plan:
- See ticket for full test setup
- Go to Syllabus with long content, long sidebar, see how you can
now scroll down the page just fine, no jumping
- Go to Syllabus with short content, long sidebar, see same
- Legacy UI remains the same
Change-Id: I746f6c6e41865e5cd20b96bf3e7a518190055294
Reviewed-on: https://gerrit.instructure.com/78098
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Previously on the Grades page of a course, if a student
using a screen reader clicked on the 'Show Saved "What-If"
Scores' button, there was no indication that anything on the
page had changed. The same happened for the "Revert to Actual
Score" button (which appeared once the "Show Saved" button
was pressed). Now there is a screereader-only flash message
that is read to indicate scores have been changed to reflect
what-if scores/original score. Focus should also be returned
to the what-if/revert button on the right pane.
fixes CNVS-27858
Test Plan:
1. Using VoiceOver in Safari, navigate to the Grades page
of a course as a student
2. Click on the "Show Saved 'What-If' Scores" button on
the right
3. The screenreader should now read "Grades are now
showing what-if scores"
4. Click on the "Revert to Actual Score" button
5. Screenreader should now read "Grades are now
reverted to original scores"
6. Ensure each time the buttons are clicked that the
focus is set back onto the button.
Change-Id: Iad31491a4de08cd3a16444c398b2e87373d6a95f
Reviewed-on: https://gerrit.instructure.com/76192
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins
also improve how single vs multiple errors are handled in error boxes
and in the screenreader flash message list.
finally, put screenreader flash messages in a div instead of a span,
because our form validation can add p tags to this area (because there
may be several error messages to display) and VO doesn't handle block
elements inside of span's very well.
fixes CNVS-20800
test plan:
- try to save a blank external feed url
- it should give you an error before trying to make a request to the
server
- try it with a screenreader (with a blank url, text that is not a url,
and a valid url)
- screenreader messages should be intelligible
Change-Id: I0a7a16253c128c2f62e87bc4b2e1d6e9b08f3d56
Reviewed-on: https://gerrit.instructure.com/64134
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes: CNVS-28914
Test plan:
- New UI only
- Go to your institution's Settings page and see if
the ePortfolios feature is enabled:
http://screencast.com/t/Eo1ltqyIG
- Change your ePortfolios account setting
- IMPORTANT: restart your Canvas server and hard-
refresh your browser
- Click on the Account link in the primary
navigation. If ePortfolios is disabled, you
should no longer see the ePortfolios link in
the menu:
http://screencast.com/t/GVLlTFzKX
Change-Id: I9c45ffe36241450557ab270203eebb9358be1104
Reviewed-on: https://gerrit.instructure.com/78576
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-29170
test plan
- update workflow_state of non student users
- it should not make a due date cacher job
Change-Id: Ia7ab7dc7ef0ce93434d9a2e63496883b5ae6d007
Reviewed-on: https://gerrit.instructure.com/78836
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
these also happen in go_to_checklist, so they are redundant
Change-Id: I93d9e0f78c3ee1f577d699a18e343b2d75b68a05
Reviewed-on: https://gerrit.instructure.com/78829
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
per http://marcgg.com/blog/2015/01/05/css-animations-failing-capybara-specs/
animiations slow things down and sometimes make it hard for selenium to
interact with things (e.g. it tries to click on a link that is moving, so
it mis-clicks and nothing happens)
requires a css tweak to dashboard color picker so that it still works with
animations disabled
this should fix ./spec/selenium/courses_spec.rb:178 and many others
Change-Id: I23667019948db4d1857ee9bb6c176ae8bc24f518
Reviewed-on: https://gerrit.instructure.com/78853
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
closes #CNVS-29171
Change-Id: I798663815215c5b4ddde3cb2bc779919fff99d68
Reviewed-on: https://gerrit.instructure.com/78861
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create a group set with two groups
* create a graded group discussion topic
and assign it only to one of the groups
* the root discussion topic page should only list a
link to the group the topic is assigned to
closes #CNVS-27979
Change-Id: I8e3864d1d377620c2a88902ed112b3f347208d77
Reviewed-on: https://gerrit.instructure.com/78691
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Rob Orton