Previous workaround for student submissions which were outstanding was
to visit each individual quiz show page from the moderate page. This
cleans up the moderate page with the ember styling, and adds the
functionality of outstanding quiz checking and submitting through the
API endpoint.
Closes CNVS-15502, CNVS-16197
Test Plan:
- Basically, a QA regression of the quiz moderate page
- ensure all quiz extensions still function
- ensure icons for manually unlocked, in progress time alterations,
and quiz extension notices are present
- Check for outstanding quiz extensions button functionality
- Shows an alert on page refresh if outstanding quiz submissions
exist
- Submits the selected submissions
- Hides alert if all the outstanding submissions were submitted,
otherwise shows the success flash message, but retains the alert
- Overflows with large lists
Change-Id: Idba6a4849a3dc32fe9c077236a7fa13a6db6ce00
Reviewed-on: https://gerrit.instructure.com/41441
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Change screenreader text to say Manage Announcement
Fixes CNVS-13974
Test Plan:
- NVDA in FF
- Go to the Announcements page
- Select an Announcement
- Navigate to the Manage Announcements link (Gear icon that comes after the edit button)
- Verify it say manage announcement
Change-Id: I059cd0a6d339569729df90df25246282860ecf1e
Reviewed-on: https://gerrit.instructure.com/42398
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
Corrected any noticed accessibility issues for quiz show control
buttons.
Closes: CNVS-6764
Test-Plan:
- Test that quiz show buttons are buttons
- Test that screenreaders read the buttons properly
Change-Id: I860b911e123500401d7925195a652918e56a33a1
Reviewed-on: https://gerrit.instructure.com/42106
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
when unlocking a quiz (with no time limit or for a specified period), the
quiz will now unlock correctly, and the students will be able to take it.
fixes CNVS-11727
test plan:
- Create a quiz. Set a due date, but no "from" or "until" date.
- Save and publish the quiz.
- Lock the quiz; note that the date/time at which you lock it now appears in the "until" field.
- Unlock the quiz with "No time limit". Note that the current date/time appears in the
"Available from" cell, and the "Until" date has been cleared out.
- Verify that you are able to take the quiz as a student, and note that there is no
specified end date for the quiz.
- Lock the quiz again, then unlock the quiz with a time limit (choose any date). Note that
the current date appears in the "Available from" cell, and the specified end date
appears in the "Until" cell.
- Verify that you are able to take the quiz as a student, and note that there is a specified
end date for the quiz.
Change-Id: I94ed3e26b7c91e84728c27e58c0e130444ef95a2
Reviewed-on: https://gerrit.instructure.com/42016
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
remove worse-than-useless policy block (the controllers are not
using it, checking :manage_grades on the context instead), and
let the view check whether the grading standard has assessed an
assignment, consistent with learning outcomes.
(Also, consistent with learning outcomes, the API can still edit
them. we just make it hard to mess with them accidentally in the
UI. I don't actually like this much, but apparently people
depend on this behavior.)
test plan:
1. link an assignment to a grading scheme
2. verify the grading scheme can still be edited
on the grading schemes page
3. as a student, submit the assignment
4. verify the grading scheme can still be edited
5. as a teacher, grade the student's submission
6. verify the grading scheme cannot be edited on
the grading standards page (no pencil icon appears)
fixes CNVS-15933
Change-Id: I21b67a25083169312c8b1c929d8e8ef305adc36c
Reviewed-on: https://gerrit.instructure.com/42234
Product-Review: Hilary Scharton <hilary@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Adds a status and selection field that have an aria-live attribute. Allowing
the fields to announce changes to it. Each time a result is
calculated for the autocomplete, the fields are updated and
the screen reader announces the changes.
fixes CNVS-12803
Test Plan:
- Activate a screenreader
- Go to /conversations
- Create a message.
- When you navigate to the To field and start typing the
autocomplete should popup. The screenreader should also
announce the number of items showing up in the list.
Change-Id: I80c38c412e0ce8eb3022ac26ce1bb733ef4b4b65
Reviewed-on: https://gerrit.instructure.com/41758
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
test plan:
* enable localization and choose a language for the course
with a different date format (e.g. Japanese)
* create a module and set an unlock date
* reload the page
* try to edit the module
* confirm that it did not localize the date inside the input box,
thus breaking the form
closes #CNVS-14984
Change-Id: Ice4b4d83c9bffa06d3292b123c2e10c632801718
Reviewed-on: https://gerrit.instructure.com/42177
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-15853
test plan:
- with DA on
- make a differentiated assignment and dont assign it to every section
- when saving there should be a new warning message
"Not all sections will be assigned this item"...
- with DA off
- do the same (make sure "everybody else" is not checked)
- dialog should give the old warning
- in both scenarios the Go Back button should be on the left now
Change-Id: I0f8728cda8e56e295b40c01e1b8d8b2956694092
Reviewed-on: https://gerrit.instructure.com/41857
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes: CNVS-14514
CNVS-12805
test-plan:
1.) Make sure your user is in a group
2.) Navigate to conversations
3.) With screenreader on, navigate to course filter
4.) Verify that the drop down is navigable
5.) Navigate to compose message and verify that the
course filter there is also navigable
Change-Id: I10d8f2131645adb59fab4a9b200591c1fd341010
Reviewed-on: https://gerrit.instructure.com/41915
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
test plan:
* using IE 10, should be able to add attachments when
composing a message in conversations and send the
message successfully
* should also work in other browsers as before
closes #CNVS-13369
Change-Id: I28459ffbbd9a58751c26d69ce9c6718d3a05c304
Reviewed-on: https://gerrit.instructure.com/42093
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-15592
Test Plan:
- Enable better files browsing
- Go to files
- An H1 tag should be there for screen readers only
- The title in the header/tab should be present as well
Change-Id: I045b9516148b4adc5e351f17dd6d551c211631d1
Reviewed-on: https://gerrit.instructure.com/41945
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
fixes CNVS-14094
test plan:
- course with DA as students and teacher
- api show & index
- quizzes index page shows only assigned quizzes
- quizzes show page url redirects to index if
quiz isnt visible to user
- grade calculation
- gradebook/grades page
- calendar events events
- modules filter out quizzes correctly
- observers see same things as their students
- if a student takes a quiz and it is not graded and then
loses visibility, make sure that the GB greys out the cell
rather than showing a submission icon
- same course with DA off works normally
Change-Id: I10b936f1516d6d24f11d74c0bb572051f0b1d1c4
Reviewed-on: https://gerrit.instructure.com/39897
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Product-Review: Mike Nomitch <mnomitch@instructure.com>
Fixes: CNVS-15567
Multiple small UI tweaks to increase foreground-
background contrast in the STUDENT view of the
Grades section in high-contrast mode.
IMPORTANT: This ticket is only for the high-
contrast UI. To enable the high-contrast UI, go
to Settings then scroll down and make sure
"Use High Contrast Styles" is set to ON.
Test plan:
- Enable high contrast UI in Canvas (see above)
- Go through each issue Nathan entered into the
JIRA and compare with the updated UI to make
sure it's fixed.
- The webAIM color contrast tester can be found
here: http://webaim.org/resources/contrastchecker/
Change-Id: I7eea468504fb0f8be151bfb3417ad27fe0a0e4e6
Reviewed-on: https://gerrit.instructure.com/41828
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
added Reply Button, and a cog containing Reply All, Forward, Star, Archive, Delete
to the top of the message details
Fixes CNVS-14513
Test Plan:
- Got to an inbox with a message
- Click the message
- There should be a reply and cog at the top of the thread
- The cog should contain Reply All, Forward, Star, Archive, Delete
- All items should function correctly
Change-Id: I47d4844c794d2033ffda036c43e2486ea4675f4e
Reviewed-on: https://gerrit.instructure.com/41288
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
test plan:
* should be able to use the ui or the api to
specify a "course_format" (i.e. whether a course
is online or on-campus)
closes #CNVS-15470
Change-Id: I5772cfa416c066e94b24d45bd6ce7c1aa24d8c5f
Reviewed-on: https://gerrit.instructure.com/41994
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
* reproduce a state where a module item's content has
a different workflow state than the module item (either
manually or through a reproduction step for one of the
associated tickets)
* should show the true workflow state of the item on the
modules page
close #CNVS-15400
Change-Id: I72e3caf335fee112266da526c4efd2272820e0f2
Reviewed-on: https://gerrit.instructure.com/42002
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
it's a shim of the rails 2 variety, and breaks in rails 4 in the
common case because the options became a scope
Change-Id: I712a8fed35ee0a9747a13c1495f7d51b8dac6823
Reviewed-on: https://gerrit.instructure.com/41716
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nick Cloward <ncloward@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Chrome's x-webkit-speech was deprecated, replaced it with javascript API
added functionality:
now actively tracks interim results and displays them to the user
added variety of error messages and prompts
fixes CNVS-13432
test plan:
- use Chrome (Version 35 or 36)
- navigate to an assignment, then to speedgrader
- click the microphone/pencil icon under the comment box
- dialog should pop up. Click record (then 'allow' if prompted)
- begin speaking
- interim results should appear in blue while talking
- final results should turn black
- when you hit stop, spoken text should appear in comment box
- should generate error for mic not allowed or no text spoken
- should bring up error if recording times out after long silence
- cancel button should discard spoken text w/out adding comment
- ensure mic does not appear in FF, Safari, or IE
Change-Id: I46eae92892dd37e0a3906023150653aaaf2e2ece
Reviewed-on: https://gerrit.instructure.com/38833
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
when previewing a quiz, the preview message now correctly displays
whether the quiz is a draft or published.
fixes CNVS-13984
test plan:
- Create a quiz in a course with at least one question in it.
- Publish the quiz.
- Click on the gear icon in the top right corner of the quiz description page and click "Preview".
- Notice the message correctly displays "This is a preview of the published version of the quiz".
- Unpublish the quiz.
- Click on the "Preview" button in the top right corner of the quiz description page.
- Notice the message correctly displays "This is a preview of the draft version of the quiz".
Change-Id: Ia3db9b602f927a2d04098987bdd7174a71114bf1
Reviewed-on: https://gerrit.instructure.com/41838
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
refs CNVS-15735
test plan:
* load a page with an lti tool embedded
* using the browser's console, post a message to the window, e.g.:
window.postMessage('{"subject":"lti.frameResize", "height":250}', '*')
- the lti window should resize to the given height
test plan (alternative):
* load a page with an lti tool embedded that knows how to issue resize
messages to canvas
- the lti window should be resized as the lti tool wishes
Change-Id: Ief192a0552ed96ca829ea1048bdb1a202b377676
Reviewed-on: https://gerrit.instructure.com/6578
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
updated discussions page to match module locked page used on assignments and
quizzed. updated module locked page to show module's unlock time if module is
timelocked
fixes CNVS-6314
test plan:
- create a discussion topic, assignment, and quiz
- add them to a module that is timelocked
- attempt to view all three as a student
- error pages on all 3 should match, stating the unlock time of the module
Change-Id: I099b645387321b5514d442d477a47ebffdfb88c4
Reviewed-on: https://gerrit.instructure.com/40711
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
test plan:
* import a qti quiz package into a course
* re-import it, making sure to *not* check the
"Overwrite assessment content with matching IDs" checkbox
* should not put all of the questions into the same question bank
* repeating the previous while checking the box should behave as
it currently does
closes #CNVS-14669
Change-Id: Ibfed20a191986fa29e52d7a08313b879c917d5a6
Reviewed-on: https://gerrit.instructure.com/41735
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Test Plan:
* Go to the courses page (/courses)
* Look under My Groups
* Course name/term for groups should be displayed like terms
for courses
* Course term (if any) should be in parentheses
Test Plan:
* Create a course group with multiple words
* Add a student to that group
* As the student, go to /courses
* Hover over the group name
* Make sure that all the words show up in the tooltip
Multiple groups with the same name are now better identified with their
context names (and term names if they are courses).
Test Plan:
* Create two courses, with one of them in the Default Term
* Create course groups in those courses
* Add a student to both course groups
* As the student, go to /courses
* Make sure the course name appears under the group name
* Make sure the term name appears (unless it's in the Default Term)
* Do the same for /groups
This changes the quiz drag and drop handle to be the same icon we use for
drag and drop reordering on the index pages. Now when the icon is dragged it
gives normal drag and drop reordering, but when it is clicked it will bring
up the move modal dialog.
This also adds a warning message when the item is focused on that tells that it
is an accessible alternative.
This also fixes a bug with accessible reordering of quiz questions when there
are greater than 25 questions in a quiz.
fixes CNVS-15778
test plan:
- as a teacher
- create a quiz
- the drag handle should now always show when creating questions and groups
- you can drag the handle to reorder with drag-n-drop
- you can click the handle to bring up the move to dialog box
- create a quiz with no question groups
- use screenreader
- you should be able to use the dialog to reorder the questions
- it should read the warning message on focus
- create a quiz with > 25 questions
- use screenreader
- you should be able to use the dialog to reorder the questions
- it should read the warning message on focus
- create a quiz with question groups
- use the screenreader
- you should be able to reorder both questions/groups
- try moving items in any way you can think - outside/inside groups, etc
- it should read the warning message on focus
- for all these situations, the normal drag-n-drop should continue to work
- no drag and drop handles should show up in question banks
- check banks with both < 50 questions and > 50 questions
Change-Id: If23ce2a68f1f8d60cc8f3ca76d4fea36f89b7a9b
Reviewed-on: https://gerrit.instructure.com/41703
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
So cool! Press ALT+SHIFT+T (or ALT+CTRL+T) at any time while you're
taking the quiz, and screen-reader will read the time remaining right
away without stealing focus away.
Closes CNVS-14086
TEST PLAN
---- ----
- make a quiz with a time limit
- take it and turn on VoiceOver or something
- right after the quiz instructions, you should now hear a new note
explaining the new shortcut
- now press ALT+SHIFT+T
+ verify you hear the remaining time
+ verify your cursor is still where it is; you can resume doing
whatever you wanted to do after hearing the remaining time
Change-Id: I18ccce6bf2f85c1f60206a61a46b8ef683a79dea
Reviewed-on: https://gerrit.instructure.com/41680
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-14737
test plan:
- after submitting a quiz, use screenreaders to navigate through the answers
- note that each answer that has a colored flag next to it reads the flag
- attempt to navigate to the answers given on matching, multiple answer, and
other types of questions
Change-Id: I6cfe570a5b934a3bda4c592083b397dff9006af3
Reviewed-on: https://gerrit.instructure.com/41658
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-9048
test plan:
- as a teacher
- create a quiz with no question groups
- use screenreader
- you should find a 'move to' button near where the drag handle is
- clicking this brings up a dialog
- you should be able to use the dialog to reorder the questions
- create a quiz with question groups
- use the screenreader
- you should find a 'move to' button for both groups/questions
- clicking this brings up a dialog
- you should be able to reorder both questions/groups
- try moving items in any way you can think - outside/inside groups, etc
Change-Id: I065cac8a60f3652a75ce8154614133da4b6af5e9
Reviewed-on: https://gerrit.instructure.com/41381
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
test plan:
* in one tab, start to fill out an ajax form
(e.g. editing a quiz)
* in another tab, log out of canvas
* return to the original tab and try to
submit the form (e.g. save your changes)
* should get an error message with a link to
login in a new tab
* login in the new tab
* return to the original, and try to resubmit
* should save successfully
closes #CNVS-3957 #CNVS-13673
Change-Id: I7758514de8ce09361fef469034645d8a29e2a5e5
Reviewed-on: https://gerrit.instructure.com/40396
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
closes #CNVS-14238
Change-Id: Ie2d24a9adf6b205ab14e10ce6315484ff781a0c2
Reviewed-on: https://gerrit.instructure.com/41602
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dminkevitch@instructure.com>
Tested-by: Dan Minkevitch <dminkevitch@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
I actually squashed 3 commits into this one
because I figured it would be easer to qa
it all together
first commit:
fixes: CNVS-15604 CNVS-15599 CNVS-15598
see this doc for what to look for and what this fixes:
https://docs.google.com/a/instructure.com/document/d/1XxZXnIeWVJGR6Iko1EuaW6LyiqzEQ-HAucFNq0LQHqs/edit
second commit:
mark newfiles grid up with aria-grid roles
closes: CNVS-15597
test plan:
open new files using a screenreader
the main pane with the grid of files should
function like a table to the screenreader
third commit:
adds screenreader-only feedback and info to
let you know that if you click a col
header it will sort by that col and tells you
if it is sorted ascending or descending
adds a screenreader-only "select all" checkbox
in the header.
Change-Id: I7cfd7133d90079e50cef9c978c2a199fa0530903
Reviewed-on: https://gerrit.instructure.com/41327
Tested-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-14095
fixes CNVS-15157
test plan:
- with DA on and off
- go to modules page
- only the right assignments show
- completion requirements ignore
assignments that cant be seen by a user
- modules page works with changing sections
- complete/incomplete updates properly
- as does locked/unlocked
- modules page shows correct content when
a students grade is deleted and this makes
them lose assignment visibility
- modules api doesnt return any content that
a student cannot see
Change-Id: Ia1acfd919214823cdfc3b45e974876b4529bb14d
Reviewed-on: https://gerrit.instructure.com/38970
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Mike Nomitch <mnomitch@instructure.com>
test plan:
0. configure a course navigation LTI tool with full-width launch
1. start a content import via the API, specifying the parameter
migration_settings[import_in_progress_notice]=1 **
2. you should see the import notice on the course front page
3. you should not see the notice when viewing the full-width
LTI app
** alternatively, you can just turn on the import-in-progress
notice in the Rails console, which will give you more time
to test:
course.add_content_notice :import_in_progress
then remove it when you want it to go away:
course.remove_content_notice :import_in_progress
fixes CNVS-15679
Change-Id: I3171812e0d631eab96ae7d0061280e57abbdcc46
Reviewed-on: https://gerrit.instructure.com/41456
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes CNVS-12669
This fixes the contrast ratio issues we were having on normal and
high contrast UI.
Testing Process:
- Make sure you have letter grading enabled for assignments
- Make sure you have some students that have had assignments
graded
- As a teacher or admin, go to Grades
- The letter grade that shows in the "Total" column should be passing
contrast in Webaim for Regular and High Contrast now
Example: http://cl.ly/image/350X350X0623
- Click on a student
- The letter grade that shows up in the "Score" column should also
be passing Webaim for contrast in both regular and High contrast
settings
Example: http://cl.ly/image/3F2e352v3x1O
Change-Id: Ibb92571df760add588e998e82bd0455eca322a77
Reviewed-on: https://gerrit.instructure.com/41066
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Colleen Palmer <colleen@instructure.com>
test plan:
0. have a course with a module that will be unlocked at a
future time
1. enroll two teachers, and set different time zones for
each in their user preferences
2. each teacher should see the unlock time in her own
time zone (not the time zone of whoever saw the page
first)
fixes CNVS-12088
Change-Id: Ifcde9af7c7abaf2298ba59180fd0737a73945a3d
Reviewed-on: https://gerrit.instructure.com/41351
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Screen readers no longer enter, exit, or report applications mode/region when
passing over menu trigger controls. Menu triggers can also be navigated
to with screen reader "jump to next/previous button" navigation shortcuts.
Fixes CNVS-15275
Test plan:
- Visit each kyle menu in Canvas.
- Verify with a screen reader:
- That the trigger is reachable via normal arrow key navigation
- That the trigger is reachable when navigating by buttons
- That the menu opens when enter is pressed on the menu trigger
- That forms mode is activated when the menu is opened (N/A in Voice Over).
- That the up and down arrow keys allow one to navigate through the menu
- That pressing enter on a menu option activates that action
- Verify that menu triggers are reachable by the keyboard (sans screen reader).
- Verify that all the other functionality relating to menus as discussed above
is accessible to keyboard only users.
Change-Id: I81d7678251b7c43e67504d5569e59ccd2f846949
Reviewed-on: https://gerrit.instructure.com/40951
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
test plan:
- preconfiguration variants:
- with & without user set to a different timezone
- with & without different locales (e.g. Japanese)
* navigate to the calendar
* click on a day to begin creating an event
* fill in the date and start/end times
- with & without valid start/end times
* click 'More Options'
- ensure the edit page includes start/end times as typed
- correct invalid start/end times, if necessary
* click 'Update Event'
- ensure the event appears on the calendar with the correct date/time
* click on a day to begin creating another event
* fill in the date and start/end times
* click 'Submit'
- ensure the event appears on the calendar with the correct date/time
fixes CNVS-11067
Change-Id: I31f6b1d7550b166a90c45d3f02132379c6dd7459
Reviewed-on: https://gerrit.instructure.com/40374
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
fixes CNVS-15246
There was a random </div> close tag in here that was causing
the right sidebar to be pushed wayyyy right. This fixes it.
Test plan:
- Go to /accounts/
- Choose an account you know has courses
- On that index page the right sidebar should no longer be pushed
all the way to the right
Should look like this now: http://cl.ly/image/1N253D1b2F0u
Change-Id: Ibc813ddbf8051f0514673e3bba9e1da86d285123
Reviewed-on: https://gerrit.instructure.com/41182
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-15487
test plan:
- open the gb csv upload modal
- click the link to learn more
> it should open a new tab and take you to the guide pages
Change-Id: Ief4cffbdac0a59de8896ae8c17c2cde28d0d6311
Reviewed-on: https://gerrit.instructure.com/41175
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-15104
test plan:
- visit edited pages from spreadsheet below
- test page headings with screenreader in safari
- pages should have level 1 headers for screenreader that proceed in order logically
- compare top level headers on assignments, modules, syllabus, and wiki pages
bewteen their actual pages, and their pages when called from home page selection
- headers for the above pages should be h1 on their respective pages, and h2
when called from home page, and stll proceed logically
Changes need to be tested on the following pages
default home page (/)
home page set to course modules
home page set to front page
home page set to assignments list
/courses/1
/courses/1/assignments
/courses/1/assignments/new
/courses/1/assignments/1/edit
/courses/1/discussion_topics/new
/courses/1/discussion_topics/1
/courses/1/discussion_topics/1/edit
/courses/1/gradebook#tab-assignment
/courses/1/gradebook/speed_grader(just pick any assignment w/ speedgrader)
/courses/1/groups
/courses/1/user_services
/courses/1/pages/(whatever page for course)
/courses/1/quizzes/1/edit
/courses/1/quizzes/1/take?preview=1
/courses/1/question_banks/2
/courses/1/quizzes/1/take
/courses/1/conferences
/courses/1/modules/progressions
/calendar2
/about/1
/profile/settings
/dashboard/eportfolios
/conversations?#filter=type=inbox
/accounts/1
/accounts/1/users
/accounts/1/sub_accounts
/accounts/1/account_authorization_configs
/accounts/1/groups
/accounts/1/users/2
/accounts/1/permissions
/accounts/1/avatars
/users/2/user_notes
/accounts/1/rubrics
/accounts/1/grading_standards
/accounts/1/user_notes
/accounts/1/admin_tools
/users/1/admin_merge
/users/1/teacher_activity/student/1
/users/1/masquerade
Change-Id: Ifdad341a22631c0d6773977743be741e74fecd88
Reviewed-on: https://gerrit.instructure.com/40370
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes: CNVS-14508
Adds new markup and styles for K-12 Canvas header.
Big change to application.html.erb - the #header
is split into 2 sets of markup: the new K-12
markup and the existing Canvas header.
To enable the K-12 feature flag:
- In Rails Console, enable the k12 feature flag
as follows: Account.find(1).enable_feature!(:k12)
Note: Due to Canvas caching, the Courses link in
the primary nav will only update once every 15 mins.
To update the link, either wait out the cache or
temporarily remove the cache code around the list
item element.
Test plan:
- Make sure the K-12 feature flag is disabled.
To disable: Account.find(1).disable_feature!(:k12)
- Click around the existing Canvas header. Make sure
it is working as expected in both regular and
high-contrast modes.
- Enable the K-12 feature:
Account.find(1).enable_feature!(:k12)
- Click around the new header. It should look like
this in regular mode...
http://cl.ly/image/2b1V3e2g0C3z/k12-regular.png
...and this in high-contrast mode:
http://cl.ly/image/3E0x3O2L3P2B/k12-high-contrast.png
- The new header is responsive down to tablet-size.
When you reduce the screen width enough, the icons
should stack on top of the link text in the primary
navigation.
- The new header also features an Inbox link in the
primary navigation (the existing header does not
have this). Confirm this is working and that the
user nav in the top-right no longer has an Inbox
link.
Change-Id: I38cd0d215fe67000fba01204f208801f550df089
Reviewed-on: https://gerrit.instructure.com/38925
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
fixes: CNVS-15244 CNVS-15261 CNVS-15374
changes:
handles overflow by scrolling
matches blake's mockup
test plan:
try the folder tree in both new files and by pressing
the "add image" icon in the tinyMCE toolbar and going
to the "From Canvas" tab.
TODO: 'active' style
it should look good and work well.
Change-Id: I6219da771758fd00d6ed3005ed459097a83fcd7e
Reviewed-on: https://gerrit.instructure.com/40922
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
test plan:
* enable the lor feature flag
* create an external tool with quiz_menu and
discussion_topic_menu configured
* should show external tool links specific to each type
on the assignments index page for graded discussion topics
and quiz assignments
closes #CNVS-15520
Change-Id: I020ab9cbc583d7940b0051056d27acb557ab152c
Reviewed-on: https://gerrit.instructure.com/41172
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes: CNVS-14748
Adds an accessibility warning to the discussion
field headers so that SR and Keyboard users know
to navigate to the manage menu to emulate "drag n
drop" behavior.
Test-Plan:
1.) Navigate to discussions
2.) Make sure there are 2 or more pinned discussions
3.) Tab until you're just past the header
4.) Verify that a warning message has appeared
5.) Remove a pinned discussion so you have 1 or less
6.) Repeat steps 2-3
7.) Verify that no message appears, and that it takes
a single tab to move from the header to the content
Change-Id: I71503a511b627dc6fadb696ca25b5fb6637c898d
Reviewed-on: https://gerrit.instructure.com/40429
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
When a quiz is in progress, it should be marked late if the student is
still taking the quiz when the due date is reached. If the lock date
comes up, the quiz should autosubmit at that point. If there is a quiz
timer and a lock date, the lock date overrules the quiz timer.
Closes CNVS-13689
Test Plan:
- Create 4 types of quiz scenarios:
- Lock date only
- submits at lock date
- never marked late
- Lock date and due date
- autosubmits at lock date
- late if submitted after due date
- No due date
- Never late
- Autosubmits at course completion
- Lock date and timer which runs beyond lock date
- Gives the student time until lock, not normal timer
- autosubmits at lock date
- Monitor all these for sane prompts and alerts
- deadline approaching flash messages for LATENESS (occur at T-30
minutes, T-5 minutes, and T-1 minute)
- autosubmission flash prompts (and popup @ T-10 seconds)
Change-Id: I5af9eb360a5f13527b32e7f84c205149bea1935b
Reviewed-on: https://gerrit.instructure.com/40609
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Because of the way the events are done/handled by the form
a submit occurs on the form whenever a form element has focus.
When the form dialog opens the first focusable item is given
focus. This provides a empty non-interactive element to receive
focus when the form dialog opens preventing an automatic
submit from triggering. While not ideal, it works.
fixes CNVS-14966
Test Plan:
- Go to the modules page (/courses/##/modules)
- Use the keyboard to navigate to the edit option in the cog
menu.
- Press "Enter" on the "Edit" option.
- The form should not close automatically.
- Do the same with module items.
Change-Id: Icf22c23b502b66a7678111224bf0907876bc72f8
Reviewed-on: https://gerrit.instructure.com/41031
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Quizzes which are only partially graded are no longer shown as if they
were fully graded. Now, the behavior is to show a quiz grading in
progress icon in the gradebook.
Closes CNVS-15073
Test Plan:
- Create a quiz which contains both autograded and manually graded
question types (M/C and essay)
- Take quiz as student
- Confirm that quiz grades as follows:
- Student views:
- Student grade summary view shows quiz icon
- Teacher view:
- Teacher gradebook view shows quiz icon
Change-Id: I8261a11f0ffddfb34947ad5f9089aa503b274cb1
Reviewed-on: https://gerrit.instructure.com/40501
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-15492
Test Plan:
- Go to the courses page (/courses)
- Any terms should be displayed in a italicized light gray
color next to the course title.
Change-Id: Ie1bb9040a8d03c551f02ce0e8171178532136ee0
Reviewed-on: https://gerrit.instructure.com/41043
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes: CNVS-15344
Added a scope to the row headers in the table.
Test Plan:
- Using a screen reader, visit the first table on the page.
- Use the screen reader navigation keys to navigate through the table,
and verify that as you move up and down in the second and third
column, the screen reader reads the row heading from the left column.
Change-Id: I3bbe277c1bc19145df6b8922ccb6d67f89f9389a
Reviewed-on: https://gerrit.instructure.com/40845
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
fixes CNVS-13130
fixes CNVS-13110
test plan
- as a teacher, go to /courses/:id/rubrics
- using screenreader, click 'Add Rubric'
- a ~magical~ rubric table should appear
- complete the tests for Criterion and Ratings below
- as a teacher, go to an assignment with a rubric
- verify that you can edit the rubric
- verify that you can delete it from the assignment
(no need to do a complete test run as below, just make sure the icons in the table header are accessible and that nothing fell down and died)
Criterion:
- the 'Edit' icon for the criterion description should be accessible
- click 'Edit' for the criterion description
* click 'OK'; it should focus on the 'Edit' pencil
* click 'Cancel'; it should focus on the 'Edit' pencil
- the 'Delete' icon for the criterion should be accessible
Ratings:
- the 'Edit', 'Delete', and 'Add' icons should be accessible
- verify that they read the correct messages ('Edit rating', 'Delete rating', 'Add new rating category after current rating')
- click 'Edit' for a rating
* click 'OK'; it should focus back on the 'Edit' pencil
* click 'Cancel'; it should focus back on the 'Edit' pencil
- click 'Add' for a new rating column; verify it focuses on that table cell
- click 'Delete' for your newly added rating; verify that focuses on the chunk of the table with ratings in it
- verify that adding and editing rubrics works just fine for keyboard only users
- celebrate, for rubrics are now ACCESSIBLE!!!!! \o/
🎉
Change-Id: Ifbd3043f217c09cc7cb24e411b0a572fdce6ef52
Reviewed-on: https://gerrit.instructure.com/40639
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-15277
Test Plan:
- Go to the modules page (/courses/##/modules)
- When using keyboard navigation, when you get to a drag &
drop handle, a warning should appear with the text:
"Warning: For improved accessibility in reordering Modules
(or Module items), please use the Move To Dialog option
found in the menu."
- Go to the course settings page (/courses/##/settings)
- Using keyboard navigation, when you tab into the
navigation tab, a warning should appear with the text:
"Warning: For improved accessibility in reordering Course
Navigation elements, please use the Move To Dialog option
found in the menu."
Change-Id: I3e2b6a295f1e63099e5a90fef3ce96b63980b937
Reviewed-on: https://gerrit.instructure.com/40629
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-15446
test plan:
- Turn on user profiles and avatars for an account.
- Enroll a teacher and student in a course in that account.
- As the student, go to the course's people page and find the
teacher.
- Click on the teacher to go to the teacher's profile page.
- Check the page source as described by the jira issue.
- Go to the student's own profile page.
- The student should still be able to edit their own avatar.
- The gravatar pane of the avatar edit dialog should be
properly initialized with the student's default email
address.
Change-Id: Iae4fa9d74161192eedda14316029ae8631570cfc
Reviewed-on: https://gerrit.instructure.com/40988
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CNVS-15295
Normally users will logout through the link in the upper right, which
does a DELETE request and bypasses this screen. If somebody DOES do a
GET to /logout for any reason though, we'll now display a logout
confirmation screen, rather than an error.
Also fix protect_from_forgery for saml_logout and destroy. Rather than
error when the token is bad, though, redirect to the confirmation
screen. The goal here is to try really hard to let people log out, so
they're never stuck in a situation where they got an error and now can't
see how to log out (that's a security risk).
test plan:
* The logout link in the upper right should still log you out,
without a confirmation screen.
* SAML logout should still work correctly, with both GET and POST
requests.
* If you manually visit /logout in your browser, you'll:
* See a confirmation screen, if logged in.
* Confirming should log you out as expected.
* Get redirected to /login, if not logged in.
* Login in one tab. Open a second tab, log out and back in. Back on the
first tab, hit logout in the top right.
* With this change, you'll see the logout confirmation screen.
* Without this change, you would get an error.
Change-Id: I13740f35cc27caeea22470e1cedf838ad4ce771d
Reviewed-on: https://gerrit.instructure.com/40834
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
QA-Review: August Thornton <august@instructure.com>
fixes CNVS-15295
In rails2, the `:method => :delete` parameter added an onclick handler
that built up and submitted a form. In rails3, this transparently
changed to using UJS and even hooks, which has been causing problems
with people clicking the link (a) when a js error prevents UJS from
getting setup or (b) before the UJS has a chance to get set up via AMD.
It's important that logout works even in the face of these errors, so
I'm bringing back the onclick handler, but with a form always present
for simplicity.
test plan: The logout link in the top right should still function as
usual. Especially test in IE10 and IE11, where problems with it have
been most prevelant.
(note that there are existing selenium tests for the logout link)
Change-Id: I612884ef261628dace4a24407fce7b84bbd6dd4e
Reviewed-on: https://gerrit.instructure.com/40833
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
closes CNVS-13380
closes CNVS-8057
closes CNVS-5156
Test plan:
* scribd should no longer exist
* document previews should work in canvadocs
Change-Id: I5ac60c3e986f030c3aea88e32d2992ec7b1c7a08
Reviewed-on: https://gerrit.instructure.com/37895
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes: CNVS-15370
When a user is logging in to Canvas,
the Login button used to say Login. However, on
the next screen when Canvas is requesting access
to their account, the button says Log In.
The second button is accurate in the context of
how we are using the term Log In.
Change-Id: I3ad2d6cc86822f438e39b0d6e6089f2557224ec4
Reviewed-on: https://gerrit.instructure.com/40794
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
test plan:
- an admin user should see the "Delete My Account" link
in /profile/settings, after clicking Edit
- a non-admin user with a SIS ID should not see that link,
but should still see the "Cancel" and "Update Settings"
buttons
fixes CNVS-15429
Change-Id: I338e3027c9caefa6978738c73dd2c6aa2b75775e
Reviewed-on: https://gerrit.instructure.com/40921
Product-Review: Cosme Salazar <cosme@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes CNVS-14929
test plan:
- with DA on
- make a group assignment
- you should get a warning in the group assignment box
- publish the assignment and turn in homework from a student
- go back to the edit page
- you should see a different warning in addition to the
original warning
- repeat steps for a graded group discussion
- with DA off
- there should not be an error related to DA
Change-Id: Id2ca3c12a50df009cfd9273d8a0f0fd778f81646
Reviewed-on: https://gerrit.instructure.com/40870
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-15348
test plan
- send a conversation message
- ensure that the notification does not include the author's email
address
- in the account's settings page, check "Show the email address of
sender for user interaction Notifications"
- send another conversation message
- ensure that the notification includes the author's email address
Change-Id: I2816d82fb2f6413d1c2c972296a758b571fb03de
Reviewed-on: https://gerrit.instructure.com/40766
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Fixes: CNVS-14749
This adds a warning message to the groups page
when first tabbing into the main content. It
informs the users if they are keyboard users, that
there is a MoveTo button in the menu for them to use
to move the students around.
Test-Plan:
1.) Navigate to the groups page
2.) Tab into the main content
3.) Verify that a message appears to inform of MoveTo option
Change-Id: I3e8d860fc3a3a22d9426ff9e856ea87a767a2e12
Reviewed-on: https://gerrit.instructure.com/40510
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Modules collapsed/expanded state is now indicated by screenreaders
The module title can now be accessed and expanded/collapsed
by keyboard only users. It is essentially a temporary fix for
a couple of issues until the module page can be refactored.
closes CNVS-14721
test plan:
- Using a screenreader (specifically JAWS is requested)
- Go to the modules page (/courses/##/modules)
- The module titles should not be recognized as headers
- Navigate to a module title header.
- The module should be able to be expanded/collapsed using the
keyboard
- The screenreader should announce if the module is expanded or
collapsed.
Change-Id: I40277af739d8be1f1bb5b19aee205dfbee7c615f
Reviewed-on: https://gerrit.instructure.com/40826
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-14243
test plan: create an Uncategorized account-level group, easiest way to
do this is a SIS import like so:
group_id,name,status
fromsis,from SIS,available
Then visit /accounts/self/groups. The group should appear in the
"Uncategorized" tab. Visit the group homepage /groups/:id by clicking
the gear -> "Visit Group Homepage". The group homepage should render
without error, and you should be able to interact with the group like
any other. Test this as a student enrolled in the group, as well.
Change-Id: Id4f08b704226653acc35df517fe58ce4f8f9e6eb
Reviewed-on: https://gerrit.instructure.com/40789
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fixes CNVS-15258
test plan:
- create an assignment and enable turnitin and open the advanced options
- change different combinations of settings: check/uncheck boxes, radio
buttons, dropdowns, and fill in fields
- no matter what settings combinations you pick, when you press "Update
Settings", and then re-open the dialog, it should be consistent
- if you close the dialog with the x, it should not keep your changes
- when you save the assignment and go back to edit it, it should keep
your last 'updated settings'
Change-Id: I150402907b7829474f2c2a7102d2a4039438f809
Reviewed-on: https://gerrit.instructure.com/40644
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-14515
test plan
- as a teacher, visit /conversations
- make sure your inbox is set to display 'All Courses'
- using screenreader, compose a new message
- verify that no course is selected
- verify that the 'To' autocomplete fields are disabled
- select a course
- verify that the 'To' autocomplete fields are no longer
disabled and are available to the screenreader
- celebrate! 🎉
- go back to your inbox
- filter messages by one course
- compose a new message
- verify that the course you filtered for is selected
- verify that the 'To' autocomplete fields are not disabled
- reply to an existing message, verify that the 'To' field is accessible
- as an admin, visit /conversations
- verify that 'To' is *not* disabled for screenreaders
Change-Id: I2fddc876c881dda87ddc06e8e39a31b37bedf1d9
Reviewed-on: https://gerrit.instructure.com/40781
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Fixes CNVS-14087
Test plan:
- Create a discussion topic
- Set the discussion's "available from" date to a non-hour date in the
future (e.g. 12:30pm)
- Publish the discussion
- View the discussion as a student and ensure that the full hour and
minute are displayed as part of the "This topic is locked until..."
message
Change-Id: Ic014fe90d59e111f484875291d0bb81e1d98b3c3
Reviewed-on: https://gerrit.instructure.com/40404
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Fixes CNVS-13871
Test plan:
- Create and send a conversation message
- Locate the message under "Sent" and click on it
- Ensure that the the full date and time, including the year, are
displayed in the upper-right corner of the message
Change-Id: I00c3c0df252dc8e32e4aeb2567460c7507750dda
Reviewed-on: https://gerrit.instructure.com/40675
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
fixes CNVS-15252
test plan:
- create a new course and DO NOT visit the assignment index page
- go create a new ungraded discussion
- refresh the discussion show page a few times
- go to the assignment index page
- there should only be 1 assignment group (the default)
- repeat the process with an ungraded quiz
Change-Id: If6714bef05379a0f1253a0843d473695a1372456
Reviewed-on: https://gerrit.instructure.com/40709
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-14906
Test Plan:
1. Navigate to a page under Pages in a course
2. In VO, press ctrl+option+cmd+h to go to the first and
only header
3. Press a second time to confirm that there are no more
headers
4. Hold shift while pressing those same keys to confirm that
there are no previous headers
5. Header should be recognized as a H1
Change-Id: I29ee832829581f08e23f0d3b01a264e908c67deb
Reviewed-on: https://gerrit.instructure.com/40673
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
* add various communication methods to your user
* navigate to any page other than your user's settings
* using the console, increase the bounce count of all channels:
User.find(id).communication_channels.unretired.each do |cc|
cc.bounce_count = 100
cc.save
end
* refresh the page
- a notification should show at the top of the page, indicating a
potential problem on your settings page
- navigating anywhere other than the settings page will cause the
notification to persist
* navigate to the settings page
- the notification should disappear
- your communication channels should all indicate a problem with
delivering messages to you
* removing and re-adding the channels should remove all indicators
* navigate to any page other than your user's settings
* using the console, increase the bounce count of one channel:
cc = User.find(id).communication_channels.unretired.first
cc.bounce_count = 100
cc.save
* refresh the page
- once again, the notification should show at the top of the page
fixes CNVS-15255
Change-Id: If45664c1b33d75fbfe8aa3480dfebd8872c6b064
Reviewed-on: https://gerrit.instructure.com/40534
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Some tools aren't meant to be selected in the ET UI. This
adds an option to hide them.
Test Plan:
* Install an external tool with the property "not_selectable" as true
* when you look in the asmnt/module item external tool list the tool
should not be listed
closes PLAT-619
Change-Id: I0a8b0771b2b2d84bc6fe0b66779728abec1ef212
Reviewed-on: https://gerrit.instructure.com/40505
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-14375
Previously grading counts were only available
aggregated as a count for the assignment. This
lets you consume them split out by section
rather than.
needs_grading_count_by_section is the flag
to send. This also splits out the needs_grading
query off into it's own object to reduce the
cognitive load of working in the assignment model.
TEST PLAN:
- setup a course with multiple sections and
assignments that need grading for students in
each
- hit the assignments API index with the
"needs_grading_count_by_section" parameter set
to true
- the JSON response should include a
"needs_grading_count_by_section" key for
each assignment and it should have a hash
of section ids and counts
Change-Id: I290a080b5f657996423798cacfb37660f5ed427c
Reviewed-on: https://gerrit.instructure.com/39627
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Modified core jqueryui datepicker :/
Updated mini calendar external
Fixes CNVS-14481
Test Plan:
I'd like to pair with who ever tests this. So I can get an idea how
these are tested.
- Make sure the mini-cal is invisible to Screen Readers
Change-Id: Ib95c812746dabb5e5a2b25472923bb8e1e7c9ca6
Reviewed-on: https://gerrit.instructure.com/40298
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
Fixes: CNVS-14739
On focus of month and week buttons in calendar
a message appears to inform keyboard only users
to use the agenda view.
Test-Plan:
1.) Navigate to calendar
2.) Use tab to navigate to the week and month buttons
3.) Verify that a warning message appears next to
the button
Change-Id: Iefab5a5196b0efa9abbbcfdf95b849123f70b784
Reviewed-on: https://gerrit.instructure.com/40092
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-5352
only link to a user page if one is visible to the person viewing the
page. prefer the /about/:id page if the account has profiles enabled.
otherwise, prefer the /users/:id/profile page when viewing my own
portfolio and the /users/:id page otherwise (and only if permitted).
test-plan:
- have a target user with a student enrollment
- create a public portfolio for the target user
- enable profiles on the account
* log out and view the portfolio
- the portfolio owner's name should not be linked
* log in as portolio owner and view the portfolio
- the portfolio owner's name should be linked to /about/...
- following the link should be authorized
* log in as an account admin and view the portfolio
- the portfolio owner's name should be linked to /about/...
- following the link should be authorized
* log in as a teacher in the student's class and view the portfolio
- the portfolio owner's name should be linked to /about/...
- following the link should be authorized
* log in as an unrelated non-admin user (i.e. student from some
other class) and view the portfolio
- the portfolio owner's name should not be linked
- disable profiles on the account
* log out and view the portfolio
- the portfolio owner's name should not be linked
* log in as portolio owner and view the portfolio
- the portfolio owner's name should be linked to
/profile
- following the link should be authorized
* log in as an account admin and view the portfolio
- the portfolio owner's name should be linked to /users/...
- following the link should be authorized
* log in as a teacher in the student's class and view the portfolio
- the portfolio owner's name should not be linked
* log in as an unrelated non-admin user (i.e. student from some
other class) and view the portfolio
- the portfolio owner's name should not be linked
Change-Id: I812076d10bd3c56b87938627c9f095a1793128e6
Reviewed-on: https://gerrit.instructure.com/39863
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fixes CNVS-14750
test plan!
- on the assignment index page
- as a teacher (or other person with admin powers)
- using keyboard navigation and all the screenreaders
- tab to the assignment group drag and drop handle
- a wild accessibility warning should appear
- it should be read by screenreaders
- tab away from the drag and drop handle
- the warning should ~disappear~
Change-Id: I56d239d9dcb930b25f6ea0704cfaa7d20708aba2
Reviewed-on: https://gerrit.instructure.com/40212
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
test plan:
* as with g/39874, add an external tool to a course
with 'discussion_topic_menu' configured
* enable lor feature flag for account or user
* confirm that menu items for the tool are added to the
gear menus on the index and individual show pages for
discussion topics
closes #CNVS-15239
Change-Id: Ic309c14f75ae0b2e38f9d1324b7a8d370fa93fde
Reviewed-on: https://gerrit.instructure.com/40550
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Closes CNVS-15109, CNVS-15173
CHANGES
-------
- "auto-grading" of due submissions that was previously done
synchronously in the index action is now done in a DJ
- when viewing the index page, you don't get to see due/available
dates on load, instead the dates are fetched on the client-side and
load progressively
- new API endpoint for retrieving assignment overrides for a bunch of
quizzes at [GET] /courses/:course_id/quizzes/assignment_overrides
- we now cache the user's quiz permissions
- Canvas AMS API serializer now accepts a new option, see docs
- QuizSerializer behavior changed radically:
- "takeable", "submitted_students", "unsubmitted_students" disabled
- all associations disabled including the submission, assignment
group, and any student participants
- it can now utilize preloaded permissions
Rationale behind disabling things in the serializer is that these were
exclusive for the "show" action, so the next step forwards is to
allow the serializer to recognize different "modes" for output (e.g, for
index and one for show) and tailor the associations/fields accordingly.
Using "#filter" right now isn't cutting it, because assocs get loaded
anyway.
REFACTORING
-----------
- broke down index into three actions for visibility:
1. default, Draft-State version
2. legacy non-DS version that's not reachable in the UI, kept around
until we upgrade the tests
3. ember version
- legacy non-DS ERB code goes into its own file
- moved code that used to grade due submissions inside index to
SubmissionGrader in preparation to remove it from there entirely
- cleaned up internal docs for the Canvas AMS api serializer
TEST PLAN
---- ----
- create ~30 quizzes
+ make one of them have many questions
+ make a good number of submissions (i tested with 420 and 20
students)
- create multiple sections
+ specify date overrides for certain sections, and have at least one
student enrolled in that section
- as a teacher and/or an observer, go to quizzes index
+ verify the page renders fine
+ verify that you see "loading indicators" in the due/available
field which get replaced with actual dates when they're loaded
+ verify it's faster than the version in master (should be at least
60% faster)
- as a student in the general section, go to quizzes index
+ verify the page renders
+ verify you see the same loading behavior for dates as in teacher
view
- as a student in one of the section with overrides, go to index:
+ verify you see the overridden date
Change-Id: I741d89625da1b858148baa95e881fcc75c1802e5
Reviewed-on: https://gerrit.instructure.com/40350
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
fixes CNVS-15160
test plan:
- Create a course with two users enrolled.
- As one user, go to the other user's /courses/X/users/Y page
- The profile picture should not be a link and should not be
clickable.
- As the same user, go to your own profile page; the profile
picture should be clickable and let you change your avatar.
Change-Id: I6bac70eef1b23288c5a360058c48742d9a556255
Reviewed-on: https://gerrit.instructure.com/40431
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Uses labelled-by to force screenreaders to read the labels,
this shouldn't be needed, but for some odd reason here it
was.
fixes CNVS-13909
Test Plan:
- Using a screenreader (NVDA) go to the accounts settings
page on the quotas tab
- Navigate to the quota inputs
- The screenreader should read the various labels so that
you can tell which quota you are editing.
Change-Id: I8d5683e67808115027b18732c77c770b40998cc7
Reviewed-on: https://gerrit.instructure.com/40377
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-14487
fixes CNVS-14488
test plan
- using all the screenreaders
- with learning mastery gradebook enabled
- go to gradebook 2
- tab into the "skip to content" link
- skip to the content
- verify that the warning about accessibility appears
- verify that the warning is accessible as the first item in the content pane
- verify that the warning link takes you to srgb
- verify that when you tab away from the warning it disappears and does not reappear
- celebrate
Change-Id: Ibefaa975381129f8b223c95070722b44a240364b
Reviewed-on: https://gerrit.instructure.com/39893
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-8332
test plan:
- create a discussion topic
- reply to said discussion topic
- a minute later, edit the reply
- ensure that the time shown above the reply is the time you
originally created the reply, not the time at which you
edited it
Change-Id: Ie00e8920c3117fffe219ce941a3565a63a2234b7
Reviewed-on: https://gerrit.instructure.com/40302
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-14590
Test Plan:
- Using a screenreader, go to any page in Canvas,
even the login page.
- When you navigate to the footer "By Instructure" the
screenreader should simply read "By Instructure"
Change-Id: Ie61711610ab93f17792c0d288c1069fc0283a4e6
Reviewed-on: https://gerrit.instructure.com/40456
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Associates the instructions with the input so that screenreaders
can read it to users. NVDA will read the text immediately when
the input has focus. VoiceOver will not, but it will read it
as help text if you leave focus on the box long enough.
fixes CNVS-14597
Test Plan:
- Using a screenreader go to the login page.
- Click the forgot password link
- Navigate to the email input box.
- The additional text should be read as indicated in the
commit summary above.
Change-Id: I605ce8d1e922f6674ed6d2cd73dbe223e742c6bf
Reviewed-on: https://gerrit.instructure.com/40459
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test-plan:
- have profiles enabled on the account
- log in as an admin
- flag some other target user was "public"
- try and view that user's profile
- should not get a 404
Change-Id: Ibcae7f577b5824d42996c830030d5dd87094685f
Reviewed-on: https://gerrit.instructure.com/40250
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes CNVS-13905
Test Plan:
- Using NVDA in Firefox go to the account settings page
(/accounts/##/settings)
- Using the "B" key the "Add a New Course" and "Add a New
User" buttons should be recognized.
- Using the "F" key the same should occur
Change-Id: Ief88cec1f0c12a48ba55ac50614ca83877358a20
Reviewed-on: https://gerrit.instructure.com/40369
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Test Plan
- lti content should be able to enter full screen mode
fixes PLAT-614
Change-Id: Icffa991ca618cc6aeab2ac5ba0743746ab8bac41
Reviewed-on: https://gerrit.instructure.com/40320
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Modifies the screenreader instructions group to be much simpler
just warning users to use the new dialog. Makes the warning
appear for keyboard-only users.
closes CNVS-12799, CNVS-14733
test plan:
1. Load up the course settings page (/courses/##/settings)
2. Click on the gear icon in the enabled list.
3. Click 'disable'
4. It should now appear in the disabled list, the gear icon link
should have changed to 'enable'
5. Use the gear and click on move.
6. A dialog should appear allowing you to move things within
a list.
7. Clicking the save button should persist changes beyond the
current session.
8. Repeat the above steps using a screenreader.
a. When you tab off of the navigation tab, a warning should
appear (and be read by the screenreader)
b. The message should disappear when tabbing off of it.
Change-Id: Ie3d2cae23a47535d5a3995174794e0f0d853e629
Reviewed-on: https://gerrit.instructure.com/40169
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Addresses: DES-167
For the upcoming K-12 header, we will be using the K-12
feature flag to split up the markup for the header and
its navigations. This would make the application.html.erb
file a big mess of logic; so to make it more readable, we
will start by putting the primary and user navigations
into partial files.
Code review test plan:
- Make sure the partials are correctly called into the
application.html.erb file.
- Do the QA test plan.
QA test plan:
- Click on the links in the primary and user
navigations, and make sure they're all going to
the right places.
Change-Id: I666d515793b4dcd18838219094f2457f326e6e75
Reviewed-on: https://gerrit.instructure.com/40167
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Chris Hart <chart@instructure.com>
headers in the content should come before headers
in the sidebar
fixes CNVS-15105
Change-Id: I6ae02bd784ecf893acae6574f93685f9216f035a
Reviewed-on: https://gerrit.instructure.com/40101
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
test plan:
* as with g/39874, add an external tool to a course
with 'assignment_menu', 'quiz_menu' and 'wiki_page_menu'
configured
* enabled lor feature flag for account or user
* confirm that menu items for the tool are added to the
gear menus on the index and individual show pages for
assignments, quizzes and page
closes #CNVS-14555 #CNVS-14556 #CNVS-14557 #CNVS-14558 #CNVS-14559 #CNVS-14560
Change-Id: Ib5fcda93b51567bc3e64229014822382918113ac
Reviewed-on: https://gerrit.instructure.com/40168
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes #CNVS-15119
This is for the workflow when you're adding
a user to a course as a teacher. Currently
it makes it sound like the error is an email
formatting problem.
This also sets up a reusable way to push
account settings info over in the environment
and check it in a handlebars template.
TEST PLAN:
- Login as an instructor
- Make sure the root account has
"open_registration" turned off
- Try to add a student to your course by email
who isn't currently a canvas account holder
- The error message should tell you that if the
formatting is ok, you need to ask your admin
if they have a canvas account
Change-Id: I0cfc07c4612ff4db7ef759cc146e612f94c1075b
Reviewed-on: https://gerrit.instructure.com/40230
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Adds screenreader-only text to the empty table headings
closes CNVS-15088, CNVS-15161
test plan:
- Go to the people page (/courses/##/users)
- Viewing the source should show scope attributes on the th's
- Presumably a screenreader or other assistive technology will
work better with this.
Change-Id: I802c7650a5bf409bd431b21da0d970252941cdae
Reviewed-on: https://gerrit.instructure.com/40192
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan: with a VERSION file in your rails root, run delayed jobs, the
process name will include the contents of the VERSION file. with no
VERSION file, it won't.
Change-Id: I773ff4ace5facdb48d415ad7528daaf761aeab1d
Reviewed-on: https://gerrit.instructure.com/40162
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
Fixes CNVS-14659
Test plan:
- Visit the list of discussion topics for a course.
- Verify that the discussion titles are recognized as level three headings by
screen readers.
- Verify that the visual appearance of the page has not been effected.
Change-Id: Ideddc504730cd0e8cdc91a8f34174922acafed76
Reviewed-on: https://gerrit.instructure.com/38886
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matthew Wheeler <mwheeler@instructure.com>
fixes #CNVS-13065
Per Erin Hallmark, "Question Group" makes
more sense than "Quiz Group"
Test Plan:
-Login as an instructor
-try to add a question to a question group
-see the better label that using the preferred
wording
Change-Id: I372e4bce7e223557ae5ce3a08f2d91882bd45857
Reviewed-on: https://gerrit.instructure.com/39760
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-14803
test plan:
- make sure the headers are unchanged on the following pages:
- /accounts/1/account_authorization_configs
- /accounts/1/sis_import
- /courses/1/content_exports
- /courses/1/confirm_action?event=delete
- /accounts/1/terms
- /accounts/1/sub_accounts
- /accounts/1/users/1/delete
- /users/1/admin_merge
Change-Id: I4563e243cb733e2826d52b408991032da3767efa
Reviewed-on: https://gerrit.instructure.com/39373
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CAT-465
Test Plan
1. Start canvas with full localization support enabled
(ie $ LOLCALIZE=true rails server)
2. Ensure the time zone select inputs on the course settings,
account settings, user profile settings and new user confirmation
pages are localized appropriately
3. Ensure the course and user profile time zone is localized
when not editing the settings
Change-Id: Ic9cb64986451a9a10925b716b727eae45b3b1806
Reviewed-on: https://gerrit.instructure.com/39435
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nick Houle <nhoule@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: Adam Phillipps <adam@instructure.com>
(previously, canvas only did this for users with SIS IDs and
managed authentication. I do not see how the managed auth part
is relevant.)
test plan:
- The Edit Settings page at /profile/settings should show the
"Delete My Account" link only if
* the user is an account or site administrator, or
* the user has no SIS ID
- the "Really delete" page (users/1/delete) should redirect
back to the profile page with an error message for non-admins
with SIS IDs
- the Users API should return a 401 (Unauthorized) error if
non-admins with SIS IDs try to delete themselves
fixes CNVS-14804
Change-Id: I93a003235204b0fbde226c76aaf8677f3a417f9d
Reviewed-on: https://gerrit.instructure.com/39789
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-13317
test plan:
> assignments global navigation should be gone
- type in '/assignments' as the URL manually
> it should redirect you to the user dashboard
Change-Id: I6f26b825119268b62164ee37897be86909682a17
Reviewed-on: https://gerrit.instructure.com/39788
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Makes the modules page more accessible for both screenreader and
keyboard only users.
fixes CNVS-9045
test plan:
1. Using a screenreader go to the modules page (/courses/##/modules)
3. Navigate to the admin links cog for a module item.
4. You should see a "Move to..." option.
5. Click it using whatever the screenreader uses for click
(VO: Ctrl+Option+Space)
6. A dialog should appear (This dialog should be accessible)
7. You should be able to move a module item to whatever location
you want.
Change-Id: I7f6cffef2eb321103889fb81e932e9551f8b912e
Reviewed-on: https://gerrit.instructure.com/39930
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
test plan:
* create an external tool with one or more of the
following extension types configured:
'assignment_menu', 'module_menu', 'quiz_menu',
'wiki_page_menu'
* enable lor feature flag for account or user
* for a course, the gear menu for modules and exportable
module items (assignments, quizzes, and wiki pages for now),
should contain a new link (if configured)
* clicking the link should launch the tool, passing a query
parameter (either 'modules%5B%5D=:id' for modules, or
'module_items%5B%5D=:id' for items)
(note: '%5B%5D' is equivalent to '[]' escaped)
closes #CNVS-14547 #CNVS-14552 #CNVS-14553 #CNVS-14554
Change-Id: Ifebf669c25f600c6491648ad8ec5ab65c62932ba
Reviewed-on: https://gerrit.instructure.com/39874
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-15081
Test plan:
make sure you can move your total column in gb2 whether or not your
assignment groups are weighted.
Change-Id: I7e76f1ea95f67de326ba77fbf963017bb824a881
Reviewed-on: https://gerrit.instructure.com/39984
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
- removed `role="dialog"` because that puts the
content into "application" mode, royally
messing up navigability
- added `aria-hidden="true"` to all of the content
outside of the dialog
- rearranged some opening/closing tags in app
layouts so they live in the same file
closes CNVS-14476
Change-Id: I83be208a2f993caf8b436112da1b3e30e0f533fa
Reviewed-on: https://gerrit.instructure.com/39933
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
Test Plan:
- install a tool with the message_type 'ContentItemSelectionResponse'
- launch the tool
- it should have the JSON param content_items
- content_items should have a placementOf -> id that points to a migration API endpoint
- run the migration by POSTing to the given endpoint
- the migration should have all course content in it
- try a migration with one assignment, one quiz, one module, and one page
* add quizzes[]=:id&assignments[]=:id&modules[]=:id&pages[]=:id
- the migration should only extract the specified items
closes CNVS-14613
Change-Id: Ic43c3fb1e77c12d5f4d6712d42932e63bc36762e
Reviewed-on: https://gerrit.instructure.com/39427
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
closes CNVS-14683, CNVS-14684, CNVS-14685
test plan:
- Go to the courses page (/courses)
- Make sure you have enrollments in various courses in various
states (e.g., unpublished/published, past/future/current)
- Each section (My Courses, etc.) should have a table within
- My Courses should have stars in the first column
- Clicking on a star should toggle the color of the star
if the course is favoritable, e.g. students can favorite
courses that are unpublished, while teachers can.
- Stars that are colored yellow, should appear in the courses
dropdown on the main navigation after a refresh.
- The type of enrollment should be indicated on the far right.
- Unpublished courses should have an indicator to the left
of the enrollment type.
- Hovering over the unpublished courses should have a
tooltip saying:
"This course has not been published. Students should contact
the course instructor for access."
- Screenreaders should also detect this information.
Change-Id: I660485b5143f877ef231b0edb52b2c82b8cdaab3
Reviewed-on: https://gerrit.instructure.com/39227
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Makes the modules page more accessible for both screenreader and
keyboard only users.
fixes CNVS-9045
test plan:
1. Using a screenreader go to the modules page (/courses/##/modules)
2. The "keyboard instructions" area should inform you to use the
move module options.
3. Navigate to the admin links cog for a module
4. You should see a "Move to..." option.
5. Click it using whatever the screenreader uses for click
(VO: Ctrl+Option+Space)
6. A dialog should appear (This dialog should be accessible)
7. You should be able to move a module to whatever location you
want.
8. Close the screenreader, repeat steps 3-7 using only the
keyboard.
9. When the drag-and-drop handle has focus a warning should appear.
Change-Id: Ie64b79ab6fa85d728fd97fba3842717b1a6ed99b
Reviewed-on: https://gerrit.instructure.com/39806
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-13924
test plan:
- Go to a course syllabus in Chrome
- Make sure several assignments are there with due dates
- Resize the window to be small
- Date and Day columns should not overlap but remain in their
own columns.
Change-Id: I51602d4df85d5c6c07e1a987a8ea5a1852d906dd
Reviewed-on: https://gerrit.instructure.com/39558
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
this way the user experience is identical (sighted
or screenreader), whether the notification
originated from the server or the client
test plan:
1. do something that causes a flash notification
from the server (like un/publishing a course)
- observe the visual design animates in
- observe that the screen reader announces
the notification
2. do something that causes a flash notification
from the client (like sending a message)
- observe the visual design animates in
- observe that the screen reader announces
the notification
closes CNVS-12222, CNVS-12221, CNVS-12224, CNVS-14881
Change-Id: I0a61b8a12292211726bc99d23d056c92918c5f76
Reviewed-on: https://gerrit.instructure.com/39486
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
test plan:
* enable self-enrollment on the root account
* enable self-enrollment on a course
* disable self-enrollment on the root account
* self-enrollment should not work on the course
closes #CNVS-9109
Change-Id: Ic186497ae11376c00872200460d9850e4dfecc38
Reviewed-on: https://gerrit.instructure.com/39684
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes #CNVS-12635
Per Erin Hallmark, "Grading Scheme" is more
conventional than "Grading Levels"
Test Plan:
-Go to assignment details
-Confirm the appropriate wording per the ticket
Change-Id: If2ada1072633c568145229da622c66c33a3b18ac
Reviewed-on: https://gerrit.instructure.com/39761
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
fixes: CNVS-13196 CNVS-14408 CNVS-14960
accounts that have an AccountAutorizationCofig
(those that use cas ldap or saml) are able to set
a login_handle_name (so on the login screen they
could have it say "USU ID #" instead of "Email").
but there are a lot of customers that don't use
cas, saml or ldap that need to set it too.
for example, a school that uses a csv upload for users.
This allows these accounts to set a custom
login_handle_name too.
Test plan:
* for an account that does not use cas, saml, or ldap
* go to the account settings page, you should see
http://cl.ly/image/1W3B3K392p2B
* set something for "Login Label:"
* go to the login screen
* it should use that new value you set
Change-Id: I5a7fd025229a792db4bf898015752024dafa173d
Reviewed-on: https://gerrit.instructure.com/39628
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Fixes: CNVS-14602
Test plan:
- Trigger a to-do in the right sidebar
- Ensure that the color contrast meets WebAIM
standards of 3:1 in the default UI and at least
4.5:1 in the high-contrast setting.
- Note: the body background image is around #e5e5e5,
which is what I used to test the ratios while
working on this.
Change-Id: Ic4188d7d633da177abadbb5b3320ce0f70b9ac99
Reviewed-on: https://gerrit.instructure.com/39155
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
fixes CNVS-14164
test plan: as an account admin, go to the accounts page and visit the
admin tools tab. there should be an h1 heading. the aria labels for the
search fields on each tool should make sense. the "view notifications"
tab should read a notification (via screenReaderFlashMessage) when the
ajax search results are found, so that screen reader users know that
they can tab down to the results.
Change-Id: Ib9a6d54ede47c37b16f1d47da48c12b1627de2bb
Reviewed-on: https://gerrit.instructure.com/37990
Reviewed-by: Aaron Cannon <acannon@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
test plan:
* create several types of external tool integrations
(user navigation, account navigation, course navigation,
external tool module items, external tool assignments, etc)
* when launching the tool in an iframe and finishing the tool use,
instead of showing a generic "Tool Use Finished" page, it should
break out of the iframe and redirect to another page
closes #CNVS-13800
Change-Id: I069e7052c819accc63f2bf546b46ff2db0c3afca
Reviewed-on: https://gerrit.instructure.com/39382
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Removes customization from the courses dropdown menu. Combines the
customize and the view all courses link.
closes CNVS-14682
test plan:
- Open up Canvas and hover over the Courses
- The link next to the My Courses title should say
"View All or Customize (##)"
- Clicking on the link should take you the My Courses page
Change-Id: Ic1a3923908393664a33709c683550d8fd12daad1
Reviewed-on: https://gerrit.instructure.com/39090
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-14933
test plan:
- Make sure it works for Transifex
Change-Id: I6598e5dc5854fbcea70caf77f2373817e17e3494
Reviewed-on: https://gerrit.instructure.com/39583
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Fixes: CNVS-14304
Test plan:
- Check the main Courses dropdown in regular-contrast mode
and verify that the subtitle text (Enrolled as: teacher)
is now darker, like the screenshot I have posted in the
JIRA
- Create a discussion and a couple of replies
- Verify that the Reply link is now darker, like on the
screenshot I have attached to the JIRA. I used the
ensure-color-contrast function, so the colors should
now adhere to WebAIM standards.
Change-Id: Id5deac49b5650370469e320e631b0c747dd1adb4
Reviewed-on: https://gerrit.instructure.com/39114
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
test plan:
- in an environment with redis caching enabled,
- create a content migration with the API and add the
undocumented parameter
settings[import_in_progress_notice]=1
- while the course import is in progress, course pages
should show a blue banner at the top of each page
indicating that an import is in progress, and linking
to the migration status page
fixes CNVS-14517
Change-Id: I9cf5c10e043f07460a1e42491addd029cfe31396
Reviewed-on: https://gerrit.instructure.com/38815
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-13896
test plan:
- Using NVDA in Firefox go to the account settings page
- An h1 heading "Account Settings" should be detected.
- It should not appear on the page.
Change-Id: Iafd81fecbd4e31954f31f39ecd934bd56a06f340
Reviewed-on: https://gerrit.instructure.com/39024
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-14922
test plan:
- See if Transifex works properly with this file.
Change-Id: I677482d5b631e8cd12f74f8f5f22f092cd1e9f17
Reviewed-on: https://gerrit.instructure.com/39556
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Will allow proper differentiation of media in Kaltura in the future.
There are two ways that partner_data makes it up to Kaltura:
(1) via a bulk_upload of attachments in the backend
(2) via the rich text editor upload/record video button
For (1), we globalize the id in KalturaMediaFileHandler. For (2) we
move the domain_root_account_id to js_env as we globalize it.
fixes CNVS-14870
Test Plan
(requires a dev with db access to kaltura to check partner_data)
Kaltura should receive partner_data that includes a global
root_account_id in all of the following contexts:
- upload a video via RTE
- record a video via RTE
- upload a file and add it to a document
Change-Id: Ia4e96ee555465d447015e4cf7a7508e093e51ec2
Reviewed-on: https://gerrit.instructure.com/39496
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Paul Hinze <paulh@instructure.com>
This commit brings in canvas_quiz_statistics, a client app that can be
embedded in Canvas.
Closes CNVS-14781, CNVS-14846, CNVS-14847, CNVS-14850
> What's done
- full build integration, meaning the app runs with ?optimized_js=1:
+ JavaScript "built" source gets piped into the r.js build pipeline
like any other Canvas JS source in public/javascripts/*
+ SCSS sources get picked up by the sass-compiler like Canvas style
sources and they get compiled from the grounds-up
+ I18n: phrases are extracted properly, with default values and
options, by our i18n rake tasks
- new rake task js:build_client_apps that builds client apps and
injects them as input to the rest of the JS build process
- support for using Canvas JS packages, like d3, jQuery, and Backbone
- support for using Canvas SASS variables & helpers
- super i18n support: use raw I18n.t() calls like you are in Canvas,
with development-time interpolation, as well as super new
Handlebars-like block-style translations in React, perfect for very
long phrases (mini-articles)
> Docs and References
The code was originally developed in its own github repository. While I
won't be pushing code to that repo anymore, the Wiki will still house
the docs until we find a better place.
- Repo: https://github.com/amireh/canvas_quiz_statistics
- Development guide: http://bit.ly/1sNOhER
- Integration guide: http://bit.ly/1m9kA9V
> TESTING
- login as a teacher
- go to /courses/:course_id/quizzes/:quiz_id/statistics_cqs
+ make sure you see something that looks like the Ember stats
+ click one of those little "?" help icons, you get a dialog:
- verify the contents within the dialog are actual English text,
not code gibberish
- there's also a link at the end of that dialog, click it and
verify it takes you to an Instructure help article
- build the assets: `bundle exec rake canvas:compile_assets` then:
+ add ?optimized_js=1 to the URL and reload the page:
- verify the app still works
Change-Id: Ic474650dfb06a1c22869ed9680dd04d1ca0f651d
Reviewed-on: https://gerrit.instructure.com/39105
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Hannah Bottalla <hannah@instructure.com>
Reviewed-by: Adam Ard <aard@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
lets the teacher decide if the students
turn it in paper gets submitted to the
repository or not
closes PS-1863
test plan:
1. enable turnitin
2. create an assignment
with turnitin enabled
3. go to Advanced Turnitin Settings
4. validate new checkbox for include
in repository is there
5. validate you can check it and
uncheck it and save the assignment
and the setting stays for that assignment
6. uncheck it as a teacher and save the assignment
7. submit the assignment as a student with a file
upload essay
8. Originality Report should come back as a new
submission
9. revise the essay file upload and resubmit
the Originality Report should come back as
a new submission
old behavior:
1. first submission Originality Report was fine
once revised and submitted again the Originality
Report was coming back as plagiarized because
it was comparing the revised essay against
the first submission. this is undesirable
Change-Id: I85770425e53c3b9bc50a2591125ce45f253b9cf2
Reviewed-on: https://gerrit.instructure.com/38592
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Jake Sorce <jake@instructure.com>
universalsubtitles.org returns a 503 error now
fixes: CNVS-14832
test plan:
try to make subtitles for a video,
make sure the page it takes you to exists.
Change-Id: I162247580f6a30f530725725c657dfc45ee4e3b7
Reviewed-on: https://gerrit.instructure.com/39396
Reviewed-by: Paul Hinze <paulh@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Adjusts the element_toggler to use a span rather than a link.
Also adds a tabindex to the description so that screenreaders can
actually read the description.
fixes CNVS-14484
test plan:
- Using a screenreader go to account settings (/accounts/#/settings)
- Navigate to the Feature Options tab
- Navigate to the toggle feature details button
- Using either spacebar or enter should cause it to activate
- Tabbing through should read the details if they are expanded
Change-Id: I50295fdcee91f90884383a340911ed8b8778deae
Reviewed-on: https://gerrit.instructure.com/39297
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
refs: CNVS-14114
refs: CNVS-13987
Test Plan:
Reference: g/37503
Message in admin tools should be gone and drop down should be visible.
The funcionality should behave as it was before it was disabled.
Hit an Audit log api call and it should work as it was before we
disabled it.
Change-Id: I13eac39aece25dff28b403eb733060e8b3a7f338
Reviewed-on: https://gerrit.instructure.com/37541
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
Fixes CNVS-14490
Test plan:
- Create a new course, and an assignment within
- Enter student view to generate the test student enrollment
- Submit the assignment as the test student
- As a teacher, give the student a score for the assignment
- With the test student's submission graded, the course should
still be unpublishable
Change-Id: Ib11fb7a2baa834ddf0a7f39a8ac12542539ab1e4
Reviewed-on: https://gerrit.instructure.com/39009
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes CNVS-14293
Test plan:
Visit the following pages and verify that each:
- has an unaltered visual appearance
- has exactly one level 1 heading which can be navigated to by screen readers
- When appropriate (I.E. when the length or organization of the page warrents
it) has lower level headings which can be navigated to by screen readers
- when lower level headings are present, heading levels proceed in order, and
logically
The following pages should be verified to confirm they meet the above criteria.
Note that the URL fragments provided may not be reachable on all installs,
and should be modified appropriately.
- /courses/1/assignments
- /courses/1/assignments/18
- /courses/1/discussion_topics (Sections should be level 2, individual
discussions level 3.)
- /courses/1/users/prior
- /courses/1/pages/front-page
- /courses/1/pages/front-page/revisions
- /courses/1/assignments/syllabus
- /courses/1/outcomes
- /courses/1/rubrics
- /courses/1/quizzes/11/take?preview=1
- /courses/1/quizzes/11/moderate
- /courses/1/question_banks
- /courses/1/modules
- /courses/1/statistics
- /courses/1/confirm_action?event=conclude
- /courses/1/copy
- /courses/1/content_migrations
- /courses/1/content_exports
- /courses/1/content_exports
- /profile/communication
- /users/2/user_notes
- /courses/1/users/1/usage
- /courses/1/announcements
- An additional heading can be seen by loading the page when no
announcements exist.
- /courses/1/pages
- /courses/1/files
- /courses/1/quizzes
- /courses/1/settings
- /dashboard/files
- /courses/1/outcomes/users/1
Change-Id: I26d7dba115105c36026758cf55644139116224ec
Reviewed-on: https://gerrit.instructure.com/37669
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* modify an lti app xml to be configured
for the 'global_navigation' extension
* add the tool to a domain root account using
the modified xml
* should add a new link item to the global menu header
* edit the xml to add a property to the global_navigation
extension:
<lticm:property name="visibility">admins</lticm:property>
* configure another tool for the domain root account
* confirm that the new link item is only visible
for teachers and account admins
closes #CNVS-13815
Change-Id: I5ce42515ebc545d6f14bdc9dd628e1740b94d667
Reviewed-on: https://gerrit.instructure.com/39060
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
when entering a course id in the course section cross-listing
dialog, the results should be read by the screenreader.
also fixed the styling of the dialog buttons to match the
standard canvas dialog button styling.
fixes CNVS-14007
test plan:
- go to the course section cross-listing dialog.
- enter a bogus course ID and press enter.
- screenreader should read both the intermediate "confirming"
message and the final error message.
- the confirming message might get cut off by the error
message in some screenreaders, that's just how they work.
- enter a valid course ID and press enter.
- screenreader should read both the intermediate "confirming"
message and the name of the course.
- the confirming message might get cut off by the name of
the course in some screenreaders, that's just how they
work.
- make sure both the "cross-list this section" and "cancel"
buttons still work.
Change-Id: I645f769285148cb4e40e2e92f7542aad04ed4c50
Reviewed-on: https://gerrit.instructure.com/39093
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes: CNVS-9194
This adds a configuration to CAS and SAML which will redirect to when an
unknown user is authorized from CAS or SAML but we do not have a
pseudonym for them in canvas yet. Instead of logging them out of CAS or
SAML it will redirect them to a custom url. By default if no url is
configured it will redirect to the login page or cas login page.
Test Plan:
CAS:
- Setup a User on the CAS server that can login.
- Make sure the user is not in Canvas and wont be matched up to any
other Canvas pseudonyms.
- Log in to CAS and Canvas.
- Canvas should redirect to cas_login_url.
- Configure the Canvas CAS setting unknown user url to redirect to
a custom url.
- Log in to CAS and Canvas
- Canvas should redirect to the custom url specified.
- The user should not be logged out of CAS.
SAML:
- Setup a User on the SAML server that can login.
- Make sure the user is not in Canvas and wont be matched up to any
other Canvas pseudonyms.
- Log in to SAML and Canvas.
- Canvas should redirect to login_url and provide a flash message
stating that the user could not be found.
- Configure the Canvas SAML settings Unknown User Url to redirect
to a custom url.
- Log in to SAML and Canvas
- Canvas should redirect to the custom url specified.
- The user should not be logged out of SAML.
Change-Id: I29a78f8ec60c94caecf63547584d8ae804ffc9de
Reviewed-on: https://gerrit.instructure.com/38472
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
closes CNVS-1296
Test plan:
* conclude an enrollment in a course
* open the gradebook, the user shouldn't be displayed
* download the csv, the user should not be included
* include concluded enrollments in gradebook display
* download the csv again, it should include the user
Change-Id: I5a464b3fa5e963e9989837a216fd2732fc9979b6
Reviewed-on: https://gerrit.instructure.com/38954
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Fixes CNVS-14027
Test Plan:
1. Be logged in as a teacher
2. Go to the People page
3. Using a screen reader navigate to the Search People box
4. Hear that the screen reader now says what the field is, before
describing how to use it.
Change-Id: I0db141e47c6e9be150fc7ee89944b79efe42fa38
Reviewed-on: https://gerrit.instructure.com/39011
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Naberezny <mnaberezny@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-13120
test plan:
- using NVDA with Firefox
- go to the assignments#edit page
- verify that the "Group Assignment" combobox is accessible
- verify that you can use the whole combobox
- verify that you navigate to "Peer Reviews" combobox next
Change-Id: Ibc996d7831793f04cd314acf463c462cbe58d541
Reviewed-on: https://gerrit.instructure.com/38880
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Liz Abinante <labinante@instructure.com>
fixes PLAT-588
test-plan
*headers for the external apps table should have scope defined on them
Change-Id: Id53d88ac2ac48ae375ada0206d282cbbf0ef58ba
Reviewed-on: https://gerrit.instructure.com/38865
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-14336
test plan:
- Go to a course syllabus
- Make sure there is at least one assignment with a due date
- The date column should include day of the week, month, day, and
year
Change-Id: Iae4cfec5fd401f32626e514e68f5071a67b374ff
Reviewed-on: https://gerrit.instructure.com/38971
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
fixes CNVS-4373
* fixes tooltip showing when total col is moved
* changes to have consistent border on cells
* changes .sass to .scss file so we know it's actively worked on
test plan:
- load up the gradebook page
- move total column to first and make sure tooltip works on hover
- make sure dotted line border appears on table cells (see comments for screenshots)
Change-Id: I7927ec37658f938bbfdb3e87c12f7da5014aeaa1
Reviewed-on: https://gerrit.instructure.com/37393
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Fixes CNVS-14516
Test plan:
- Open a conversation
- Open the reply dialog.
- Using a screen reader, verify that the close button is properly read.
Change-Id: I4b5a01c4b2bdc8311d001938a90d1b195a03492a
Reviewed-on: https://gerrit.instructure.com/38888
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
The <noscript> element is not allowed to contain an <h1> tag when it is in <head>. This was causing W3C validation to hard fail for every page, masking further validation errors.
Also add proper a11y, i18n, capitalization to the message.
See: http://www.w3.org/TR/html5/scripting-1.html#the-noscript-element
Test plan:
- Disable JavaScript
- Ensure the "You need to have JavaScript enabled..." message appears.
- Run W3C HTML Validator on a Canvas page
- Check that there are no errors referring to <noscript> or <h1> tags
in the <head>
Change-Id: I2904b5ecdff11cd4722d3fee173c5ff1dedf0063
Reviewed-on: https://gerrit.instructure.com/38807
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
Product-Review: Adam Phillipps <adam@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Fixes: CNVS-13520
Add label to "student learning master gradebook" "outcome group"
expand all and collapse all buttons, and
cause them to properly set the aria-expanded attribute on each
individual item. Also disable button when they are irrelevent.
Test Plan:
1) Create a course, add a student, and turn on the student learning
mastery gradebook
2) Add at least two outcome groups, each with at least two outcomes
3) Assume the identity of the student, and visit the gradebook,
learning mastery tab
4) With your screenreader, verify that the outcome group exapand and
collapse all buttons are usable.
* Validate that the Expand All button is reported as disabled for
screen reader users if and only if all items are collapsed,
regardless of whether they were expanded via the expand all button,
or manually, one-at-a-time.
* Verify the inverse of the previous for the Collapse All button.
Change-Id: I685dab01f93608c5a34204bf3403d3f6fd4aa793
Reviewed-on: https://gerrit.instructure.com/37927
Reviewed-by: Aaron Cannon <acannon@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: David Josse <david@instructure.com>
I found that only 2 icons were missing error & question. Calendar was
overly huge. I decided it would be best to use the icons that are
actually rendered on the dashboard where the announcement is visible
to users.
I also moved some business logic out of an erb template and into a
helper. The announcement layout in the admin area is now more inline
with how they are actually rendered on the dashboard.
Fixes CNVS-14421
Test Plan:
- Log in as an admin and go to an account's settings page.
- Click the Announcements tab and Click the blue "+ Add a New Announcement" button.
- Fill in all the details of the announcement, but leave the icon as the default, then click the Add Announcement button.
- Verify the announcement appears on the announcements list and the icon shows a Yellow warning sign with an exclamation mark.
- Now, create a new announcement and change the icon to something else, then click the Add Announcement button.
- Look at the icon on the announcement's icon on the announcement list. The icon should now show up.
Change-Id: Ie8c0ad64c5de5ab6ab76b90ff3e95712f71be8d6
Reviewed-on: https://gerrit.instructure.com/38609
Reviewed-by: Mark Severson <markse@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Test Plan:
- Verify that the following launches still work:
sessionless, borderless, module item selection, and direct link
fixes PLAT-459
Change-Id: I2b5c4d448540292ff451dd3d77ba69610f0764ab
Reviewed-on: https://gerrit.instructure.com/38790
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Adds an extra style 'tall-row' to be added to td's that have more
than one row of text permitting these cells to line up with their
label counterparts.
fixes CNVS-4772
test plan:
- Open up Settings > Course Details
- Look at the "Ends" row
- The Ends label should line up with the content.
- Look at the "Language" row
- The Language label should like up with the content.
Change-Id: I3dcaaade2c96e9870a750c242c737c4355b5e549
Reviewed-on: https://gerrit.instructure.com/38806
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Test Plan:
- create or edit a quiz
- switch editors by clicking on "HTML Editor"
- Confirm that the editor switch text now reads 'Rich Content Editor'.
Extra WYSIWYG locations:
- Confirm that assignments, syllabus content, calendar events, eportfolios, and wiki rich text editors are also edited
- confirm that locales are updated
Closes #CNVS-14658
Change-Id: I87348365706cd7a9d77932b805204879e521425d
Reviewed-on: https://gerrit.instructure.com/38885
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
Test Plan
- Visit /courses/:course_id/external_tools/retrieve?url=:launch_url&borderless=1
- There should be no insecure warning for an https launch
fixes PLAT-581
Change-Id: I050b93f5f4f1fc82f8039a29cde802addc734fcd
Reviewed-on: https://gerrit.instructure.com/38757
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Adds an aria-label for screenreaders and overrides the default id
to keep it from conflicting with the create section input. Localizes
the label as well as updates the tests.
fixes CNVS-14482
test plan:
- Go to a course settings page and click on the sections tab
- Add a section
- Edit a section
- This should work without problem
- Use a screenreader to navigate to the added section
- The screenreader should indicate to edit the section name
- Navigate to the add section field
- The screenreader should indicate this as adding a section.
Change-Id: I8eef887948fd728e3a104eb8c0b72d0a1a4e977c
Reviewed-on: https://gerrit.instructure.com/38875
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-1455
test plan:
- create a graded discussion that requires peer review
- the discussion should have a peer review icon in listings
- assign peer reviews to students
- the students should have a peer review link in their
activity stream
Change-Id: I416c876c9e21b5ce2a72c46fceb7a33bdfd3f96e
Reviewed-on: https://gerrit.instructure.com/36459
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: David Josse <david@instructure.com>
Changes the widths to allow proper resizing in Chrome, etc.
Removes the redundant 'Day' column. Changes the first column to
align left rather than center.
fixes CNVS-13924
test plan:
- Go to a course syllabus in Chrome
- Make sure several assignments are there with due dates
- Resize the window to be small
- Date and Day columns should not overlap but remain in their
own columns.
Change-Id: I74a190d35ac9acacd1b179d520e8328b84ec34d5
Reviewed-on: https://gerrit.instructure.com/38802
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes PLAT-587
test-plan:
the edit and delete tool buttons on the External tabs page should be readable by NVDA and screenreaders
Change-Id: I090c43137d49189ba20469ef54aad6b6833b7d2e
Reviewed-on: https://gerrit.instructure.com/38860
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-9975
test plan:
- Go to a user's profile
- Click edit
- Change the user's name
- Click cancel
- The user's name should not update.
Change-Id: Iaa2bbeada63eaeb5521bbb1be627f530d6093563
Reviewed-on: https://gerrit.instructure.com/38758
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Fixes CNVS-14505
Test plan:
- Visit the inbox
- Using a screen reader, verify that the currently selected item is read as
the label of the button to open the message filter drop-downs
- Verify that screen reader users can navigateand select items from both lists
- Verify that the appearance remains unaltered.
Change-Id: I1e177ca0be0d6b0c0ad6094de477938dfd440868
also remove some code that accomplishes nothing but confusion
test plan: perform content migrations into a course via the web UI
1. without adjusting dates
2. shifting dates
3. removing dates
and verify that the correct operation is performed for each migration.
test all of these workflows:
1. Course Settings / Copy this Course
2. Import Content / Copy a Canvas Course
3. Import Content / course export package
fixes CNVS-14183
Change-Id: I965a8ba6e6b0971cd0b5561627716989191a9680
Fixes CNVS-14126
Test plan:
- Visit the Calendar
- Click Add New Event
- Click More Options
- Navigate to the cancel button
- Verify that it is recognized as a button by screen readers
Change-Id: Ice93078d7d728503bc4bda29a5894ae19583692c
Converts external_tools.sass -> scss while adding a few styles to
truncate the names properly. The styles added convert the table
to render using the fixed style and the first column to have a width
of 500px and overflow the text using ellipsis. A title attribute is
also added to the column to help with UX.
fixes CNVS-7223
test plan:
- Go to Settings > Apps
- Add an app with a long name around 160 characters
- You should see that the name is truncated with an ellipsis
- Hover over the name
- A tooltip with the full name should appear
Change-Id: I24cc71a0073799e66efa57421b80b0b70bdbecdb
This patch adds a keyboard-accessible dialog that lists the available
TinyMCE keyboard shortcuts within quizzes.
Closes CNVS-9795
TEST PLAN
---- ----
- go to the create or edit quiz page
+ verify you see a little "?" help icon next to the "HTML Editor"
link in the editor action-bar
+ click it and verify that it launches a dialog
- verify the dialog contents match those specified in the ticket
+ press ALT+0 and verify the dialog gets opened
- you can try using the 0 on the numpad if you have one, it should
work too
+ verify that you can get to the "?" icon using your keyboard by
TABbing around
Change-Id: I18df7ce74d33369df2245e2fff4d9d0c7e1735a2
added tests and removed secondary speedgrader link that caused error
fixes CNVS-8868
test plan
- set large_roster flag to true for a course
- go to gradebook and click the text bubble on a submitted assignment
- link to speedgrader should not appear
- set large_roster flag to false
- only one link to speedgrader should appear
Change-Id: I0bfb5452a8adddb140fe80b0ee12b82b2249dc3c
Reviewed-on: https://gerrit.instructure.com/38503
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Closes CNVS-11854
Test Plan:
1) Restart your server after checking out this code (there is new feature flag)
2) As a user, visit /profile/settings and see that there is no option
for disabling the inbox
3) As an instructure employee viewing settings for the root account,
turn "on" the inbox opt out feature flag. If the button says "allow"
instead of "on", you are in the wrong place and want to be on the
account's settings, not the site admin settings.
4) As a user, visit your settings again: /profile/settings
5) See that you can now disable the inbox.
6) Do so.
7) Check the that conversations notification settings no longer appear
at /profile/communication
8) Check that when you have new conversation messages, the unread
messages badging doesn't display on the inbox link in the main nav
9) Visit your settings a 3rd time, and un-disable the inbox
10) check that the inverse of 7 & 8 are now true
Change-Id: I061e2d3ab9052a7809fb43f80d8e2e92d99316ee
Reviewed-on: https://gerrit.instructure.com/38313
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: David Josse <david@instructure.com>
fixes PLAT-583
test plan:
the links on the App Setting page for eduappcenter and Canvas community topics for lti tools should be more descriptive
Change-Id: I066a6181ee60daa6e4200b2737c799f7976f4bed
Reviewed-on: https://gerrit.instructure.com/38777
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
Test Plan:
- Create a homework assignment that accepts a website url
- Add an external tool that supports homework submission
- Submit a URL from the tool in a tab (not the more tab)
- It should save the submission
Regression Test
- File submissions via LTI should still work
fixes PLAT-579
Change-Id: I1a0ef11c0c4293d175c1e7604622922eadb8bf7f
Reviewed-on: https://gerrit.instructure.com/38707
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Closes CNVS-11570
Test Plan:
- create or edit a quiz
- switch editors by clicking on "HTML Editor"
- Confirm that the editor switch text now reads 'Rich Text Editor'.
Extra WYSIWYG locations:
- Confirm that assignments, syllabus content, calendar events, eportfolios, and wiki rich text editors are also edited
- confirm that locales are updated
Change-Id: If110012fea46090dc2283bfba1170e82034e7ff5
Reviewed-on: https://gerrit.instructure.com/38729
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
fixes PLAT-573
test-plan:
*The title of the Add New App modal should be "Add New App"
*Screen readers should read the extra help text for the Custom Fields text box
Change-Id: Icdd277542f8fddf9165f95f2add26bbab741c0ab
Reviewed-on: https://gerrit.instructure.com/38576
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
test plan:
1. use the content exports api with export_type=zip
to export files from courses, groups, and users
a. confirm only users who have permission to
download files from these contexts can perform
the export
b. confirm that deleted files and folders do not show
up in the downloaded archive
c. confirm that students cannot download locked files
or folders from courses this way
d. check the progress endpoint and make sure
it increments sanely
2. perform selective content exports by passing an array
of ids in select[folders] and/or select[attachments].
for example,
?select[folders][]=123&select[folders][]=456
?select[attachments][]=345
etc.
a. any selected files, plus the full contents of any
selected folders (that the caller has permission
to see) should be included
- that means locked files and subfolders should
be excluded from the archive
b. if all selected files and folders are descendants
of the same subfolder X, the export should be named
"X_export.zip" and all paths inside the zip should be
relative to it. for example, if you are exporting A/B/1
and A/C/2, you should get "A_export.zip" containing
files "B/1" and "C/2".
3. use the index and show endpoints to list and view
content exports in courses, groups, and users
a. confirm students cannot view non-zip course exports
(such as common cartridge exports)
b. confirm students cannot view other users' file (zip)
exports, in course, group, and user context
c. confirm teachers cannot view other users' file (zip)
exports, in course, group, and user context
(but can still view course [cc] exports initiated by
other teachers)
4. look at /courses/X/content_exports (web, not API)
a. confirm teachers see file exports they performed
b. confirm teachers do not see file exports performed by
other teachers
c. confirm teachers see all non-zip course exports
(cc/qti) including those initiated by other teachers
5. as a site admin user, perform a zip export of another
user's files. then, as that other user, go to
/dashboard/data_exports and confirm that the export
performed by the site admin user is not shown.
fixes CNVS-12706
Change-Id: Ie9b58e44ac8006a9c9171b3ed23454bf135385b0
Reviewed-on: https://gerrit.instructure.com/34341
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-13971
Test plan:
- Visit a discussion with edit privileges
- Using a screen reader, verify that the edit button is reported as being a
button
Change-Id: Ie89a3595d33f14fbb990dc2f8140216d5a08bfe2
Reviewed-on: https://gerrit.instructure.com/38469
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: David Josse <david@instructure.com>
fixes CNVS-2684
fixes CNVS-2768
test plan:
- in the site admin account settings page:
- the notification tab should be gone
- updating settings should still work
- in the root account settings page:
- the notifications tab should still be present and functional
- in a sub-account settings page:
- the notification tab should be gone
- updating settings should still work
Change-Id: Ic6b016be8d0b7a00f4153870220dbb34388a350b
Reviewed-on: https://gerrit.instructure.com/38367
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Safari does not fully support built-in HTML5 validations, error message was being skipped.
fixes CNVS-14162
test plan:
- Click the edit cog for the assignment group cog
- Enter text into min/max score fields
- Chrome and FF should display default HTML5 validation text, box should contain arrow incrementers
- Safari should display our built validation text "you must use a number" and arrow incrementers should be disabled
Change-Id: I8a25372a11de14e56288d42f68b0353a0b745414
Reviewed-on: https://gerrit.instructure.com/38450
Reviewed-by: Liz Abinante <labinante@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Closes CNVS-2143
TEST PLAN
---- ----
- create a quiz with no questions, set a time limit
- visit the moderate page (DS, not ember)
+ click the little pencil/edit icon next to a student row of your
choice
- give them like 3 extra minutes for each attempt
+ verify you see "gets 3 extra minutes on each attempt" in the
block
+ do it again, give them 0 minutes
- verify the message disappears
+ rinse and repeat with different inputs for different students,
it should always update properly
Change-Id: I0f8724b95221f52d6eba94577fcbae1bfd47d1b8
Reviewed-on: https://gerrit.instructure.com/38418
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
test plan:
* create a role in site admin with only permission to create other roles
* add a user to that role (and no other roles)
* log in as that user, and go to a *different* root account's settings
* it should not show an empty x, or even the ability to add admins
(the only available roles are Account Admin, which the limited admin
does not have permission to create)
Change-Id: I295c25bff8b3f7ec1c190a514e4ac95b96d0be91
Reviewed-on: https://gerrit.instructure.com/38349
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-14163
test plan:
- visit the sub_accounts page for an account
- navigate through the account action buttons via screen reader
and make sure meaningful text is read
- specifically with NVDA, navigate through the account action
buttons via arrow keys and make sure meaningful text is read
- when an account has courses in it, the delete account button
should read the reason it is the account cannot be deleted
- when an account does not have courses in it, the delete
account button should read normally
- make sure the page has not visually changed
Change-Id: Ic08070d333bd041fc120cd82183aea0fa1724c6a
Reviewed-on: https://gerrit.instructure.com/38338
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Aaron Cannon <acannon@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-14416
test plan:
- make sure the publish final grade feature works in draft
state modules. Setting should be remembered and have the
desired effect (see jira for details).
Change-Id: I6960edf74b0bb71fdda0a01944972c0d24e0783d
Reviewed-on: https://gerrit.instructure.com/38231
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-13902
Test plan:
- Visit the announcements page.
- Add an external feed
- Using a screen reader, insure that the remove feed link has a meaningful
label.
Change-Id: I54797e9d150e16e3edaad0a9869aeb1d7ffdf254
Reviewed-on: https://gerrit.instructure.com/37830
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: David Josse <david@instructure.com>
Tested-by: David Josse <david@instructure.com>
test plan:
* as a student, visit /dashboard/data_exports
* should be able to export a zip file containing
all of the student's submissions
refs #CNVS-14242
Change-Id: Iaab216e7411c27fa6d259f677e40a75d3de3f5a8
Reviewed-on: https://gerrit.instructure.com/36872
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
* set up a course_home_sub_navigation enabled tool, as in
the test plan for g/37834
* launch the tool from the course home page
* select the imscc file on the test tool content
selection page
* should be redirected to the content_migration page
and have a new migration queued for the course
closes #CNVS-13797
Change-Id: If94e65d2ba3c1f2ed53624b6a3b4c9a75d25c5ce
Reviewed-on: https://gerrit.instructure.com/38206
Reviewed-by: Jon Willesen <jonw@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-13123
test plan:
- go to the course outcomes page
- enable a screenreader and view the headings list
- it should now have sequential headings, starting at h1 (specifically for this
page, it should have an h1 and an h2)
Change-Id: I616d212c343df7b8e277b505aa00e93697ddda7b
Reviewed-on: https://gerrit.instructure.com/38255
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
occasionally users connections are very slow,
no need to error out on the page
fixes CNVS-13542
Change-Id: I49e0873b42bb7bb53c73d9b37d95dee00be0a733
Reviewed-on: https://gerrit.instructure.com/38233
QA-Review: August Thornton <august@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-14078
If you're using VoiceOver or NVDA and trying to add a user to your
course but don't add a correct email, it won't read the error message.
This is now fixed.
Test Plan
Given I'm on the People page
And I'm using NVDA in FireFox
And I'm a Teacher
When I click the '+ People button
And I enter an email address that is not formatted correctly
And I press the "Next" button
Then I should see an error message explaining why the email didn't work
And the error message should have focus
And the error message should be read to the user automatically
Change-Id: Ic644bc9b5f93123bb9305a0d7c11e232d0c6620f
Reviewed-on: https://gerrit.instructure.com/38079
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
test plan:
* as an admin, visit the page of a user with an enrollment
* with a screenreader, the link with an "X" icon should
have descriptive text
closes #CNVS-13996
Change-Id: I2bb29fc10803028246f1fde121e5a0dba9f36452
Reviewed-on: https://gerrit.instructure.com/37932
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Shows red circles next to form elements that are missing or
incorrect (due_at, name).
Test Plan:
- press "Post Grades" button
- assignments with missing due dates or names should have
a red circle next to them
- choosing a date or typing a name should remove the red
circle after removing focus from the element
Fixes SIS-335
Change-Id: I9b01f4f322e20180211285bc02ed027d3aebf31d
Reviewed-on: https://gerrit.instructure.com/37211
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Eric Adams <eadams@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Tyler Pickett <tpickett+gerrit@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
test plan:
* using a screen-reader, confirm that the question mark buttons
on the Account settings/Reports tab have descriptive text
closes #CNVS-13913
Change-Id: I8c453cb60e27156d8c6b2da9f98d2940c203320d
Reviewed-on: https://gerrit.instructure.com/37977
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-12798
test plan
- Setup a quiz with a file upload question
- Take the quiz
- Upload a file
- The delete (X) button in the file upload space should have proper
accessibility
Change-Id: Ib8dfe02cf020422609258c44ca9b3156148d8025
Reviewed-on: https://gerrit.instructure.com/37793
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
fixes CNVS-9766
test plan:
* turn on the Differentiated Assignments feature flag
* from the quiz edit page
- add a due date for some of the sections, but not all
- save (update quiz)
> the only_visible_to_overrides flag on the quiz should be true
> edit the quiz again and there should not be an
empty due date row for 'Everyone else'
- add a due date for all the sections
- update the quiz
> the only_visible_to_overrides flag should not be there
- edit the quiz so that there are only due dates
for some sections but not all
* on the normal quiz show page and
* on the new Quiz Statistics show page
> there should not be a row in the due date area
for 'Everyone else'
- turn off the DA flag and make sure the quiz show page works
with the 'New Quiz Stats page' flag and without it
- make sure the edit page works with the DA flag off as well
Change-Id: Ifb090a195ff3283d963df12ae7a9eb503f32ee86
Reviewed-on: https://gerrit.instructure.com/34085
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
test plan:
* in a course that already has one or more modules,
use IE 10 toopen the "create module" dialog to add a module
to a course
* with keyboard focus on the module name text field,
press enter
* should submit the module as in other browsers
fixes #CNVS-14224
Change-Id: I1952c3d60e1ad05dfd4ea5962218f09dd2d21d5f
Reviewed-on: https://gerrit.instructure.com/37979
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes #CNVS-14351
Change-Id: Id4e04b90577b1651ba4d3bab9546b3743b38499a
Reviewed-on: https://gerrit.instructure.com/37936
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs CNVS-13987
after data fixup for CNVS-13987, the audit logs will contain tombstone
records for events that had been lost/corrupted by overwrites. these
records are essentially empty outside of ids, created_ats, and the index
entries pointing at them.
these adaptations prevent these bare events from causing errors during
the API response, and also some display indication in the admin tools
UI.
test-plan:
- revert a6304f2 to reenable audit logs
- generate tombstone events (with index entries, so they get found) in
each of the three audit logs (authentication, grade change, course
change):
# user for authentication events, course for the other two
target_course = Course.find(...)
target_user = User.find(...)
streams = [
[Auditors::Authentication::Stream, :user_index, target_user],
[Auditors::GradeChange::Stream, :course_index, target_course],
[Auditors::Course::Stream, :course_index, target_course]
]
streams.each do |stream, index, target|
index = stream.send(index)
database = stream.database
id = CanvasUUID.generate
created_at = Time.now
key = index.create_key(index.bucket_for_time(created_at), target.global_id)
ordered_id = "#{created_at.to_i}/#{id.to_s[0, 8]}"
ttl_seconds = stream.ttl_seconds(created_at)
database.batch do
database.insert_record(stream.table, {stream.id_column => id}, {
'created_at' => created_at,
'event_type' => 'corrupted'
}, ttl_seconds)
database.update(index.insert_cql, key, ordered_id, id, ttl_seconds)
end
end
- query each of the audit logs for the appropriate target through the
admin tools UI. the tombstones should show up in the results with the
correct created_at and an indication that the record was
corrupted/lost
Change-Id: I690c8a5469228b7815a644010bb4b744c8ea2e9c
Reviewed-on: https://gerrit.instructure.com/37603
Reviewed-by: Nick Cloward <ncloward@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
Fixes CNVS-13935
Test plan:
- Using a screen reader, create a new discussion topic.
- Navigate to the Available From and Until fields
- Validate that the screen reader reads the field labels correctly.
- Validate that the fields still opporate as expected.
Change-Id: I3f81dd13d8e4b04bb3034681e9fb17015e4fd9c5
Reviewed-on: https://gerrit.instructure.com/37842
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes CNVS-13584
test plan:
- as both a teacher and a student:
- navigate to assignments index page
- using the keyboard verify:
- you are able to navigate to the expand/collapse controls
- expand/collapse appears visually focused
- you are able to toggle the expland/collapse controls
- enable :quiz_stats feature flag on a course
- navigate to quiz index
- verify the above for quiz index
Change-Id: Ia9486464289d122c41d1790202b1b5e81d1a67a8
Reviewed-on: https://gerrit.instructure.com/36785
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
fixes CNVS-13848
test plan:
* create a role that only has permission to create admins
* in a subaccount, grant that role an additional permission
* in the root account, add an admin to the role
* log in as that admin
* in both the root account and the subaccount, attempt to create
an admin - it should only list your role in both cases
Change-Id: If9a2dd4952e432700c59a0d4ad5e76ffa822dd0f
Reviewed-on: https://gerrit.instructure.com/37408
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes PLAT-556
test plan:
screen readers should be able to tell which filter is selected
you can tab through the apps now, and select one with space
Change-Id: Idf96f9418420dfe79ebe6d4451901cf2766589ab
Reviewed-on: https://gerrit.instructure.com/37767
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-12770
test plan:
* turn on the Differentiated Assignments feature flag
* from the discussion edit page
- add a due date for some of the sections, but not all
- save (update discussion)
> the only_visible_to_overrides flag on the discussion's assignment
should be true
(you'll need to check the discussion's assignment with the API)
> edit the discussion again and there should not be an
empty due date row for 'Everyone else'
- add a due date for all the sections
- update the discussion
> the only_visible_to_overrides flag should be false
* on the discussion show page
- edit the discussion so that there are only due dates
for some sections but not all
> there should not be a row in the due date area
for 'Everyone else'
Change-Id: I4a998c65b1f0459ad93789672bf586473545a61c
Reviewed-on: https://gerrit.instructure.com/34272
Reviewed-by: Liz Abinante <labinante@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
Fixes CNVS-14008
Test Plan:
1) Create a course and add a student
2) Turn on the Student Mastery Gradebook feature
3) Add at least 2 outcome groups each with at least 2 outcomes
4) Masquerade as the student, and visit the Learning Mastery grades tab
5) Verify with screenreader that outcome groups are clearly clickable
Change-Id: Ib9773d8275c7adb13783ee6b0acac551b59fc09b
Reviewed-on: https://gerrit.instructure.com/37702
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
fixes PLAT-534
test-plan:
the link in Canvas Apps page should go to eduappcenter.com instead of edu-apps.org
Change-Id: I65ea243e017573e6ad97398c56815ba62dc1a8fb
Reviewed-on: https://gerrit.instructure.com/37781
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-13733
test plan:
- go to individual gradebook view and turn on a screenreader
- select an assignment
- go down and click on the "Message Students Who" button
- it should read the first select box as "Message Type"
Change-Id: Ib3aa136457dd03f4da6dba934e6e05ced0ea0a81
Reviewed-on: https://gerrit.instructure.com/37682
Reviewed-by: Liz Abinante <labinante@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Liz Abinante <labinante@instructure.com>
fixes: #CNVS-13908
test plan:
go to "/accounts/{id}/settings"
add some quiz ip filter ranges.
using NVDA, make sure the delete 'x' says 'Remove Filter'
Change-Id: I8e2c4421ec7f04e3bd0b957fa50a0df8e0aa1813
Reviewed-on: https://gerrit.instructure.com/37643
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Adds an option to Quiz that prevents the students from seeing their
results more than once after their submission.
Closes CNVS-13877
CHANGES
-------
- New option in quiz settings:
"Let Student See Their Responses" => "Only Once After Each Attempt"
- Teacher can always see the student's results
- Moderate dialog allows teacher to manually reset the result-locking
flag, allowing the student one more glimpse
- The flag is reset whenever a new attempt is taken
TEST PLAN
---- ----
- create a quiz
- toggle the new option: "Let Student See Their Responses" then "Only
Once After Each Attempt"
Turn off Ember/quiz stats:
- take the quiz by a student, turn it in:
- verify that you see your results
- reload the page
- verify that you no longer see the results
- take the quiz again:
- verify you see the results once, then not
- go to the moderate page as the teacher
- open the moderate dialog for that student
- check the new option "Let the student see the results one more
time"
- click Save
- reload the page as the student, verify that you see the
results
Turn on Ember/quiz stats:
- repeat the process
Other things to test:
- verify the new field "has_seen_results" is visible in the
submissions API and is documented
- verify the new field "one_time_results" is visible in the quizzes
API and is documented properly
- verify that the new option has no effect if the Quiz option is not
set
- verify that you can always see the student's results as a teacher
(the setting should not affect teachers)
Change-Id: I6eb4909f777e038acf6afc9ef2823352f5ea78be
Reviewed-on: https://gerrit.instructure.com/37544
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
cameron removed most of the controller/model stuff in:
3c434e8aff
but this removes the remaining view/coffeescript/stuff
Test plan:
canvas should still work
(sorry, this looks big but none of it was ever actually loaded)
Change-Id: Ie4e31fcdf5bc2820c9eafaef6e8b25332aaea4bc
Reviewed-on: https://gerrit.instructure.com/37508
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes CNVS-14009
Test Plan:
- create a course with a learner
- Turn on the Student Learning Mastery Gradebook
- Add an outcome group and an outcome
- Navigate to the grades for a student, then the learning mastery tab
- Expand outcome group and verify the alignments link has 2 ARIA attrs
- aria-owns="outcome_detail"
- aria-hasspopup="true"
- Click the alignments link and verify the modal has an id of
"outcome_detail"
Change-Id: I6e78b177530b3150e82ed3d126b3cd80762b4473
Reviewed-on: https://gerrit.instructure.com/37512
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes: PLAT-549
test-plan:
*the thumbnail images for apps in the canvas app center should have an alt tag
Change-Id: I87f1f73a88230fe6a0b1db7555cea3f613ac3618
Reviewed-on: https://gerrit.instructure.com/37092
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
Reviewed-by: Eric Berry <ericb@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
we changed the name of the interpolation argument without updating the key, so
translations that weren't updated in time are broken.
fixes CNVS-14193
test plan:
- go to the course homepage in a language that does not have an updated
translation for this key
- it should not error
Change-Id: Ideeceacdc6fcf3178c4e6bc94844b9cf3d2004b3
Reviewed-on: https://gerrit.instructure.com/37604
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
test plan:
* add a group to a course
* visit the 'People' page
* cliking on the 'Everyone' tab should not take you to
/courses/1/users
refs #CNVS-14011
Change-Id: Icc8d662d6165b6f746c623fa24e867f44c6a536c
Reviewed-on: https://gerrit.instructure.com/37488
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CNVS-13987
what was called CanvasUuid was *not* generating UUIDs. it was generating
slugs. by default, its generate method only creates 4 character slugs.
these should obviously not be used as UUIDs. the misnomer already caused
a bug in EventStream where it used these slugs as UUIDs, causing
collisions. to fix:
(1) rename canvas_uuid gem to canvas_slug, and rename it's primary
class CanvasUuid to CanvasSlug
(2) create new canvas_uuid gem, with class CanvasUUID, extracted from
lib/uuid_singleton for actual UUID generation
(3) fix event stream use CanvasUUID, rather than following the rename
of CanvasUuid to CanvasSlug
test-plan:
- have cassandra set up for audit logs
- create an audit log entry (e.g. change a grade)
- look at the generated audit log entry's id field; it should be a UUID
value, not a 4 character slug
Change-Id: I19758fff4433cd6cb2e21219217dced19ee05c5a
Reviewed-on: https://gerrit.instructure.com/37506
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
refs: CNVS-14114
refs: CNVS-13987
Test Plan:
Audit Log in Admin tools should have a message saying they have been
disabled.
Try to hit an api call to the audit log search and it should return a
503 with a message that they are disabled.
Change-Id: If3c46f16010d8fd9ace30de885d5572c7299c0ee
Reviewed-on: https://gerrit.instructure.com/37503
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
Fixes: CNVS-14010
Test plan:
1) create a course with a learner
2) Add an outcome group and an outcome
2) Navigate to the grades for a student, then the learning mastery tab
3) Expand the outcome group and see that the individual outcome title
is in an h4.
Change-Id: I506ed259eb3064bad69c69e8b7505105a9167e16
Reviewed-on: https://gerrit.instructure.com/37461
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: David Josse <david@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
test plan:
* navigate to /profile/observees
* add new observees (specifying usernames & passwords)
* new observees should appear in the list
notes:
- the 'Observing' tab does not appear until at least one observee has
been added for the user (and the page is refreshed)
- the observing user should gain Observer enrollments for courses the
observed user is enrolled in (both present and future)
closes CNVS-13356
Change-Id: Icda0f0d256fc73bcb554523db6436457941d8b58
Reviewed-on: https://gerrit.instructure.com/37283
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Test plan:
* go to an account that has canvadocs configured
* you should see the url you configured
* go to another account that hasn't had canvadocs configured
* there shouldn't be a base url filled in
Change-Id: I6889a02998f84a9ac7c6ac14d985beffea3a796c
Reviewed-on: https://gerrit.instructure.com/37412
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes CNVS-995
test plan
- on dashboard recent feedback should read "past
two weeks" instead of "next two weeks"
Change-Id: Ic31055ef02c323b4c3899a1eba853afccd542f0c
Reviewed-on: https://gerrit.instructure.com/37299
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fixes CNVS-13991
test plan
- specs should pass
Change-Id: Ie689f634e5ec51f85e07bdd4b1af21a311af97ad
Reviewed-on: https://gerrit.instructure.com/37328
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ken Romney <kromney@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes #CNVS-13548
When adding a module item the + link should have been a button with a
label. It now is a button with a label and works in JAWs and voice over.
Test Plan ------------
As a user that can create a module item
Given I'm using jaws and/or voice over
When I navigate to the modules page
I should be able to click on the add module items button
And it should be a button
And it should have a label
And it should work in Jaws
And it should work in voice over
Change-Id: I617dc3e37a9aeb2e54ee17a273f8284dbc7787f4
Reviewed-on: https://gerrit.instructure.com/36203
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
The internal order of blanks (in question_data) is no longer relevant
when rendering the results but instead should follow the order of the
[blank] definitions found in the question text.
Closes CNVS-3544
TEST PLAN
---- ----
- create a quiz with a FIMB question
- create two blanks, call them "color" and "size", e.g:
"My shirt is colored [color] and is [size] big."
- take the quiz and verify that your answers are shown in the
correct order per blank ([color] and then [size])
- edit the quiz and do this:
- edit the question
- select the portion of the "is colored [color]" and drag it using
your cursor to be somewhere after the "[size]" blank, e.g:
"My shirt and is [size] big colored [color]" (yes, ignore the
grammar this one time)
- directly click on Update Question without pressing anywhere else
- save quiz and republish
- take the quiz again by the student, submit it and:
- verify that the disabled input boxes still read in the correct,
newly-adjusted order which is [size] and then [color]
- verify that the result boxes look right overall
Change-Id: I497b15f5c0dfa863e39f4fd5856d56fb84581fde
Reviewed-on: https://gerrit.instructure.com/37251
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
Fixes CNVS-13729
Test plan:
- Reply to a discussion.
- Using a screen reader, add an attachment, and verify that the
attachment field is labeled.
Change-Id: I193b18a210e3255deb61f27f50349d74f395f6e8
Reviewed-on: https://gerrit.instructure.com/36863
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <braden@instructure.com>
QA-Review: David Josse <david@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes RD-79
test plan:
- add an lti app with the course_settings_sub_navigation
extension (probably have to modify the xml for an existing
app).
- go to the course settings page and see the app shows up at
the top of the right sidebar.
- on the console, change the integration_type for the tool to
'lor'.
- refresh the course settings page and see the app now has a
new badge.
Change-Id: I1d5ccc57e1ee3624abe91543c22793aa6dd0350a
Reviewed-on: https://gerrit.instructure.com/36853
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-13727
Test plan:
- Visit the external feeds dialog on the announcements page.
- Using a screen reader, verify that all fields are labeled.
Change-Id: I3613744e279dddaa0d99d9c9b9ddf50122b07ec4
Reviewed-on: https://gerrit.instructure.com/37090
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-13550
-- Test Plan --
As a user that can edit module items
Given I'm using JAWS and/or voice over
When I edit a module
And I add a pre-req to the module
Then adding a pre-req should be accessible in JAWs
And the "remove" pre-req X should be a button
And the "remove" pre-req X should have a label on it
Change-Id: I421134cbf42f03bac9d7a9a9bc3d425937f7374b
Reviewed-on: https://gerrit.instructure.com/36290
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
* confirm that all users have "Courses" in the top global
navigation (instead of "Home")
fixes #CNVS-9701
Change-Id: Idc9200e5a55d8010b3cc7df61592c23b78056389
Reviewed-on: https://gerrit.instructure.com/36730
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Fixes CNVS-13732
Test plan:
- Using a screen reader, visit the course roster.
- Open the add user dialog.
- Validate that the entry field for the email addresses is labeled.
Change-Id: I844152cedb452d0cb3030efbdb030196fc8c86b8
Reviewed-on: https://gerrit.instructure.com/36927
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-13351
test plan:
* created an admin role that has permission to create other admins,
but that's it
* as an admin in that role, it should only show that role as one
to choose for new admins
* you should only be able to delete admins in that role
* verify both of the above are enforced via the API
Change-Id: I11459567ab184d787ee02af55280e0f4f76d47e8
Reviewed-on: https://gerrit.instructure.com/35672
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Fixes CNVS-13129
Test plan:
- Visit the rubrics page.
- Click add rubric.
- Click to show the long description.
- With a screen reader, verify that the long description field is labeled.
- Edit an existing rubric, and verify that the same field is also labeled.
Change-Id: Iccbda8a4b29676345e70b69bf5fee142a5d71aed
Reviewed-on: https://gerrit.instructure.com/36759
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
The "Post Grades" button should be hidden for courses and sections
that do not have an integration_id, and visible when they do.
Test Plan:
- Give a section an integration_id and it should show the
Post Grades button when selected
Fixes SIS-333
Change-Id: I31fdc25db0ee58a528f5c4010fdab70f132a1998
Reviewed-on: https://gerrit.instructure.com/36768
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Tyler Pickett <tpickett+gerrit@instructure.com>
Reviewed-by: Eric Adams <eadams@instructure.com>
Product-Review: Eric Adams <eadams@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
test plan:
* add more than 50 people to a course
the easiest way to do this would probably be an sis import,
or running the following in the console:
c = Course.find(INSERT_COURSE_ID_HERE)
60.times { c.enroll_user(User.create!) }
* confirm that the people page scrolls and
paginates correctly
fixes #CNVS-13646
Change-Id: If84251963e5502dddb5fbdac54c98b9d64bfa128
Reviewed-on: https://gerrit.instructure.com/36790
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes CNVS-12953
test plan:
- create an assignment that needs submission and 4 students
- have 3 students submit, grade 2 of them, and have 1 of the graded ones
resubmit
- check in the speedgrader dropdown, the help text that shows up underneath the
student names when you hover over them
- there should be 1 each of 'graded', 'not graded', 'not submitted', and
'graded, then resubmitted...'
- make sure they are localized (i18n)
- also make sure the link to speedgrader for teachers in the right sidebar of
an assignment page is localized
Change-Id: I62388220f6bd2c0bdf71d79e9d2802ac51db112e
Reviewed-on: https://gerrit.instructure.com/36666
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
fixes CNVS-10558
test plan:
* open Canvas
* send yourself a new conversation from another user
* wait 30 seconds
* verify that your unread conversation count is updated
Change-Id: I4e9bb2e06bbc862842fbf18e0d77f03afee1bd81
Reviewed-on: https://gerrit.instructure.com/36711
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <braden@instructure.com>
fixes RD-76
test plan:
- as a teacher, navigate to a course settings page. the right
sidebar should look normal.
- modify an lti app's xml to include the
course_settings_sub_navigation extension
- configure an lti app via modified xml.
- navigate to a course settings page, where you should see a
button for the configured tool at the top of the right
sidebar.
- clicking on the button should launch the tool.
Change-Id: Iec9e3337437295865bab66a499fe8fc096ad0ba5
Reviewed-on: https://gerrit.instructure.com/36471
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-13099 CNVS-13100
Test plan:
- Using a screen reader, visit assignments, and open the settings cog.
- Check the "Weight final grade based on assignment groups" control.
- Verify that when navigating down the right column of the table with a screen
reader, that the label for each field, the value in the left column, is read.
Change-Id: I528bf4a377e297cd4e683d25c50145ace6fce3d1
Reviewed-on: https://gerrit.instructure.com/36688
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes CNVS-13127
Test plan:
- Using a screen reader, visit the Rubrics page.
- Verify that the edit and delete buttons are properly labeled and that those
labels are read correctly by screen readers.
- Verify that screen reader users are able to successfully activate those
controls.
Change-Id: Ic033b43f2ed296f63acdc3476973069d663d3ca4
Reviewed-on: https://gerrit.instructure.com/36697
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-13659
test plan:
- visit new student learning mastery outcomes
- print the page
- the tabs, buttons, and course select should not show on the page
Change-Id: If438f4821ae05d95927189de4ae47518b5c46286
Reviewed-on: https://gerrit.instructure.com/36587
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <braden@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Drew Bowman <dbowman@instructure.com>
fixes CNVS-12747
test plan:
- create a new course in a draft-state-enabled account
- click "Choose a Course Home Page" in the bottom panel
- the description on the right should match the button in the
right sidebar ("Choose Home Page" instead of "Set Course Layout")
Change-Id: I0178fe369c89e58923e25fc4249b480813e3ec3c
Reviewed-on: https://gerrit.instructure.com/36560
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes CNVS-13594
test plan:
- with and without ember quizzes
- create a quiz with multiple attempts (not unlimited attempts)
- as instructor take quiz
- visit quiz show
- click link to view history / attempt
- in right hand area click button to allow an extra attempt
- action should succeed, ui should update with new number of
attempts
- still on history page, choose an earlier attempt
- in right hand area click button to allow an extra attempt
- action should succeed, ui should update with new number of
attempts
Change-Id: I514ff5536e39ab12d2aeba9442085ede221f254c
Reviewed-on: https://gerrit.instructure.com/36430
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
closes PS-1602
test plan:
1. enable draft state on a course
2. go to the course
3. you should see the new buttons
in the top right
4. play around with them
5. you should not be able to see course
status if there are graded submissions
in the course
6. go to course settings
7. you should see the course status now
in the top right (published or unpublished)
8. if there are graded submissions you should
be able to hover the course status and get
a tooltip saying you cannot unpublish
Change-Id: Idb7c27503f84eb489e1970b2061eb903e452de09
Reviewed-on: https://gerrit.instructure.com/36041
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jake Sorce <jake@instructure.com>
fixes ALYT-37
enable site admins to interpolate a Canvas user's
global ID in announcements using the string
{{CANVAS_USER_ID}}. This is similar in function to
what site admins can currently do with the account
domain (using {{ACCOUNT_DOMAIN}}).
Since there are only two possible substitutions, we
just gsub the notification message when displaying
it. If we continue adding more potential substitutions,
we will need to be smarter about how we handle such
overrides.
Test plan:
1) Create a new announcement on site admin, sending
to all users and using the string {{CANVAS_USER_ID}}
as part of the message text
2) Log in as two different users and verify that for
each, the appropriate user ID is used in place of
{{CANVAS_USER_ID}}
3) With sharding is enabled, it should be the global,
not the local ID, that is displayed.
Change-Id: Ia7d39f26d5916637cda133ceddc7fc615af83b9c
Reviewed-on: https://gerrit.instructure.com/36372
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <braden@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nick Nelson <nick@instructure.com>
No longer allow GET requests to /logout
There were a few places in the app that were doing GET requests to
/logout, as well as some tests, so I fixed those to do a proper DELETE
request.
test plan:
* Make sure you can log out through the web ui
* Make sure that the cancel/logout buttons still work properly on:
* The accept terms of use page
* The self-registration page
* The "already enrolled" page that you see when you click an
enrollment invite for one user while logged in as another user
* Make sure that SAML and CAS log outs work as well
fixes CNVS-12163
Change-Id: I6a0a520745a21b349d36b004bceccbb0ff2c8503
Reviewed-on: https://gerrit.instructure.com/32723
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fixes CNVS-12184
test plan
- go to course settings
- export should be a down arrow
- import should be an up arrow
Change-Id: I1160729bf6f8c02b54b1d8f2a630ba2afeb92792
Reviewed-on: https://gerrit.instructure.com/36407
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fixes CNVS-13293
test plan:
- regression on gb2 and srgb
to make sure they both still work properly
Change-Id: I4ec554589b6a77a113d2faf46e7b530faa2d535f
Reviewed-on: https://gerrit.instructure.com/35501
Product-Review: Dana Danger <dana@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
fixes CNVS-13601
test plan
- create some outcome results with fractional scores (live
assessments are great for this)
- view them in the student mastery gradebook
- ensure that the scores are rounded to two decimal places
- click to view the alignment details
- ensure that scores on the alignment details dialog are rounded
Change-Id: Ie46dd732597619c44479cb9c7000c0debe0aa2c0
Reviewed-on: https://gerrit.instructure.com/36380
Reviewed-by: Braden Anderson <braden@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
this was replaced a long time ago by test student
Change-Id: I20981ada3e72df82da89d5bae1b81a3b31cfac66
Reviewed-on: https://gerrit.instructure.com/36309
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Fixes: CNVS-12797
JAWS requires a div to exist already for it to be
accessible. The flash_screenreader_holder existed,
so adding the partial there when it's needed will
make JAWS pick it up and read it immediately.
Test-Plan:
-Use old groups by disabling new group feature flag
in account settings of admin account
-Create a group and make sure it's set for users to
join automatically
-Login as user and join/leave group
-Verify that notification is accessible
Change-Id: I431ebcd74b7d01dea5041b801699b0ee72ead5ea
Reviewed-on: https://gerrit.instructure.com/36183
Reviewed-by: Drew Bowman <dbowman@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Jayce Higgins <jhiggins@instructure.com>
fixes #CNVS-12785
The course title was wrapping weird when you were on a wiki front page.
This commit fixes that.
Test Plan ----------------
As a teacher
Given you have a wiki page
And that wiki page is set up as the front page
And the homepage is set to the wiki front page
And you have a very long course title
When you navigate to the course homepage
Then you should see the course title is ellipsed
And the edit and admin gear should be formatted nicely to the right of
it
And you should be able to change the screen size without this breaking
Change-Id: Ie5e267afba57b31c06142d5b93f1da81270725e2
Reviewed-on: https://gerrit.instructure.com/36178
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes CNVS-10700
test plan:
- as a teacher create an assignment w/ many
different due dates
- create an observer
- make observer follow a student in one section
- assignment show page displays date properly
- make observer follow a students in many sections
- assignment show page displays "multiple due date" and tooltip properly
- make observer follow a student in section w/o date
- assignmnet show page says there is no date
- students in multiple sections see the correct date
on the show page (not multiple dates)
Change-Id: I4e5b3872a69a59f771ca68efd4de36b410de639f
Reviewed-on: https://gerrit.instructure.com/35851
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-13242
This adds a special field to learning outcomes
to use for friendly reporting in case the outcome's
actual name is quite complex or cryptic (like common core
standard outcomes).
TEST PLAN:
- login as an instructor
- create or edit an outcome and validate that you can add a "friendly"
name and that it persists
- use that outcome for an assignment and let a student complete it
- navigate to the student mastery report for that student
- verify that by hovering over that outcome name on the student mastery
report you can see both the real title and the friendly name
Change-Id: I89d1a5de590666ddf6cbc82617e4475d1f7a5226
Reviewed-on: https://gerrit.instructure.com/35919
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Drew Bowman <dbowman@instructure.com>
fixes #CNVS-12824
Images in the wikisidebar were not accessible, they now are. We also
removed a few links at the bottom of the page that were not needed.
Test Plan
----------------
As a user
Given I'm editing an assignment
And I tab to the wiki sidebar's "image" tab
Then I should be able to tab to images
And I should be able to press enter to insert an image into the page
Test Plan
----------------
As a user
Given I'm editing an assignment
Then I should not see the "New Discussion" link
And I should not see the "New Quiz" link
Change-Id: Icd5f1fc66c83000a05a00c9a54dc9ea948cfa639
Reviewed-on: https://gerrit.instructure.com/36102
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-13423
test plan:
- enable draft state and quiz sttas
- as a teacher
- create a quiz with a file upload question
- view the quiz
- there is now an option to "download all files" in the settings menu
- it should initially be disable if there are no submissions yet
- trying to click on it disabled should close the menu and flash a message
telling why it is disabled
- as a student
- take the quiz, and upload a file
- as a teacher
- view the quiz again
- the "download all files" should now be enabled
- click and make sure files download successfully
Change-Id: Ia9455b18916ef6fcb403b742671104fdcd17fd39
Reviewed-on: https://gerrit.instructure.com/35952
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-12718
test plan:
- in a course with 2+ assignment groups
- once with 1 assignment each, once with 2+ each
- with draft state on
- on assignment index page
- using keyboard navigation for everything
- click 'move to' for an assignment, close the dialog
- verify that focus is directed to the settings cog for that assignment
- repeat for an assignment group
- click 'delete' for an assignment, click cancel
- verify that focus is directed to the settings cog
- click 'delete' for an assignment, click ok
- for groups with 1 assignment: verify that focus goes to parent assignment group
- for groups with 2+ assignments: verify that focus goes to previous assignment in list
- for first assignment in list: verify that focus goes to parent assignment group
- with draft state on
- on discussion index page
- repeat 'move to' and 'delete' verifications from above
Change-Id: I0940b5eed70cecb628c25c597b8439598d096d24
Reviewed-on: https://gerrit.instructure.com/35120
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-10900; fixes CNVS-13243
test plan:
* open learning mastery student view
* verify that alignments links are present on each outcome
* click on an alignments link
* verify that the alignment results for that student and outcome are displayed
Change-Id: Iba3f7166264725de2b664623a6f38a994947318d
Reviewed-on: https://gerrit.instructure.com/35982
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
this puts lti app links on the right side bar of the course
home page.
fixes RAN-53, RAN-55
test plan:
- modify an lti app's xml to include the
course_home_sub_navigation extension
- configure an lti app via modified xml
- navigate to a course home page, where you should see a button
for the configured tool on the right sidebar.
- clicking on the button should launch the tool.
- configure another tool the same way, but include a
"visibility" property in new extension with a value of
"admins"
- view the course home page as a teacher. you should be able
to tee the newly configured tool, in addition to the
previously configured tool.
- view the course home page as a student. you should only see
the first tool you configured, and not see the tool with the
limited visibility property.
Change-Id: Ibe50c649f6d5f6806a87f0c8e8402f1209b9ed40
Reviewed-on: https://gerrit.instructure.com/35161
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
refs CNVS-3134
test plan
- go to /accounts/self/settings#tab-reports
- titles should be translatable
Change-Id: I32d47572929a729e1d5f9dc0a2f20a229005fcca
Reviewed-on: https://gerrit.instructure.com/35827
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Fixes CNVS-12851
Test plan:
- Create multiple announcements.
- With a screen reader, load or reload the announcements page.
- Verify that the delete and lock buttons are visible to screen reader users
before any boxes are checked.
- Verify that these buttons also remain visible, no matter how many or few
announcements are or aren't checked.
- Verify that these buttons are reported as disabled when no announcements are
checked
Change-Id: Id77e00acbb8fc2b4d713f542bc017695ed171f2a
Reviewed-on: https://gerrit.instructure.com/35543
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-12922
fixes CNVS-11552
test plan:
* enable learning mastery student view
* open a student's grades page
* open the learning mastery tab
* verify that outcome groups have the correct statuses
* verify that the outcome have the correct statuses
* verify that the progress bars are correctly color coded
and in the correct percentages
Change-Id: I2aa0a73d4a831d9795308efc10cdf13123fe7dce
Reviewed-on: https://gerrit.instructure.com/35844
Reviewed-by: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Drew Bowman <dbowman@instructure.com>
update the document.title to be consistent with the page that the user
is viewing. update existing moderate page title to be consistent
closes CNVS-12974
test plan:
- enable :quiz_stats feature
- enable :quiz_moderate feature
- visit quiz index
- title should display 'Quizzes'
- select a quiz
- title should display '<quiz title>: Overview'
- select the moderate tab
- title should display '<quiz title>: Moderate'
- select the statistics tab
- title should display '<quiz title>: Statistics'
Change-Id: I36d94014e2225d78d59d35c77b16bb82af48d644
Reviewed-on: https://gerrit.instructure.com/36016
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
fixes CNVS-13307
test plan:
* enable learning mastery student view
* open a student's grades page
* open the learning mastery tab
* verify that outcome groups are presented in a hierarchy
* verify that very deep outcome trees are compressed to paths
Change-Id: I1f74dca2876b39b01a6ec70935f60d5e233fe02b
Reviewed-on: https://gerrit.instructure.com/35481
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
fixes CNVS-13436
test plan:
* for teachers, disable these permissions:
* Add/remove other teachers, course designers or TAs to the course
* Add/remove students for the course
* enable View usage reports for the course
* log in as a teacher
* view the course roster
* confirm that the activity columns are visible
Change-Id: Ida208431c5d94b5f6f3a7a2df2901e5c4300b3a0
Reviewed-on: https://gerrit.instructure.com/35891
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
Fixes CNVS-12223
test plan:
- Using a screen reader, visit the login page and trigger an error.
- Confirm that the error ("invalid password" or similar) is read automatically.
Change-Id: I0e9f19943a6bcdd78a73949cba58b88531e6eaf0
Reviewed-on: https://gerrit.instructure.com/35617
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
fixes CNVS-13390
- test plan
- enable draft state and quiz stats features
- as a teacher
- create a quiz with multiple attempts
- as a student
- take the quiz
- as a teacher
- go to speedgrader for this student's submission and add a note in the
sidebar
- as a student
- go to your dashboard, the teacher's note should be in the sidebar
under "Recent Feedback"
- click on the note
- it should bring you to the submission details page.
- the ember version of the page should display in the frame
- clicking on 'take the quiz again' should not cause inception
Change-Id: I1eb7d467ec08f8d3a1510602b4720483c1b1167c
Reviewed-on: https://gerrit.instructure.com/35871
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
Test plan:
- Visit the conference concluded page and verify that the accessible label on
the pop-up menu is "Settings" and not "settings".
- Visit the New Conference page and verify that the Edit option in the pop-up
menu no longer has an unnecessary aria-label.
Change-Id: I563b1a1a479b213253b65da4362bd5c050c4ec35
Reviewed-on: https://gerrit.instructure.com/34629
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
this setting should allow tools to choose how they are displayed
in the canvas interface. the new full width display removes the
canvas sidebars, footer, and breadcrumbs.
test plan:
- install a tool with course_navigation and account_navigation
extensions.
- make sure the tool displays normally without a display_type
configuration.
- use a console to set display_type = 'full_width' in a tool's
course_navigation settings.
- the tool should display as a "full width" tool when viewed
by the course navigation link. full width means without the
left or right side bar, without breadcrumbs, and without a
footer. the canvas header should still be displayed.
- the tool should display normally when viewed by the account
navigation link.
- use the console to set the display_type = 'full_width' in the
tool's top level settings.
- tool tool should now display full width using the account
navigation link.
Change-Id: Idc19c0c96031bd80a45ce984241c23e4ce1efe78
Reviewed-on: https://gerrit.instructure.com/35160
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-12503
Test plan:
- Using a screen reader, visit any page in Canvas.
- Verify that the top bar has a navigation landmark with a label of
"User Menu"
Change-Id: I0ba93c519427d83f32e74f99ede2d2501bd76172
Reviewed-on: https://gerrit.instructure.com/35510
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-13366
test plan:
* open a course's groups page
* make a user a group leader
* verify that the leader icon looks right across browsers
Change-Id: I73ae8f15cbbcf55a864cc4db81382b1820cea52b
Reviewed-on: https://gerrit.instructure.com/35707
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
fixes CNVS-13255
test plan:
- as a teacher
- create a quiz with an essay question
- take the quiz
- the attempt history table should show an asterisk next to scores
that are pending review, and a message that explains some questions
aren't graded yet
- create a quiz without an essay question
- take the quiz
- the attempt history table should NOT show an asterisk next to scores or
an explanation that some questions not graded yet
- as a student
- take the essay quiz and we should have asterisks / message as well
- take the quiz without essays, and we should not get asterisks/message
- try this with multiple attempts as well. It should highlight any attempt
that is pending review
- this should work with both fabulous quizzes enabled / disabled
Change-Id: I7fd6b0744ca12ee1486a066d15b70701bbb22770
Reviewed-on: https://gerrit.instructure.com/35643
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-11832
fixes CNVS-11836
fixes CNVS-13327
test plan
- enable feature student_groups_next for course
- regression test groups page student view
- regression test instructor groups page
- as an instructor have multiple groups in a group set
- visit one of the groups
- the instructor can switch between the groups in the group set
- as a student you should be able to create a group
Change-Id: Iacf1eaf4467b57f307d45245b53dfc93f14154ff
Reviewed-on: https://gerrit.instructure.com/34454
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Drew Bowman <dbowman@instructure.com>
the "Allowed" state means a feature is off in an account, but
sub-accounts or courses below it are allowed to enable it.
the 'allowed' state does not, however, make a lot of sense for
features that apply to RootAccount. since the feature cannot
be controlled in sub-accounts or courses, the 'allowed' state
is equivalent to 'off' here.
so to make this less confusing, remove the "allowed" state
for RootAccount features.
(specifically, lock the transition in the API, and make the
UI hide buttons for locked transitions that don't have
messages to display when the user tries to perform them)
test plan:
- set the Use New Styles feature to "Allowed" in Site Admin
account settings
- in a root account settings page, ensure the 'Allowed'
option is not selectable for this feature
- ensure that the API reports the new_styles feature is "off"
and its "allowed" transition is locked
i.e., GET /api/v1/accounts/1/features/flags/new_styles
includes state: 'off' and transitions: {allowed: {locked: true}}
- ensure the API refuses to set the new_styles feature to "allowed"
in the root account
i.e., PUT /api/v1/accounts/1/features/flags/new_styles?state=allowed
should return a 403 error and not change the state
- regression test: in a sub-account, ensure the 'Use New Styles'
feature does not appear
- regression test: verify that when a (non-site-admin)
root account admin attempts to disable Draft State in
an account, the Off button is still there, and a message appears
when you click it, and the feature remains enabled
fixes CNVS-13220
Change-Id: I4d41076c10696b02d0c482a778d2555714487f17
Reviewed-on: https://gerrit.instructure.com/35473
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-12584
test plan:
- as a teacher, enter student view and then exit (to create the test
student)
- go to gradebook and give them a grade on an assignment
- click on their name to see their individual grades page
- it should load
- when you click on the 'score details' you should get a message the
grade stats are not available for the test student.
Change-Id: I39a3d24d606569372515ec903fedbdce1e3e7558
Reviewed-on: https://gerrit.instructure.com/35474
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
students who are made group leaders can update
the group name from the group dashboard page
fixes CNVS-11835
test plan:
- make a student a group leader
- visit the group dashboard as the group leader
- change the name as the group leader
Change-Id: I5637f1ef4e423a06f45987e0eccff2e65ac94613
TODO: Add description
Reviewed-on: https://gerrit.instructure.com/35326
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Drew Bowman <dbowman@instructure.com>
fixes: CNVS-13302
Fixes the sis imports to log the sis batch correctly and to display the sis
batch on the details modal in the auditing ui.
Test Plan:
- Do a SIS import for a course.
- Open the Course Activity Audit logging and the sis batch id for the course
should be shown in the dialog.
- If the source for an event is not SIS the sis batch field will not be shown.
Change-Id: Ib93a992dac83b2ec480d888e5d4686b808bcda8f
Reviewed-on: https://gerrit.instructure.com/35475
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
fixes CNVS-9765
test plan:
- turn on the Differentiated Assignments feature flag
* from the edit page
- add a due date for some of the sections, but not all
- save (update assignment)
- the only_visible_to_overrides flag on the assignment
should be true
(you'll need to check the assignment with the API)
- edit the assignment again and there should not be an
empty due date row for 'Everyone else'
- add a due date for all the sections
- update the assignment
- the only_visible_to_overrides flag should be false
* on the show page
- edit the assignment so that there are only due dates
for some sections but not all
- there should not be a row in the due date area
for 'Everyone else'
Change-Id: I1bce92c335c1af2c9ead6d963174c817d4b10cdd
Reviewed-on: https://gerrit.instructure.com/33706
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
fixes ALYT-29
test plan:
* access pages in a course for at least two minutes
* open the course people page
* verify that Total Activity reflects your time spent
Change-Id: I3b7765ae9469a9ce1d4258b7edfc161cf196f17b
Reviewed-on: https://gerrit.instructure.com/35377
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
QA-Review: August Thornton <august@instructure.com>
test plan:
0. BEFORE APPLYING THIS CHANGE SET,
create a course, enable draft state, do not create a
wiki front page, use the *old* "Choose Home Page"
dialog, select "Pages Front Page", and save
1. NOW APPLY THIS CHANGE SET.
open the new "Choose Home Page" dialog, and confirm
that "Front Page" is grayed out and disabled,
and "Recent Activity Dashboard" is selected
2. create a new course and enable draft state
3. go to the course home page and click "Choose Home Page"
4. the new dialog should appear and should contain
a radio button for each page selectable as home page.
5. note the "Front Page" radio button should be disabled
since there is no home page.
6. click the link next to the disabled radio button
labeled "Front page must be set first". It should take you
to the "Pages" page, where you can create a page and set it
as the front page.
7. Return to the course home page and click "Choose Home Page"
8. Now the "Front Page" radio button should be selectable
and the page title should appear next to it
9. Click the "Change" link and verify it takes you to the
Pages page
10. Confirm that all the other radio buttons work as expected also
fixes CNVS-10987
Change-Id: I056f91015af6f998b3018ec9bd31b98d6848bc3f
Reviewed-on: https://gerrit.instructure.com/35260
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
* import the test assignment fixtures as a common cartridge file
* there should be an assignment in the course
* also test import of flat manifest xml files
closes #CNVS-5906 #CNVS-13219
Change-Id: I0b765ed0d140516f78a5f4fb5dbe9b81ac77ecd4
Reviewed-on: https://gerrit.instructure.com/35394
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
closes: CNVS-9814
add support throughout our formatting layer
to give us a way to convert values
to the wall clock time of the timezone for
a course (or really any other way we choose),
and then apply that to several selected
date/time displays.
TEST PLAN:
- Login as a user who's part of a course
with at least some data in each tab
- Check the following areas to ensure that
the correct timezone-differentiated hover
text is showing up:
* Announcements -> Date Sent column
* Announcement Detail -> Date Sent (top right)
* Assignments -> Due Date column
* Assignment Detail -> Due Date (bottom table)
* Collaborations -> Start Date
* Discussions -> Last Post Date
* Discussions -> Due Date
* Discussion Detail -> Post date of each reply
* Modules -> (if locked) shows date to unlock
* Quizzes -> Due Date
* Syllabus -> Dates on the left
* Syllabus -> Due dates on the right
* Settings -> Course Details -> start/end date
* Settings -> Sections -> start/end date
* Recent activity page -> Everything
Change-Id: I048c2de85d9f9b196d35c6c65ae104dab7441eee
Reviewed-on: https://gerrit.instructure.com/34861
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-12823
test plan:
* on the assignment index page (with DS)
- open the assignment group edit dialog
> the neverdrop rules should be accessible
> the dropdowns to select which assignments should never be dropped
should also be accessible
Change-Id: Icefd8a0ab5184886232765136fa40da3bab0179d
Reviewed-on: https://gerrit.instructure.com/34857
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes: CNVS-11834
This creates a way for an instructor to
assign a random student as the group leader.
It only applies when an instructor is having groups
created automatically at the time of defining
a group category.
This also take an opportunity to refactor out
some bloated code from the group_categories_controller
and move it into some separate objects
that can be more easily understood and rapidly
unit tested through all the necessary permutations
(allowing higher level integration tests to just
cover a case or two)
It ALSO removes group leadership knowledge into
it's own object so that the callbacks in other
objects are simple and the logic regarding
how to do group leadership management is in
one place.
TEST PLAN:
AUTO_DISTRIBUTION:
1) login as an instructor
2) go to the "people" tab and try to create a group
set.
3) click on the "Create [0] groups for me" radio
button; verify you now have controls for assigning
a group leader automatically and that the strategy
radio buttons are greyed out.
4) check the "Assign a group leader automatically"
checkbox; verify the 2 nested radio buttons for
"random" and "first" strategies become enabled
5) select a strategy and fill out the rest of the
form, then submit (make sure your background job
is running)
6) verify after groups are created that each group
has a leader, and that the leader is in fact a member
of the group.
SelfSignup:
1) login as an instructor
2) go to the "people" tab and try to create a group
set.
3) enable self-signup.
4) check the "Assign a group leader automatically"
checkbox; verify the 2 nested radio buttons for
"random" and "first" strategies become enabled
5) select a strategy and fill out the rest of the
form, then submit.
6) Login as a student for the same course and join
the group.
7) verify that the student has been made the group
leader.
Change-Id: I2cdd9f5ed2fd577469beec4ab7369c69ecf7eaa6
Reviewed-on: https://gerrit.instructure.com/35130
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-10776
test plan:
* log in as a user in an account-level group
* open conversations
* compose a message
* verify that you can address the message to the group
Change-Id: Icb3d840e1d17cabb94394cc564f6d3c5b5f606e0
Reviewed-on: https://gerrit.instructure.com/35309
QA-Review: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-13179
As a teacher or admin
Given you have a module
And are on the modules page
Edit a module
Then you should see 'Lock module until a given date' is capitalized
And you should see 'Students must move through ...' is capitalized
Change-Id: Icfab7c67418baa65dd0b8b4b20fb28bc5fb8b3a4
Reviewed-on: https://gerrit.instructure.com/35246
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-13178
There was no aria label on the text field. There is now
Test Plan
---------------
As a teacher
Given your course has a module
And you are editing that module from the modules page
And you are using a screen reader
When you check the 'lock module until a given date'
And you tab to the 'unlock_at' text field
Then it should read you the label for that text field
Change-Id: I4cce9b038d68917192205b908c1dee0ce6041e3c
Reviewed-on: https://gerrit.instructure.com/35282
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes: CNVS-12590
Adds a course content event type to the course audit logs.
Test Case:
- Create a course.
- Reset its content.
- The event and its data should be reflected for both
the source course and new course from resetting the
course data.
Change-Id: I473d2e237491d890c20aace57f9c7675d70d22c7
Reviewed-on: https://gerrit.instructure.com/33726
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
also,make subtitle text bigger when in fullscreen
fixes: CNVS-12293
videos should play back like they used to but this commit
switches back to using html5 by default instead of flash
because that is the only way that subtitles will show up in
fullscreen mode
test plan:
in all the browsers we support (in particular: ie10, android
and mobile safari):
* try playing a video that you have uploaded a subtitle track for.
* the playback should work
* the subtitles should show up when in normal-sized mode
* press the fullscreen button, the video should go into
fullscreen correctly and still show the subtitles
(and the subtitles should be bigger in fullscreen mode)
Change-Id: I5b77f58133fb9081909771d50bb8f0a91db23d63
Reviewed-on: https://gerrit.instructure.com/34016
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Paul Hinze <paulh@instructure.com>
Product-Review: Ben Hutchings <benh@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
also clarify some facebook plugin config steps
fixes CNVS-13203
test plan:
- go to <canvas>/facebook/ and make sure the page renders
Change-Id: I5efdcbd16c497533e5aeee8b29ee59b57c8deb98
Reviewed-on: https://gerrit.instructure.com/35174
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
- run Canvas with LOLCALIZE=1
- go to Account Settings | Permissions
- ensure the following fields are localized:
- "Course Roles" and "Account Roles" tabs
- "Add Role" button (on both tabs)
- Contents of the dialog that appears when you press "Add Role"
(also on both tabs)
fixes CNVS-3118
Change-Id: Ie53ec232df0737149597ae23fe566d9efa241035
Reviewed-on: https://gerrit.instructure.com/34958
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* should be able to create and edit external url module items
with an option to require the urls to be opened in a new tab
* on the modules index page, clicking on these items should
directly link to the url in a new window, but also redirect
the open canvas page to the module item page (so to register
progression, and show the sequence footer)
* navigation through the sequence footer should be unaffected
* should work with draft state enabled and disabled
fixes #CNVS-12579
Change-Id: Ic0b33014acd43f72b05258705a87221c4b8d61c3
Reviewed-on: https://gerrit.instructure.com/35123
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-11833
test plan
- regression test teacher view of groups page
a group can only have one group leader, and that user must be in
the group. anything that can be done to remove a user from a
group should revoke their leadership if they have it. a user's
leadership should not be revoked unless the teacher revokes it,
a different leader is chosen, or that user leaves the group. a
leader's user should have a user icon on it and their name should
appear next to the group's name
a few test cases:
- set group leader using gear menu on user in group
- revoke the leadership of the user using the gear menu
- ensure that the group is now leaderless
- set a group leader
- set a different user as leader
- ensure that a screenreader identifies the group leader link as "Group
Leader"
- ensure that the first user is no longer the leader
- set a group leader
- remove that user from the group by dragging and dropping
- ensure that the user is no longer the group leader
- set a group leader
- move the user to another group using the option on the gear
menu
- ensure that the user is not the leader of their original or new
group
- in a large-roster course, add users to a group user the plus
button next to the gear menu
- set a group leader using the gear menu next to a user
- fill a group up to it's maximum limit of students
- ensure that the "full" label shows up for that group
- ensure that when you narrow the browser size, you can
still tell that the group is full
Change-Id: I8bb1b62e0f36a37a24e050878c945f822fe9f66c
Reviewed-on: https://gerrit.instructure.com/34360
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-12336
Test Plan:
- As a teacher create a course with an assignment of each online
submission type
- Log in as a student and submit each assignment
- Select the student grade book
- The icons should be updated to match the style guide
- As a teacher grade some of the assignments
- As the student refresh the grades page (this requires a server
restart if done locally because of CNVS-12995)
- The grades should still be displayed correctly (we're checking
this because there were significant refactors of this display)
Change-Id: I7aa61643eae86a98b735a18414d9f3a58eddde62
Reviewed-on: https://gerrit.instructure.com/34817
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
closes PS-1484
test plan:
1. go to calendar2
2. create a new calendar event
3. you should now be able to add location name
4. if you click more options you should be able to
edit locaiton name and location address
5. should save successfully
6. should be able to view and edit the event with
the new location stuff
7. this change does not touch the show page
of the calendar event. If you create an
event and click it from the calendar
and click the title no location data
has been displayed there.
8. the location data should also show
up in the calendar feed as well
Change-Id: I28452f18345d2bc9cdc56188f409e13c0a85892a
Reviewed-on: https://gerrit.instructure.com/34411
Reviewed-by: Dave Jungst <dave@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Jake Sorce <jake@instructure.com>
QA-Review: Jake Sorce <jake@instructure.com>
test plan:
- have a module that does not require sequential progress
- have an assignment in the module whose "available from" date
is in the future
- have other items before and after it in the sequence
- as a student, try to navigate the module sequence from
the item before, to the locked assignment, to the item
afterward
- the module sequence footer (next and prev buttons) should
still appear and function on the locked assignment page
fixes CNVS-12898
Change-Id: I9bdd5ecac19852086009294d73b1d2302039f68e
Reviewed-on: https://gerrit.instructure.com/35143
Reviewed-by: Mark Severson <markse@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-4734
test plan:
* in gradebook 2
* change a grade in the gradebook cell
* click the submission comments dialog box for a submission
* for a graded submission: verify that it is displayed in the grading box
* for an ungraded submission: verify that the grading box is empty
* change the grade (for all grading types) and hit 'Update Grade'
* verify that the grade is updated in the cell
* verify that the assignment group grades are recalculated
* verify that all members of a group have their grades updated for group assignments
* verify that the set default grades dialog works correctly for all grading types
Change-Id: Id6d117c9f126136a358f975604e973fe1ad36bb1
Reviewed-on: https://gerrit.instructure.com/32960
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Liz Abinante <labinante@instructure.com>
the 'Quizzes::' prefix broke the CSS selectors. this commit
removes namespaces from the item class
test plan:
- have a quiz in multiple modules
- edit the module item to rename the quiz
- the name should update in both modules without reloading the page
- also do a sanity check on adding and renaming other item types
fixes CNVS-13083
Change-Id: I7e32c3b90c6e516770a7307090448d621823af17
Reviewed-on: https://gerrit.instructure.com/35022
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes CNVS-10395
This provides the ability to set the timezone
at the course level in the Course Details
area of the Settings tab. If there
is no time_zone set, it defaults to the
default_time_zone of the root account. For
this ticket, this value is used nowhere, it just
allows it to happen (and tests are added to
verify that it does happen). Permissions
are currently granted in tandem with
the ability to rename a course. If you can rename
it, you can set the timezone. Making
use of this new value throughout the rest of
the application is taken care of in: CNVS-9814
TEST PLAN
1) Log into a course as an instructor.
2) Click on the settings tab. You should see
the timezone for the associated root account
(if the course timezone won't be set yet).
3) Edit the course to change the timezone and save.
4) the timezone should now be the one selected.
Change-Id: I50e1ed1da283689511795bf018adaa021f42d6f5
Reviewed-on: https://gerrit.instructure.com/34779
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Drew Bowman <dbowman@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
test plan (with draft state enabled):
* navigate to the course home page
- the button should now read 'Choose Home Page'
* click the 'Choose Home Page' button
- the dialog title should read 'Choose Home Page'
* confirming the dialog should correctly change the home page
fixes CNVS-12128
Change-Id: Ic1088ad1335c1288f4a5a9721bdb62c6c95f5ad6
Reviewed-on: https://gerrit.instructure.com/34738
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
Ryan Taylor
