closes CNVS-18151
test plan:
* setup MGP
- navigate to a student's grade page
> there should be a dropdown to the left of the 'print' button at the top
> the dropdown should say the current grading period
> the page should only show assignments/grades from the current grading period
- choose a different grading period
> the page should refresh
> the dropdown should show the grading period you chose
> only assignments/grades from that grading period should show
- choose "All Grading Periods"
> it should refresh and show all assignments
Change-Id: I56e1386dff928c16b40c9dcf5d5fe991e69fe4b7
Reviewed-on: https://gerrit.instructure.com/48704
Product-Review: Cameron Sutter <csutter@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
fixes CNVS-18175
Test plan:
- make an ungraded survey
- edit the survey
- it should work
- edit a regular quiz
- the post_to_sis box should work
Change-Id: Ieb6f977876cd8f5e27147e5b62b6c7a8b299d653
Reviewed-on: https://gerrit.instructure.com/47774
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes CNVS-18308
test plan:
- go to a course, and create a new announcement
- on the creation page, there should not be a publish icon
- save the announcement
- on the show page, there should not be a disabled publish button
- publish icon/button should still be present and work for discussions
Change-Id: I3ae7fe3dbb91ed3559ab6e9590dcbc7453602d8b
Reviewed-on: https://gerrit.instructure.com/48589
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* create a course with differentiated assignments enabled
* create a module and an assignment item
* give the course a term from the past so teachers have
read-only access
* enroll a teacher
* as the teacher, view the modules page
* should be able to see the assignment item
closes #CNVS-17938
Change-Id: I5b988dd84ff8c69daed8e413bdc27c90372fe5e8
Reviewed-on: https://gerrit.instructure.com/48790
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
test plan:
* modules should still do their thing
closes #CNVS-18560
Change-Id: Icfc885b9cf13884a1ff4d6914de253007717d7b6
Reviewed-on: https://gerrit.instructure.com/48788
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
this commit does three things:
* runs a data migration to delete duplicate external feeds. duplicates
are defined as having the same context, url, verbosity, and header match
* prevents duplicates from being created on course copy, by searching
for and re-using an existing feed if it exists when importing
* validating uniqueness of newly created/saved external feeds, and
exposing validation errors in the UI
fixes CNVS-17523
test plan:
- before downloading this commit, create two courses, go to the
announcments pages, and create several different external feeds, some
of which only duplicate the url (but have differences for other values)
and some of which are exact duplicates
- checkout this patchset, run migrations
- those courses should now only have unique feeds (the full duplicates
will be deleted)
- now try creating a new full duplicate
- you should get an error message that says "taken" on the url field
- try importing the feeds from a course with a feed into another course
that has the exact same external feed
- it should succeed, but not create a duplicate feed in the second course
Change-Id: If1655283102a74626c4579c24382cde92115e776
Reviewed-on: https://gerrit.instructure.com/45991
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-18317
test plan:
- create an account admin, and a course
- enroll the account admin as a student in the course, along with other
normal students
- create a peer review assignment
- submit as the admin, student A and student B
- assign both the admin and student A to peer review student B
- complete the peer review as student A first
- then complete the peer review as the admin
- it should work
Change-Id: Id89ca9fd06e0e113156083d3bec031bd64fb394e
Reviewed-on: https://gerrit.instructure.com/48387
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* create a course with self-enrollment enabled
* log out and visit the page to self-enroll
* enroll in the course
* log out again and visit the page to self-enroll
* log-in again and try to re-enroll
* the page should not be stuck spinning and instead
redirect you to a page notifying you that
you're already enrolled
closes #CNVS-14910
Change-Id: Id434b9da1b81ebb8f248a6a4c45a590d2b6f3783
Reviewed-on: https://gerrit.instructure.com/48678
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* visit the "Import Content" page for a course
* select the "Copy a Canvas Course" type from the
drop-down
* should receive a warning icon with a popover explanation
when trying to copy the current course into itself
closes #CNVS-14642
Change-Id: Ieb50e156146af03365f4b283b7d6d2bbe183ef9d
Reviewed-on: https://gerrit.instructure.com/48533
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
correctly
fixes PFS-1035
Test Plan:
1) Add an e-portfolio to your page and copy and past the Rich Text table from this page (https://alamo.beta.instructure.com/eportfolios/10508/Teaching)
2) click "Download the contents of this ePortfolio as a zip file".
3) Verify that the table is rendered properly.
4) Try with some HTML and various text to confirm behavior is as exptected.
Change-Id: Ia9eb7b03d00090c639499ce5a03ddab5ae848476
Reviewed-on: https://gerrit.instructure.com/48373
Reviewed-by: Sean Mikkelsen <smikkelsen@instructure.com>
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Cody Tanner <ctanner@instructure.com>
Product-Review: Cody Tanner <ctanner@instructure.com>
QA-Review: Cody Tanner <ctanner@instructure.com>
Tested-by: Cody Tanner <ctanner@instructure.com>
fixes CNVS-8924
test plan:
- go to the discussion index page
- click a discussion cog and choose 'Close for comments'
- click the cog again
- the wording should now be 'Open for comments'
Change-Id: I0d4bfb76c0576629329934c1e70ad87502ed6ec3
Reviewed-on: https://gerrit.instructure.com/48399
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-13753
There were a few instances of hardcoded content reading "Speedgrader" instead
of "SpeedGrader." This commit replaces those instances.
Change-Id: I6e8ecf8320cd12da49fd00b89f8f7815af20da7a
Reviewed-on: https://gerrit.instructure.com/48523
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
Google Drive OAuth 2 works
Test Plan
- Setup a google dev account with drive api access
- Enable Google drive plugin
- In user setting add google drive
fixes PLAT-887
Change-Id: Ib174d4233c284e4bb61eea5c9b4cbc09e2a9fab9
Reviewed-on: https://gerrit.instructure.com/48220
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Reviewed-by: Brayden Lopez <blopez@instructure.com>
replace Bootstrap styles with non-broken Canvas Style Guide
test plan:
- in Account Settings, confirm the "Find a Course" and
"Find a User" boxes (comprising the edit field and the
"Go" button) operate, and are the correct width
(look on Setting, Sub-Accounts, Courses, and Users tabs)
fixes CNVS-18377
Change-Id: I348180e196d5bcdb4d9fd5758efacaf8ae807650
Reviewed-on: https://gerrit.instructure.com/48592
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Turns off student accessibly QLA records
Test plan:
- Confirm no student access
- Confirm teacher access
Change-Id: Idca90b00b966acea3c63ea0dd105e6c0bfbd3ceb
Reviewed-on: https://gerrit.instructure.com/48600
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Taylor <rtaylor@instructure.com>
test plan:
- have a course with an assignment due in the future,
and a student enrolled
- set the home page to a wiki page
- as the student, view the course home page. the right sidebar
should have a "Coming Up" section showing the upcoming assignment.
fixes CNVS-18405
Change-Id: Ie7f050c3c5b324583cffafd83a7a4e08a47cc8e3
Reviewed-on: https://gerrit.instructure.com/48544
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
test plan:
* create a custom course role
* add people with that role into a course
* deactivate the role
* visit the course settings
* the user counts on the right-hand sidebar
should signify that the role is inactive
refs #CNVS-18343
Change-Id: I774be6a401cc1bd8745d96f958ac748a3cc39bdd
Reviewed-on: https://gerrit.instructure.com/48534
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a custom course role
* delete it
* create another custom course role with the exact same name
* invite people into a course with that role
* should be able to select the role from the drop-down on the
people page and find people
refs #CNVS-18343
Change-Id: I7f62d76984af1d92179d3541b03e41801c53327c
Reviewed-on: https://gerrit.instructure.com/48486
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
fixes: CNVS-18444
this just put whether they are k12 as part of the
cache key so we don't have to wait 15 minutes for
cache to clear.
test plan:
turn on k12 in account settings
reload
it should have blue k12 header
turn k12 off
reload
you should not have to wait 15 minutes to go
back to looking "normal" (not k12)
Change-Id: Ie7030d6df3c4cbab1d08c74d5883f54d90461e28
Reviewed-on: https://gerrit.instructure.com/48492
Reviewed-by: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes CNVS-14714
Test plan:
- Visit a discussion with replies (both threaded and not).
- With a screen reader, verify that the reply buttons specify whether
they reply to the main discussion post, or to a comment.
Change-Id: If262dcc5726bf7cf9ea9ff4cf4b599da60def399
Reviewed-on: https://gerrit.instructure.com/48006
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
closes: CNVS-17088 CNVS-17586
test plan:
* go to /accounts/{root account id}/settings
* set stuff for these guys: http://cl.ly/image/2W3h3m2F1F1X
* completely clear browser cache and restart browser
* go to any page, the favicon should be the new one you set.
* add a shortcut to your android and iOS home screen
* it should use the apple-touch-icon.png you uploaded
* in windows 8 using IE 11+, bookmark the page as
one of your windows tiles.
* it should use the image/settings you set.
Change-Id: Ia5c5a374d8e221145ef3469750f5304a00aa5259
Reviewed-on: https://gerrit.instructure.com/46929
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-18159
test plan:
- go to the announcement index page
- the '+ announcement' button should read as 'add announcement' and as
a button for screenreaders
Change-Id: I6010ee90c9363988f9629e738512f29a31c7f566
Reviewed-on: https://gerrit.instructure.com/48288
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes CNVS-13138
Test plan:
- Log in as a student.
- Using a screen reader, verify that the "show by" radio buttons have labels
that say "show by date" and "show by type", and not simply "date" or "type".
Change-Id: I615b0e10eede1cbf4d00274d1ff5c74ffb5ea3e7
Reviewed-on: https://gerrit.instructure.com/48153
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-18208
test plan:
- for each supported screenreader
- go to the assignment index
- using the headings finder, you can jump
to each assignment group title
- using a screenreader click you can toggle
the assignments to show/hide
- stylistically the group names are the
same as before
- note: ideally they would say "button" not "link"
but they dont
Change-Id: I92c23e79f32e1c0cbb57c430197b1e376f38318f
Reviewed-on: https://gerrit.instructure.com/48246
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-18389
This commit adds an 'average' scoring policy to quizzes. You can
now choose to keep the average score of all attempts of a quiz.
Test plan
- Create a quiz with multiple attempts, and an 'average' scoring policy
- Take the quiz multiple times, choosing different answers for different
scores per attempt.
- The kept score should be the average of all attempts scores.
Change-Id: I1d3c6a9072188af338611f340a0963108cba148e
Reviewed-on: https://gerrit.instructure.com/48353
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes: PLAT-810
test-plan:
open an lti modal from the tinymce editor
you should be able to tab around in the iframe
see PLAT-810 for more info
Change-Id: I7c1d92e1f276b556d3dddbb4c72937b0f2d44001
Reviewed-on: https://gerrit.instructure.com/48094
Reviewed-by: Brad Humphrey <brad@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-17102
test plan:
* turn on the MGP account feature flag
* create 2 grading periods
* one that is currently going on
* one that is in the past
* create assignments with due dates in both grading periods
- navigate to gb
> it should only show assignments from the current grading period
> there should be a dropdown next to the Section drop down
which allows you to select a grading period
> it should say the title of your current grading period
- select different grading periods from the dropdown
> it should refresh the page and load only the assignments from that
grading period
> the dropdown should show the correct grading period
> when the page is refreshed, the same grading period should persist
between page refreshes
- select All Grading Periods
> it should refresh and load all assignments
Change-Id: I41e3ec150cded551ad3ee9ecd20bf8fc6740f454
Reviewed-on: https://gerrit.instructure.com/46716
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes CNVS-15964
This adds the blue help icon next to HTML Editor text on essay questions.
Test Plan
As a user that can take a quiz
When you go the a quizzes take page with an essay question
Then you should see the tinymce editor above the essay question
And there should be a blue help icon next to "HTML Editor"
And clicking on it should show the keyboard shortcuts help menu
Change-Id: Ic91acecec25f4347e7c961e1c77cea77857a5ff4
Reviewed-on: https://gerrit.instructure.com/47737
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins
Product-Review: Hilary Scharton <hilary@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
The Save it Now button which is visible when quiz questions have been
modified but the quiz hasn't been saved will now actually save the
changes.
Closes CNVS-18063
Test-Plan:
- Alter a quiz by adding a question
- Visit the quiz show page "/course/id/quizzes/id" and see the button
- Click the button
- Confirm:
- Refresh the page, no button in sight is good.
- Preview the quiz and confirm the question edits stuck.
Change-Id: I1112da5dc596e31bdcc505b351f4856dc0253ad7
Reviewed-on: https://gerrit.instructure.com/48098
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
On moderate page refresh, only the very most recent edit was shown in
the AJAX updates. This adds a few minute buffer which should eliminate
most of the "I edited a batch and only see one thing edited" problem.
Closes CNVS-16804
Test Plan:
- Edit multiple students attempt count on a moderate page
- Confirm that all of the students are shown that change.
Change-Id: Ia462d6e0f538985e692b7ae46d9ba0e5b3e8c5f8
Reviewed-on: https://gerrit.instructure.com/47986
Reviewed-by: Derek Bender <dbender@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Fixes CNVS-16056
Test plan
- create a graded survey with a custom possible points
- take the survey as a student
- leave a comment on a question in the survey as the teacher
- the survey should still have recieved full points
Change-Id: Id5a0513584c2991a3ece15506268936f7b1c33c3
Reviewed-on: https://gerrit.instructure.com/47977
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
fixes CNVS-18309
test plan:
- Navigate to a course section
- Verify after clicking on the "Back to Course Settings" button
you are taken to the proper endpoint /settings instead of the blank
view /details like prior behavior
Change-Id: I654cd56fd10f42efea7863754c9449c15e6ce493
Reviewed-on: https://gerrit.instructure.com/48105
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: August Thornton <august@instructure.com>
fixes CNVS-18234
When editing a wiki page, the little help icon next to "HTML Editor"
was absolute positioned and didn't move with the text when a longer
sentence was introduced. This commmit fixes that
Test Case
Given I'm a user than can create/edit a wiki page
And I'm editing a wiki page
When I click on "HTML Editor"
Then the "i" help icon text to the text should move text to "Rich
Content Editor"
And non of text should overlap the help icon
Change-Id: I345e44a223011cc6b04b5108375d4d1eed964a92
Reviewed-on: https://gerrit.instructure.com/48080
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
Bug Description: If a teacher marked a file in a course
as unpublished, the user could still access that file by
going to their legacy user files /files/:id (show) URL.
fixes CNVS-18256
Test Plan:
* Enable "Better File Browsing" Feature Flag
* Open two browser windows; one as a teacher
and one as a student in a course that the
teacher is enrolled in
* As the teacher, go to a course's Files page
* Select a file or upload a new one
* Make sure the file is unpublished
* Preview the file, then copy the number after
"?preview=" in the URL that's in the address bar
* Go to /files/THAT_NUMBER_THAT_YOU_JUST_COPIED
* You should see a preview of the file
* As the student, go to:
/files/THAT_NUMBER_THAT_YOU_JUST_COPIED
* You should see a message stating that the file
is locked
Change-Id: I85759ec4d1642effbfdc98131238338b25ba598d
Reviewed-on: https://gerrit.instructure.com/48020
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-17365
Test Plan:
* As a teacher create a course and several groups sets with several
groups in them
* As a student use the keyboard to navigate the groups tab in the People
section of the course you created
* Ensure that lock icons can be reached and that appropriate tootips are
provided when the lock receives focus
* Ensure that the expand/collapse arrow icon can be clicked with the
keyboard and that the list of group members is shown accordingly
* Ensure that when using a screen reader appropriate announcements are
made for each of the controls as you navigate the list of groups
* Ensure that when you focus the arrow icon that expands the group
member list it announces whether the list is expanded/collapsed
* Ensure as a student when on the People page that when the Groups
tab has focus it has a visible outline
* Ensure as student when on the Groups tab of the People page that the
Everyone tab has a visible outline when it has focus
Change-Id: I9246c5716a424979585d8e4cd4396bab138b093c
Reviewed-on: https://gerrit.instructure.com/47355
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Brayden Lopez <blopez@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
also don't allow default terms to be deleted
test plan:
* create a enrollment term, and keep the tab open
* add a course in another tab and add it to the enrollment term
* switch back to the enrollment terms tab and try to delete
the term
* should not actually delete it
* try to delete the term through SIS
* should not be deleted
* delete the course or remove it from the term
* should be able to delete the term now
closes #CNVS-18032
Change-Id: I54480f80259ba41348801de4bda9609060f40fc1
Reviewed-on: https://gerrit.instructure.com/47944
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
test plan:
* visit a course user profile page for a teacher/ta
( e.g. /courses/X/users/Y )
* click on the link next to "Privileges" to toggle
whether the teacher/ta can view all students in the course
or just their own section
(may have to click on "more user details to see)
* should not flash an error message on successful change
* repeat with profiles enabled on the root account
and with profiles disabled
closes #CNVS-12455
Change-Id: Ib0687b5c85142ab13fae83b6d98c8b1983215cc9
Reviewed-on: https://gerrit.instructure.com/47975
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Create a form to view grading periods, for
Accounts and Courses. This commit only
focuses on 'viewing' the grading periods;
other tickets will handle the creation,
deletion, and updating of grading periods.
closes CNVS-17842
test plan:
1. Set up data. Create a grading period group and a few grading
periods for a course using the rails console. For
example:
$ bundle exec rails console
$ course = Course.find(1) #grab any Course you want. here i'm getting
the course with ID 1
$ course.grading_period_groups.create!
$ course.grading_period_groups.first.grading_periods.
create!(title: "Course Grading Period 1",
start_date: Time.zone.now,
end_date: 30.days.from_now,
weight: 0.50)
$ course.grading_period_groups.first.grading_periods.
create!(title: "Course Grading Period 2",
start_date: 30.days.from_now,
end_date: 60.days.from_now,
weight: 0.50)
Next, add a few grading periods at the Account-level:
$ course.root_account.grading_period_groups.create!
$ course.root_account.grading_period_groups.first.
grading_periods.create!(title: "Account Grading Period 1",
start_date: Time.zone.now,
end_date: 30.days.from_now,
weight: 0.50)
$ course.grading_period_groups.first.grading_periods.
create!(title: "Account Grading Period 2",
start_date: 30.days.from_now,
end_date: 60.days.from_now,
weight: 0.50)
2. Turn on the multiple grading periods feature flag
3. Go to the grading_standards page for the course
'/courses/:course_id/grading_standards'.
Verify the page shows the two Course-level grading periods
you created (it will not show the Account-level
grading periods; this is being addressed in another ticket).
Note: the date-picker buttons, input fields,
update button, and delete icon will not be functional. Just check
to make sure you can _see_ the correct
information - you should not be able to update it.
4. Go to the grading_standards page for the account
'/accounts/:account_id/grading_standards'.
Verify the page shows the two Account-level grading periods
you created, and does NOT show the Course-level
grading periods that were created. Note: the date-picker buttons,
input fields, update button, and delete icon will not be
functional. Just check to make sure you can _see_ the correct
information - you should not be able to update it.
5. Ensure the pages are accessible-friendly, with appropriate
labels, navigation, etc. The datepicker icons
are not tabbable right now; this will be addressed with
the ticket that involves getting 'update' functionality
to work. Let me know if you have any questions!
Change-Id: I260bb6a870a0d56c1488823de67fd7d8522006cc
Reviewed-on: https://gerrit.instructure.com/47094
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
closes CNVS-17207
Test Plan:
- In Firefox, create a course with a super long
course title, greater than 100 characters
- Make a page in said course
- Make that page the Front Page
- Set the front page to be the course home page
- The buttons to edit the page should be shown
- The title should be ellipsized
- Check this behavior in other browsers as well
Change-Id: Ia794d3a05141646bc257b5a5062903d1ec132856
Reviewed-on: https://gerrit.instructure.com/47970
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes CNVS-17726
This block of code was removed as part of the pre-draft state cleanup,
but needs to be present to show that an announcement is delayed.
Test plan:
- Create an announcement, with a 'delay posting' date in the future.
- Verify the presence of the delayed posting message on the #show page.
Change-Id: I707e4a50e0d0a90f9a04380c35f6b1c8e452e3be
Reviewed-on: https://gerrit.instructure.com/47595
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
test plan:
* confirm that the permission to "View the answer matrix
in Quiz Submission Logs" is only visible when the
"Quiz Log Auditing" feature flag is allowed on the
account level
closes #CNVS-18192
Change-Id: Ibbd0a082af20e49ef5fd5471c22ce6c236fbfade
Reviewed-on: https://gerrit.instructure.com/47820
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
also remove some no-op code
test plan:
* create a new ta role
* disable their permission to "manage faculty journal entries"
* add them to a course
* they should not be able to see "faculty journal" buttons
on student profiles and be able to access their journal pages
closes #CNVS-9000
Change-Id: I35b1cef5a458c6dec68209e4aa964a64a51edd65
Reviewed-on: https://gerrit.instructure.com/47818
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixed the way nvda was reading the published icon from
reading it as a header to not reading it as a header.
fixes CNVS-13112
test plan:
- go to the assignment edit page as a teacher
and with nvda on
- press h and go through the headers
- notice that the published icon does not read
Change-Id: I00263d2c0ffb3ac86e786fc96b83e83a82518d66
Reviewed-on: https://gerrit.instructure.com/47773
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
closes: CNVS-16994
this worked before but it broke in
2cfd50d759
when we tried to get it to work in IE10
Test plan:
- Perform the following without and with a screen
reader, in IE10, IE11, firefox, safari, & chrome
- Navigate to the compose dialog in conversations.
- Using the keyboard, tab to the "Add Attachment" button.
- Using the keyboard, verify that an attachment can in fact be attached to
a message, and that message sent.
- Reverify the above in IE with Jaws, Firefox with NVDA, and Safari with VO.
Change-Id: Iad232a019fcb3102bb33def46e147b49d5b03b07
Reviewed-on: https://gerrit.instructure.com/46970
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
remove the account model methods, since these don't have
access to the request IP address, which is needed for
international terms of service.
test plan:
0. enable self-enrollment in account settings
1. enable self-enrollment in a course in the account
2. register a new user using the course's self-enrollment URL
3. terms of use and privacy policy links that appear on the
"require acceptance of terms" dialog should function
(and should not take the user to another "require
acceptance of terms" dialog)
4. create a new user via the Accounts page, then click the
link in the email sent to the user to complete the registration.
the terms of use/privacy policy links that appear in the dialog
should work (as in 3). (note that you can go to
/users/<id>/messages as an admin to see this email even if
outbound email is not configured in your portal.)
closes CNVS-18025
Change-Id: Ibf19d2892c587f9e251917f70448212aac0709ad
Reviewed-on: https://gerrit.instructure.com/47607
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
- fixes CNVS-2436
- In the SpeedGrader view scores are rounded to two points of precision,
and any trailing zeros are trimmed.
Test plan:
1. As a teacher, create a quiz with Multiple Answers.
2. Under the Multiple Answers question, create 4 answer options of which 3 could
be correct.
3. As a student, take the quiz. Answer only 1 of the 3 correct answer options,
submit the quiz.
4. As a teacher, view the attempt in speedgrader - notice ongoing decimals for
the question score. There should only be two numbers after the decimal.
Change-Id: Ic78dc6d99ab65adbd943c55816190b8183363f7c
Reviewed-on: https://gerrit.instructure.com/44378
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
ref CNVS-16922
This adds a whole new look and feel to our Styleguide!
QA Test Plan:
- Go to /styleguide
- See all the new look and feel!
- I should look similar to this: http://invis.io/CT1QH2OHX
(small changes have been made from static to digital guide, ux
is aware of those changes)
- Make sure all navigation items in subnav go their proper places
- See notes
Notes:
- This only affects /styleguide and does not touch any canvas
styles.
- This is purely aesthetic - no functionality had changed
- Right now all the sections are being loaded onto one page; we
know this and plan on making improvements to hide/show per top nav
item in future iterations
- There is a 1px border when you shift between sections on Firefox,
ux is ok with this.
- We are aware that sometimes the automatic scrolling seems "fast"
but will change that in a future iteration
Change-Id: I0ef10c78d3fccc83bb1923970d6fc884298b6775
Reviewed-on: https://gerrit.instructure.com/47716
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Derek Hansen <dhansen@instructure.com>
fixes CNVS-16171
fixes CNVS-16888
fixes CNVS-16843
This adds back-end style work to our tours to make them better.
1/14 - We have now taken out the Agenda Tour. This should no longer
popup.
Test Plan:
There used to be a notification popup when you log in to Canvas,
nothing should show up now to kickoff any tours.
Change-Id: Ic36d764f54c26d76de2af583cf4f0ef9364060a4
Reviewed-on: https://gerrit.instructure.com/43116
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes: CNVS-18040
Changes what fragments are being cached so the form for logout is not
being cached.
Test Plan:
- Login to Canvas
- Click the logout link in the navigation.
- Login to Canvas again.
- Click the logout link in the navigation again.
- Should not see a page asking if you are sure you want to logout.
Change-Id: I9e1a91a11fb074525b3b0227f87c1a0a1bc53663
Reviewed-on: https://gerrit.instructure.com/47491
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
Fixes: CNVS-18100
Addresses:
- Logo alignment issue. Canvas logo should now be
vertically centered.
- The need of Sales to see Commons logo in main nav.
We are aware this is not a perfect solution, but it
will help Sales with K-12 demos in the short term and
will not affect anything in the regular (non-K-12)
Canvas UI.
QA Test Plan:
Note: Due to Canvas' caching, you might have to wait
15 minutes to see these changes, if you're swithing
over to K-12 from the regular Canvas UI.
- Enable the K-12 UI feature flag.
- Enable Commons/LOR in your Settings (add it as an
App, if you haven't already).
- Confirm Commons is showing up in your main navigation,
complete with a Commons logo.
- Confirm the Canvas logo at the top left is now
vertically centered.
Change-Id: I90a9672e3e855e4c13055fbd8ddb6c80ea9dc226
Reviewed-on: https://gerrit.instructure.com/47681
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Cameron Sutter