there is one for draggable to get our WYSIWYG editor working
and another for escaping dialog titles.
Change-Id: I2030e8bf81e75802c489f488a0bde1ea3c930b32
Reviewed-on: https://gerrit.instructure.com/5801
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
As of jQuery 1.6, the .attr() method returns undefined
for attributes that have not been set
Change-Id: Ibc2301735bb038ee2f897dfc12049012211d1620
Reviewed-on: https://gerrit.instructure.com/5452
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Whenever we create a migration that drops or renames a column, in that
same commit we need to add that column to the list in this initializer.
Then, when we deploy and restart, AR will already see the column as
removed, and we can safely run the drop migration after deploy without
any window where users will get page errors due to stale column
information.
Change-Id: I1c95fd146ac8046af579256cccf95b42f01442b7
Reviewed-on: https://gerrit.instructure.com/5823
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
- New rake task `rake jst:compile` to precompile
JavaScript templates into functions.
Add handlebars templates to app/views/jst and
they'll get compiled to public/javascripts/jst
- New rake task `rake jasmine` and `jasmine:ci` to
run JavaScript specs.
Add specs to spec/coffeescripts and they'll get
compiled into spec/javascripts
- Added Guard gem `$ guard` that watches
coffeescript and handlebars files and compiles
them when changes are made.
- Created Handlebars Ruby class that precompiles
the templates into JavaScript functions
- Added JS Template constructor to abstract
our tempting API
Change-Id: Ie993d0fc50d49b161ed94dbc066c4475cefdc427
Reviewed-on: https://gerrit.instructure.com/5813
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
* Doesn't display enrollments with identical
created_at and updated_at fields (SIS garbage)
* Always displays "See all Courses" link with a
count of all current enrollments.
* No more duplicate links to /courses, i.e.
"... and 12 more" "See all enrollments"
* Displays 12 instead of 8
* Sorts alphabetically after sorting by
rank_sortable and state_sortable
* Moved the logic out of the view into the user
model and some helpers
Change-Id: Ibcd274cae8e192585ad77f1bad6e0b54da041c8b
Reviewed-on: https://gerrit.instructure.com/5822
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
enrollment restriction by end-date only prevents adding new submissions,
posts, etc. to the course; students can still access other read-only
aspects of the course.
fixes#5759
Change-Id: I41d0ac8d375471744e49082deb72476b1e2d9803
Reviewed-on: https://gerrit.instructure.com/5827
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
notable changes:
* nothing is processed as a sis-import blocking error now. bad imports now
result in warnings, while just skipping bad data
* we no longer check for duplicates before going to the database
Change-Id: Iedc96b29d92caccdc6a71ae1de8100a1c82dd137
Reviewed-on: https://gerrit.instructure.com/5724
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Message that displays when a filter matches no messages only
displays when there are no <li> elements in the $conversation_list
element. The ajax spinner is stored in an <li> though, so
this condition is never met.
Fix is to add a :not filter on the spinner <li>'s ID to the
test.
Change-Id: I97cd0d9a7e707117489be837d8e3c449e76db153
Reviewed-on: https://gerrit.instructure.com/5656
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Also had to change the export/importing of blti links
from canvas
refs #4153
Change-Id: Iae2d6e9c677d310d7e824fa78885c8aca2c1af83
Reviewed-on: https://gerrit.instructure.com/5703
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
This also fixed some problems with the web content
part of the importer and made the spec run the full
migration from a cc package
refs #4153
Change-Id: I1700043b578fe79586104cf13b260c78c3166194
Reviewed-on: https://gerrit.instructure.com/5702
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
This will allow a UI where the user doesn't need to identify
the type of package they're uploading. For now it's only used
for common cartridge/canvas cartridge packages.
refs #4153
Change-Id: I2488777316660c9af60f544884429de7355f358f
Reviewed-on: https://gerrit.instructure.com/5701
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
you only need one of the following:
Student Name, ID, SIS User ID, SIS Login ID
per row in the gradebook csv uploads
fixes: #5725
Change-Id: Ic5785d14b146d68603654beba122ca1f73cd9c1e
Reviewed-on: https://gerrit.instructure.com/5771
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Stop storing recent messages in conversation stream, as streams
don't exist on user level and so can't reflect user differences
in deleted messages.
Change-Id: I4750f7c58bf80e9f06060eb089fe83cfc5668d2b
Reviewed-on: https://gerrit.instructure.com/5646
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
(note that this is the only place that assert_by_email is used)
Change-Id: I5ed8985a5a84940e50b403b3753f9102bad23164
Reviewed-on: https://gerrit.instructure.com/5772
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
A slight change was made during code review and the doc was not
updated to reflect the change.
Change-Id: Iebb71b672296487677063aa28c81e865e69d1ade
Reviewed-on: https://gerrit.instructure.com/5744
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Firefox sends 191 for / like it should until the
shift key is pressed, then it sends 0. Mapped
0 to 191 (will cause < and > and perhaps some
other keys to also pull up the dialog. Same
behavior can be found on github).
Change-Id: I1759132f2b628dc40f15f5d1b778b7769d6446e4
Reviewed-on: https://gerrit.instructure.com/5722
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
now properly fills in saved user answers for multiple fill
in the blank questions when the user closes and re-opens
the browser.
Change-Id: I48d41f4cd2564feef9e99449132c45f72c425d06
Reviewed-on: https://gerrit.instructure.com/5654
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
Cody Cutrer