just like we hide inactive enrollments from the "Courses" menu, also
hide groups from courses that don't have an active enrollments in the
groups portion of the "Courses & Groups" variation of the menu
fixes#5797
Change-Id: I91a9fd742b04faab5d97793b6baa17409a4f043a
Reviewed-on: https://gerrit.instructure.com/5901
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
use src from <content> element to download, instead of constructing our
own url (fragile!). also, use https instead of http.
Change-Id: I9e2ca48558b63522bc730309d64411208ad92f9c
Reviewed-on: https://gerrit.instructure.com/5922
Reviewed-by: Zach Wily <zach@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Jacob Fugal <jacob@instructure.com>
NOTE: a previous commit tried to do this, but it
broke specs, so it was reverted
this was to introduce sanity where we don't have
one file with ~3600 lines of javascript:
* if something looked like it was worthy of its own
plugin file, or should have been one in the first
place, it got it. (ex: jquery.keycodes.js)
* if there were a bunch of methods that obviously
belong together, I put them all together in their
own file (ex: jquery.instructure_forms.js)
* all of our monkeypatching of jQuery went into one
file so it is easier to see where that is happening
when we choose to upgrade.
* move the remaining jQuery helpers (things like $.blah)
into jquery.instructure_misc_helpers.js
* move remaining jQuery plugins (things like $.fn.blah)
into jquery.instructure_misc_plugins.js
Change-Id: I2978c79299ec8b73e5e14d941c20ffe35c4bba99
Reviewed-on: https://gerrit.instructure.com/5862
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Bryan Madsen <bryan@instructure.com>
was receiving an error, "can't dup nil class," because
view was expecting @stored_params, which only exists while
a user is taking the quiz.
Change-Id: Ifd4c06adf562b8fabe1536cb8a0eff655c4961d6
Reviewed-on: https://gerrit.instructure.com/5897
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
now we can have things like
app/coffeescripts/lib/myWidget.cofffee
(also changed to regex watch pattern to get rid
of deprecation warning)
Change-Id: Ia6561dcb57215b2b1b405bcd64c43d7fd2ded85d
Reviewed-on: https://gerrit.instructure.com/5894
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
optimizing query: SELECT * FROM `discussion_topics` WHERE (`discussion_topics`.assignment_id = xxx AND (discussion_topics.root_topic_id IS NULL)) ORDER BY created_at LIMIT 1
Change-Id: Id2f461021ae33f1466f2eee8ec66673fefb49ba7
Reviewed-on: https://gerrit.instructure.com/5895
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Thanks to Gabe O'Brien for the initial patch
Change-Id: I0b589e9cceb531607b8609d71f6da3687829a116
Reviewed-on: https://gerrit.instructure.com/5883
Reviewed-by: Zach Wily <zach@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
they were just white, that was a mistake.
the new theme has them looking exactly like the
new styles we are working on but this will get
them looking right now.
Change-Id: I115b84351d8afe44bfdf17e1a3758ba9e4d129e5
Reviewed-on: https://gerrit.instructure.com/5850
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
so that memory_store can be used in development
Change-Id: Iaa3badc732b32c0f6970a969b172aa76190e08f7
Reviewed-on: https://gerrit.instructure.com/5882
Reviewed-by: JT Olds <jt@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Conversation actions links are now selected properly in the tab
order. Because moving #conversation_actions inline caused problems
re: overflow and stacking, the tab order is manipulated by JS
instead of DOM order.
Change-Id: I76050763be9e915998dbe23dcbbfa935e1ca3d08
Reviewed-on: https://gerrit.instructure.com/5644
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
this should be in the next jquery release. applied the fix from
2931fa875f
Change-Id: Ie3aa32fc829c5486bae3507ddeae02a6bfc461be
Reviewed-on: https://gerrit.instructure.com/5871
Reviewed-by: Jon Jensen <jon@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
some plugins might change how authlogic works, but we'll still be
able to find the Pseudonym itself
Change-Id: Ib88d583a124d47249555cae12610684c3abecc69
Reviewed-on: https://gerrit.instructure.com/5863
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
wrap Assignment#group_category and Group#category accessors as
Assignment#group_category_name and Group#group_category_name accessors,
respectively, in order to make naming consistent and free up the field
"group_category" for a new association.
Change-Id: Ieb926088d96ebb8b46f70768a77b82fa1dcc8817
Reviewed-on: https://gerrit.instructure.com/5761
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
This problem was hidden in 1.8 because Array#to_s is an alias for
Array#join , but manifests itself in 1.9 where it aliases Array#inspect
Change-Id: I118696cdc129f71f31997ad852d8d7c6d3ad0fc9
Reviewed-on: https://gerrit.instructure.com/5842
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
in ruby 1.9, the load path doesn't include the current working directory
Change-Id: Ib61070da970af462dd58885477f97e83fe77b36f
Reviewed-on: https://gerrit.instructure.com/5841
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
this matches the expected behavior of all the plugin lambda blocks,
which is that no args will be passed in
Change-Id: I60cfc3dd411d6e7b0655c8ba7307f524c9601930
Reviewed-on: https://gerrit.instructure.com/5839
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
starting in 1.9.x, the number of args passed to a lambda is enforced --
procs still allow variable number of args
Change-Id: Id1a4338d10b87b870cd53989ea17ea422d848278
Reviewed-on: https://gerrit.instructure.com/5834
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
it was returning an array, which was being implicitly joined with #to_s.
but in 1.9, Array#to_s is an alias for Array#inspect, rather than
Array#join
Change-Id: I63f4f64b56b2edab9e5225f118716b9f6ee29d1b
Reviewed-on: https://gerrit.instructure.com/5836
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
these are syntax errors in 1.9.x
Change-Id: I7cbd66643cb371e4be9f8da0365bf1e988ee5de8
Reviewed-on: https://gerrit.instructure.com/5833
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
this was to introduce sanity where we don't have
one file with ~3600 lines of javascript:
* if something looked like it was worthy of its own
plugin file, or should have been one in the first
place, it got it. (ex: jquery.keycodes.js)
* if there were a bunch of methods that obviously
belong together, I put them all together in their
own file (ex: jquery.instructure_forms.js)
* all of our monkeypatching of jQuery went into one
file so it is easier to see where that is happening
when we choose to upgrade.
* move the remaining jQuery helpers (things like $.blah)
into jquery.instructure_misc_helpers.js
* move remaining jQuery plugins (things like $.fn.blah)
into jquery.instructure_misc_plugins.js
Change-Id: I7ef9b39de424bb187665cacb6a96a8f869dc9994
Reviewed-on: https://gerrit.instructure.com/5524
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
JT Olds