Pat Renner
|
e846eaec57
|
remove account_id from outcome_proficiency model
closes OUT-3760
flag=none
test-plan:
- Run migrations
- Ensure outcome proficiencies cannot be made
without defining context (or context_type/id)
> rating1 = OutcomeProficiencyRating.new(
description: 'best', points: 10, mastery: true, color: '00ff00')
> rating2 = OutcomeProficiencyRating.new(
description: 'worst', points: 0, mastery: false, color: 'ff0000')
> OutcomeProficiency.create!(
outcome_proficiency_ratings: [rating1, rating2])
- Should pass with provided context
(may need to delete current proficiency ratings for Account.first)
> OutcomeProficiency.create!(
outcome_proficiency_ratings: [rating1, rating2], context: Account.first)
Change-Id: I67ea2237641e02e3339dbb7c468f9e91381422b2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242532
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Brian Watson <bwatson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Pat Renner <prenner@instructure.com>
|
2020-08-06 15:11:15 +00:00 |