Commit Graph

3 Commits

Author SHA1 Message Date
Cody Cutrer 809904d8b6 add frozen_string_literal comment to migrations
Change-Id: Idf4ddb29567c1dfab9f01b09c7a1056367ae7b44
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261814
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2021-03-30 18:14:36 +00:00
Augusto Callejas 26c29259fe Backfill values without using a job
closes OUT-2178

test plan:
  - run on your test environment and confirm no migration errors:
    * docker-compose run --rm web bundle exec rake db:drop RAILS_ENV=test
    * docker-compose run --rm web bundle exec rake db:create RAILS_ENV=test
    * docker-compose run --rm web bundle exec rake db:migrate RAILS_ENV=test

Change-Id: I08ae607ae0c6ad48a7990a56dce2e0041c229c30
Reviewed-on: https://gerrit.instructure.com/151889
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Frank Murphy <fmurphy@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
2018-06-01 22:07:36 +00:00
Augusto Callejas 798e2a0700 Propagate hide points/results
closes OUT-2138

test plan:
  - create a course level outcome
  - in the course, create an assignment with
    a rubric containing the outcome as a criterion
  - in the rails console, set the hide attributes on the
    rubric association:
    > RubricAssociation.last.update(hide_points: true,
      hide_outcome_results: true)
  - as a student, submit to the assignment
  - as a teacher, grade the assignment in speedgrader, giving
    points to the outcome in the rubrics
  - in the rails console, confirm the attribute values were
    propagated (all should be `true`):
    > RubricAssessment.last.hide_points
    > LearningOutcomeResult.last.hide_points
    > LearningOutcomeResult.last.hidden

Change-Id: If3bd30a22973fdb7a6b4bdea171f050a4a7bdeab
Reviewed-on: https://gerrit.instructure.com/147699
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Tested-by: Jenkins
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
2018-04-24 20:41:05 +00:00