this also means we don't have to spend any time cleaning up old ones either
Change-Id: If7af1c3bfe8a274614571a4fc5df641d4cb9a654
Reviewed-on: https://gerrit.instructure.com/121147
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
This removes what is believed to be completely dead code.
test plan:
* ensure Jenkins passes
Change-Id: I5d540588dea3b9ea11b176b46c9abba10d8bb1b7
Reviewed-on: https://gerrit.instructure.com/121144
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CNVS-38281
test plan
- upload diffing file
- upload empty diffing file with just headers
- it should diff the files
Change-Id: I5d9c5dbf04c37e485de408ca038ba524461d0afe
Reviewed-on: https://gerrit.instructure.com/119610
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes CNVS-38231
test plan
- delete an admin
- admin should be gone from every where
- admin should not have permissions to do stuff
Change-Id: I56c90a12b2be879c5d646c1ab6980693ff161673
Reviewed-on: https://gerrit.instructure.com/119220
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Updates docker-compose.yml to use redis:alpine, which is the same
version we use to run tests on jenkins. Our lua scripts don't seem to
work with redis 2.6.
Change-Id: I608d7bbea9e813a5fb31f0c32b8fdf5ba127f16d
Reviewed-on: https://gerrit.instructure.com/121058
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Now:
irb(main):001:0> Canvas::Security.config
=> {"encryption_key"=>"<%= ENV[\"ENCRYPTION_KEY\"] %>"}
With this fix:
irb(main):001:0> Canvas::Security.config
=> {"encryption_key"=>"facdd3a131ddd8988b14f6e4e01039c93cfa0160"}
Test plan:
- Apply this patch over a fresh clone of the canvas-lms repo
- Run `docker-compose run --rm web bundle exec rails console`
- Run `Canvas::Security.config['encryption_key']`
- Check that the result is `facdd3a131ddd8988b14f6e4e01039c93cfa0160`
Change-Id: Ieba33697900cb4c539aa204d0c0dd14ad8baa896
Reviewed-on: https://gerrit.instructure.com/121036
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
closes CNVS-36350
Widens the permissions for for_course and
for_course_and_other_parameters so that teachers can use the endpoint
as well.
Test Plan
1. Create a grade change for a student, as a teacher.
2. Note the id of the student, the id of the teacher, and the id
of the assignment.
3. Navigate to CANVAS.URL/api/v1/audit/grade_change/courses/COURSE_ID
as a teacher. Use the course id from step 1. If you get a
successful response, good. If you get a 401 or 404 response, bad.
4. Navigate to CANVAS.URL/api/v1/audit/grade_change/courses/COURSE_ID/
assignments/ASSIGNMENT_ID/students/STUDENT_ID/graders/GRADER_ID
using the course id, assignment id, student id, and grader id
from step 1.
5. If you get a successful response, good. If you get a 401 or 404
response, bad.
Change-Id: I38a3288fc517a574ff22607c88d94e6d9009a24f
Reviewed-on: https://gerrit.instructure.com/119435
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CNVS-38028
fixes CNVS-38029
test plan:
- enable the notification service
- enable MFA via text message but set Setting.set('mfa_via_sms', 'false')
- try to log in
- you should get an MFA text
Change-Id: I1848bf666a51a771619de8f538bed5b39d38a262
Reviewed-on: https://gerrit.instructure.com/119695
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes: CNVS-38400
Test plan:
[your Canvas instance]/styleguide#forms
- Radio button :focus state should look like:
https://www.screencast.com/t/LkhrTWyPMkk
- Checkbox :focus state should look like:
https://www.screencast.com/t/CIzQakkac
Change-Id: I9b04019cdec529e307e195b5b4e1da5d52740b37
Reviewed-on: https://gerrit.instructure.com/121012
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
test plan:
- enable International SMS feature in the root account
associated with a user's login
- on the account settings page, click "+ contact method",
select the SMS tab, and ensure "Iceland (+354)" appears
in the country list dropdown
closes CNVS-34699
Change-Id: I71b771500814d3db84910264452039263c2990ae
Reviewed-on: https://gerrit.instructure.com/119974
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- create a discussion topic via the modules page
- it should not be graded
- regression test SIS-2854
fixes CNVS-38297
Change-Id: I2f89d50387aba494712573bdd388fde7df8a0b46
Reviewed-on: https://gerrit.instructure.com/119944
Reviewed-by: Nick Houle <nhoule@instructure.com>
Tested-by: Jenkins
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: I2f4ca4a671a0e5bdcfbeb90b4714465ec34acc9f
Reviewed-on: https://gerrit.instructure.com/120891
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes CNVS-38056
test plan:
* Create a course with a late policy, multiple students, and one
assignment which is to be graded using points
* Ensure the assignment is late for some students but not for
others
* Ensure the late policy deducts a reasonable number of points
for every day the students are late
* Submit the assignment from all students
* Grade the assignment for all students and verify that the late
policy is taking effect as expected
* Now alter the assignment so it is graded using pass / fail
or complete / incomplete
* Go back to the gradebook and verify that when you grade
students this time, no late deductions are applied
* Now alter the assignment so it is considered a "not graded"
assignment
* Go back to the gradebook and verify you don't see it listed
* Alter the assignment back to points
* Grade the students and verify late deductions are applied
Change-Id: Ifaae1729ccb6790ef642d02c0d86da145f8ad178
Reviewed-on: https://gerrit.instructure.com/119163
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Fixes: CNVS-38393
test plan:
- as a user navigate to local canvas and ensure the left-hand
main nav background color displays correctly when hovered
Change-Id: Ia1d4a3dc2b7e38cac83f7ebf54294873c12b0ba6
Reviewed-on: https://gerrit.instructure.com/120743
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-38402
test plan:
- navigate to the dashboard and using browser inspector
ensure the background-color has been removed from
`.ic-app-header__secondary-navigation` which is the
container for the toggle button
- example: https://screencast.com/t/NFGT93CnUui
Change-Id: I430686a021489d19a1c529ed8f04255eef814fd5
Reviewed-on: https://gerrit.instructure.com/120854
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
closes: CNVS-38396, CNVS-38397, CNVS-38405, CNVS-38404, CNVS-38394
refs: CNVS-38400, CNVS-38403
Test plan:
* the places that use these css variables should still look like they
Did before.
* especially check in ie11
- the only place that appears to still be using the original
accordion styles is within the right sidebar for pages,
assignments editing, etc...
- example view: https://screencast.com/t/DrwOKmQkmCtu
Change-Id: I3e6329912e7c2bdd69bce8628ac466d4b7247725
Reviewed-on: https://gerrit.instructure.com/120775
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38412
test plan:
* check this out
* run bundle exec rake brand_configs:generate_and_upload_all
* compile assets
* make sure buttons look how they did before
* especially check in ie11
Change-Id: If1d87ef9fa5c184cc21b1b51212d26ee1c7c1da5
Reviewed-on: https://gerrit.instructure.com/120726
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38411
these are all the uses of variables that don’t do
anything funky like `lighten` or `darken` or `rgba`
Test plan:
* Make sure everything looks exactly as it did before
* especially in ie11
Change-Id: I8ad0274c360d76dbbe42c2018ce9d7dd99ff5262
Reviewed-on: https://gerrit.instructure.com/120575
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38410
This fallback will make it so in browsers that
don’t support css variables it will use a fallback
and display the theme editor stuff just like the
browsers that do. The only browser we support
that doesn’t support css variables is IE11
this polyfill has to do an Ajax get request to get the
content of the css files so there will be a slight flash
of unsetyled content but I try to help subsequent page
loads by using a sessionStorage based cache.
Test plan:
* in a normal browser, css should work fine as usual. No changes.
* in IE11, all the css that uses theme editor colors should still
show up as it did before.
Change-Id: I76eda5444aa7808c1bc78e99ecb14cbcb23acbd5
Reviewed-on: https://gerrit.instructure.com/120654
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38408
NOTE: this does not actually change any behavior, it just
gets things set up so we can actually start using css variables
in follow-on commits.
test plan:
* with this checked out,
* run bundle exec rake brand_configs:generate_and_upload_all & compile assets
* open a page in canvas
* there should be a stylesheet near the top of the <head> with css variables
of all the theme editor variables.
Change-Id: I2caa210917d9245ae103d1444d6353ecfdeb59fe
Reviewed-on: https://gerrit.instructure.com/120574
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-38309
when the batch is saved it will write the messages to file, but
if it has more work to do, it will skip future messages for the
error file.
test plan
- run an import that has errors and warnings
- it should report all of them to the file
Change-Id: I2891651febdf2b16270ea62d623e143c30e59cbc
Reviewed-on: https://gerrit.instructure.com/120651
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
… so Jenkins logs are less noisy
Test plan:
* verify that the “full console” view
For the selenium build of this patchset doesn’t
Have a bunch of noisy progress output from webpack
Change-Id: Id69b04435be52bcc3213298e5ae55ac146d8e2ed
Reviewed-on: https://gerrit.instructure.com/120863
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Jon Jensen