refs INTEROP-7086
flag=none
why:
* to prepare for further refactoring - moving all
message handlers to their own file
test plan:
* specs pass
Change-Id: I3c16befd29e5c970eee3cd5502d7ea1bc71b00aa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273930
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
refs INTEROP-7086
flag=none
why:
* to prepare for further refactoring
* this handler will be folded into the general postMessage handler
* these message types aren't referenced anywhere else, and having them
in a separate file has proved to be too much indirection
test plan:
* specs pass
Change-Id: I9edf35aadeef06b052e0f1a5eee6db39b747fe39
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273931
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
The course participation section is now synced with the homeroom
participation if the option “Sync enrollments and course start/end
dates from homeroom” is checked. If the homeroom participation option
is set to course, the course start_at and conclude_at dates will be
synced with the ones in the homeroom, and if the participation is
set to term, the same enrollment_term will be set to the course too.
Closes LS-2580
flag=none
Test plan:
- Set a k5 course as a homeroom
- Set the homeroom participation to term
- Create a course with the option “Sync enrollments and course
start/end dates from homeroom” checked
- Expect to the new course has the participation option set to term
and the term be the same as the homeroom
- Go to the homeroom settings and change the participation option to
the course and select the start and end dates
- Go to the settings page of the course you created and click update
- Expect the participation option to be set to course and the dates
match with the ones in the homeroom
Change-Id: Idea7b476ad818f9777fc8ff2ca89c7b024b6b6ce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273478
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes: LS-2604
flag=none
test plan:
- Change the student’s language to a non-English option
- Navigate to the calendar and reserve an appointment slot
- See that the icon and tooltip display properly
Change-Id: Ifa71d4038e886e1309ddd81ec38b4eb52a362dca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274206
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
they may have a different license
Change-Id: I158d52c9964fcfea2e04ae0ceb28d80f89ec079d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274654
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes VICE-2066
demo video:
https://share.getcloudapp.com/yAuyEgm8
test plan:
as an admin,
visit /accounts/self/settings
go to announcements tab
verify that + new announcement
is now under Global Announcements
but over the list of existing announcements
purely visual, existing specs
are good enough
Change-Id: Ie5898addd4b98a2e6e7e9e167f64d7550815518c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274650
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-2107
flag=draft_discussions
Test Plan:
- turn draft discussions ff off
> verify that the save text doesn’t show in the bottom left of
any RCE in discussions
> verify that the “My Drafts” option isn’t available in the
filter
> verify that no drafts are saved
Change-Id: I017623817f8b042a7ac9b75ee9430b11545b0b97
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274581
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
test plan
- reply to a discussion thread
- go to reply again
- it should not load the draft from the last reply
refs VICE-2079
flag=none
Change-Id: I1f930fb6809ffc65997dd5c1736d592bf7024cd9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
refs INTEROP-6833
flag=none
why:
* in prep for extending controller functionality and creating module
items and assignments in different scenarios
* existing organization wasn't very flexible
test plan:
* deep linking still works, specifically creating multiple items when
adding to a module
* Lti::ResourceLinks are still created for all deep links
* specs still pass
Change-Id: I17972f96ddf752e94957a8ce064c92ac2b34281f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272068
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
refs VICE-2107
flag=draft_discussions
Test Plan:
- "Draft Discussion Entries" ff should be available
Change-Id: Ifd977f28e557eee55ba33f8f2e41590831f6e5b6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274579
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
and add an override so you can set the severe level however you want
Change-Id: Ie932c96cde67db284e42d095509e654b057c1f00
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274569
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
we no longer have a bajillion variants, so it's easy to look for exactly
what we want
Change-Id: Ib8569d0729b1563f978ab7d8db5b717bf4c38b11
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274591
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
because I'm about to add a feature that leverages
user_preference_values in a temporary capacity and
I don't want to clutter the database
test plan:
- add a course nickname
- notice a UserPreferenceValue is created having user_id
matching the owner and a key of "course_nicknames"
- delete the nickname
- the UserPreferenceValue should be deleted from the database
flag = none
refs LS-2670
Change-Id: I1fe9a5e0391acb467cb80c8b0cf1b818e7e9ec7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274331
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan
- run report
- it should work
- existing specs should pass
fixes VICE-2084
flag=none
Change-Id: I786b98576aa303d49c6f58863b9ce6d36ac449f6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273683
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes: LS-2621
flag=none
test plan:
- Set a k5course's visibility to institutional
- Visit the course as an unenrolled user
- Check that the proper tabs appear
Change-Id: I9e66b6411c23bb0086b1ba500d03cbc3c0f4e211
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274202
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
This also includes a controller action change from show to index. This
better follows other route endpoints where index loads the collection
page and show loads an individual pace plan. It's a little confusing
because a pace plan is loaded but the endpoint URL suggests it should
go to index.
fixes LS-2625
flag=pace_plans
test plan
- Enable pace plans feature flag and pace plans on a course
- Click Pace Plans from the course menu on a course with no pace plans
- Verify the page to load without an error
- Verify the course to have a created pace plan in the database
Change-Id: Ia2a1a7ba803f37274701c97c85d01b7f8e1d3aa3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273670
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeff Largent <jeff.largent@instructure.com>
QA-Review: Jeff Largent <jeff.largent@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
refs FOO-2401
flag = none
test plan: tests are skipped
Change-Id: I70ce388cf79745ad93d6006b44e171f07a1bd7d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274565
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
refs INTEROP-7004
flag = none
this provides a way to publish the Canvas subgraph schema to our schema
registry.
test plan:
- create a file `config/subgraph_registry.yml` with contents like:
```
development:
graph_name: InstAPIGateway-Nonproduction
eager_variant: test
stable_variant: test
registry_key: <secret>
```
- the `registry_key` can be generated on the Apollo Studio dashboard
- run `bin/rake graphql:subgraph:publish VARIANT_KEY=eager`
- the task should succeed
- change your registry_key to an invalid one and the task should fail
Change-Id: I84b6ebd7554f4861f3251a81bc7ea395bd5aa2b9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273495
Reviewed-by: Sean Scally <sean.scally@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
but do run rlint (correctly) for plugins
Change-Id: I6728c3e5ce28196caa91ca6d3425097b88e067f6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274421
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
it was just too confusing on which one an editor is using, double comments
in jenkins, etc.
this is accomplished by several things:
* required cops are just marked as severe, instead of using a separate
config for them, and failing if anything shows up from that config
* get rid of all the logic to only include certain directories for
certain cops. turns out it's not _that_ ominous to correct errors
across the entire repository before marking a cop as required.
* but still auto-generate config to turn _off_ autocorrect for
non-severe cops. this is important because auto-correct must run
for entire files, and we don't want it auto-correcting optional
things that you didn't touch.
* update gergich to get more details from the parsed comments.
this plus the prior point means we _don't_ have to have heavy mode when
in autocorrecting, but we still display out-of-context lines that were
autocorrected
this also makes it so we can use per-dir .rubocop.yml files again, so
take some of the exceptions out of the root and put them in their own
directory
Change-Id: Ie936d1a9920b68910acd250ba817c7b4a670b958
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274394
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes EVAL-1298
flag=visible_assignments_scope_change
Test Plan:
1. Enable the visible_assignments_scope_change site admin flag.
2. Create an assignment assigned to a section.
3. As a teacher, deactivate the enrollment of a student in that
section.
4. Verify the submission for the deactivated student is NOT
soft-deleted:
Submission.find_by(assignment_id: <id>, user_id: <id>)
.workflow_state # should not be 'deleted'
5. As the student, verify you are not permitted to view the assignment
page in the UI.
6. As the student, verify the assignments_api_controller#index API
endpoint does not return the assignment.
7. Re-activate the students deactivated enrollment.
8. As the student, verify you are now permitted to view the assignment
page in the UI.
9. As the student, verify the assignments_api_controller#index API
endpoint now returns the assignment.
Change-Id: I300de4bd0999edf55fca5384bb1c56f73e1bec93
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272227
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
refs INTEROP-6833
flag=lti_deep_linking_module_index_menu
test plan:
* FF is created and can be enabled
Change-Id: Ifffb20dcff1d172296ae3e0db6a2a8c587932795
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272901
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alexandre Trindade <alexandre.trindade@instructure.com>
QA-Review: Alexandre Trindade <alexandre.trindade@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
Davis Hyer