this is included in yarn.lock, and
imported in various files. it should also
be in package.json
flag=none
Change-Id: I4a16b16e750280892ac0c9b7e960036524a58055
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335917
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
also:
- more tests passing in vitests
- specifies which folders are left to resolve in the vitest config
test plan:
- build passes
Change-Id: I34fee1a8b44101fec4b801fa6f67b9562df0425c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335009
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Closes FOO-4017
flag=none
Several bug fixes, plus this has the requested changes
from InstUI for the new look and feel for the side and
top navigation bars.
Test plan:
* automated tests pass
Change-Id: I5292256e4e479c70837cc77b10b97dfaba235848
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333822
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
this commit adds the foundation for react-query to the rubrics redesign.
it also uses new graphql queries to return rubric data to the front end.
closes EVAL-3616
flag=enhanced_rubrics
test plan:
- navigate to /accounts/<id>/rubrics
- verify that if the account has rubrics, they are displayed in the
table
- navigate to /courses/<id>/rubrics
- verify that if the course has rubrics, they are displayed in the table
Change-Id: Ib340a37ad1c3a3d28413b3e8cfce359aa3f5db7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331718
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
test plan:
badge counts show up in navbar items in new SideNavBar
flag=instui_nav
refs FOO-3880
refs FOO-3894
refs FOO-3895
Change-Id: Iea01d6d9b5aa6aed7afe129842b17b1a6463c9b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331126
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Ochoa <martin.ochoa@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
We need more work to integrate the newer SourceCodeEditor.
Let's not do that with the clock ticking toward deployment.
closes LF-781
flag=none
test plan:
- the RCE's pretty html editor works as expected
- try flipping between wysiwyg and html
- try flipping between pretty and plain html editor
- try various combinations of fullscreen and switching
back and forth between editors
- insert enough html that you have to scroll, switch
to html editor. expect the html editor to resize
so that its scrollbar is correct.
Change-Id: Ieb0ad96ad2bb549676f7f9199d1231ece02b5aae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330095
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan:
- Ensure that Account Grading Settings tabs still work
- Ensure that "Act as..." page still works
- Ensure that group dropdown in Student Groups pages still renders
flag=none
Change-Id: If04a5faab051fab7301f0550637fd9ae489b58e8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328746
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Refs FOO-3190
Refs FOO-3708
Refs FOO-3913
flag=none
[fsc-max-nodes=30] [fsc-timeout=60]
Uprevs InstUI and addresses all post-uprev tasks. Also now that
InstUI is fully TypeScript, a bunch of type errors appeared
which needed to be addressed.
It builds against the commit of MRA that will have to merge
concurrently with this.
Still to do: theme -> themeOverride which is a separate commit
off of this one that is ready to go.
Test plan:
* cross your fingers
* (this will need some extensive review before merging)
Change-Id: I45a1138530d415398b019cfedcf8a3b57a051912
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329443
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
The uplift to instui 8 also changed RceHtmlEditor to use
the newer instui SourceCodeEditor, which introduced a number
of new bugs. Revert and implement with the new component later.
closes LF-781
flag=none
test plan:
- the RCE's pretty html editor works as expected
- try flipping between wysiwyg and html
- try flipping between pretty and plain html editor
- try various combinations of fullscreen and switching
back and forth between editors
- insert enough html that you have to scroll, switch
to html editor. expect the html editor to resize
so that its scrollbar is correct.
Change-Id: Ib9d431c8a5051b862d2dac6d0ebb2cf36f524dbf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327977
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Refs FOO-3190
Refs FOO-3708
flag=none
[fsc-max-nodes=30] [fsc-timeout=60]
[pin-commit-multiple_root_accounts=03b5f961bbaa28af3d43b0a6a2ab072654cc6468]
Uprevs InstUI and addresses all post-uprev tasks. Also now that
InstUI is fully TypeScript, a bunch of type errors appeared
which needed to be addressed.
NOTE:
This is an amalgam of g/314136 and g/326557 which will get abandoned
once this passes Jenkins and is merged.
It builds against the commit of MRA that will have to merge
concurrently with this.
Still to do: theme -> themeOverride which is a separate commit
off of this one that is ready to go.
Test plan:
* cross your fingers
* (this will need some extensive review before merging)
Change-Id: I860c3dc04d34237e32aeaa138f6c377a016ceeae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327683
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
this should fix issues with the media player in safari
closes LF-662
flag=none
test plan:
- in a Safari browser, add some media to a page using the rce
- ensure that you can pause/play/pause again the video/audio
as expected, both in the rce and after saving the page
- ensure otherwise that the media player is still working normally
Change-Id: I7431924592b5ae2d7c33e308673a6ca7466aacc9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327631
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
I tried v7.5.0, the last version before the api became soley
react hook based, but it didn't work
closes LF-46
flag=none
test plan:
- you can drag cards around on the card dashbaord
- you can drag discussions around on the /discussion_topics page
- check Mastery Paths in course settings
- create a couple assignments
- edit an assignmenet and go to the Mastery Paths tab
- put a couple assignments in there
- you can drag assignments between sections
- you can drag an assignment on top of another and they will
be joined together
- you can drag them apart
Change-Id: Iedf956e45ebd995e6b30e7df0a993bffb3a96f4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327233
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes LF-356
flag=none
test plan:
- yarn storybook
- play with all the stuff under Calendar > RecurringEvents
- especially play with CustomRecurrenceModal, since that's
what will go into Canvas
> expect it to spit out correct RRULEs
- in CustomRecurrenceModal story
- change repeat every to Month
- open the Select
> expect "Monthly on day 7" and "Monthly on the first Monday"
as the 2 options
- in the form at the bottom of the page, change the eventStart
string so the day of the week is the last one of the month
> expect the Select to have 3 options for the date,
the nth day of the week, and the last day of the week
Change-Id: Id68645399880c97d86a67fd974d06eabf58f674c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321191
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
This fixes an issue where DER-encoded LDAP root CA's were failing to
parse, because they were incorrectly being interpreted as UTF-8.
fixes AE-317
flag=none
test plan:
(1) upload a DER-encoded root CA
- verify it continues to parse
(2) upload a PEM-encoded root CA
- verify it continues to parse
(3) upload a PKCS7-encoded cert chain
- verify the root CA continues to parse
(4) repeat steps 3 and 4 with CRLF line endings
Change-Id: I25b0fe902f37e5dc1c671555595504fef6a0b39e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319489
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Refs FOO-3190
flag=none
Trying to uprev InstUI to version 8 revealed that our
front-end build config needs a little attention first.
Most of this was stuff that's been "wrong" for a while
but this major version upgrade of a major dependency
really uncovered where some things needed to be tweaked.
Test plan:
* This only touches build toolchain stuff, so...
* If the automated build passes, this should be good
Change-Id: I89bd29a581a8c84b7f82d319a0501a4adf59016e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/318035
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
flag = none
Test Plan:
- Existing tests pass
- Story book runs correctly
-- yarn storybook
By upgrading to typescript 5, we broke storybook.
TS 5 dropped certain methods that the storybook TS plugin relied on.
https://gerrit.instructure.com/c/canvas-lms/+/313551
more information on this issue can be found in this GitHub storybook thread
https: //github.com/storybookjs/storybook/issues/21642
Change-Id: If7f6c68b41e3e2fb35f183a825af2dff0aaa9ac1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317575
QA-Review: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Update some eslint packages removing the need for
some eslint-disable directives.
Changed react/no-unknown-property to warning since
we have several instances of it already in the
codebase.
Refs CFA-5
flag=none
Test plan:
- Automated tests pass
Change-Id: I4967d53477de7c4effe8861ee71e735be33f6b14
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317894
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Update media-capture to fix issues with microphone selection in
RCE media capture modal.
Closes MAT-1310
flag=none
QA Risk: Medium
- Updates dependencies used in the RCE and Canvas,
potentially there may be side-effects
Test plan:
- In the RCE:
- Open the "Upload/Record Media" dialog, select "Record" tab
- Compare the selected microphone option to the browser
defined one (accessible from the video icon on the
right side of the chrome address bar)
- Make some noise and ensure the audio indicator responds
- Refresh the page, and ensure audio still works
Change-Id: Ia4a653ae489c3fb1ec8233207d078fd209e9c5ee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316209
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Yona Appletree <yona.appletree@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This will allow an admin to specify an internal CA that they would like to
trust when connecting to their configured LDAP instance. It also allows
an admin to explicitly opt in to TLS certificate verification prior to our
enforcement date.
closes AE-180
flag=none
test plan:
- with the `verify_ldap_certs` flag disabled:
- verify LDAP connections succeed with bad certs
- upload a CA certificate
- verify LDAP connections still succeed with bad certs
- define the `ldap_validate_tls_cert_enforcement_date` setting
- verify the "Verify TLS Certificate" checkbox is visible, and
editable
- verify the help text appears
- enable the checkbox
- verify connections fail with bad certs
- verify connections succeed if the cert was issued by the uploaded CA
- clear the `ldap_validate_tls_cert_enforcement_date` setting
- verify the "Verify TLS Certificate" checkbox is hidden
- with the `verify_ldap_certs` flag enabled:
- verify LDAP connections do not succeed with bad certs
- upload a CA certificate
- verify LDAP connections succeed if the cert was issued by the uploaded
CA
- define the `ldap_validate_tls_cert_enforcement_date` setting
- verify the "Verify TLS Certificate" checkbox is on, but disabled
- verify the help text is hidden
- clear the `ldap_validate_tls_cert_enforcement_date` setting
- verify the "Verify TLS Certificate" checkbox is hidden
Change-Id: I41536261bdc7e5554cbf5b9915638ced996192f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315294
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
Aaron Shafovaloff