closes: CNVS-38396, CNVS-38397, CNVS-38405, CNVS-38404, CNVS-38394
refs: CNVS-38400, CNVS-38403
Test plan:
* the places that use these css variables should still look like they
Did before.
* especially check in ie11
- the only place that appears to still be using the original
accordion styles is within the right sidebar for pages,
assignments editing, etc...
- example view: https://screencast.com/t/DrwOKmQkmCtu
Change-Id: I3e6329912e7c2bdd69bce8628ac466d4b7247725
Reviewed-on: https://gerrit.instructure.com/120775
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38412
test plan:
* check this out
* run bundle exec rake brand_configs:generate_and_upload_all
* compile assets
* make sure buttons look how they did before
* especially check in ie11
Change-Id: If1d87ef9fa5c184cc21b1b51212d26ee1c7c1da5
Reviewed-on: https://gerrit.instructure.com/120726
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38411
these are all the uses of variables that don’t do
anything funky like `lighten` or `darken` or `rgba`
Test plan:
* Make sure everything looks exactly as it did before
* especially in ie11
Change-Id: I8ad0274c360d76dbbe42c2018ce9d7dd99ff5262
Reviewed-on: https://gerrit.instructure.com/120575
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38410
This fallback will make it so in browsers that
don’t support css variables it will use a fallback
and display the theme editor stuff just like the
browsers that do. The only browser we support
that doesn’t support css variables is IE11
this polyfill has to do an Ajax get request to get the
content of the css files so there will be a slight flash
of unsetyled content but I try to help subsequent page
loads by using a sessionStorage based cache.
Test plan:
* in a normal browser, css should work fine as usual. No changes.
* in IE11, all the css that uses theme editor colors should still
show up as it did before.
Change-Id: I76eda5444aa7808c1bc78e99ecb14cbcb23acbd5
Reviewed-on: https://gerrit.instructure.com/120654
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-38408
NOTE: this does not actually change any behavior, it just
gets things set up so we can actually start using css variables
in follow-on commits.
test plan:
* with this checked out,
* run bundle exec rake brand_configs:generate_and_upload_all & compile assets
* open a page in canvas
* there should be a stylesheet near the top of the <head> with css variables
of all the theme editor variables.
Change-Id: I2caa210917d9245ae103d1444d6353ecfdeb59fe
Reviewed-on: https://gerrit.instructure.com/120574
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-38309
when the batch is saved it will write the messages to file, but
if it has more work to do, it will skip future messages for the
error file.
test plan
- run an import that has errors and warnings
- it should report all of them to the file
Change-Id: I2891651febdf2b16270ea62d623e143c30e59cbc
Reviewed-on: https://gerrit.instructure.com/120651
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
… so Jenkins logs are less noisy
Test plan:
* verify that the “full console” view
For the selenium build of this patchset doesn’t
Have a bunch of noisy progress output from webpack
Change-Id: Id69b04435be52bcc3213298e5ae55ac146d8e2ed
Reviewed-on: https://gerrit.instructure.com/120863
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Test plan:
Periodic jobs run
Change-Id: Iecd5fc2660f7daa7da355cb3cd04cbadc8883178
Reviewed-on: https://gerrit.instructure.com/120806
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Neil Gupta <ngupta@instructure.com>
QA-Review: Neil Gupta <ngupta@instructure.com>
closes: CNVS-38384
This is just to keep our tooling up to date
Test plan:
* automated tests should pass
* build tooling should work (meaning webpack builds
In prod & dev)
Change-Id: I11fbda35827487e59712c762a71540a51258d1db
Reviewed-on: https://gerrit.instructure.com/120434
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Closes: CNVS-38399
Nothing uses this so it should be fine to remove
Test plan:
* course wizard “X” box should look like it did before
Change-Id: Ifb29782ac242bd0927d841c6a9eccf461fed18e5
Reviewed-on: https://gerrit.instructure.com/120773
Reviewed-by: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
it also simplifies the code for Chrome and Firefox
-ps3 replace line that got removed in merge
Change-Id: Ied37b46d0a90bb8587d211b2e798c535b5b4319e
Reviewed-on: https://gerrit.instructure.com/120611
Tested-by: Jenkins
Reviewed-by: Santosh Natarajan <snatarajan@instructure.com>
Product-Review: Santosh Natarajan <snatarajan@instructure.com>
QA-Review: Santosh Natarajan <snatarajan@instructure.com>
Change-Id: Ida11d721bad3c3a9c63b2c8885ab407b3230bad1
Reviewed-on: https://gerrit.instructure.com/120678
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
update: removed more skip_if_chromes
update: remove commented out lines of code
Change-Id: I80438ce61c13ca253d9827beb4b919a87e71854d
Reviewed-on: https://gerrit.instructure.com/120681
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
also clean up a final few mocha => rspec-mock translations that
were missed
Change-Id: I805c82c84d73099cc396bf9d3a976ebfc972c84c
Reviewed-on: https://gerrit.instructure.com/120680
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
there's no need; all stubs are automatically removed after each spec
Change-Id: I7fe5fbf8aa5c86694b3c00ea7bc59b2334f5ad21
Reviewed-on: https://gerrit.instructure.com/120711
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Fixes FALCOR-474
Test Plan:
* Christi's user should see the planner and not
forever load.
Change-Id: I6502790d81f801a384295dea7988a3e609dc0796
Reviewed-on: https://gerrit.instructure.com/120119
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
closes CNVS-38358
test plan:
- send a coures invitation
- the "Get Started" link should still look good
- if your user has a different locale set, it should be translated
Change-Id: I8c68ccbbd12f1ddea007b16b1c79f716bca8d319
Reviewed-on: https://gerrit.instructure.com/120368
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Change-Id: I4688b88742733d19ddb64fd78598f9194b327c9f
Reviewed-on: https://gerrit.instructure.com/120640
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Change-Id: I94cf12d549c259a0a98d7358ff258a272428e6b7
Reviewed-on: https://gerrit.instructure.com/120471
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Change-Id: I780864e4dcd5dee943a4e94d29b2ed6f8feffaff
Reviewed-on: https://gerrit.instructure.com/120465
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
closes CNVS-38367
test plan: send a message, it should work
Change-Id: Ic1b99120ee0c93155a4a4475f4d1dfb3d373be37
Reviewed-on: https://gerrit.instructure.com/120424
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Matt Smith <msmith@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Change-Id: Ic6e4f64874021639f5e8950e2fe42f714ae31250
Reviewed-on: https://gerrit.instructure.com/120225
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: Ic1f07de07910a4fac5c091df3b9f24793f0f9526
Reviewed-on: https://gerrit.instructure.com/120440
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Fixes FALCOR-530
Test Plan:
* Make an unpublished assignment due in the past.
* Go to planner, make sure it doesn't show up in opportunities
dropdown.
Change-Id: I0a804dd82169c8d0bca08591ad1819dae557a791
Reviewed-on: https://gerrit.instructure.com/120586
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Venk Natarajan <vnatarajan@instructure.com>
whoa, a commit that I didn't have to manually fix anything after
running thorugh the automated fixer!
Change-Id: I6ff371a3d8fa775afdf224027dfb5162580506d5
Reviewed-on: https://gerrit.instructure.com/120565
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Transifreq