Fixes: CNVS-38646
test plan:
- as an admin navigate to the account theme editor
- select *any* of the default themes
- within the preview pane of theme editor - scroll down to
"switch-style checkbox"
- the focus state has been updated - example of new look:
https://screencast.com/t/IM2oRSLdEpO
Change-Id: Ifaa47fa3b5dae931b4587b654853a4f6e0347bfc
Reviewed-on: https://gerrit.instructure.com/122498
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38645
test plan:
- as an admin navigate to the account theme editor
- select *any* of the default themes
- select the "watermakr and other images" section
- the watermark opacity slider uses the "range-input"
styles... move the slide back and forth to see the
updated focus & active styles
example of new styles: https://screencast.com/t/tlnqb5eN
Change-Id: I58bcba9d1c62f79697a8b6c8323df681e7e893f6
Reviewed-on: https://gerrit.instructure.com/122493
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38371
Test plan:
- As a teacher/admin, create a course assignment or
discussion that has peer reviews
- As a student in that same course, complete the
assignment
- As a teacher/admin, go to the assignment, then click
`Peer Reviews` in the right sidebar
- Assign a second student to peer review the assignment
completed by the first student
- Reload the page, then hover over the incomplete peer
review under the second student's name
- Confirm there is a bell/alert button now showing to
remind the student he/she needs to complete the
peer review:
https://cl.ly/2P033s2w3L2O
Change-Id: I123be5c4bd9001e89a53c24a2924d5e2adbb0920
Reviewed-on: https://gerrit.instructure.com/122016
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-38644
Test plan:
- Code reviewer: confirm Canvas CSS and assets compile
ok.
- All reviewers:
- Confirm that in normal contrast, the newer Canvas
CSS form inputs have the following :focus state
(see /styleguide):
https://cl.ly/3B3j1I3M1I1H
- Confirm that in HIGH contrast, the newer Canvas
CSS form inputs have the following :focus state
(see /styleguide):
https://cl.ly/0a473P412824
Change-Id: Iaa791c20f71fa4ce2f7b8ffdcd4eac3665f71768
Reviewed-on: https://gerrit.instructure.com/122495
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
test plan:
* create a question bank in a blueprint course
with a multiple choice question
* create a quiz with a quiz group linked to
the question bank
* lock the quiz
* sync to an associated course
* should be able to preview and take the quiz
and have answers scored
closes #CNVS-38629
Change-Id: Iab770823411ad68dcf293ba2dc53c08bdce729f0
Reviewed-on: https://gerrit.instructure.com/122571
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes FALCOR-505
closes FALCOR-554
Test Plan:
- Enable the planner feature flag
- Create some To Do items from the planner
- Add some other items that have due dates or "to do" dates
- These items should show in the widget
NOTE: The widget only shows when on the card view or recent activity views
of the dashboard
- Click the X icon on one of the items, it should remove the item.
- Click the title of a non-todo note item and it should take you to the
show page for that item.
- See if show more button shows up only when you have more then 5 todos
- Click show more buttons shows all the todos
Some things to note for future changes this only pulls first 10
for now but we will add pagination and day limiting in the future
Change-Id: Ie1babd4de190bcfb62df87e40676d9c9293feed2
Reviewed-on: https://gerrit.instructure.com/118917
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
messes up sometimes and it's not really necessary anymore
Change-Id: I20c8429c323048774f4289996787734ef376c085
Reviewed-on: https://gerrit.instructure.com/122605
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
closes GRADE-146
Test Plan:
1. Go to the Individual Gradebook and select a Student + Assignment for
a missing submission.
2. Verify there is a 'MISSING' label in the 'Grading' section.
Change-Id: Ie2581d1c2e154b2b22bd12f59e4996f729dcb772
Reviewed-on: https://gerrit.instructure.com/122233
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
test plan:
* add an associated course to a blueprint course
* delete the associated course
* the accounts index shouldn't say "1 associated course"
closes #CNVS-38562
Change-Id: Ifac1b8e999f2cce76585f09ec5964ba189fac105
Reviewed-on: https://gerrit.instructure.com/122436
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Change-Id: I4421d13c6905265f8565d16fd6ca001ba86f3f32
Reviewed-on: https://gerrit.instructure.com/122444
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
When 1) a grading period is deleted, or 2) a grading period's start
or end date changes, we now update the cached grading_period_id on
submissions in the course.
closes GRADE-177
Test Plan:
1. At the account level, create two grading periods. For simplicity
sake, let's make them full-year 2016 and 2017.
2. Create a course under that account with at least one student, and
create an assignment without a due date.
3. Enter a rails console and verify the submissions created for the
assignment have the grading period id for grading period "2017".
assignment = course.assignments.find(<the-assignment-id>)
submission = assignment.submissions.find_by(user_id: <a-student-id>)
submission.grading_period_id # should match the id for "2017" period
4. Update the "2017" grading period so that its start date is Jan 1,
2015, and its end date is Dec 31, 2015.
5. Enter a rails console and verify the submission from step 3 has had
its grading_period_id updated to reflect the id for grading period
"2016".
submission.reload.grading_period_id # should match the id for "2016"
6. Delete the "2016" grading period (so that the only the "2017" grading
period remains, whose dates span Jan-Dec of 2015).
7. Enter a rails console and verify the submission from step 3 has had
its grading_period_id updated to reflect the id for grading period
"2017".
submission.realod.grading_period_id # should match the id for "2017"
Change-Id: Ideec6a1f22801593eaaa94e829b68dfc95f170e8
Reviewed-on: https://gerrit.instructure.com/122295
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Change-Id: Ibdbca9847de64e79f472df8d3ff886e3b9c4a4ba
Reviewed-on: https://gerrit.instructure.com/122503
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs CNVS-38321
test plan:
* go to account settings
* open the time zone dropdown
* there shouldn't be a bunch of zones at the top without translations
Change-Id: Ib3d641f641c0773e510eb36f3e85fba3c257a036
Reviewed-on: https://gerrit.instructure.com/122163
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
it's a new named time zone
fixes CNVS-38321
Change-Id: Ie5424a164ad3e67d34a20c5d33850efb8c2886ec
Reviewed-on: https://gerrit.instructure.com/122177
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes QUIZ-2232
test plan:
- As a teacher, navigate to the Assignments page of a course
- Click on the "+Quiz/Test" button
- Tab to the cog menu in the top right corner
- "Not Published" label should not be tabbed
Change-Id: Icb00788f0df73b59819e6c09bdd66dfc0041d628
Reviewed-on: https://gerrit.instructure.com/121847
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Omar Khan <okhan@instructure.com>
Product-Review: Han Yan <hyan@instructure.com>
closes OUT-1431
notes:
this upgrade is necessary to avoid imports from failing on Rails 5.
test plan:
- confirm that importing standards from Academic Benchmarks v3 succeeds
Change-Id: I8daac14a2ec6100d5cc97d5a76433808d742bc44
Reviewed-on: https://gerrit.instructure.com/122487
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
Change-Id: I2139b75e78b02fba2232cc78ccce527b20eea3da
Reviewed-on: https://gerrit.instructure.com/122325
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
also remove a method that doesn't do anything
should make things faster maybe?
Change-Id: Ie3849b6faa539317338c6f55a0f7be86b8a20c3d
Reviewed-on: https://gerrit.instructure.com/122440
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
add the ability to select a role in User Search and
only see users enrolled as that role
closes CNVS-33428
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/people
- make sure the new role selector works
- make sure the correct users show up
- make sure keyboard navigation/a11y are good
Change-Id: Ib0620deb4618e06ce202ab41981e1301b3c8d256
Reviewed-on: https://gerrit.instructure.com/119365
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Andrew Katsanevas <akatsanevas@instructure.com>
the issue is that our js_env helper short circuits if request.type.html?
is false, which apparently it is for */*, even though respond_to then
resolves it to html.
fixes CNVS-38332
test plan:
- request the announcements index page, passing a */* accept header
- it should respond without error
Change-Id: Ib9e2f48b5ff6419a1de5ef2af76b30a54b5c92db
Reviewed-on: https://gerrit.instructure.com/120096
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
at some point we started loading/caching the cassandra config before
forking, which made every worker share the same keyspaces, causing
various specs to fail during the initial run
test plan:
* the build should be more stable
Change-Id: I804178152c165d72f3665ce1103c8af4736a9aa6
Reviewed-on: https://gerrit.instructure.com/122252
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Change-Id: I93e7764dc0a400ab0e422b824c6cb954dc135351
Reviewed-on: https://gerrit.instructure.com/122466
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Change-Id: Ic66c2b859214bc9ab3f09f873f4deb2deab2637f
Reviewed-on: https://gerrit.instructure.com/122131
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
don't need to serialize a whole user AR object just for a name
closes CNVS-38377
test plan: make sure all scheduler notifications from appointment groups
still work
Change-Id: Ie2343b90ec189ca30ce9ae2f9dd35a529e57d9ff
Reviewed-on: https://gerrit.instructure.com/120519
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
fixes: CNVS-38329
test plan:
- create a master course with a discussion and sync to a child course
- go to the master course discussions page
> expect the lock, publich and subscribe buttons to be on a single
> line
- go to the child course's discussions page
> ditto
Change-Id: I5b0109f25776bc7cca5c238399391e34ba1d5e2c
Reviewed-on: https://gerrit.instructure.com/120080
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: David Mirabile <dmirabile-c@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Tested-by: Jenkins
fixes GRADE-75
test plan:
* Create a Quizzes.Next quiz
* Complete the quiz as 2 different students
* As the teacher, access the quiz in speed grader
* Adjust the fudge points for the first student
* Navigate to the second student and then back to the first student
* The quiz should still be visible
Change-Id: I4cd9d743f8a2c0c5b511f8f5615c8ed0edc81991
Reviewed-on: https://gerrit.instructure.com/122041
Reviewed-by: Brian Park <brian@siimpl.io>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Change-Id: I9a8764caf8e6d435a79b1b61db5526258ace63a2
Reviewed-on: https://gerrit.instructure.com/122358
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
this will help speed up ContextModuleProgression#evaluate a bit more.
test plan: basic regression test of evaluate (tests should pass)
Change-Id: Id85c6c182a59b4f6afeb91e6a52137fd75d9518d
Reviewed-on: https://gerrit.instructure.com/122169
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
update: code review
update: add a force click function to the code
update: update the comments on the force click function
Change-Id: I6a7b2a631a6039cf86d721310038a76a2e72c17f
Reviewed-on: https://gerrit.instructure.com/121602
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Closes: CNVS-38601
This change makes it so if you have a database
connection, it will look at the db for the brand_configs
that exist there and generate them all when you
compile_assets. It should prevent people in dev
mode from getting the vanilla white page
that you get when you get a 404 for the css file
That has all of your brand_configs css variables.
Test plan:
* set up a custom theme for yourself in canvas
* rm -rf public/dist
* check this out
* run bin/rake canvas:compile_assets
* load a page,
* you should not get a 404 for a css file or js file
with your brand_variables
* the page should be themed and not be a vanilla white page
Change-Id: I796ac99c06aafe5d7d229e457988094a7b48e8bd
Reviewed-on: https://gerrit.instructure.com/122155
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
This came out of hack night at InstCon
Test plan:
* Create a grading standard via the api
* Using the id that is returned from that request retrieve the grading
standard using the following endpoint:
/api/v1/courses/:course_id/grading_standards/:grading_standard_id
* Try and retrieve a grading standard with an id that doesn't exist
* Ensure that you get a 404
* Try to retrieve a grading standard with a user that doesn't have
permission to do that in the context
* Ensure that you get a permission related response
Change-Id: Id7f5652c9735078c4d7a29f3c3e6790eb51e7311
Reviewed-on: https://gerrit.instructure.com/120685
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Change-Id: Id0e0ad36c03cb52eb9ec158318a456386b169679
Reviewed-on: https://gerrit.instructure.com/122209
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-38514
test plan:
- as a user navigate to dashboard
- if *not* HC ensure the "To Do" links are not underlined by
default.... but do underline upon hover
- now go to user settings and turn on HC to ensure the same
links are now underlined by default and do not upon hover
- lastly, turn off HC mode for user settings but turn on
"underline links" to ensure the same "To Do" links
underline properly
Change-Id: Ic181a8067bd2abf5ca194314e0e0347ef6663427
Reviewed-on: https://gerrit.instructure.com/121806
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Stephen Jensen <sejensen@instructure.com>
closes: GRADE-133
Test Plan:
1. Navigate to gradezilla
2. Change some late policy values in settings cog menu
3. Observe that upon clicking 'Update' in the menu,
all late and missing assignments are updated to show
the new grades.
- Late submission deductions are applied when enabled
- Late submission deductions are updated when penalty
value is changed
- Late submission deductions persist when late
deductions are turned off
- Missing submission grades populated when policy set
- Does not affect existing grades!
- Missing submission grades unchanged when policy unset
- Submissions in closed grading periods are unaffected
by any late or missing policy changes
Change-Id: I6d0f759a1653ab58a749a9d7b0b95eff453a432c
Reviewed-on: https://gerrit.instructure.com/119148
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
fixes: GRADE-3
depends-on: GRADE-133
Test Plan:
1. As teacher/admin, navigate to Gradezilla
2. Set up a late policy
3. Find or locate a late submission
4. Grade the late submission
- Observe late penalty is applied
5. Re-grade the submission as its adjusted grade, e.g.:
- 90/100 is penalized to 80/100
- submission is regraded as 80/100
6. Observe the late deduction is applied to the new grade
7. Repeat 3-6 with SpeedGrader, Submission Details Page
Change-Id: I392e5adeeef9354f7a8953f267d13b984b048530
Reviewed-on: https://gerrit.instructure.com/121200
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Change-Id: I60ec3b519219fcb5256a132c05f63538600df73f
Reviewed-on: https://gerrit.instructure.com/121760
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
use content_tag_for on creation so we can populate the
@content_tag_index for reuse in the migration
closes #CNVS-38017
Change-Id: Ia1b9fd773f55b4e3dcd068c740896ff0ec6d43e0
Reviewed-on: https://gerrit.instructure.com/122108
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
this was caused by jquery's data() function converting strings to
integers. e.g. "01" -> 1
fixes: GRADE-169
test plan:
- Given an assignment created with an override
- When clicking save after editing the title of the assignment
- Then the assignment is saved and there are no javascript
errors in the console
Change-Id: Idf8f41b72488edf5c76fd201fa1c4fa922ee1446
Reviewed-on: https://gerrit.instructure.com/121879
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Pam Hiett