some qti questions that are converted don't have an identifier
like they're supposed to. This allows those questions to still
be processed without causing an error
refs #5546
Change-Id: I2bc931a65095fca2e73beaaf578f99037e5e09e3
Reviewed-on: https://gerrit.instructure.com/6400
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
There are a couple small changes for the bulk migration tool
refs #5449
Change-Id: I357f69c8ccdc3ef7e08cfb274091ebd3a222105c
Reviewed-on: https://gerrit.instructure.com/6023
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
it was returning an array, which was being implicitly joined with #to_s.
but in 1.9, Array#to_s is an alias for Array#inspect, rather than
Array#join
Change-Id: I63f4f64b56b2edab9e5225f118716b9f6ee29d1b
Reviewed-on: https://gerrit.instructure.com/5836
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
This will allow a UI where the user doesn't need to identify
the type of package they're uploading. For now it's only used
for common cartridge/canvas cartridge packages.
refs #4153
Change-Id: I2488777316660c9af60f544884429de7355f358f
Reviewed-on: https://gerrit.instructure.com/5701
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
A qti-specific import allowed this before, but now it can
be configured for other migration types
closes#5044
Change-Id: I96e63725ca42937980c73f80f794848848cd59b1
Reviewed-on: https://gerrit.instructure.com/5268
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
put it on the individual answer or the question as appropriate, and
don't put the correct answer feedback on both the correct and incorrect
question feedback.
Change-Id: I63671d2c6ee6caa63e0e17b0d37c13ad3725cfef
Reviewed-on: https://gerrit.instructure.com/5251
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
remove a handful of now-unused files from the original shopify plugin
Change-Id: I7042e661724ec1148214b69d08ff470fc159e256
Reviewed-on: https://gerrit.instructure.com/4808
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
There is a coresponding commit in the python qti tool
refs #55
Change-Id: Iab00905b66676ee3c10b536a9478cfaf49d4b44e
Reviewed-on: https://gerrit.instructure.com/5087
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
This is the first of a few commits converting the QTI
specs to using the python QTI migration tool so that
the full qti import stack is tested.
This also uncovered a bug with BB8 matching questions
that this commit fixes
refs #4422
Change-Id: I0f3ebda5c77fbc9e451ab602ff00f59ab5014511
Reviewed-on: https://gerrit.instructure.com/4020
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
This way it's easy to tell what job created a file, and it makes cleanup
more reliable, since Dir.mktmpdir will remove the whole directory when
the job ends and the block exits.
Closes#5093
I was a bit worried about the performance impact of making a new
directory for every single job, but on an active job server of ours, it
only seems to add about 160 microseconds per job.
Change-Id: Id4318da20cac75e6ba232ec2250b78c38485f9e4
Reviewed-on: https://gerrit.instructure.com/4811
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
YAML was serializing this with the PluginSetting settings hash, and
barfing when trying to load it back in.
Change-Id: I318e90506299c9c46fc7978c2b53de98d1b5deee
Reviewed-on: https://gerrit.instructure.com/4764
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Basically, don't call a bazillion procs everytime you check_policy;
just the "given" statement. Everything else is evaluated just once,
and cached on the class. This does lose functionality (the ability
to access the instance inside of set_policy, and set methods), but
none of it was currently in use.
Change-Id: I736879d98beb4115a2e8c492931c755076291d08
Reviewed-on: https://gerrit.instructure.com/4665
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
Bracken Mosbacker