ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
49,193 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

9 Commits

Author SHA1 Message Date
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2021-11-25 14:03:06 +00:00
Cody Cutrer dd8fc67c41 RuboCop: Layout gems 
Change-Id: Ie49d89234f4ffed27236a1713d072a00f637a253
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274064
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-09-22 15:35:24 +00:00
Ethan Vizitei 1ed8ad8ab2 spec: coverage for diffing csv with nil column 
refs FOO-890

Change-Id: I09778f86c99f93023816e877f5f57dd371389536
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252038
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2020-11-06 15:13:01 +00:00
Ethan Vizitei 564e4dc7b7 avoid exploding on csv files with trailing commas 
closes FOO-890

TEST PLAN:
  1) provide a csv file to sis imports with trailing
     csvs and diffing enabled
  2) it doesn't break

Change-Id: If5ac926cf7933116eac18b72100a2a86fb629ace
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252016
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
 2020-11-05 21:02:36 +00:00
Cody Cutrer d6e044ff76 add # frozen_string_literal: true for embedded gems 
Change-Id: Ib49bc8939cf1706e758429e531a87c57d0231a37
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 2020-10-28 22:08:40 +00:00
James Williams 4ca2847776 add sis batch setting to disable diffing on high diff row count 
test plan:
* use the sis imports API to create a diffed sis batch
* refer to the API docs for 'diff_row_count_threshold'
 to use the setting similarly to 'change_threshold' but
 instead set an explicit row count and confirm that
 diffing does not happen if the number of rows that
 would be run in the diff exceeds the threshold

closes #CORE-2711

Change-Id: Idfc77d0aa64a82cf0665ffb5e3cc31f04d9e60e3
Reviewed-on: https://gerrit.instructure.com/189099
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2019-04-16 12:31:50 +00:00
Rob Orton 9e97c6e11a handle empty files for diffing mode 
fixes CNVS-38281

test plan
 - upload diffing file
 - upload empty diffing file with just headers
 - it should diff the files

Change-Id: I5d9c5dbf04c37e485de408ca038ba524461d0afe
Reviewed-on: https://gerrit.instructure.com/119610
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2017-08-01 19:56:44 +00:00
Landon Wilkins c5b5cc786d da licença part 53 
add consistent license headers to all source files

Change-Id: I405d2def01ad68c76533b9254983497485cd7073
Reviewed-on: https://gerrit.instructure.com/110160
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
 2017-05-01 21:06:11 +00:00
Brian Palmer 17fbe349ab csv_diff gem 
Change-Id: If566585cea572067bde2b019804c15dc1851f3e5
Reviewed-on: https://gerrit.instructure.com/48424
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Tyler Pickett <tpickett+gerrit@instructure.com>
Product-Review: Linda Feng <lfeng@instructure.com>
 2015-02-26 15:52:58 +00:00