closes: GRADE-1867
test plan:
- checking and unchecking the final grade override checkbox still works
- interacting with both the late policies and the advanced tab works as
expected (two separate requests that both fire on save)
- interacting with just the late policies tab does not trigger a
request to save the gradebook settings
- interacting with just the advanced tab settings does not trigger a
request to save late policy settings
Change-Id: I5c5bfdc7c62cf0adec64d06b8e2af88c4f39ff7a
Reviewed-on: https://gerrit.instructure.com/175559
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
closes CORE-2106
Test Plan:
- Enable Content Security Policy feature flag
- Go to account settings
- There should be a tab there that says 'Security'
- Clicking it should show you some placeholder text
Change-Id: Id34feba1b831d57951a0ba5ab2b717af29a5f449
Reviewed-on: https://gerrit.instructure.com/171476
Tested-by: Jenkins
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
This only affects javascript files and only affects things
from the prettier whitelist
This will run slowly if you don't have node_modules installed
locally (e.g., in Docker), but it will gladly attempt to
run things in Docker for you.
This adds a new githook_installer image that will install
the githook whenever a docker-compose up happens in the
repo. It will also install the hook whenever a `yarn`
occurs locally (as a postinstall hook).
This commit should also not fail things. For example
having unused variables is an ESLint error, but it isn't
autofixable. It will log the error, but will otherwise
continue. However, it will make this pretty with prettier
as well as fix any other autofixable ESLint errors.
closes CORE-2118
Test Plan:
- Run `yarn`
- Add some semicolons to something from the whitelist
- git add that file
- git commit and it will strip semicolons
- In a dockerized Canvas:
- docker-compose up
- Add semicolons to a file
- git add that file
- git commit, it will take forever (~60s)
- It should have stripped out semicolons
Change-Id: Id9198aa008808e898f29acb9ed64dd14ff843222
Reviewed-on: https://gerrit.instructure.com/171510
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Landon Gilbert-Bland