fixes INTEROP-6733
flag=none
Test plan
- Install more than 3 LTI tools
- Verify that you can launch an LTI
tool from the assignment submission
- Verify that all LTI tools load
and look ok
- Verify that if you choose the wrong type
of file from an LTI tool that it won't
let you submit
- Verify other types of submissions
also still work
Change-Id: If03f0d0e7532741d14bac0906feb07b66f1887b7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265629
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Sean Scally <sean.scally@instructure.com>
This also adds things in this directory to the whitelist
to make sure nothing ugly gets introduced.
Test Plan:
- Automated tests pass
- Make a non-pretty change in a js file within spec/coffeescripts
- Commit it
- Notice it has been prettierfied
refs COREFE-347
flag = none
Change-Id: I52a32b5888da2ad8fc8054f753bc75e48b5ab843
Reviewed-on: https://gerrit.instructure.com/212515
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes: PLAT-3109
Test Plan:
* Verify you can still create an online_upload submission via API
withouth specifying a eula timestamp
* Install a plagiarism detection tool
* Install https://lti-tool-provider-example.herokuapp.com/xml_builder
using all placements
* Create a single assignment with submission types 'onine upload' and
'text entry.' The assignment should be associated with the
plagiarism detection tool
File Upload & Text Entry
- As a student visit the assignment. Click the 'File Upload' tab
and upload a file.
- Verify the tool's EULA is displayed by a checkbox
- Verify the checkbox must be clicked before submitting
- Verify the page allows submitting once the checkbox is
clicked.
LTI Homework Submission Placement
- Click the LTI submission tab
- Go through the content item flow and return a
File Item
- Verify a link to the plagiarism tool's EULA
is shown.
- Verify the checkbox must be clicked before submitting
- Verify submission is successful once box is checked
* For all submission types verify the the `eula_agreement_timestamp`
is set in the DB in the submission's 'turnitin_data' (i.e.
turnitin_data: {:eula_agreement_timestamp=>"1522430904822"})
* Verify if the plagiarism detection tool has no EULA offered the
checkbox does not appear in the LTI submission tab.
Change-Id: Idb08d3c5d37c8c05ebf075f3c95c33c4c531aabf
Reviewed-on: https://gerrit.instructure.com/145314
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
...and pass them through amdtoes6, eslint, and prettier
This converts most of our coffeescript spec files to javscript, to
es module syntax and applies our eslint code formatting rules to it.
Because this is just spec files, as long as the tests still run
and they all still pass, this should be good. That makes these a lot
easier and safer to deal with converting than the stuff in
app/coffeescripts
After this commit there should not be any .coffee files in the
/spec/ directory.
test plan:
* jenkins should run the same # of js specs as before and they should
all pass
Change-Id: I701c101777486e2e37d0ec1327692f16099352cd
Reviewed-on: https://gerrit.instructure.com/141556
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
this will not pass jenkins since it renames these files to .js
without also converting the syntax to javaScript. However, this is
intentionally it's own commit so that when you `git log --follow`
a file, it can track its history across the name change.
the following commit actually changes the syntax.
test plan:
* make sure the next commit passes. This should just rename things
Change-Id: I4b56f2789eda12cba64a3716462fecce31b2e895
Reviewed-on: https://gerrit.instructure.com/141555
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Ryan Shaw <ryan@instructure.com>
Mysti Lilla