Commit Graph

9 Commits

Author SHA1 Message Date
Cody Cutrer e9d63396ff rubocop: split configuration
* remove spurious .rubocop.yml override files
 * split the configuration into an enforced and optional
 * run both configurations in jenkins (may result in some duplicate
   comments at different levels)
 * auto-correct the enforced configuration in the pre-commit hook
 * fix comments for Gemfile.d and the root dir; enforced configuration
   is only applied to that directory for now

Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 16:02:22 +00:00
Cody Cutrer 60af1af7d7 Revert "pin gem paths to the actual current directory"
This reverts commit 765b685eb6.

Change-Id: Ib9901630d55f81e7674e7fc566195ac3e9076af9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271839
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-08-19 20:28:54 +00:00
Cody Cutrer 765b685eb6 pin gem paths to the actual current directory
not one with the same name, in case we're inside a symlink that has changed

Change-Id: I5142b727f89ab662c4d909eccc7b781888551239
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/270998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-08-10 01:06:30 +00:00
Cody Cutrer 4e09b12caa add frozen_string_literal comment to Gemfile and Rakefile
Change-Id: I721bd841d310efb7389a232001b3d36bb8efbf0b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261812
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-03-30 17:51:26 +00:00
Landon Wilkins 8403054825 da licença part 22
add consistent license headers to all source files
(ruby, coffeescript, javascript)

except for vendor files

Change-Id: I289eec4c72b19324a049188939dc14b5965c1f25
Reviewed-on: https://gerrit.instructure.com/110044
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-27 21:51:33 +00:00
Ryan Shaw 5b88629fe0 Remove RequireJS support
closes: CNVS-31785

test plan:
all builds should pass

Change-Id: I2925934692a3d2f115f1289d7b50cb72d8cb907f
Reviewed-on: https://gerrit.instructure.com/104492
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
2017-03-13 22:10:23 +00:00
Cody Cutrer b078234eff don't auto-require gems that are just dependencies
we have them in the gemfile to lock them to a specific version,
but normal behavior doesn't auto-require them

also, use 1.9 hash syntax in gemfiles (_except_ _before.rb)

Change-Id: I549c2775c65d48ff23ba1358b43713965df97813
Reviewed-on: https://gerrit.instructure.com/51636
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-08 15:55:26 +00:00
Cody Cutrer 2148803b55 don't use a rake_tasks bundler group
it's nonstandard, and messes with spring

Change-Id: I6e9d4a663d5bfb94f58028613f70176eec23a637
Reviewed-on: https://gerrit.instructure.com/37827
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2014-07-21 19:36:07 +00:00
Joseph Rodriguez baeeb6efc3 refactor and make gem rake task inclusion explicit
fixes: CNVS-12513

test plan:
- run rake tasks for i18n and jst

Change-Id: Ied2b1d67979e55356adfef1cc7aaed42aa0c4b5a
Reviewed-on: https://gerrit.instructure.com/33501
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
2014-04-24 15:50:31 +00:00