fixes #CNVS-517
fixes #CNVS-761
test plan
- start with a course with students in different sections
- create a quiz with a lock date that locks the quiz currently
- create a lock date override that unlocks the quiz for one section
- ensure that a student from a section that the override does not apply to
does see a lock icon on the course's quizzes list for the quiz
- ensure that a student from the section that the override does apply to
does not see a lock icon on the course's quizzes list for the quiz
Change-Id: Ic1f553818ff106e1d29a8f1b66d8445b99aecffc
Reviewed-on: https://gerrit.instructure.com/16228
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
fixes #CNVS-474
when displaying submission lateness in the speed grader,
respect any assignment overrides.
test plan:
* create an assignment due in the past with an override
due_at in the future;
* as a student to whom the override applies, submit the
assignment;
* as a teacher, view the submission in the speed grader
and verify that no late message is displayed.
* make a late submission and verify that the late message
is still displayed as expected.
Change-Id: Id9c0a55569b39f2e7d316ee0ced9189795ccfbf9
Reviewed-on: https://gerrit.instructure.com/15961
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
refs #CNVS-1360
test plan:
1. go to /about and /about/self
2. you should see your profile (if profiles are enabled)
Change-Id: I7f03cd8806247f0ed5a627ee56a98062e0a1f085
Reviewed-on: https://gerrit.instructure.com/16277
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
test plan:
- Using the "update an admin role" API, attempt to set permissions
for a role that doesn't exist
(e.g., PUT /api/v1/accounts/1/roles/NonExistentRole?permissions...)
- You should get a 404 error, not a 200 response showing the
permissions you just set...
Change-Id: Ic78b79a1d7e2a20868c969f3be3fdc27b602099d
Reviewed-on: https://gerrit.instructure.com/16208
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Removes some stray debugger statements, and some commented-out
debuggers.
test plan:
- spec/selenium/teacher_wiki_and_tiny_wysiwyg_spec.rb should not hang
Change-Id: I10736d4346c77522497d946f90b74f5f49fe0e9b
Reviewed-on: https://gerrit.instructure.com/16210
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
instead of deleting it if it can, and deactivating it otherwise,
but returning the same response code either way.
add a separate endpoint for deactivating a role.
also document all three endpoints (delete, deactivate, activate)
test plan:
- create a role
- delete the role, and verify it gets deleted
- delete the role again, and verify you get a 404
- create a role and assign it to someone
- try to delete the role, and verify this fails with
"Role is in use" error message
- deactivate the role; this should succeed
- reactivate the role; this should work too
fixes #CNVS-2223
fixes #CNVS-2260
Change-Id: I04a567de104d5d39ef2cda6bb10c915a85d18ec5
Reviewed-on: https://gerrit.instructure.com/16122
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
note: a prior commit handles "false" as a string (among other
things); this commit fixes a bug handling false as the native
JSON data type.
test plan:
- disable a permission for a role where it is enabled by default,
using a raw JSON request body using native boolean true and
false values, not the strings "true" and "false".
for example, use the request line
PUT /api/v1/accounts/1/roles/TaEnrollment
pass the header (in addition to Authorization)
Content-Type: application/json
and the raw request body
{ "permissions": { "read_forum":
{ "enabled": false, "explicit": true } } }
Change-Id: Ifbd7dee36b00bab801f9284d23c94cb731efe615
Reviewed-on: https://gerrit.instructure.com/16235
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
test plan:
1. self enroll in a course
2. you should see the regular "terms" checkbox and text
Change-Id: I8c3e677d8e30343626d198258e604c65755dddf3
Reviewed-on: https://gerrit.instructure.com/16225
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
broadcast policy was being kicked off too early
which caused the previous due date to be sent on a
due date change notification
test plan
* create an assignment
* change the due date
* the assignment due date change notification
should have the correct due date
Change-Id: Icaa26143e36113e8ad001e7ce950e463d7526787
Reviewed-on: https://gerrit.instructure.com/16170
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
test plan:
1. run the specs
Change-Id: Ie2ca5ba3c12eac62818570f19ba82825a2cadfd1
Reviewed-on: https://gerrit.instructure.com/15893
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
include separate sections in each column for
custom student, teacher, and ta roles
test plan:
* create custom roles
* enroll users in a course using the new roles
(note: this will be difficult until the ui for
enrolling custom roles is ready)
* confirm that the "People" page shows correctly
(including sections)
closes #CNVS-1167 ( also #CNVS-2244 )
Change-Id: I73fcf82e407c6af00f6f8f7a8c30141adb704227
Reviewed-on: https://gerrit.instructure.com/16058
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
fixes #CNVS-2300
test plan:
* using a course that has no sections
* click 'Student View'
- the Student View should show correctly (not error)
Change-Id: I2dbfab8775d51a4a0cf4aae22de9f7207da848c3
Reviewed-on: https://gerrit.instructure.com/16223
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
test plan
spec should be able to enroll users in valid term
Change-Id: I0be35a673b0534abfdcc50c1d2a2b14d96726542
Reviewed-on: https://gerrit.instructure.com/16260
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
Tested-by: Brian Palmer <brianp@instructure.com>
we have $.fn.disableWhileLoading that is great for
when you want to disable an element while a deferred
(ajax request) is working. this is for when you just
want to show a little loading icon, and is a lot lighter
weight.
Change-Id: I0271c9be9a5bb84e1faae5d94f09bac8a718c70e
Reviewed-on: https://gerrit.instructure.com/16035
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
To support instructors of MOOCs, making a submission comment
via gradebook or speedgrader should no longer create a
conversation message in the instructor's inbox. The
conversation will only exist in the sent folder.
If a private conversation between the teacher and student
already exists, the message will be added to the private
conversation and its state will not be modified for the teacher.
In general, the behavior of submission comments was changed so
that creating a submission comment does not create a message in
the author's inbox. Instead the message should appear in the
author's sent folder. This applies to all users (teachers and
students).
fixes #CNVS-1162
test plan:
- As a teacher, create a submission comment from gradebook.
Make sure the comment doesn't show up in the teacher's inbox.
- As a teacher, create a submission comment from speedgrader.
Make sure the comment doesn't show up in the teacher's inbox.
- In general, create submission comments as a teacher and a
student and run through the following combinations of states:
- Existing Private Conversations:
- If a private conversation between the student and the
teacher already exists, the state of the message should not
be updated for the submission comment author.
- If a private conversation between the student and the
teacher does not already exist, the message should only show
up in the sent folder for the submission comment author.
- Notification Preference: Mark new submission comments as read
- Setting this should still prevent incoming submission
comment messages from showing up in the instructor's inbox
or changing the state of an existing private conversation.
- Muted Assignments:
- When an assignment is unmuted and only one user has made
submission comments, that user should be treated as the
message author.
- When an assignment is unmuted and more than one user has
commented on the submission, the message is treated as a new
message for everyone.
Change-Id: Ic55cc64f181e8a0c560fe325bd31ea65082568d2
Reviewed-on: https://gerrit.instructure.com/16007
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
warn users when beginning or resuming a one question at a time, can't go back
quiz from the right sidebar (we are already warning for the main page links).
fixes #CNVS-1952
test plan:
- take a one question at a time, can't go back quiz (with multiple attempts)
- leave it, go back to the quiz page
- click resume from the right sidebar
- it should warn you about can't go back
- finish the quiz
- take it again from the right sidebar
- it should warn you about can't go back
Change-Id: Iff5f2b9bd10a926c86c8b0a7ca6586854f62260b
Reviewed-on: https://gerrit.instructure.com/15948
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley+gerrit@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
test plan:
- Create a user enrolled in a course
- Create a course announcement that includes a link to course content (chosen
from the handy menu on the right of the announcement editor box)
- Fetch the activity stream json using /api/v1/users/self/activity_stream
- Ensure that the anchor tag in the announcement message text in the returned
json has a 'data-api-endpoint' attribute and that the href includes the
host and protocol
fixes#10658
Change-Id: I5c218ba7dbe12d99d9ffa56f78e397f3241b89d6
Reviewed-on: https://gerrit.instructure.com/14314
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
add support for self enrollment caps to limit the size of a particular
course. there is no UI for setting caps (yet)
test plan:
1. run specs
2. follow test plan for https://gerrit.instructure.com/15819
Change-Id: Ibf0a8f04f0c2efa820d0850cef26dfae20849246
Reviewed-on: https://gerrit.instructure.com/16021
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
fixes #CNVS-1119, potentially supersedes
https://gerrit.instructure.com/14501 with a little work.
simpler flow that is more consistent with FFT signup. whether you click
the "join course" button (popup) or go to the join url, the workflow is
the same:
1. if you are authenticated, you just click the enroll button.
2. if you are not authenticated, you can either:
1. enter your (canvas/ldap) credentials and submit to join the course.
2. register and join the course (single form). you will then be
dropped on the course dashboard in the pre_registered state just
like a /register signup (you have to follow the link in your email
to set a password).
note that if open registration is turned off, option 2.2 is not available.
other items of interest:
* fix CSRF vulnerabilities where you can enroll authenticated users in
open courses, or un-enroll them if you know their enrollment's UUID
* move to shorter course-id-less route (w/ join code)
* reuse UserController#create
* handy openAsDialog behavior and embedded view mode
* better json support in PseudonymSessionsController#create
* extract markdown helper from mt
* show "you need to confirm your email" popup when you land on the course
page the first time (already showed on dashboard)
test plan:
1. test the authenticated/unauthenticated scenarios above, for both the
popup and join pages
2. regression test of /registration forms
Change-Id: I0d8351695356d437bdbba72cb66c23ed268b0d1a
Reviewed-on: https://gerrit.instructure.com/15902
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
This require now throws LoadError rather than MissingSourceFile
test plan: in an environment such as production that doesn't have rspec
installed in the bundle (bundle install --without development test), run
`bundle exec rake -D` and you should not get an error.
Change-Id: I66583857fb3e0cdacfc60e876c61dff522a549c2
Reviewed-on: https://gerrit.instructure.com/16201
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
Tested-by: Brian Palmer <brianp@instructure.com>
we were adding the text of the placeholder word directly as a class, and so
using certain words, like 'answer', had the potential to interact strantely
with javascript
fixes #CNVS-2029
text plan:
- create a quiz, with a multiple drop down question
- user [answer] as the placeholder text in the question
- create a few possible answers
- save the question
- re-edit it
- you should not see an extra, blank, correct answer option
Change-Id: I9642a1e820dd18d55f1ba71a7a47693779bc5043
Reviewed-on: https://gerrit.instructure.com/16074
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley+gerrit@instructure.com>
Adds a convenience method to get all the roles available
to a course and the count of those enrollments in the
course
Test Plan:
* Run specs
refs #cnvs-1166
Change-Id: Ia884591e135b9f84c2472d4ef2f2df3fa528a6f3
Reviewed-on: https://gerrit.instructure.com/16098
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
Fixes #CNVS-508.
Added Observer tests.
Testing Notes:
=========
* As a teacher, setup an assignment that has different
lock dates for the base versus a section.
* As a student, in a section, verify that the alternate
lock dates are used for display and submission.
* Can also test that a default lock date that would be locked
is NOT locked when a section has different dates. It
should still allow the student to submit an assignment.
Change-Id: Iccb6d7407d10575edafc2e0b888760d78cd5abd1
Reviewed-on: https://gerrit.instructure.com/15883
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
- make course/account/user associations not load deleted grading standards
- make course copy not copy deleted grading standards
- never show more than 100 grading standards on a course/account page
fixes #CNVS-2230
test plan:
- in a course, create a grading standard
- delete it
- copy the course
- the destination course should not have that grading standard
Change-Id: I0063b5ca704667b2863f1d571c86df82c2a5cb97
Reviewed-on: https://gerrit.instructure.com/16108
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
gear menus in discussions could previously be selected and navigated,
but links could not be selected with the enter key.
test plan:
* create at least one discussion in a class;
* using voiceover or another screen reader, navigate to the course
discussions page and tab to the gear menu;
* press "enter" to click on the gear menu, and then use the arrow
keys to navigate to a menu option;
* click the menu option with the enter key and validate that the
link works as expected;
Change-Id: I4f6bc65d2156169bb86784d566441f964f224c1a
Reviewed-on: https://gerrit.instructure.com/13463
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
test plan:
as a teacher go to courses/x/users/y/grades or as a
student go to courses/x/grades and press command+p
or press the print button on that page,
make sure the print-preview looks nice
Change-Id: I5feab9c231d857a29c79a3fbad7e4b77eb95b7f1
Reviewed-on: https://gerrit.instructure.com/15725
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
[Fixes #CNVS-1145]
* Adds support for attaching AssignmentOverrides to quizzes
* Links common overrides for Assignments that belong to Quizzes
so quiz.due_dates_for(user) == quiz.assignment.due_dates_for(user)
* Moves common functionality for VDD out of the Assignment model
and into the DatesOverridable module, which is now included on
Quiz for a consistent interface
Test plan:
* Run through a few of the old VDD scenarios and verify things
still work as expected since a lot of code has shifted around
* No interface changes have been made to quizzes yet, so nothing
to check there
https://gist.github.com/f12b3694016f3dcc979e
Change-Id: I32b4a54273f90fac689e05174039b8efc952dd39
Reviewed-on: https://gerrit.instructure.com/16028
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan:
on an android in the mobile chrome browser go to log into canvas
try to log in with a non-email username (for example, mine is 'ryan')
make sure it lets you log in.
right now it errors because we add "type=email" to
the input to get the nice email-hinted keyboard entry.
but by doing so, it will also use native validatation
to make sure it is a valid email, adding "novalidate"
to the <form> fixes it
Change-Id: Ie3215100d07a932508c366dac147d59502696c8e
Reviewed-on: https://gerrit.instructure.com/16175
QA-Review: Mark Suman <marks@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
has no visible impact, just code organization
Change-Id: I0c7546c5fedb785c23c44c4f5b64cce6c0b3071a
Reviewed-on: https://gerrit.instructure.com/16034
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley+gerrit@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
refs #CNVS-1292
Was unable to find any job-per-student
behavior (not to say that we won't ever discover
any), but I did find several instances of loading
full collections into memory
of student objects or objects
that would be instantiated in the same order of
magnitude as students for a course, and was able
to tweak many of those. There are undoubtably
more to find.
Change-Id: I044a1d92f90c830b4d1d07f0d4de17a718bcbe55
Reviewed-on: https://gerrit.instructure.com/16030
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
test plan:
* full regression test on dashboard stream items and activity
stream in the API
Change-Id: I7739fd7d7ea6350f6f7088b7736fd5d287e9384e
Reviewed-on: https://gerrit.instructure.com/15487
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <ethan@12spokes.com>
QA-Review: Clare Hetherington <clare@instructure.com>
no need to do a permissions check here b/c the block is
empty.
Change-Id: I425e3bb36e4889adbc10de318f7b014983f994b2
Reviewed-on: https://gerrit.instructure.com/15963
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
this commit adds a new endpoint to return users who have
memberships in the given group; it facilitates using the
API entirely for the collaboration interface.
test plan:
* create a group with members;
* make a call to /api/v1/groups/:id/users and verify
that user JSON is returned;
* make a call w/ the per_page param set to 1 and verify
that the endpoint is properly paginated;
* make a call to the endpoint as a user outside the group
and verify that 401 is returned.
Change-Id: I829dbdfa30f73c0dcb7dee3887ed7b3d9fd2aa1e
Reviewed-on: https://gerrit.instructure.com/16088
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
Tested-by: Zach Pendleton <zachp@instructure.com>
setting default_internal will cause issues with reading and writing to
files, and is no longer necessary now that we override
ActiveSupport::SafeBuffer to always be utf-8 encoded.
however, setting default_external is still necessary to correctly read
in files like erb templates, scss files, etc.
fixes #CNVS-2165
test plan: course migrations and other operations that read/write to
files should work, but erb templates should also display without error.
in a console, File.open('test', 'w').external_encoding should be nil.
Change-Id: Ica02ff164a29617e95ee3d65a0e4f31414c2ce33
Reviewed-on: https://gerrit.instructure.com/16143
Reviewed-by: Ethan Vizitei <ethan@12spokes.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
fix bad reference to UniqueConstraintViolation
improve the queries so that postgres can use a better query plan
for re-runs
Change-Id: If4ae4db930f546a9434ec82d63f32fc7b7a62ecf
Reviewed-on: https://gerrit.instructure.com/16081
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
expose the existing GroupsController#context_index action
to API clients.
test plan:
* create account-level and course-level groups;
* make API requests as a student and verify that:
* at the course level, all of the groups you belong
to are returned;
* course groups you do not belong to are excluded;
* at the account level, a 401 is returned.
* make API requests as a teacher and verify that:
* at the course level, all groups are returned;
* at the account level, a 401 is returned.
* make API requests as an account admin and verify that:
* at the course level, all groups are returned;
* at the account level, all groups are returned.
Change-Id: I27775def062d700c6f1c1fbae4fd83f9eb03378f
Reviewed-on: https://gerrit.instructure.com/15939
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
durations may be specified with a single digit unit prefix
e.g. M# (minutes), H# (hours), D# (days)
if no unit is specified, seconds is assumed
fixes #CNVS-1283
test plan:
* perform a Blackboard Vista/CE/WebCT course migration
- the course should include an assessment with a time limit
* verify that the imported quiz has the correct time limit
Change-Id: I02c9144540eadf5a43c623a4ffeb78e22c3786e5
Reviewed-on: https://gerrit.instructure.com/15944
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
closes #CNVS-2165
This is recommended in some guides for upgrading a Rails 2.3 app to Ruby
1.9, but it was causing a lot of problems with file reading and writing,
especially in gems.
Our override for ActiveSupport::SafeBuffer to always be encoded as utf-8
fixes the issue that originally prompted us to add these default
encodings in the first place.
Change-Id: Ifb4649dd6aa86bfb15ff16daa706a5c6df33292a
Reviewed-on: https://gerrit.instructure.com/16079
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <ethan@12spokes.com>
QA-Review: Brian Palmer <brianp@instructure.com>
fixes #CNVS-1279
test plan:
- create a discussion topic, reply to it, and create 5 side
comments to the reply with at least one with an attachment
- refresh the page and then click the arrow to show all the
side comments
- see that the side comment attachments are still visible
Change-Id: I47b7795f4e44caad3ce42bf31af21d73bf6dc6bf
Reviewed-on: https://gerrit.instructure.com/15797
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Tested-by: Jon Willesen <jonw@instructure.com>
test plan:
* existing stream items should still show up correctly
* new stream items shoudl also show up correctly
Change-Id: I62d4ed0ebb2266e26a2aca5230890525f86c33f6
Reviewed-on: https://gerrit.instructure.com/15510
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan:
* in calendar 2 create a scheduler appointment
* setup time slots for the appointment
* select a course calendar for the apointment
* select the checkbox for users to signup in groups
* save and publish
* edit the scheduler appointment
* you should be able to add another time slot
Change-Id: Ic32e76787bbb183f10d256d83a1680704f05ff40
Reviewed-on: https://gerrit.instructure.com/15461
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
key and value are passed as two args, not one arg that needs
deconstructing. this incorrect deconstruction worked in 1.8 but not in 1.9.
test plan: in 1.9, account reports tab should show up, and you should be
able to generate a report.
Change-Id: Id970a6b55b72ed26ab05b1b6384547305514d802
Reviewed-on: https://gerrit.instructure.com/16060
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Joel Hough
