test plan:
- have a course with draft state enabled
- have a bunch of unpublished module items
- reorder them
- reload the page and make sure the order sticks
fixes CNVS-10906
Change-Id: I47713b454cce41330803eb742455697b4a26e0b0
Reviewed-on: https://gerrit.instructure.com/29591
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Change-Id: I1f9cb0a894ce7a1af63b03d432396f7d911c5bf6
Reviewed-on: https://gerrit.instructure.com/29790
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes cross shard user search by id for rails 3
prevents the where from inferring the user's home shard, cause this query
really needs to happen on the account's shard
Change-Id: I0a3539be638ece276b8fb33f87c75e8a33ab51ef
Reviewed-on: https://gerrit.instructure.com/29589
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-10555
test plan:
In screenreader gradebook and gradebook2
- open the assignment muter dialog
- focus should be on the content of the dialog
Change-Id: Id4972ebef2f9a496b984bd0e799172844ffbb158
Reviewed-on: https://gerrit.instructure.com/29309
Reviewed-by: Matthew Irish <mirish@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes CNVS-10130
test plan:
- Edit existing quiz
- Go to the questions tab
- "Find Questions" button
- Select the group
- In the "Add questions to the quiz group:" drop down, select "[New Group]"
- Fill out the form with sane values
- "Create Group" button
- The group should be created successfully
Change-Id: I4197a3296d708b203ede265e7774456ec44ee894
Reviewed-on: https://gerrit.instructure.com/29763
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
fixes CNVS-2607
test plan:
- set the language for a course to something other than English
- view the course home page
- that language should be used
- other courses' home pages/other pages should be unaffected
Change-Id: Ibee1b22003871ff942ad2f46e98073f12c449377
Reviewed-on: https://gerrit.instructure.com/29617
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- create a custom student role
- enroll one or more students in a course with this role
- also enroll some normal students
- go to the groups page, and create a group set
- both normal students and custom students should show up
in the "unassigned" list and be assignable to groups
- if you divide students into groups automatically, both
custom and normal students should be assigned
fixes CNVS-10434
Change-Id: Ib609af34063e10af605c8d8e11cde50d1fee967a
Reviewed-on: https://gerrit.instructure.com/29667
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
test plan:
- enable draft state
- go to modules page
- publish a module and ensure the cloud icon changes
- unpublish a module and ensure it changes back, without
having to reload the page
- repeat the two previous steps a couple of times
fixes CNVS-10829
Change-Id: I0806a29ccb9d1ff8e37e31e26e6eb39b3aa90fac
Reviewed-on: https://gerrit.instructure.com/29555
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
test plan:
* regression test term index
Change-Id: I9e37b1676beb19a3e49efde78d6b1b051f5b6bdf
Reviewed-on: https://gerrit.instructure.com/29099
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
also refactored add_variable_mapping to be more explicit
Change-Id: I38b21975ae80cf510f81bfba84ece7b3b568bfa9
Reviewed-on: https://gerrit.instructure.com/29241
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stephan Hagemann <stephan@pivotallabs.com>
Product-Review: Stephan Hagemann <stephan@pivotallabs.com>
QA-Review: Brad Humphrey <brad@instructure.com>
because the zip central directory can lie
test plan:
1. Create a huge file (say a gigabyte) where every byte is the
same.
2. Zip it. The repeating data will be compressed. The ZIP will
be tiny but will uncompress to a huge file.
3. Edit the zip file binary. Open it with a hex editor and
change the file size in the directory. Make the file
appear to be small enough to fit into the course quota.
(The zip file format is documented at
http://www.pkware.com/documents/casestudies/APPNOTE.TXT
or ask the committer for help)
4. Try to import the zip file into a course (migrations/
import zip file into folder)
5. You should receive a quota error.
fixes CNVS-10722
Change-Id: Ib1bd1c432ef900f0c6c61ebe6eab2881f8515104
Reviewed-on: https://gerrit.instructure.com/29704
Reviewed-by: Mark Severson <markse@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: I7e783504c6134099014254f1fffd68366ab488d1
Reviewed-on: https://gerrit.instructure.com/29717
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: I7e0e9db5d4d8f920ce63c4dfcac966783473c39a
Reviewed-on: https://gerrit.instructure.com/29716
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-9716
test plan:
1. As a teacher, using the scheduler, create a set of appointment groups.
2. As an admin, create two user accounts, and enroll them into the course
with the appointment groups.
3. Sign into each user account and using the scheduler, sign up for
different scheduled appointment times.
4. As an admin, merge these two accounts.
5. As the user, navigate to the Scheduler and observe that the scheduled
appointment tied to the current account is still tied to the account. but
the other that is tied to the old account has not updated to reflect being
tied to the new account.
Change-Id: I69b4b0fd46774d6096b48189132190183ac4eb4a
Reviewed-on: https://gerrit.instructure.com/29640
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
Closes CNVS-10154
Test plan
---- ----
- create a quiz with a FIMB question and take it
- fill in some answers with single-apostrophes in them (ie: foo'bar)
- refresh the take-quiz page
- verify that the answers are still there
Also, you can see the screencast attached to the ticket for info on
reproducing the issue.
Change-Id: I3196860866dfc586b400b241c89421b5ca16ec00
Reviewed-on: https://gerrit.instructure.com/29565
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
eql? is not true anymore for this array with a user service in it.
Change-Id: I5812f0b42ec17cf9c44b6bc5e31710bba1c00e85
Reviewed-on: https://gerrit.instructure.com/29694
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
fixes CNVS-10864
test plan
=========
- add drop rules to never drop one or more assignments
- verify that the totals in Gradebook, GB2, and the student grades
summary page match
Change-Id: I1ac4a31a03b664ac6d3e92bc2cd761c69d2056b5
Reviewed-on: https://gerrit.instructure.com/29619
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
- have a user enrolled in >10 courses
- hit the /api/v1/courses endpoint as this user
- verify that only the first 10 courses are returned
- verify that you can use ?page=2 to get the next page
of results
fixes CNVS-10763
Change-Id: I1eae1a46d5c7b049fa19af6a802ab4d9fa499d2b
Reviewed-on: https://gerrit.instructure.com/29542
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-10777
test plan:
- As teacher go to GB2
- When assignment groups are weighted, total grade should not have a tooltip
- When assignment groups are not weighted, tooltip should display normally
- As a student to to grade summary page
- When assignment groups are weighted, total grade should not have a tooltip
- When assignment groups are not weighted, tooltip should display normally
Change-Id: I80db6ddfff15116a2660e387fc517149cfc0f602
Reviewed-on: https://gerrit.instructure.com/29279
Reviewed-by: Matthew Irish <mirish@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Mike Nomitch <mnomitch@instructure.com>
test plan:
* regression test user index
Change-Id: I514ebef4be0ee0e42c2ad5607da330010dd8a832
Reviewed-on: https://gerrit.instructure.com/29094
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
test plan:
* regression test context media object inline
Change-Id: If5a7685f53cba1b5a83b97b7d55f6554b1daff40
Reviewed-on: https://gerrit.instructure.com/29164
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Change-Id: I783618bc5457ea53a9d59ab36d3ccf7b7fde7b2e
Reviewed-on: https://gerrit.instructure.com/29595
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: Ie68af02a84ce4149869f4ade51d51c44c3f9b022
Reviewed-on: https://gerrit.instructure.com/29649
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* regression test add group category results
Change-Id: I1933791d655eadfdb59cb50c5f7111b10e79cd8d
Reviewed-on: https://gerrit.instructure.com/29141
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
touch no longer runs save callbacks
Change-Id: I1a0e703cfc196c77cba91d233f10a1e8ee138196
Reviewed-on: https://gerrit.instructure.com/29575
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Jeremy Stanley