fix where observers with concluded enrollments are unable to view
grades of linked students who are also concluded
closes EVAL-3319
flag=none
test plan:
- have a course with an enrolled student and an observer linked to that
student
- conclude the enrollment for both the observer and the student
- go to Prior Enrollments and act as the observer
- go to the grades page and see that it does not give the unauthorized
error and instead shows the grades page for the student
Change-Id: If6bd9e250f2bb02f4d1449f65803bd6a2e1f40ee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325927
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jackson Huang <jackson.huang@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Observers were able to filter by students who were enrolled in a future
section causing a error to be thrown in some cases. Now students in
future sections with the 'Students can only participate in the course
between these dates' will not be an option in the student drop down or
in the case of that being the only student being observed the observer
would not be given access and shown the 'Not yet available' screen.
fixes EVAL-1404
flag=none
Test Plan:
1. Have a course with 2 students enrolled and another course with 1 of
those students also enrolled
2. Create 2 sections in the course with both aforementioned students
- 1 current section with dates including the present day
- 1 future section with a start date in the future
- both with the 'Students can only participate in the course
between these dates' selected
3. Add the student in both courses to the future section and the other
to the current section
4. Create an observer and link them to both students
5. As the observer navigate to the grades page of the course with both
students
6. Ensure that only the student in the current section is shown
7. Unselect the 'Students can only participate in the course
between these dates' in the future section
8. Check to ensure both students are shown on that grade page now
Change-Id: Ia2f7ca68bd93ac5e6780ef8708727ea3372aecc7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256582
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
test plan:
* use the course people page to create a new user as an
observer in a course
* they should recieve an invitation
closes #CNVS-26611
Change-Id: I3f919a9b9907a57efa03d140f789359d0d63b92c
Reviewed-on: https://gerrit.instructure.com/74401
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
Adds the ability for observed_users to be returned to the
courses_controller#index and
favorites_controller#list_favorite_courses when
include[]=observed_users is passed to the calls.
fixes CNVS-24881
test plan:
- Create a course with two users besides the teacher: one student and
one observer.
- Set the observer to be an observer of the student
- Create an assignment and create a submission for the assignment
from the student
- Call the API at /api/v1/courses?include[]=observed_users&include[]=term&include[]=total_scores&include[]=license&include[]=is_public&include[]=needs_grading_count&include[]=permissions&include[]=favorites
- Observe in the enrollments section of the return there is data
for the observed student
- Call the API at /api/v1/users/self/favorites/courses?include[]=observed_users&include[]=term&include[]=total_scores&include[]=license&include[]=is_public&include[]=needs_grading_count&include[]=permissions
- Observe in the enrollments section of the return there is data
for the observed student
Change-Id: Ic2472cab56e6de7359e9cb908e20fd733112faf5
Reviewed-on: https://gerrit.instructure.com/66878
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CNVS-24185
test plan
- enroll an observer in a course
- ensure that the observer does not get any notifications about
the enrollment
Change-Id: I6404e589f89197ffc4e437fb1b90f540ec5cf50b
Reviewed-on: https://gerrit.instructure.com/66084
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
fixes CNVS-15156
test plan:
- with DA on:
- submission:
- make a differentiated assignment
- turn in a submission as a student
- give the student a grade
- as the student, ensure you have the notification, and then
delete it
- as a teacher, take away visibility and delete their grade
- as the student, you should not have a new notification for grade
changing
- as a teacher, comment on this submission
- as the student, you get notified about the comment
- quiz:
- as a teacher make a differentiated quiz
- students without visibility dont get notified about it
- discussion:
- discussion notifications are broken so we cant QA
- with DA off:
- submission:
- comment on a submission as a teacher and make sure the
student is notified
- grade a student as a teacher and make sure the student
is notified
- quiz:
- making & assignment a quiz sends out notifications properly
- discussion:
- discussion notifications are broken so we cant QA
Change-Id: I891f9782b5ae70252e7949a6858896b73ac28871
Reviewed-on: https://gerrit.instructure.com/41025
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes#7666
test plan:
* add a student and observer to a class; link the observer to the
student
* remove the student from the class
* masquerade as the observer, and go the grades page
* it should not error
Change-Id: I67af21e236d834511860538b89c01d313f31ac8f
Reviewed-on: https://gerrit.instructure.com/9321
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Samuel Lee