this commit fixes an issue where the gradebook csv upload would fail
if the file size was 0 bytes. the failure would not trigger the progress
object to be set to a failed state, so the UI would hang indefinitely.
fixes EVAL-4012
flag=none
test plan:
- create a gradebook csv file with no data. ensure that the file size
is 0 bytes.
- create a valid gradebook csv upload file.
- upload the file to the gradebook. the user should be prompted with an
error alert indicating "The CSV file is empty or invalid."
- verify you are upload a valid gradebook csv file and that the upload
is successful.
Change-Id: I1909dee317e9c7761ac4eeee6234a1c2aa352a52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/352988
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
closes CNVS-27034
stops dumping the file to the delayed job parameter, which was never a
good idea. This sends it to S3 or file storage and streams it from
there on import. With the current setup, way more memory than necessary
is consumed while the job is running, and this is the way we process
large files in places like SIS anyway so this makes it more consistent.
TEST PLAN:
1) gradebook imports should still work
2) gradebook import jobs should not eat memory like popcorn
Change-Id: If5bc1aab2eba01c617d6c37480fe777000d80165
Reviewed-on: https://gerrit.instructure.com/71414
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Chris Soto