Commit Graph

198 Commits

Author SHA1 Message Date
Cody Cutrer 016ae41723 lint several more idempotent schema changes in non transactional migrations
and actually enforce the linter (by setting a cutoff date for old migrations)

Change-Id: I50001b479e24b30714c37c331515b186bc089468
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:39:11 +00:00
Cody Cutrer 00f1eeeca9 bundle update rake
Change-Id: I4cdde145effb3ce7060d3c1eb280fcc75a873050
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332704
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:37:43 +00:00
Cody Cutrer 37251bea15 bundle update racc
Change-Id: I07bf6a8a8f344a95b59f172d512fbe5affbfe64a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332703
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:37:24 +00:00
Cody Cutrer d1db9417e5 bundle update irb
Change-Id: Ia88628eefb81c9cd53308260a1fd99ec1ff63b73
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332699
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:36:05 +00:00
Cody Cutrer 3d6f5bb1d3 bundle update base gems
Change-Id: I459650c8b3bc332aa1e1f8f0927d1f41b69939d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332696
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:34:17 +00:00
Cody Cutrer ec2a6a9e2d lint that datafixups strand downstream jobs
fixes AE-496

Change-Id: I9808be8abb432c0813a043f876d336ecd92397e2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332715
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 19:36:10 +00:00
Cody Cutrer b878286167 bundle update racc
Change-Id: Ie99af6c789f1ebbf37e0cf1d6ac5bdc8f9a28439
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331820
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-03 13:24:46 +00:00
Cody Cutrer 07e2f4f3a1 bundle update rubocop-rails
Change-Id: I27eca23d33ed1e935cfcdeba14e4c59b883c17fa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331606
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-30 20:41:45 +00:00
Cody Cutrer 6dc5a62f5b bundle update irb
Change-Id: I2a662a0e1061a7b3c08f2c8aeeffc6f02b60ab2d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331114
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-27 21:12:08 +00:00
Cody Cutrer 9df794a20c bundle update thor
Change-Id: Id5f6dc47d0a42ab31a98d25ada621858b12c2189
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331117
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-27 21:10:40 +00:00
Cody Cutrer bf74e3b33f bundle update mini_portile2
Change-Id: If2eafbfb030736865ab2b54c5e107eedff1c06e8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331115
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-27 21:09:56 +00:00
Cody Cutrer b76ac95f7d bundle update psych
Change-Id: I399c8da6e9441905d8cf53af1aa86a90eaba9de0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331113
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-27 21:08:07 +00:00
Cody Cutrer e639661b1e bundle update rubocop
Change-Id: Iff17ea17d38ceec199edcf37781d7ce16171573f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331120
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-27 17:05:57 +00:00
Cody Cutrer a260921309 bundle update loofah
Change-Id: Ib83abefa015737d06b1291609df89789530550ff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330094
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-11 14:32:07 +00:00
Cody Cutrer 7b82e24803 bundle update psych
Change-Id: If2d1d6952d1fa6ea336fbac07dcb6aa6568a2837
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330092
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-11 14:31:36 +00:00
Cody Cutrer cbcfaad422 bundle update rubocop
Change-Id: Ifdf9bc5694376dd37be073d17a6ef1ae42074add
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330091
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-11 14:30:59 +00:00
Cody Cutrer b4a5283325 bundle update outrigger
Change-Id: I0dd92d8dbabdef34b29cd9c3618b96f01be07daf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329686
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-06 21:15:25 +00:00
Cody Cutrer f724a2343a bundle update parser
Change-Id: Idb75b78e56a8aee5211c82274f940d73f3aba7ba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-04 21:31:55 +00:00
Cody Cutrer 72a244f5cc bundle update reline
Change-Id: I58b3c155203308f8f3589e341d925bec908336ba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329313
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-04 15:16:46 +00:00
Cody Cutrer 5ce6049cd7 bundle update rubocop-rails
Change-Id: Iec06836b5498954eedcc8782961043f804fb7559
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329159
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-02 17:51:10 +00:00
Cody Cutrer 4d68265e3c bundle update unicode
Change-Id: I794fcd04f3d224eb477918740c001e2657cc6b6c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/329158
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-10-02 17:51:00 +00:00
Cody Cutrer bd0097b762 bundle update --bundler
Change-Id: I20dc6723943fc442865dad2fb68d512d7b98459a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328959
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-29 15:42:35 +00:00
Cody Cutrer ee75c847da bundle update rubocop
Change-Id: I6e4b876b20c72038862ab32294df49950402f899
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328928
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
2023-09-28 14:54:28 +00:00
Cody Cutrer 30c5ab7e51 bundle update zeitwerk
Change-Id: I7a6fcbf9b07a46d87264bea187581bdcc6ed8646
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328625
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-26 14:23:19 +00:00
Cody Cutrer 22b7677b3b switch from byebug to debug
It's the new default debugger in ruby 3.1. Rails switched to it in 7.0,
avoids issues with Zeitwerk, has a more modern interface based on
current IRB, supports Unix Domain Sockets for remote debugging,
promises even better future maintenance due to being part of Ruby,
etc.

Change-Id: Ieaa7872f1c0308b16ae180fdb16df5dd6caa87a8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328241
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-20 23:48:39 +00:00
Cody Cutrer 59af724f62 bundle update rubocop-rails
Change-Id: I8bdd3d631c11eb0043f2b8fdfcc69611fa0f90bc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327828
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-09-15 21:43:53 +00:00
Cody Cutrer c32ccde352 bundle update rubocop
and apply Rails/SelectMap and Rails/RedundantActiveRecordAllMethod

the offenses in User were manually fixed to maintain sharding
correctness

[skip-stages=Flakey]
[skip-crystalball]

Change-Id: I96f877ee8474655bd62a149f3aa54b312d38a5e4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327334
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-09-13 13:31:05 +00:00
Cody Cutrer f4d059689f bundle update rails
Change-Id: Ie89256cf0eff7ac0adbdb590248cfbe548f8353c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327335
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-09-13 13:30:05 +00:00
Cody Cutrer 6dff8b8bfe bundle update factory_bot
Change-Id: I8a72032faaa8aa359a7b34b041633c947f3801b9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326814
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-11 16:04:11 +00:00
Jeremy Stanley 5532285bc6 don't give bad advice about add_replica_identity
g/325983 requires `add_replica_identity` to be in a separate
migration from the commit that creates the table, for
complicated DBA reasons. change the phrasing of the
Migration/RootAccount cop so it doesn't contradict the
newer Migration/SetReplicaIdentityInSeparateTransaction

test plan:
 - make a new migration that creates a table
   and does not do `add_replica_identity`
 - the cop should tell you to do that in a different migration
   and not after the `create_table` block in this one

flag=none
refs AE-443

Change-Id: Id37914399d40739e9fd8a72b90745c29d9e7cbda
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326791
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
2023-09-01 18:53:02 +00:00
Cody Cutrer 9f0be6b653 bundle update rubocop
Change-Id: I442d7399c7631a39f1bcadf06f97e2d0902f7868
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326447
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-31 19:20:57 +00:00
Cody Cutrer f4c34f6393 bundle update --bundler
also, don't set BUNDLER_VERSION env var in Docker, so that
bundler's auto-install-and-restart-with-the-correct-version
feature can work

Change-Id: I8e3722197fb3598b5c40679d997f19b3b3957ea8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326580
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-30 23:31:39 +00:00
Cody Cutrer 6f5fabb3bc enforce that set_replica_identity isn't in the same migration as its create_table
closes AE-443

Change-Id: I1cd910d59c5447a6d283e97b9a396339143ad2a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325983
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-08-28 23:32:51 +00:00
Cody Cutrer 1397092957 bundle update rails
Change-Id: I8c3e93b99f9656e64520400e1ee10123b836a075
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325864
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-22 22:23:08 +00:00
Cody Cutrer dd453ba37c bundle update rails
Change-Id: I39eb3799ab011b16fb2cb448f032ffafd21087d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325834
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-22 21:18:44 +00:00
Cody Cutrer 3bdca1ff92 bundle update rubocop
Change-Id: I6fd6d6ac27554ed95c2c1473c6c53ff54c6d7329
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325720
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-21 23:37:19 +00:00
Cody Cutrer 5088ae332d bundle update nokogiri
Change-Id: I6f47dd35205d7d463e93dcfdca032080d7626272
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-21 19:08:06 +00:00
Cody Cutrer d2bc4a9d38 bundle update rack-test
Change-Id: I242eac144911d29481e5169232409b61e9a647a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325585
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-18 20:19:43 +00:00
Cody Cutrer 067af65314 bundle update rails-dom-testing
Change-Id: I1a15e312907f9728e657897677737afa219ea0f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325520
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 23:00:22 +00:00
Cody Cutrer d7e49a55cf bundle update parallel
Change-Id: I16bd4467b67fa1b3c7947712b5aac45cb8258ad3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325514
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 22:59:17 +00:00
Cody Cutrer 6347778e4e bundle update tzinfo
Change-Id: Iea47a60ee8056b761d38ef854aa44ccb435bc585
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325486
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 19:37:28 +00:00
Cody Cutrer 37c355a671 bundle update regexp_parser
Change-Id: Idd859875b4167b399472550da333620f0f6370d1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325477
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 19:36:31 +00:00
Cody Cutrer e1a6ca4982 bundle update rubocop
no new cops, but a few fixes to existing cops (notably
Style/RedundantReturn)

Change-Id: I64a744c3d81e25329c1612e4622ca96783b0801d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/324942
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-14 16:32:06 +00:00
Cody Cutrer f450de57b6 bump rails
Change-Id: Idf23d6f1926efb208d8d8b3e6f9629676b4bdb76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/324918
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-11 17:42:20 +00:00
Cody Cutrer 5de85fb2d3 bump rails
Change-Id: Ia59f4a8831c6bfc6f44d6490f7f2f5dbf43c0006
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323855
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-08 17:30:30 +00:00
Cody Cutrer ccba9e75b1 bump rspec-related gems
Change-Id: Id53c1d31be838972bcfb5c45dd9d9861aa240752
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323856
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-07 20:13:45 +00:00
Cody Cutrer 8f8f6f7313 bump rubocop gems and apply changes
[skip-stages=Flakey]

Change-Id: I5f080be6efb64351b4a89e6bd6040bc6f0432e82
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323854
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-07 20:13:35 +00:00
Cody Cutrer aa7041d2c1 update rubocop, and apply new cops
[skip-stages=Flakey]

Change-Id: I2d3ffbeb652a6668941125a8a2afe87f104c8d0a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321953
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-07-03 22:11:42 +00:00
Cody Cutrer 399181bb27 bump rails
Change-Id: Ia540a9ccc668e7dab62cda642b6eb9da2b661604
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321691
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2023-06-30 19:07:11 +00:00
Cody Cutrer 003e65f3aa bump rails
Change-Id: Ib9a7f75fde9d85ac8d650ae2cad1b00cd5f98a4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320432
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-06-27 19:06:17 +00:00