and actually enforce the linter (by setting a cutoff date for old migrations)
Change-Id: I50001b479e24b30714c37c331515b186bc089468
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
fixes CANVAS-MKX9
flag=none
test plan:
- canvas doesn't error on boot with `:nodes` defined
Change-Id: I6b15737d380f3003d9600db0de8b6e6de6363543
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332346
Reviewed-by: Ethan Fox <ethan.fox@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Change-Id: I2a662a0e1061a7b3c08f2c8aeeffc6f02b60ab2d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331114
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Id5f6dc47d0a42ab31a98d25ada621858b12c2189
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331117
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: If7630a45e0fd1105a5f3e51c9d6c6c1d6bdcdbf4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331116
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: If2eafbfb030736865ab2b54c5e107eedff1c06e8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331115
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I8ef1f67cda81f62017307081163f8a7bd4a80d06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331118
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I399c8da6e9441905d8cf53af1aa86a90eaba9de0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331113
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Idc6e52600bbf2e7d838c1b2fa53d65b13749f40e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331112
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Ie11064ce39d8d5d8b32adf7a47ee65a6dd053df5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330264
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
refs CNVS-60234
`...` was stuffing the failsafe kwarg into a hash as the
first non-kwarg
Change-Id: Ia0b468416be130e1134b5e814f69faac9581f9f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331323
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
to specify the (singular) key you will operate on, so address
a specific node when it's a distributed redis client
Change-Id: I9c4c0ab7114ea491439b42e4f4310f81470422a7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331131
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
need to run the pipeline against a singular node
Change-Id: I33befbf4e11daaf5942c37af9233d8f90adde732
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331124
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes INTEROP-8239
flag=lti_resource_link_id_speedgrader_launches_reference_assignment
Why:
* Some places (notably, launching an LTI assignment) override the
resource_link_title to have the Assignment's title (cf.
app/controllers/application_controller.rb:2120).
* But when launching from
SpeedGrader (e.g. when grade passback has returned a LTI launch for a
submission), this code path is not followed, so resource_link_title is
not overridden, and it falls back to the tool name.
* Because we actually have an assignment context in this launch, we
should use the Assignment's title.
* This also expands a fix in 59674c92 which set the resource_link_id,
but only for New Quizzes tool launches (unclear why)
* Note: this does not affect LTI 1.3 -- when launched in speed grader,
the https://purl.imsglobal.org/spec/lti/claim/resource_link claim
(and similar title claim) are still the course. But LTI 1.3 tools can
use the $ResourceLink.id and $ResourceLink.title expansions to get the
assignment info.
Test plan:
- Have an LTI 1.1 tool with assignment_selection placement (for
ContentItemSelectionRequest)
- create an LTI 1.1 assignment
- create an LTI 1.1. launch submission. I did this by:
* save to a file the example XML under "LTI Launch URL" at
https://canvas.instructure.com/doc/api/file.assignment_tools.html
* launch the LTI 1.1 tool, and in devtools, grab the sourcedid in the payload.
put this into the XML file to replace the dummy sourcedid there.
* send a passback request, e.g., from a rails console (replace your
host, tool ID, and filename):
def grade_passback(host, tool_id, xml)
tool = ContextExternalTool.find(tool_id)
consumer = OAuth::Consumer.new(tool.consumer_key, tool.shared_secret)
client = OAuth::AccessToken.new(consumer)
url = "http://#{host}/api/lti/v1/tools/#{tool.id}/grade_passback"
client.post(url, xml, 'Content-Type' => 'application/xml')
end
grade_passback("web.canvas-lms.docker", 123, File.read("gradepassback.xml"))
# where 123 is the tool id
- view the submission and speedgrader
- with the feature flag off, lti_resource_link_id and
lti_resource_link_title should correspond to the tool
- with the feature flag on, lti_resource_link_id and
lti_resource_link_title should correspond to the assignment
- optional: test a non-assignment launch to make sure resource_link_title
is still the tool name.
- optional: test a module item launch to make sure resource_link_title
is still the module item name.
Change-Id: I71940c88581edb0255c020a882abfeca228537c1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327925
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Cody Cutrer