Chrome OS has a long-term support (LTS) channel which is updated every
6 months. Some schooles have chosen to use this channel for their Chrome
OS updates. Unfortunately, the LTS distinction is not reflected in the
User-Agent string.
This change checks if the browser is Chrome running on Chrome OS and
compares it to the minimum version specified in the configuration file.
This does mean means that slightly older versions of Chrome on non-LTS
Chrome OS will also be be allowed to run Canvas without warnings, but
that's better than not allowing LTS versions to be supported at all.
flag=none
Closes FOO-3343
Test Plan:
- Visit a page in Canvas with a browser that is running an LTS version
of Chrome OS that is older than the latest support Chrome.
- You can spoof this in Chrome dev tools by changing the User-Agent
under "... > More Tools > Network Conditions".
Change-Id: Ic9cadd20a6170f144103249daba6d729ba41e47c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311263
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
closes: DE-1483
Test Plan:
- new image starlord.inscloudgate.net/jenkins/selenium-node-chrome:107.0
- Jenkins build uses chrome 107
- No failures in Jenkins
Change-Id: I31f453d34dcfcbc71c88b3bc379380bbd17ef133
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/306441
QA-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
refs FOO-2964
some partners are based on chrome versions just a touch outside of what
we've recently updated to support. we can open up a few additional
versions to continue to include them.
Change-Id: I1a141b69757415306d31042de676426bb486d185
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293697
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Ben Rinaca <brinaca@instructure.com>
Product-Review: Ben Rinaca <brinaca@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=none
This file controls the "you are on an unsupported browser"
alert message and should be updated to reflect the most
recent version minus one of our supported browsers. In
this case I used the "long term support" version of
Firefox (current 91, last 78), along with version 98 of
Chrome and 14 of Safari.
Test plan:
* you agree with the browser versions listed here
Change-Id: Ia967dcf387c3b963c830e180394b1a0b35781e63
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/292214
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
flag=none
This file controls the "you are on an unsupported browser"
alert message and should be updated to reflect the most
recent version minus one of our supported browsers. In
this case I used the "long term support" version of
Firefox which is 91, along with version 94 of Chrome
(because that's what our own seleniums test against in
Jenkins) and 15 of Safari.
Test plan:
* you agree with the browser versions listed here
Change-Id: I1f2c026e689f72c9e4493538abebdc5a32e1ec23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/292135
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
This reverts commit 5424423ad5.
Reverting because this is causing issues for some customers.
Change-Id: I40bd487237bbbe66d98ffb96fc86dde83dd8e80e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230131
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
we recently upgraded our test browser to chrome 78 so we can make
this file match.
flag = none
Change-Id: I46548ab165d0d66c11040938fc47808b9d1ccdf3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/222655
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Rex Fleischer <rfleischer@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Current version of Chrome is 78; Firefox is 70
CLOSES: DOC-1154
Test plan:
- specs pass
Change-Id: I29466e7fe5ae0908fa11a54788d0537658bb9a8c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/218451
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This file only manages the warning banner that displays
for customers that are using a browser below the minimum
supported version. We need to bring the banner back for
users of Firefox below version 68. Firefox is already at
version 69 as of this ticket date, and Firefox ESR 60
has an end of life at the end of October; users need
to upgrade before then.
CLOSES: DOC-1107
Test plan:
- Jenkins passes
Change-Id: Ie842b54230cec3d7488d96d0bc11a4db0cb98851
Reviewed-on: https://gerrit.instructure.com/208290
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Erin Hallmark <erin@instructure.com>
Product-Review: Erin Hallmark <erin@instructure.com>
Closes: COREFE-251
If their login flow requires any javascript to actually execute
that will probably still not work since if it is our javascript
it will probably have syntax ie11 can’t understand but
if all they need is the server-rendered html & css of the login page
this should let them do that
This also ups the “minimum supported ie version” to 12. So that if
they do get to the login screen, and javascript actually works, they
will see something like this: https://cl.ly/e192872f4a66
Test plan:
* try to login from ie11
* it should show the login screen and let you login but once you hit
Submit, on the page that loads after, it should redirect you to the
Ie-is-not-supported.html page
Change-Id: I8dc93cf2a5810a7e189cef05ba26c390cd9e16e0
Reviewed-on: https://gerrit.instructure.com/208125
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Closes: DOC-1088
We are trying to keep this file more current to reflect
broswers supported by Canvas. Firefox will continue to
show the most recent version of ESR, since most ESR
customers use Firefox. Chrome ESR users can set their
own version and should be using one of the most recent.
Test plan:
- file notes chrome minimum as 67
- jenkins passes
Change-Id: I3a2f2b4c3d2d92cae40b18c9086716ee1ec6daf4
Reviewed-on: https://gerrit.instructure.com/201124
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Erin Hallmark <erin@instructure.com>
Product-Review: Erin Hallmark <erin@instructure.com>
refs CORE-2793
useragent hasn't been updated in years, and browser gives us more features
for detecting mobile platforms easily
test plan:
* use a modern browser
* nothing should change
* use an old version of IE, Chrome, Safari, and/or Firefox (or spoof
the user agent string)
* should still get a warning about an unsupported browser
Change-Id: I57707a49d4e6cd9c4389103acb546a9eadbb36f3
Reviewed-on: https://gerrit.instructure.com/190809
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
ESR users are seeing the warning banner
and would like to see it removed; the
only way to do that is to lower the Firefox
version to 60 from 64. Firefox 60 is the
top-level ESR offered by Firefox.
Chrome Enterprise allows admins to pin
at any version, so we will not adjust
the Chrome browser number.
Closes: DOC-1047
Test plan:
- specs pass
Change-Id: I8723093637b8df297210538abdf459b0b1e584d8
Reviewed-on: https://gerrit.instructure.com/190491
Tested-by: Jenkins
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Test Plan:
- All specs pass in FF and Chrome
- Code Review
Change-Id: I4373f1396aaa892aec19ba8f9bb20a89ec44c8e8
Reviewed-on: https://gerrit.instructure.com/122992
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
fixes CNVS-30456
Test Plan:
- All specs pass in FF and Chrome
- Code Review
Change-Id: Ia891e2ceb8f0379554f4424cb1761d4d3a792a84
Reviewed-on: https://gerrit.instructure.com/85439
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
This reverts commit e0dde74179.
Change-Id: I7a23936e4a3ad13f1552a9fc9ca10b5c4c4d737f
Reviewed-on: https://gerrit.instructure.com/85437
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jon Jensen <jon@instructure.com>
closes CNVS-30456
Test Plan:
- All specs pass in FF and Chrome
- Code Review
Change-Id: I797c44055693539b88a002265155eef0e8207ab6
Reviewed-on: https://gerrit.instructure.com/85426
Reviewed-by: Pedro Fajardo <pfajardo@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes CNVS-17785
our guide on 'guides.instructure.com' says
we've dropped support for a lot of browsers that
we still don't show a message to.
This updates the config file to match what's
currently documented on our guide
so users using browsers we don't officially
support get the standard browser warnings.
Change-Id: If90038fa8620b685bb0dc9d6e185d1c5f3f41386
Reviewed-on: https://gerrit.instructure.com/46616
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes #CNVS-12517
test-plan:
* with chrome 33 & 34, verify browser warning does not display
* with safari 6 & 7, verify browser warning does not display
* with firefox 27 & 28, verify browser warning does not display
* with internet explorer 10 & 11, verify browser warning does not display
Change-Id: I8a86dcef641c8c2b936097237e239320e6b0190c
Reviewed-on: https://gerrit.instructure.com/33493
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
treat minimums as a blacklist, and assume that anything we don't recognize
is supported
test plan:
1. load canvas in unsupported browsers (e.g. IE 8), confirm you get a
warning
2. load canvas in supported browsers (e.g. IE 9), confirm you don't get a
warning
3. load canvas in an unknown browser (e.g. Android), confirm you don't get
a warning
Change-Id: I87ed90e97d031431f6a48c814dfa874b785ea777
Reviewed-on: https://gerrit.instructure.com/18801
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
test plan:
1. use canvas in any supported browser (including mobile)
2. you should not see a warning
3. use canvas in an unsupported browser (e.g. ie8, old firefox)
4. you should see an orangish warning at the top of every page
5. it should not be dismissable
Change-Id: I092455c416a754d102ddadbda99280856b4082de
Reviewed-on: https://gerrit.instructure.com/18524
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
Jason L Perry