Test plan:
- Add a new .js or .jsx file
- Create a new commit locally
- A warning should appear
flag=none
Change-Id: If4d389e67e86d3dda48c33d8adc12b624f3269a2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332764
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes FOO-4051
flag = temporary_enrollments
test plan:
• ensure temporary enrollments feature flag is enabled
• have a recipient and provider or temporary enrollments
• visit /accounts/self/users
• verify
• a temporary enrollment icon for finding a recipient
• a temporary enrollment icon for listing recipients
• a temporary enrollment icon for listing providers
Change-Id: If7d05e907d8ab305a2b38c567ef6f40d644646c3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332724
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
and actually enforce the linter (by setting a cutoff date for old migrations)
Change-Id: I50001b479e24b30714c37c331515b186bc089468
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
closes LF-737
flag = differentiated_modules
Test plan:
- Go to the modules and edit one
- Expect to see the loading overlay while saving
- Expect the tray to be closed when the request finishes
- Tray to edit a module again, but this time make the
request fail
- Expect the tray to keep open but the loading overlay to be closed
- Verify this also works for the Assign to tab
Change-Id: Ic648f0163eaf1d747341e11161e49b4a3bbe7c51
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332548
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
flag=react_inbox
fixes VICE-3764
the issue referenced in the ticket was a regression caused by
https://gerrit.instructure.com/c/canvas-lms/+/310218
the 2 consts defined outside of the boundingBox hook
meant that whenever the hook is triggerred, it doesn't
use a fresh value for isFullScreen and isEmbedded,
which, in react inbox's case, had ended up always being
null
by putting these const declarations inside the hook,
we ensure that both consts are fresh when they are needed
to determine if we are embedded, or in full screen mode
test plan:
- enable kaltura plugin /plugins/kaltura
- ask caleb for plugin credentials
- visit inbox
- send a message with a video
- view the message you sent
- verify the video thumbnail
shows the full video picture and not
super zoomed in
- switch to full screen
- verify that full screen sets video to full screen
Change-Id: I41f052358028f9490d382567dae5d181d425f5c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332705
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
they'll get updated when their primary record does
also ensure we select root_account_ids, so that the refresher
doesn't have to save every record if it didn't change
also ensure other columns are selected that callbacks would
fill in a default if they're not present
Change-Id: I2950916cb3d574eddd8ffc7f02b27ccdc6baca57
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332727
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fix issue where the late policy was not being applied for multiple
attempt submissions on a quiz with an essay question that has not been
graded
fixes EVAL-3619
flag=none
Test Plan:
- create a late policy that has point deductions
- create a classic quiz with more than two questions that allows for
multiple attempts and is also late
- have at least one of the questions be an essay question or a
non-automatically graded question
- have the rest be automatically graded question such as a true or false
question
- have the student take the quiz twice
- go to speed grader and confirm that the grade in the input box is
correct by adding all the scores of the correct quiz questions and
does not have the late penalty added upon it
Change-Id: I42f71ecaa2218dfee14e371fefea728f34429c64
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331812
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
closes VICE-3882
flag= create_discussion
Exclusion, does not work for updating a discussion assignment
That work is blocked by VICE-3891.
Test Plan
1. in graphiql create a new graded discussion
2. Verify that the post_to_sis boolean is set correctly
Behaviors
1. if input is not provided, it shoul dbe false
2. Otherwise the post_to_sis follows the given input
Change-Id: I2a7705558369729c590b473c5a7e83214cde3ff6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332620
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
We made a change a few months back that changed the way we were finding
the observer enrollments when fetching assignments from the api. This
caused cross shard observer enrollments to not be found. I kept around
the change to ensure the bug it was fixing is still fixed, but brought
back the original context_enrollment to ensure that cross shard
enrollments are found.
closes EVAL-3617
flag=none
Test Plan:
- enroll two users that are not observers in a cross shard course
- enroll one as a student and the other as an observer that is
linked to the student
- make a few assignments and give a few grades to the student
- as an observer hit the assignment group api endpoint (this is
used by the mobile app to fetch the assignment and submission data
for the gradebook)
- GET /api/v1/courses/:course_id/assignment_groups
-include[]=assignments,submission,observed_users,score_statistics,
discussion_topic,all_dates
-ensure the submission data is returned for the observed student
with the appropriate scores
Change-Id: Ie25608ca164250434f63b2d78ebc21230a1cc889
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330778
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Samuel Lee <samuel.lee@instructure.com>
QA-Review: Jackson Huang <jackson.huang@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
testing to be performed on
https://gerrit.instructure.com/c/notorious/+/330646
refs: DE-1663
Change-Id: I57e275860b2941a125a4780dcefdf3dddd1dda6f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330818
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
This commit expands the CustomUseQueryOptions type to include all the
type parameters of the underlying UseQueryOptions type hook. This allows
us to infer the type of parameters to the queryFn parameter
test plan:
Typechecks pass. There are no runtime changes in this commit
flag=none
Change-Id: I94b1c15291b2165a0f5cb594300296af278d8611
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332384
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes OUT-6011
flag=none
The header and carrot nav icon need to be updated in
LMGB to match current designs for the navigation epic
Test Plan:
- Open a course with LMGB enabled
- Make sure that the LMGB Redesign FF is disabled
- Navigate to "Grades"
- Ensure that the Gradebook Menu renders according
to figma designs found in the ticket
- Ensure that the dropdown menu correctly navigates
to all other available gradebooks for the course
Change-Id: I57ac9e04344ef8f38fc8df859f377e2bfaa8172d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332031
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Yosifov <martin.yosifov@instructure.com>
QA-Review: Martin Yosifov <martin.yosifov@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
why:
* make it very clear when this API is supported
and what to do when it's not
closes INTEROP-8273
flag=none
test plan:
* info is accurate
Change-Id: I158a6264d044c911020cf97367f332df85a33d03
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332247
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Hawkins <ryan.hawkins@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
This updates the temporary enrollment modal to use the
latest/updated API enrollment fetch params.
refs FOO-4041
refs FOO-4019
flag = temporary_enrollments
test plan:
- tests pass
Change-Id: I0e743ec1d7d2865a514b552c41257e965a40aeee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332610
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Michael Hulse <michael.hulse@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
refs FOO-4041
refs FOO-4019
flag = temporary_enrollments
test plan:
• enable temporary enrollments feature flag
• have a temporary enrollment recipient and provider
• make a call to GET /api/v1/users/:user_id/temporary_enrollment_status
• verify the response contains the recipient and provider
temporary enrollment status if that user is a recipient or provider
/doc/api/enrollments.html#method.enrollments_api.temporary_enrollments
• create a user with an active temporary enrollment and an
enrollment that is completed
• fetch /api/v1/users/:id/enrollments with the provided args
• temporary_enrollments_for_recipient=true
• include=temporary_enrollment_providers
• state=current_and_future
• verify that the response includes the current temporary enrollment
with an included "temporary_enrollment_provider" object
• fetch /api/v1/users/:id/enrollments with the provided args
• temporary_enrollment_recipients_for_provider=true
• state=current_and_future
• verify that the response includes the current temporary enrollment
for the specified provider
Change-Id: Ie547fea0cf2a0ee383a94a5e44a07a7ad24de0f7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332550
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
closes LF-994
flag = none
Test plan:
- wait for the package-translations job to run
- make sure the resulting commit has complete translation sets for
vi, th, sv, and ru (these were the only locales with translations
in both s3 and transifex; other locales should not be affected as
they were only present in a single source)
Change-Id: Ia78c006fe30290256813938c7a87d2c7d9cdb116
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332518
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
this commit adds the foundation for react-query to the rubrics redesign.
it also uses new graphql queries to return rubric data to the front end.
closes EVAL-3616
flag=enhanced_rubrics
test plan:
- navigate to /accounts/<id>/rubrics
- verify that if the account has rubrics, they are displayed in the
table
- navigate to /courses/<id>/rubrics
- verify that if the course has rubrics, they are displayed in the table
Change-Id: Ib340a37ad1c3a3d28413b3e8cfce359aa3f5db7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331718
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
The updated grading scheme selector and editor was not available in
discussions. This commit adds the grading scheme selector and editor to
graded discussions.
closes EVAL-3649
flag=grading_scheme_updates
flag=points_based_grading_schemes
Test Plan
- Enable 'Improve Letter Grading Scheme Usability'
(grading_scheme_updates) site admin flag
- Enable 'Points Based Grading Schemes' flag and create one
- Set a course level grading scheme
- Edit a discussion
- Select Graded
- Select 'Display Grade As' to Letter Grade or GPA scale
- Test selecting of assignment grading scheme,
and adding, removing, editing, and managing of course
level grading schemes
- Ensure it works exactly as the assignment edit page
Change-Id: Id5e2742d85af686e9e6bfba3c842fabfe6419b36
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332212
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Jackson Huang <jackson.huang@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Closes LF-988
Test Plan: passes Jenkins with and without CI turned on for
differentiated modules.
Change-Id: I9e6c6eeea91baeaae1a5b24510c363b8e1daf7ed
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332295
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
issues:
- click a card with the tray open and focus is not on close button
- buttons in the tray do nothing
- no links to open badges or Lightcase (where will these come from ?)
refs VICE-3932
flag=learner_passport
test plan: n/a
Change-Id: Id289b01842ec52a2dcb93f5db194071c91fd9205
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332261
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Suggs <aaron.suggs@instructure.com>
QA-Review: Aaron Suggs <aaron.suggs@instructure.com>
Product-Review: Aaron Suggs <aaron.suggs@instructure.com>
Fixes FOO-4042
flag=none
The new react-router initializer was getting called
very early in the front end boot process, sometimes
completing before all of the required capabilities
have loaded, such as I18n. Since the loading router
provider includes a fallback component which calls
I18n.t, sometimes the translation file for the user's
locale would not be loaded before that fallback
component rendered, resulting in an Eager Lookup
Violation to be logged.
This just makes sure that translations are loaded
before firing up the React Router.
Test plan:
* automated tests pass
* components that use the React Router still work
* we won't know if this really fixes the issue
until and unless the logged Sentry errors go
away
Change-Id: I490b662c2b4bbbb9631ba0e912c3d3ad6d4cee8c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332535
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Jenkins