with bundler-multilock, you might get a _lot_ of warnings, since this
gemfile fragment is used multiple times
Change-Id: I8683044d3c08d70bad9e2d72e9f36d39d8b27122
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351019
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
closes RCX-1839
flag=none
Test plan
- Test with https://github.com/instructure/canvas_link_migrator/pull/34
- Have a link in rich content that looks like
<iframe title="media file" src="media_objects_iframe/media_id?type=video" data-media-type="video"
data-media-id="undefined"></iframe>
- Ensure it points to a valid media object that doesn't have an
attachment in the course
- Copy the course and ensure the link comes over
as a media attachment correctly
Change-Id: I1712ce7e31e74b22028256c8d098577074102cad
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346989
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
fixes RCX-1948
flag=file_verifiers_for_quiz_links
Test plan
- Create links to files in an Old Quiz
- Create links to files in other areas
of rich content in Canvas
- Copy and export/import and ensure old Quiz
to old Quiz or other rich content Canvas areas
links should not get verifiers
Change-Id: I7b2c3f5715b72633382f18dc06b7e7a33a4169c4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349361
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
and apply new cop 99% Style/SuperArguments
and a couple Layout/EmptyComment and Style/ArgumentsForwarding that
are found by fixes in those cops
Change-Id: Icc0af9c8065f035bca43868b564f73e8776052f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348626
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
This reverts commit 63a05bc983.
Reason for revert: bundler 2.5.10 is now available as a system gem on our servers
Change-Id: I53031bd6b11a30184cf6b584f72f72892c09dc35
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348271
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
This reverts commit 698049fdf0.
Reason for revert: Passenger isn't loading the correct version of bundler, and the new version causes a conflict with the old version
Change-Id: I030f29872e6052c0af59ae8d7810725189261170
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345745
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
test plan: Enable the feature flag translating the
inbox message for current user.
Go to inbox, click compose. Verify that checkbox is
at bottom of screen. Click checkbox,
select language, and select message position.
Also turn on Inbox Settings QW flag, set
signature for message, and verify that signature
persists after translation.
flag=translate_compose_message
refs ADV-105
Change-Id: I72d34b05771ff6a845fa2a76e8e66c6abb373abf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347122
Build-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Windle <jacob.windle@instructure.com>
Product-Review: Jacob Windle <jacob.windle@instructure.com>
Add `cohere.embed-multilingual-v3` as new embedding strategy for smart
search.
Test plan:
* Add bedrock creds to rails credential store
* Make sure that background jobs processor is running
* Open search page on existing indexed course
* Confirm that course is re-indexed and run searches
* Confirm that newly enabled courses are also index properly
flag=smart_search
closes ADV-98
Change-Id: I664a954f34e5c474db0b210f2ae092f891d60f89
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346524
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jacob Windle <jacob.windle@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
test plan: Put translation AWS credentials into Canvas vault.
Create a test discussion in new discussions UI. Enable feature flag.
Click the kebab menu icon on discussion post page, click show translation.
Select a language from translation dropdown menu. Ensure loading icons and translations
are happening.
flag=translation
refs ADV-100
Change-Id: Id86f53184b31e504fe3736bab9e5b15b47a87e5d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346282
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Jacob Windle <jacob.windle@instructure.com>
Product-Review: Jacob Windle <jacob.windle@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes LF-1550
flag=none
Test plan
- In Canvas, create a link like <a id="media_comment_m-media_id"
class=" instructure_video_link instructure_file_link"
title="title.mp4" href="/courses/1/files/1/download?wrap=1">Text</a>
in rich content
- Copy the course and verify it copies the page and the link looks correct after copy
(the data media id doesn't update if you put one, but that seems
unrelated)
Change-Id: I1704be7e3c8d0c954366aa2367ca4f9526167151
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346585
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Cody Cutrer