This reverts commit aa04a41504.
Reason for revert: something about the order of guard clauses trips up retrieve launches for LTI 1.3 tools, like embedded content. easy enough to nail down and fix but it's affecting so much that we will just revert first and fix later
Change-Id: Id9dc816d784ff6d042f35aa3d1ae71633756f452
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282047
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
fixes EVAL-2138
flag=none
test plan:
- have a course with atleast one student and one
assignment.
- create a file upload assignment with a past
due date.
- submit a file to the assignment as the student.
- make an annotation in the submission.
- view the annotation as the student.
- go back to the speedgrader and notice the text
does not overlaps.
Change-Id: Iddbc1804dda1ef2756b71bcc9b0ef26a27d9c3cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283017
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
fixes EVAL-2105
flag=none
test plan:
- have a course with some students and one assignment.
- enable the feature flag "Comment Library".
- go to the speed grader for the created assignment.
- select he comment library option.
- create at least 30 comments in the comment library.
- scroll down the list and double click on a selected
comment.
- notice that when pasted it is the right comment that
was selected.
Change-Id: Id184a5d65cc94a3b98fceda7d30159ba62252f25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282954
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
closes MAT-401
flag=rce_a11y_checker_notifications
Test Plan:
- Enable the rce_a11y_checker_notifications flag
in your root account
- Create a page in a course with an image that
has no alt text
- Verify the notification bubble on the A11y checker
button now matches the the InstUI "info" color
- Turn on high contrast mode for your Canvas user
- Repeat the above steps and verify the "info" color
matches still
Change-Id: I4dd342a88afc96e1d1c043edda77432649c405cd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283045
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Change-Id: I1d8305402c73e677a66bae6bcc7343302a98510b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283137
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Defer errors until the Canvas URL provided by the RCS is actually needed
See https://instructure.slack.com/archives/C01M74AT65A/p1642114749205300
flag=none
test plan
- Ensure you don't have an RCS running
- Go to a page that contains an RCE
- Validate that when the page loads, there are no RCE-related errors in
the console, and no "Something went wrong" message shown on the page
- Insert an equation
- Validate that some errors about RCS are displayed on the console, and
the "Something went wrong message" is shown on the page
- Validate that the equation still inserts
- Switch the RCE to HTML view
- Validate that the equation image URL is relative but otherwise valid
(i.e. `/equation_images/<LaTeX>`)
Change-Id: Ic52aaead39e44b58cf9dd1be24f4530336acbdca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282947
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Brian Watson <bwatson@instructure.com>
Reviewed-by: Gonzalo Penaranda <gonzalo.penaranda@instructure.com>
QA-Review: Gonzalo Penaranda <gonzalo.penaranda@instructure.com>
Product-Review: Jon Scheiding <jon.scheiding@instructure.com>
Closes MAT-606
flag=none
Test Plan:
- Create a page in a course and check the "add to student todo"
checkbox when saving. Choose some future date.
- Create a module in the course that requires completing
all module items
- Add the page as a module item
> Log in as the student and verify you see a calendar
event for the page
- As a student view the page and mark it as complete
> Navigate back to the calendar and verify the associated
event now has a strikethough style
Change-Id: Ie12df5a7d6ab25ebca201a949c8d31e229d4de23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282707
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
Reviewed-by: Joe Hernandez <joe.hernandez@instructure.com>
QA-Review: Joe Hernandez <joe.hernandez@instructure.com>
fixes VICE-2422
flag=discussion_anonymity
flag=partial_anonymity
test plan:
- do the steps in this video: https://share.getcloudapp.com/geud459d
Change-Id: I329166139acdb0521f83a54a00c3abbcec41d0e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283119
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
closes VICE-2417
flag=react_discussions_post
test plan:
- Specs pass
- Go to a discussion
- Delete a reply
- Notice that you aren't able to tab
thru it and doesn't have a tooltip.
qa risk: low
Change-Id: I1ac2694df57bfc25cf81e486706f49314637a3fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283113
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
fixes VICE-2416
flag=react_discussions_post
flag=discussion_anonymity
since the reply optimistic
response does not know the id,
do not display the id for its author info
test plan:
- as a student, visit an anonymous discussion
- type a response and submit
- the immediate thing you see in your response should be
Anonymous (You) , no longer Anonymous current_user (You)
NOTE: this will eventually be replaced by the real server response
where it says Anonymous [whatever the id is] (You)
Change-Id: Ia962cf0d18130e437ff779c8e24ecc1cbe32d2ff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283112
QA-Review: Chawn Neal <chawn.neal@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes EVAL-2114
flag=assignments_2_student
Test Plan:
With the FF ON:
1. As a teacher, create a group assignment with a few students
2. As a student, make a submission and leave a comment on the
submission
3. View the assignment in the speedgrader
4. Teacher should see the student's comment on the group assignment
5. Ensure that the message that all comments are sent to the whole
group shows up only for group assignment
5. Repeat steps for a regular assignment
Change-Id: I38f3f60f9acca08ad809b072dc283237ecc06dd9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282328
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
closes VICE-2409
flag=discussion_anonymity
test plan:
- Specs pass
- Go to an Anonymous Discussion.
- Edit it, change anything on it.
- Save it. It should save without issue and go back to the topic.
qa risk: low
Change-Id: I69295d74fd304451ccbaa7c11ffeec90715e0ef6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283106
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
When g/143124 was done, the shadow record lookup didn't include the root_account_id
This would semi-randomly break deleting cross-shard observer links if there were
links associated with multiple root accounts (since a random one would be picked
on the other side of the association). Because of the random nature of the failure
writing a useful spec is feasible, but existing specs passing should indicate that
this change is at least not wrong.
Fixes FOO-1551
Change-Id: I3a98ece487ebf345d72416cbebe2e470b4eb670d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283102
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
in preparation for migrating qti_migration_tool to python 3
once that migration is complete, we can remove the python 2 version
refs DE-993
Change-Id: Iea25e7418c6e4bc87e639cc1883b216eea94ca6c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282813
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
When a student had two section enrollments, one active and one concluded,
with the concluded section being assigned a quiz it was possible for the
student to still take the quiz even if the availabilty was in the past.
This was due to the quiz being overriden for the user but the concluded
enrollment not being included when checking if it is locked. This allowed
the user to see the quiz and not see that it is locked.
fixes LS-2895
flag=none
test plan:
- Create a course with 2 sections
- Create a quiz with access dates in the past assigned to only one section
- Create a student in the course with an active enrollment in one section
and a concluded or inactive enrollment in the other section
(this should be the section assigned to the quiz)
- Create a module and add the quiz to it
- As the student, navigate to the modules page and see that you are not
able to take the quiz
Change-Id: I66b97ee60537599f852ad6dc3f2a270fa6e26eb2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282797
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
This PS removes the groups tab if the user does not have the
read_roster role, which is the same used to hide/remove the people
tab and the one used to check if the user is authorized to request
the groups API
fixes: LS-2939
flag= none
Test plan:
- Set a k5 subject as public
- Access to the course without logging in
- Notice the groups tab is not present and the 401 error does not
appear anymore
- Access to the course as a user that is not enrolled in the course
- Expect not to see the Groups tab
- Access to the course as a user that is enrolled in the course
- Expect to see the Groups tab as usual
Change-Id: Ia1422a630111e433f14547d3d051e95a77a4f231
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282957
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
closes OUT-4811
flag=individual_outcome_rating_and_calculation
Test plan:
- Enable Improved Outcomes Management FF
- Enable Individual Outcome Rating and Calculation FF
- Disable Account Level Mastery Scales FF
- Go to Account > Outcomes
- Select an Outcome and click on Kebab menu -> Edit
- Verify that in the Edit Modal there is a form for
selecting proficiency ratings
- Click on + button to add a proficiency but do not
enter description
- Verify that error message appears below the description
field and that Save button becomes disabled
- Enter description
- Verify that error message disappers and that Save button
becomes enabled
- Repeat the above 4 steps this time creating a rating
with description but without points
- Click on Save button and verify that the outcome is
updated with the selected proficiency ratings
(view response to graphql mutation in devTools -> Network)
- Go to Account > Course
- Add an Account level outcome to the course, select that
outcome via Tree Browser and click Kebab menu -> Edit
- Verify that in the Edit Modal the proficiency ratings
are displayed but cannot be changed
- Disable Individual Outcome Rating and Calculation FF
- Enable Account Level Mastery Scales FF
- Go to Account > Outcomes
- Select an Outcome and click on Kebab menu -> Edit
- Verify that in the Edit Modal there is no form for
selecting proficiency ratings
Change-Id: Id2b7d4b46b84931db02606f84858517f2139a3b8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/281523
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Reviewed-by: Marcus Pompeu <marcus.pompeu@instructure.com>
Reviewed-by: Chrystal Langston <chrystal.langston@instructure.com>
QA-Review: Chrystal Langston <chrystal.langston@instructure.com>
This allows us to move forward with more speed and confidence
as we refactor and split out the file.
activateTooltips & activateKeyClicks imports were removed, as they
are already loaded in ui/index.
Test plan:
- All automated tests pass
Refs EVAL-2190
flag=none
Change-Id: Ic54b988c87d4b161bd61172afa4e0f63e8543df9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282901
Product-Review: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
fixes FOO-2671
flag = none
Test plan:
• After checking out this patchset run:
• `rails db:migrate`
• `./script/nuke_node.sh`
• Using the default Themes templates found under /brand_configs
select or ensure you're using the Default Template and navigate
to the Global Navigation dropdown tab
• Verify the default "Nav Badge Active" color is set to: #0374B5
• Verify the default "Nav Badge Text Active" color is
set to: #ffffff
• To trigger a notification badge to appear on one of the global nav
menu items, it's easiest to just send a message via Inbox to
the user in question that is under test. You will then be able
to verify the badge has a white background with black text
indicating the number of notifications needed to be read
• See associated Jira for more details and acceptance criteria
Change-Id: Iebbfd850fc5e3cdba47ee8ac145dbaa6ef799484
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283057
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
Migration-Review: Ben Rinaca <brinaca@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
fixes MAT-245
flag=none
test plan
- Create a wiki page with a long content.
It's suggested more than 3-screens size text.
- Using HTML editor, add an id to an element in
the middle of the content.
Ex. <div id="test"></div>
- Save it.
- Create another wiki page.
- Create a link inside the page linking to the
previous page and using id.
Ex. href="/courses/1/pages/page#test"
- Save it.
- On wiki page preview click the link.
> Verify that the page navigate to the 1st page
and positions the viewport starting from
the element with the given id.
> Verify this with the supported browsers.
Specifically Chrome and Safari.
Change-Id: I2f4fb02b0e98b534f3851c019f0ea71a65835484
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282953
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
Change-Id: Ia2d06a7d28f7937eb5a677c5acba098c655ad17c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283060
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
closes VICE-2429
flag=discussion_anonymity
test plan:
- Specs pass
- Go to Account -> Notifications
- Change Discussions -> New Reply to be Notify immediately
- As that user, create an anonymous discussion
- Act as student and reply to it
- Go back to the user that created the discussion
- Go to http://0.0.0.0:3000/users/[MAIN USER ID]/messages
- You should see the notification with the anonymous user
- NOTE: Make sure to have delayed jobs running
qa risk: low
Change-Id: I2ba9ddc1264d98c6b2b4deb433c7b2402bdbbb50
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283019
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag = new_quizzes_bank_migrations
Test Plan:
- New Quizzes Bank Migration should have a beta pill
- New Quizzes Bank Migration is hidden in production
Change-Id: Idbddab5d05bb900c22e6e324bf34bbe3ef8c34a9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283047
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Susan Sorensen <susan.sorensen@instructure.com>
We have many "Browserslist: caniuse-lite is outdated" warnings.
This enables one to run `npx browserslist@latest --update-db`
Test plan:
- All automated tests pass
flag=none
Change-Id: Ia1c863323f5ef0e0b748425a4bd40ace26ca54fa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282886
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
With this we can more easily identify tests that can be moved to Jest.
Some of these were hard to categorize. The arrangement can be improved.
test plan:
- all automated tests pass
closes EVAL-2188
Change-Id: I8d926df4715f2a30fbb464fde4cf68b4e4bd7663
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282898
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes LS-2942
flag=none
test plan:
- follow the recreate steps in the ticket
> expect to get the child events when excludes[]=child_events
is not included in the URL
> expect not to get the child events when excludes[]=child_events
IS in the URL
Change-Id: I9594defad0679a5ea47912dc8738ba9556422518
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282874
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes LS-2891
flag=pace_plans
test plan:
- in a course with a pace plan
- in settings, set Participation to "Course" and enter dates
- go to pace plans and click Show Projections, uncheck
Required Completion... checkbox if checked
> expect the caption under End Date to say
"Required by course end date"
- create a term if you don't have one
- see /accounts/:id/terms
- from course settings, set Term to be a term with an end date
- go to pace plans and click Show Projections
> expect the caption under End Date to say
"Required by term end date"
- check Require Completion by Specified End Date
> expect the caption to say
"Required by specified end date
Change-Id: I132188385976e5d27142b472dfb3b5465aa803c7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282876
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes EVAL-1960
flag=assignments_2_student
flag=observer_picker
Test plan:
- PreReqs:
- Setting.set("assignments_2_observer_view", "true")
- A course with multiple students and an assignment
- An observer in the course with multiple associated students and at
least one student enrollment of their own
- Submit to the assignment with each associated student including the
observer
- As the observer, navigate to the dashboard and select a student
- Navigate to an assignment in the course
- Observe the selected student's submission is shown
- Observe a flash message indicating the name of the student
- Repeat for each student
- Delete site cookie "k5_observed user_for..."
- Load an assignment page without visiting the dashboard first
- Observe flash message indicating the first student is being observed
- As the Observer, select their own name on the dashboard
- Navigate to an assignment in the observer's student enrollment course
- Observe their submission details are visible and no flash message is
displayed
Change-Id: I4b1354ce58c709991d1f32a531864ed32df7469a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280668
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Syed Hussain <shussain@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
refs SEC-4437
flag = none
[pin-commit-respondus_lockdown_browser=8746ff2ccfd6e9ac1d7280687c88e9fa67c0f693]
[pin-commit-multiple_root_accounts=7b11533084764b3a34f390e9a75df26e9dd871f9]
rationale in the script file and more context in the accompanying ticket
~ test plan ~
edit package.json and modify one of the explicit workspace dependencies
such as @instructure/ready to have a specifier other than "*", run the
script and verify it exits with 1
yarn --silent workspaces info --json | \
node script/yarn-validate-workspace-deps.js 2>/dev/null
Change-Id: I6624ada67a21d433477a7ad4d36acf5801853b7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282948
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
closes VICE-2410
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymit ff
- go to a partially anonymous discussion
- create an anonymous reply as a student
- edit the reply
> should not see anonymous response selector
Change-Id: I3cf2d4d896d8dcfa5a8687e9dae35489c3e90a8d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283030
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2411
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymity ff
- go to a partially anonymous discussion
- create an anonymous reply as a student
> focus should not be cut off for dropdown selector
Change-Id: I400590d3970f2e9196cab55cd0f46f12cccc8b0e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283035
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2412
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymity ff
- go to a partially anonymous discussion
- as a student:
> should see anonymous avatar without blue border
Change-Id: I5773c39f2b82ec0f27e97f24d85706e73ee3cb25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283038
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
I'd like to do some refactoring to user_search, but
wanted to see if I could cover all cases in the existing code first.
Change-Id: I40f50513d178d02dd194a463ec010c48d4334bd1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282892
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: Sean Scally <sean.scally@instructure.com>
Product-Review: Sean Scally <sean.scally@instructure.com>
closes VICE-2153
flag=react_inbox
test plan:
- Specs pass
- Go to Inbox
- Click on the compose icon
- You should be able to select To using the AddressBook
- Send a message
- Make sure selected users received the message
qa risk: low
Change-Id: Ie070548e8765fabacfaf664a69e257e275f4e04a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283015
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
closes FOO-2586
flag = none
Test plan:
• Create an assignment and assign it to the one student with a
due date (Assignment due date override for individual user)
excluding the "everyone" default section scope
• Create a second user and merge the first student into the
newly created user
• Check the submission API for the merged student and assignment
and notice that the "cached_due_date" displays the assigned due
date used when creating the assignment
• See Jira for additional notes and attachments
Change-Id: If1ecddc72939fafc373f8aa060ccfd252bd01d8a
Change-Id: Idae972fceb4f28d9b1f9a99fb70f3dba0fc0d9e1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282894
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
closes MAT-497
flag=none
test plan:
- Edit a wiki page
- Embed a Studio video in RCE
> Verify in HTML view that the iframe
contains lti-embed class
- Save wiki page
- Open wiki page preview
- With browser dev tools, adjust the screen
width to < 320px
> Verify that the page padding is removed for
LTI iframe
> Verify that the iframe width fills the page
> Verify that you can horizontally scroll
inside iframe. With this we need to make sure
that no content is cut, for example: audio
scroll controls
Change-Id: Id420208deb9161741748fccec6fafe336e435859
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Xander Moffatt