canvas-lms

Commit Graph

Author	SHA1	Message	Date
Ahmad Amireh	a4e42130c9	(webpack) ESM-ify Ember refs FOO-2835 flag = none re-package the Ember framework file as an ES module so that we can finally engage a native ESM build. This involved two things: (1) scanning for all member properties of the Ember/CommonJS export and re-exporting them as ESM specifiers (2) importing dependencies instead of expecting them to be injected into Ember.imports, which no longer exists Ember is still exposed as a global on window due to how Ember.lookup works. Additionally, we now import only the runtime portion of the Handlebars packagei as intended. ~ test plan ~ visit individual gradebook and verify that (1) it works, (2) you can "Select a student" under Content Selection, and (3) you can "Select an assignment" under Content selection. The page should work exactly as it did before. Change-Id: Id7817869803d0722b791e79279ad2b69c5e7dca1 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294129 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Charley Kline <ckline@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>	2022-06-17 17:32:05 +00:00
Ahmad Amireh	4243097b21	rename some things fixes FOO-1265 [skip-eslint=true] [pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5] [pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5] [pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf] [pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22] [pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805] Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>	2021-04-06 01:12:49 +00:00

Author

SHA1

Message

Date

Ahmad Amireh

a4e42130c9

(webpack) ESM-ify Ember

refs FOO-2835
flag = none

re-package the Ember framework file as an ES module so that we can
finally engage a native ESM build. This involved two things:

(1) scanning for all member properties of the Ember/CommonJS export and
    re-exporting them as ESM specifiers
(2) importing dependencies instead of expecting them to be injected into
    Ember.imports, which no longer exists

Ember is still exposed as a global on window due to how Ember.lookup
works. Additionally, we now import only the runtime portion of the
Handlebars packagei as intended.

~ test plan ~

visit individual gradebook and verify that (1) it works, (2) you can
"Select a student" under Content Selection, and (3) you can "Select an
assignment" under Content selection. The page should work exactly as it
did before.

Change-Id: Id7817869803d0722b791e79279ad2b69c5e7dca1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294129
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>

2022-06-17 17:32:05 +00:00

Ahmad Amireh

4243097b21

rename some things

fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>

2021-04-06 01:12:49 +00:00

2 Commits