flag=none
Test Plan:
- Navigate to inbox
- Select a conversation and hit the reply button
- It should load the compose modal
- Hit reply on a conversation message inside a conversation
- It should load the compose modal
Change-Id: I9dfe2a1df44b857bd2198f538159763d0238c352
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276778
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
closes LS-2750
flag = k5_parent_support
Test plan:
- Check out the setup steps in ticket LS-2750
- Visit the dashboard as the observer and expect to see the
cross-shard user in the dropdown
Change-Id: I9dff318e177e7891a063f4cf4afa860fb38b1280
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276370
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Add a basic component for an updated "Message Students Who" dialog,
viewable in Storybook but not yet accessible from Gradebook. This is
meant to give us a base to begin adding functionality and does not
presume to be the correct or final version of the UI.
closes EVAL-2056
flag=message_observers_of_students_who
Test plan:
- Test that the component appears as expected in Storybook
Change-Id: Ice349c68d4c717809d4fcbae4c8cae0a5fe7a5f1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276525
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
[use-rspecq]
Test Plan:
-Jenkins passes both with and without rspecq
-add sleep to one node, wait for queue to empty
-node will not run any stages since queue is empty
-add sleep to one node, wait but still have tests in queue
-node will still run stages and tests
Change-Id: Iace45f456c19284c6a338f5537a367917fd4f9c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275325
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
fixes VICE-2141
flag=react_inbox
Test Plan:
- Enable the react inbox FF
- Navigate to the inbox
- Open a conversation and reply to a conversation message
within the conversation
- Huzzah
Change-Id: If9d4baf4d538c4ea07f8df355651407276180279
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276561
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Closes LS-2767
Test Plan: passes Jenkins and tests the pace plan modules
Change-Id: Id8cdb359ca396e3ad550d2e9d46e3da420e5be02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276584
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
all manual. a few cascaded to cleaning up leaky consts in specs
Change-Id: Ia77478b92f23e06d1023f4e3cfa02a751593a368
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276484
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes FOO-2519
since they could be set to prefer_secondary, which will ignore the GuardRails.activate(:deploy)
Change-Id: I6e7234e6b6b68121406d5fbbacbb19c7bbe984c7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276727
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes VICE-984
flag=react_inbox
unfortunately, in selenium, trying to attach a media file
to upload leads to packages/canvas-media/src/ComputerPanel.js
erroring out. so this tests stops that the ui for uploading media
exists when replying
test plan: code review
Change-Id: I179d5adf369f7e38c3c9e44874941f21f526eee4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276750
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-2075
flag=discussions_reporting
Test Plan:
- load a discussion with redesign ff turned on
> should not see a unique kep prop console error
Change-Id: Ia1e3242c6f46330c34fc1c5a17905cfabaf81b21
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276751
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-1833
flag=react_discussion_post
This will fix the focus from being cut off.
Test Plan:
1) Go to a discussion.
2) create a root reply.
3) create a child for that reply.
4) delete that reply.
5) Compare delete message with existing design.
a) you can compare to cd.
b) or a deleted post before my change.
6) click on the screen above the message.
7) use the tab to novigate to the deleted_message's replies.
8) focus state should encapsulate the replies button
Change-Id: Ia788f878f6f0406be98f1af7ba768bdf10551de5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
fixes VICE-2049
flag=none
Test Plan:
- Enable profiles on the account settings
- As a teacher navigate to the people page on a course
- Click on a user with a profile picture and then click on their name
in the tray that opens
- The avatar image should no longer be clickable and there should now
be a link next to the avatar saying "Remove avatar picture"
- Clicking the link should open a "Confirm Removal" modal with the
message "Are you sure you want to remove this user's profile picture?"
- Hitting confirm in the modal should result in a success alert saying
"The profile picture has been removed." and the avatar image should
be removed from the page.
- If you refresh the page, the avatar image should show the default
avatar image.
- As a student follow the same steps as above to get to a different
user's profile page
- As a student you should see a link with the text "Report inappropriate
picture"
- Clicking the link should open a "Report Profile Picture" modal with
the message "Reported profile pictures will be sent to administartors
for review. You will not be able to undo this action."
- Hitting confirm in the modal should result in a success alert saying
"The profile picture has been reported" and the link should no longer
be a link and the text should update to "This image has been reported."
- Refreshing the page should show the text "This image has been reported."
instead of a link
Change-Id: If8fed6939d27c610fb66c3f4b0491a3fa350ef02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276261
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
When replying to an older message in a conversation we only
want to include older messages. This will allow us to exclude
newer messages when replying to a conversation message.
refs VICE-2141
flag=react_inbox
Test Plan:
- Have a conversation with a bunch of messages of varying ages
- Navigate to /graphiql
- Run the following query:
```
query MyQuery {
legacyNode(_id: <conversation_id>, type: Conversation) {
... on Conversation {
id
conversationMessagesConnection(createdBefore: <iso8601_timestamp>) {
nodes {
createdAt
body
_id
}
}
}
}
}
```
- You should only get back messages created before the given
timestamp
Change-Id: Ib32cb3224d6fbf469c78b4f35d1bc4726b0fa365
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276560
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
test plan:
- Visit ff page
- Should have a link to the community
fixes OREO-1113
flag=analytics_2
Change-Id: I6d058d0738612ef80d9a5c81a1138a45729c4447
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275521
Product-Review: Carly Curran <carly.curran@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kwok Lam <klam@instructure.com>
Reviewed-by: Bryant Larsen <blarsen@instructure.com>
Test plan:
- go to course settings integrations page
- make sure copy mentioning max number of users in a team still shows
correct numbers (25,000 and 100)
refs INTEROP-6805
flag=microsoft_group_enrollments_syncing
Change-Id: I01c6839bd63d8f221159050a68c04b28da09fda8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276585
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Evan Battaglia <ebattaglia@instructure.com>
We apparently we're restricting the values before
dbd8c466 fixed `"canvas_icon_class": { ... }` to
`"canvas_icon_class" => { ... }`
(Since that commit was ostensibly just a linting commit but changed
semantics, it might be worth revisiting other things in that commit.)
fixes INTEROP-7109
Test plan:
- Edit an LTI 1.3 dev key JSON in the Developer Keys UI
- Add "canvas_icon_class": "icon-pdf" to a placement in an LTI 1.3 dev key
- Make sure the dev key saves
- Observe that the dev key cannot be saved before this commit
Change-Id: Ibb22a8d5d9ebdb9b7afb99adf9ab2893be863165
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276645
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
Change-Id: Ia304051a03a0a311292b3730c0462d115b20d88a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276712
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
An attempt to make the spec for fixing keyboard navigation on pages
with the sticky C4E better before we just remove it.
refs LS-2729
flag = none
Test plan:
- Passes Jenkins and is not flakey
Change-Id: I0a2ae5f97405969f7a6b9ca7120ffe058b1102de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276705
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeff Largent <jeff.largent@instructure.com>
closes: LS-2734
flag=none
test plan:
- Enable K5 mode
- Create 2 courses, A and B
- Enroll into course A as a student
- Check that you can't favorite/unfavorite course A
- Enroll into course B as a teacher
- Check that you now can indeed favorite course A
- Favorite course B, leave A unfavorited
- Check that your home show only course B
Change-Id: I20f4c63b00169f5ce2089be4b9a60e5d0766d939
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276536
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
Closes MAT-167
flag=rce_buttons_and_icons
Test Plan:
- Start the RCS
- Navigate to an RCE instance in Canvas
- Open the "create" button and icons tray
- Scroll down to the "Image" section and
select "Course Images"
> Verify the current course images load
Note that most of the functionality of
this image list is already covered in
automated tests. We will be adding more
as we add a click handler
Also note that for now this list of images
_will_ include previously created
buttons and icons. These will be filtered
out in the future.
Change-Id: I8ea6def5b92a0c7456ef29a20bb846db4f54e1db
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276508
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Add support for LTI tools to consume the tool id
as defined in canvas for themselves.
Test Plan:
- Specs pass
flag = none
Change-Id: I6765b907c14a79bad8e68b3b8037efc140bd7bf5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276455
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Alex Slaughter <aslaughter@instructure.com>
fixes VICE-1986
flag=none
test plan:
- enable the discussion redesign flag
- enroll a student in a course with a discussion topic
- as that student, make a parent and child post
- the edit/delete options should show up correctly
- conclude that user's enrollement
- Enrollment.find_by(user_id: <uid>, course_id: <cid>).conclude
- refresh the page
- the edit/delete options should no longer show up
qa risk: low
Change-Id: Ic1855517600023890211194d0ba86f04829c8f2e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276523
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
quizzes specs that have had trouble with flakey spec catcher
refs LS-2655
flag=none
test plan: it passes jenkins
Change-Id: I4193252df38e0997243454604876f65f477115e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275867
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes MAT-133
flag=none
test plan:
- Verify that there is no rce_pretty_html_editor
feature flag (site admin).
- Navigate to an RCE instance.
- Verify that pretty html editor is enabled by default.
Change-Id: Ibe76738577d0716e30f06815c9a072f41ca48103
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275197
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
When caching rubric assessments in GraphQL, add the artifact attempt as
an additional key to the field, since (like many versionable objects)
different assessments can be represented by the same type and ID. This
ensures that assessments for different attempts don't stomp on each
other.
closes EVAL-2020
flag=assignments_2_student
Test plan:
- Have a course with the new student view enabled
- Have an assignment with a rubric that accepts a submission
- As a student, submit to the assignment
- As a teacher, grade the submission and assess it using the rubric
- As a student, submit to the assignment again
- As a teacher, grade and assess it again with a different score
- As a student, open the page again
- Switch back and forth between attempts multiple times, and check
that each attempt displays the appropriate rubric assessment,
instead of the same assessment appearing for all attempts
Change-Id: I3db6ce226eac24d218991469bd42fe9071665242
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275923
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Checks if any focused elements are higher on the page than the bottom
edge of the C4E tabs, and automatically scrolls up enough to reveal
them if so. Fixes this issue on both the C4E course homepage and
user dashboard.
fixes LS-2729
flag = none
Test plan:
- Create or use an existing course with a bunch of assignments and
modules
- Go to the course home page and click on "Grades"
- Tab to the last assignment link and expect the page to scroll down
at some point in the process
- Shift-tab back up through the list of assignments until you reach
one that is overlapped by the C4E course header
- Expect the window to scroll to uncover hidden elements as you
shift-tab to them
- Do the same for the modules tab
Change-Id: I4dedd8e134de90e0e9858614a8976b455a602056
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276248
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
Last name column has all the same fields as the original student
column. The first name column only shows the first name.
closes EVAL-1990
flag=gradebook_show_first_last_names
Test plan:
With the FF on and the account admin setting to show separate columns
enabled, as a teacher go to gradebook:
1. Select the "Split Student Names" view option
- See that the gradebook grid shows separate columns for student last and
first names
- Make sure all the column options in the last name column work "Sort by",
"Secondary Info" and "Show - Inactive/Concluded enrollments" and the
option to "Display as" is not there
- See that there are no column options for first name
- See that the assignment and student search work as before
2. Unselect the "Split Student Names" view option
- See that the grid shows the Student column as before
Change-Id: Ic3ffefcd2069eca84823d60bb993d98521c8861d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276013
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Dustin Cowles <dustin.cowles@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
closes MAT-422, MAT-426
flag=rce_buttons_and_icons
test plan:
- Navigate to a RCE instance
- Click Buttons & Icons button.
- In the tray, navigate to images section and
click crop button placeholder.
- Vefify that you can change the crop shapes
in dropdown and it changes in the preview.
Change-Id: Iba478fd3aef8c45a511e21f4c2025499ef7c4796
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276028
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
fixes LS-2784
flag=pace_plans
test plan:
- Create a course with pace plans enabled
- Create a module and add a published and unpublished assignment
- Go to pace plans
- Make changes to dates and publish the pace plan
- Verify it was successful and all assignments have assignment overrides
Change-Id: I89461e437d643e0687aad4e2bc6742762cd0e9f8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276532
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
the last spec/selenium/rcs test file
Because we've touched these files, we run flakey speck catcher
against them. For some reason I cannot fathom, sometimes
the tinymce pop-up toolbar for link options and image options
doesn't show up. The specs pass 90% of the time, and we know
that it works in the RCE in the real world, so I added a
rescue around the code that does that to keep the specs from
failing.
refs LS-2655
flag=none
test plan: passes jenkins
Change-Id: I1a46278b95f58fe269ab6144d38627b913af1a42
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275865
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs VICE-2075
flag=discussions_reporting
test plan:
- Go to a Discussion Entry in the Isolated View.
- Click on the kebab menu on a child.
- Click on Report and select a type.
- Click on Submit.
- Click again on the kebab menu.
- Should say Reported instead of Report.
qa risk: low
Change-Id: I58e2e4ec300398c5059ae6eda2cf4fd2f4069455
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276534
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
minor QOL mainly for me; put webpack-specific configuration in its own
folder, make it portable, and make room for esbuild
the __webpack_public_path__ initializer no longer sources the value from
the build module, instead it uses a pre-defined global that webpack
injects
~ test plan ~
build is OK
Change-Id: I4ba4a3c0cb9175f96096f2b78022e152c04fc75d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Make SpeedGrader update the currently selected student in response to
keystrokes when the custom dropdown menu is open, and fix a couple of
the most salient issues, but do not attempt to fix everything.
closes EVAL-1610
flag=none
Test plan:
SpeedGrader provides a veritable bonanza of methods to select students
using the dropdown menu at the upper right:
1. Click on the dropdown to open it, navigate between students
using the arrow keys or the Home/End keys, and hit Enter or Space to
close the dropdown and select the last-focused student. As you
navigate between students, the currently-selected item should have a
distinct background. Avoid using both the mouse and the keyboard at
once here, or the menu will get very confused.
2. Open the dropdown as described in (1), then close it. There should
now be a focus rectangle around the dropdown, and you should be able
to navigate between students using the arrow keys and Home/End.
3. Click somewhere on the header, tab until the left arrow is focused,
then tab once more to focus the invisible browser-native select menu.
Use the arrow keys to select a student.
Test that all three methods work to select students in SpeedGrader. Note
that methods 1 and 2 currently do not support switching sections using
the keyboard.
Change-Id: I3007324165ae7fa5b5cace1e2f5d7e0019e9ecc7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275524
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
- Restore the argument to selenium helper switch_editor_views
- Fix type_in_tiny (was broken w/ new rce + large inputs)
- tweak to some func parameter names to be clearer as to
what's expected
- fix a couple specs
closes LS-2753
flag=none
test plan: passes jenkins
Change-Id: I18632ecb8dcb402714346ec147ca20b6401f3c40
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276046
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Matthew Lemon