closes CNVS-6891
test plan:
- open the new assignment index page
- it should look more condensed
- it should still be accessible
Change-Id: Ic48b293f159729df4fb5667fbdaab3fdc5412d9f
Reviewed-on: https://gerrit.instructure.com/22439
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
the extra parameter in the url was confusing to the user, switching
to use a cookie prevents the confusion for the user
test plan:
- on the wiki edit page (/pages/:page/edit)
* click the settings cog
* click delete
* confirm the deletion dialog
- should be redirected to the wiki index page
- should receive a confirmation that the page was deleted
fixes #CNVS-6815
Change-Id: Icfbe2e1755eb215a57e1692ba68389a703c7079d
Reviewed-on: https://gerrit.instructure.com/22396
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
fixes CNVS-6812
test plan:
- delete an assignment group with the dialog
- it should disappear from the page
- refresh and it should be gone
- delete an assignment group with assignments
- the assignments should be gone too
- delete an assignment group with assignments and move them
to another assignment group
- the assignments should be in the other group
Change-Id: I77a471b5cf4f83cd298051766d71a14aeb3313d0
Reviewed-on: https://gerrit.instructure.com/22212
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-5674
changes
1. implement redesign of quizzes index with publish icon
2. adds header toggler to styleguide for item groups and condensed item groups
3. refactor publish button code to fix onmouseleave event issue
test plan:
in styleguide
1. check that item group headers toggle open/closed
on quizzes#show with :enable_draft = true
1. publish button continues to publish/unpublish and remember state
2. disabled the publish button when there are student submissions
on quizzes#index :enable_draft = false
1. make sure quizzes index page functions the same as before draft state features
on quizzes#index as a teacher with :enable_draft = true
1. shows 'no quizzes' message when there are no assignment or open quizzes
2. greys out unpublished quizzes
3. can publish and unpublish with the new publish icon in each row
4. disables the publish icon on the row when there are student submissions
5. editing/deleting quizzes works (and deleting prompts to confirm)
6. the 'search for quiz' widget filters the quizzes as you type
on quizzes#index as a student with :enable_draft = true
1. unpublished quizzes are not visible
2. publish icon or edit/delete links are not visible
Change-Id: Ida140d5e30761a520b118d0c62fb45bcf1a3a008
Reviewed-on: https://gerrit.instructure.com/22121
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
refs CNVS-6576
also fix multiple enrollments showing up multiple times in the
grouped version
test plan:
* hit /api/v1/courses/X/students/submissions?student_ids[]=Y
* with a lot of assignments, it should be paginated
* make sure user Y is enrolled in multiple sections
* add &grouped=1
* it should work (this one isn't paginated), and only return 1
copy of Y's submissions
Change-Id: I8db29c1319d31bb9b95589b578514c07830a52a9
Reviewed-on: https://gerrit.instructure.com/21983
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
* automatically does with_exclusive_scope
* if the scope has an order or group by, use an alternate
implementation so it's not broken
* alternate methods are cursors (postresql only) or temporary
tables. if a transaction is already open, or we're on a slave,
prefer a cursor (even over the normal method, since the query
might be slow even without an order or group by)
test plan:
* migrations should still work (especially data fixups)
* lots of account reports use find_each; make sure they still run
Change-Id: If876b7b3401e6cda1d41f1c94b93af4810b78cf4
Reviewed-on: https://gerrit.instructure.com/22364
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-6887
use a smarter query, and skip it altogether for account groups
test plan:
* regression test adding/removing users to groups in a course with
overrides and stuff.
* an sis import of account level groups should still work
Change-Id: Ie9943af04ce6aab31f9f0d76f51c7474c1299616
Reviewed-on: https://gerrit.instructure.com/22317
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-5677, CNVS-6805
changes
1. implement redesign of quiz edit page
2. put 'published' status on edit page behind feature flag
test plan:
on quizzes#edit :enable_draft = false
1. page looks the same as before draft state
2. 'published' status no longer shows up
on quizzes#edit with :enable_draft = true
1. header bar added and admin links moved to the header bar
2. padding removed around footer area
Change-Id: Id7855164fa132e078ade3720adc81c1048e8a729
Reviewed-on: https://gerrit.instructure.com/22406
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
closes CNVS-6255
test plan
- make sure notification preferences popovers
look good still
- make sure translation warning popovers still
look good
- no implemented tours, so nothing else to test
Change-Id: I786a90d98a9b1b516b0252ad5aa020fc9e7b37eb
Reviewed-on: https://gerrit.instructure.com/21418
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
fixes CNVS-6848
Test Plan
* Go to the new wiki pages and go to a page.
* Make sure there is enough content in the page
to scroll.
* Scroll down the page. Notice that the toolbar
stays on the top of the page. It's "static"
* Re-size the window and make sure the tool bar
stays within the content margins.
Change-Id: I4b272290a482c096ad8a232c44ca8f5af889417e
Reviewed-on: https://gerrit.instructure.com/22395
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
test plan (on the wiki index page):
- wiki page navigation
* click on the row for a wiki page (not the link text)
- should navigate to the corresponding wiki page
- wiki page publish/unpublish
* click on the publish icon for an unpublished wiki page
- should publish the corresponding wiki page
* click on the unpublish icon for a published wiki page
- should publish the corresponding wiki page
- wiki page edit
* click on the settings cog
* click on the edit menu item
- should be redirected to the edit page
- wiki page delete
* click on the settings cog
* click on the delete menu item
- should delete the wiki page
- should give provide feedback that the page was deleted successfully
- wiki page set as front page
* click on the settings cog
* click on the set as front page menu item
- should set the wiki page as the front page
- should move the 'Front Page' label to the corresponding wiki page
fixes #CNVS-6750
Change-Id: I08bf8e2204db3338ea62dc272d032437565ec609
Reviewed-on: https://gerrit.instructure.com/22300
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
test plan:
- create a quizquestion bank at the account level
- delete it
- go to a quiz, click the "Questions" tab, click the "Find Questions"
button. This should bring up a dialog with a list of question banks
on the left side. The question bank you deleted should not be there.
fixes CNVS-6866
fixes CNVS-5872
Change-Id: I24015cd4e21cc03b5b13bc7fc05b4a36d50ef487
Reviewed-on: https://gerrit.instructure.com/22442
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
all migrations are put on an n_strand for the course's root
account now. This is to prevent a school copying all its
course at a semester boundary from starving other jobs.
Also, some old content migration objects don't have the
migration type set which causes a page error in the new UI
Test Plan:
* in the /jobs UI a migration should have a strand name like
migrations:import_content:#{account_id}
* Course copies from new migration UI and through course settings
should work and not cause page errors when the new UI is refreshed
* Also removed the question mark for the checkbox labeled
"Select migration content"
closes CNVS-6951
Change-Id: Ifbecbc49c40b35c3212e39e92b753c14e499ed6c
Reviewed-on: https://gerrit.instructure.com/22427
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
It's redundant, it just calls the courses#users action. I've kept the
tests around to ensure backwards compatibility, and kept the route just
pointing to courses#users.
refs CNVS-5450
test plan:
* You should still be able to search for users with
/courses/X/search_users?search_term=xyz
* You should also be able to search using the recommended endpoint,
/courses/X/users?search_term=xyz
Change-Id: I628a45786bcc66dc6e6a1b51c5b1ebbfc73caa62
Reviewed-on: https://gerrit.instructure.com/22260
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
refs CNVS-6970
This allows passing two params for the :n_strand parameter, and looking
up the Setting based on just the first param. For example
["course_copy", root_account.global_id] will create an n_strand per root
account, but allow the "course_copy_n_strands" to control the # of
strands for every root account. You can also override for a specific
account with a "course_copy/<global_id>_n_strands" setting.
test plan: specs
Change-Id: Ie72468588fa1172ea967e1f0a072c9d565bae62f
Reviewed-on: https://gerrit.instructure.com/22461
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
fixes CNVS-6944
changes include:
* removing hover state on reply icon for threaded
discussions (now always visible);
* adding text "reply" next to reply icon;
* adding reply icon to the "reply" text box in the
discussion topic head;
* adjusting alignment of avatars/discussion title and
author info.
test plan:
* visit the discussion show page of a threaded discussion
and verify that the above changes appear;
* visit the discussion show page of a non-threaded
discussion and perform a regression test of its styles.
Change-Id: I818c051f0f401fa994bfd7d16f909dd2cb645780
Reviewed-on: https://gerrit.instructure.com/22430
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
this includes:
- circular avatars with a subtle border
- vertical centering of text next to avatar
- put author before date on posts
fixes CNVS-6828
test plan:
- these changes should be tested with CNVS-6944
- check styling on discussion show page, topic and posts
- check both threaded and non-threaded discusssions
- check styling on collapsed posts
- check styling on filter results (search, unread button)
Change-Id: I096174b9fe0acdb2eaa960fee3fa81f468d7e04e
Reviewed-on: https://gerrit.instructure.com/22355
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
test plan:
- embed an scribdable document in wiki text via the wiki sidebar
- the "preview the document" and "view in a new window" images
should have alt text that matches the title attribute of
the containing anchor tag
fixes CNVS-6620
Change-Id: I2c074dfd9207d4e341ae8e642a2f9635bfb90b83
Reviewed-on: https://gerrit.instructure.com/22319
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
closes PS-439
test plan
- report should return students that have no submissions in date range
Change-Id: I412791e9631f54cb2050ae2ac180872a2f170a2e
Reviewed-on: https://gerrit.instructure.com/21688
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
the subscribers method was choking on a null user object. there
appear to be many cases where the DiscussionTopic user_id can
be null in the database. just took out adding [user.id] because
the posters method already includes it in a way that doesn't
break on nil.
fixes CNVS-6925
test plan:
- create a discussion topic with posts.
- find the new discussion in the console:
dt = DiscussionTopic.find(<id>)
- set the user for the discussion to nil:
dt.user = nil
dt.save!
- make some more posts in the topic and make sure
notifications about new posts in the topic are
being sent (check /messages).
Change-Id: I3912465e9f89de5ad5b20fadb3eee693ba4de650
Reviewed-on: https://gerrit.instructure.com/22387
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
test plan:
* run jobs (script/delayed_job run), verify that jobs are still
processed without error.
* create a long-running job (you can just Kernel.send_later(:sleep,
300)), then while the job is running, kill -9 the delayed_job
processes. When you next start jobs, the sleep job should get
unlocked and re-queued to run again.
Change-Id: Ic3efba2537b29dabd2adad63699ac768512dbbe6
Reviewed-on: https://gerrit.instructure.com/22302
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fixes CNVS-6854
Test Plan:
- using the API, create a user with a unique_id that is not an email
address, and with a communication_channel[address] that is. The
user should have a login ID that matches the unique_id and an email
address that matches the communication_channel[address].
- users created with an email address for unique_id should still be
backwards compatible (i.e. the email address in the associated
communication channel should still be the same as unique_id in this
case)
Change-Id: I9bda3232a45deffb4ec5f6c8da37dc460a85f2b5
Reviewed-on: https://gerrit.instructure.com/22345
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Duane Johnson <duane@instructure.com>
Change-Id: I58d6fe5adb263720e3f2dd9674a309db81b51cad
Reviewed-on: https://gerrit.instructure.com/22423
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-6927
test plan:
- create an assignment group with assignments on the new index page
- edit the group and add a never drop rule
- the remove never drop icon should be gray
Change-Id: I7ccb4b67218d52197b0a5e600d86a20805214ef7
Reviewed-on: https://gerrit.instructure.com/22371
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-6947
test plan:
* upload a file whose name begins with ~
* download a zip of the folder the file is in
* it should work
Change-Id: I828095b2dffe96805df5dc4921cfdce7c38af287
Reviewed-on: https://gerrit.instructure.com/22414
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
the api was accepting an array, which was skipping the parsing, stripping of
'.' and whitespace, and downcasing that happened when the parameter was given
as a string. this caused the validation to try to match a file name against
' .DOC' which would always fail.
this fixes the problem and also runs a datafix to correct existing data that
is in this bad state
fixes CNVS-4622
test plan:
- before checking out the patchset, create an assignment and set the allowed
extensions to ".DOC, .XLS"
- check out the patchset and run migrations
- your assignment allowed extension value should have changed to 'doc,xls'
- try to enter the bad value again
- it should save and automatically become the good value
Change-Id: Iea45dd0d5251e418878567b9267eb6252f1e1250
Reviewed-on: https://gerrit.instructure.com/22299
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-6922
test plan:
- in the new assignment index page
- create a new assignment group
- create a new assignment with the quick add dialog
- create another
- they should both work
Change-Id: I49ea59d563877b7dfda9744802abb01976f49e93
Reviewed-on: https://gerrit.instructure.com/22363
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
make it easier to remove and re-open a dialog with a dialog form view. this
comes up when dialog form view gets re-rendered after it's dialog has already
been opened once.
test plan: n/a this is not used yet. make sure existing dialog form views
(like the people page, or turnitin settings on the assignment edit page)
Change-Id: I3b1b0c8ac42f08048f908311be9b953a3745dad9
Reviewed-on: https://gerrit.instructure.com/22361
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Also gives the "round" function in app/coffeescripts/util/round a
default rounding value of 0 decimal places if no decimal place argument
is given.
test plan:
- As a teacher, grade an assignment for a student with a score of
0.6666. When you view it in the gradebook, it should display as
"0.67".
fixes CNVS-3929
Change-Id: I39281c208ec73568d95dd18ac9a3ba712cb8ef6e
Reviewed-on: https://gerrit.instructure.com/22250
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
test plan:
* as a site admin, go to account settings for an account, and change
and save Self Registration; it should persist
* repeat as an account admin
Change-Id: Idb02a251e5c916237f5ef7a647edaa0ebd93078d
Reviewed-on: https://gerrit.instructure.com/21921
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
documentation on the server side, and adaptation of Backbone.Collection
to handle this style of document on the UI side.
refs CNVS-390, refs CNVS-6069
Change-Id: Ice854695df66efb13545aa7ae47b39e7ad673c60
Reviewed-on: https://gerrit.instructure.com/22145
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
in both requests and responses
test plan:
* in all group and group membership apis, it should be able to use
the sis id of the group instead of the canvas id (sis ids are only
supported on account level groups)
* in api responses that return groups, it should include the
sis_group_id if the calling user can read sis data at the root
account level
Change-Id: I439bf2d33661ed128a75c759c304c897fe0fc38b
Reviewed-on: https://gerrit.instructure.com/21612
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-6482
test plan:
- the show/mode module items button (otherwise known as the
collapse module button) anchor element ("a") should have
descriptive text visible only to screenreaders
(it also has a "title" attribute that contains the same
text; apparently neither is enough by itself)
Change-Id: Ida2ae3270c7d4524592268198cbd3c6fdf2b3a62
Reviewed-on: https://gerrit.instructure.com/22318
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
fixes CNVS-4439 FRD
test plan:
* in a sub account, run the sis export report, selecting the courses
option
* it should work
Change-Id: I1fe42aa4ceeb59742376dfdbeeb7481152cf7286
Reviewed-on: https://gerrit.instructure.com/21598
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
* configure MFA for a user
* login with that user, but don't remember this computer
* within 30 seconds, log out and log back in with the same code
* it should say your code is invalid
* enter your new code
* you should be able to log in
Change-Id: I943d985b392b9117ed4c77634d8af2f27cd4e5f9
Reviewed-on: https://gerrit.instructure.com/21613
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
A publish button had been added to the old module UI before
the feature is ready to release.
Test Plan:
* the publish/unpublish button should not appear on a
module in the old ui
* note that the modules are cached, so if you loaded the
modules page before this fix, and then after, you'll
probably need to clear the cache
closes CNVS-6919
Change-Id: I0ecfb01f5432425639265dccc9d166382deeaad3
Reviewed-on: https://gerrit.instructure.com/22360
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plans:
CNVS-6481:
* confirm search box on course people page has
aria-label "Search people" instead of just "search"
CNVS-6615:
* add several upcoming events to a course calendar such that
not all of them are initially shown on the right-hand sidebar
on the course main page (instead showing a link with "X more")
* confirm that hitting enter while focused on the link
(note: getting focus using Shift+Tab is probably easiest)
will set focus on the first newly revealed item, rather than
the first of all the items
CNVS-6480:
* confirm that there is a hidden h1 header at the top
of the course people page
CNVS-6516:
* on the course settings page - right sidebar,
inspect the current users html element and confirm that it is
now an <h3> tag inside a <caption> tag (but appears the same)
CNVS-6517:
* on the course settings page -> course details form,
left hand labels should not be contained within <th>
tags but instead in <td> tags (should otherwise be the same)
fixes #CNVS-6481 #CNVS-6615 #CNVS-6480 #CNVS-6516 #CNVS-6517
Change-Id: Ie62944ca8927b943529c78b78c594f340cd653c2
Reviewed-on: https://gerrit.instructure.com/22243
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
also rename method to prevent future mishaps
test plan:
* try to visit a deleted page (that is not the
front page)
* should not get a page error
fixes #CNVS-6868
Change-Id: If0bea59d810fc0d41d3e9169fffc58fa20d74cd9
Reviewed-on: https://gerrit.instructure.com/22309
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
broke with g/22210 ... these are always ordered by name now (previously
the order was arbitrary, though arbitrarily the same in the spec and the
controller)
Change-Id: I1a7a52409d6d7f38087a3d4964b5447b4bd336cc
Reviewed-on: https://gerrit.instructure.com/22316
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes an error when run with other specs
Change-Id: Iefd101232e5c542557e8230840428f3504e60d21
Reviewed-on: https://gerrit.instructure.com/22025
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
Simon Williams