closes CNVS-27212
Gives us the ability to turn on RCE integration
for one category of use case at a time rather than all
at once
TEST PLAN:
1) nothing uses the higher level feature flags yet
2) make sure you can enable and disable the new feature flags?
Change-Id: I187f2da931a1374ff0893000849a6dbef3332c0b
Reviewed-on: https://gerrit.instructure.com/73065
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
initially, the feature flag only toggles a button on the course
settings sidebar.
test plan:
- enroll as a teacher
- check there is no conditional release button on course
settings right sidebar
- enable conditional release feature
- check there is a conditional release button
- revoke "manage all other content" permission for teachers
- check there is no longer a conditional release button
fixes: CYOE-44
Change-Id: Ic8299ba179bf6331ce9a2da5d40e60ac0bc88ee6
Reviewed-on: https://gerrit.instructure.com/72474
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
QA-Review: Jon Willesen <jonw@instructure.com>
Tested-by: Jenkins
it's never used
keep it in the API response for back-compat reasons
test plan:
* regression test feature flags; nothing should be broken
Change-Id: I6b023c04148dc6bdb686199d1891e13fcdc8ffa8
Reviewed-on: https://gerrit.instructure.com/70442
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
fixes CNVS-26796
test plan
- should not be typoed
Change-Id: I6b8629d3245b93a6abf0b8c9bfd6480107f0a0ee
Reviewed-on: https://gerrit.instructure.com/70969
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
fixes: CNVS-26648
test plan:
you should not see "beta" next to the New UI feature option
Change-Id: Ifcac554dc860f5ad4cc9b90f22f1e0eff2b3484a
Reviewed-on: https://gerrit.instructure.com/70725
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Fixes CNVS-26271
Test plan:
- Ensure that the International SMS feature flag is off by
default
- Ensure that you don't have the option to choose a country when
adding an SMS phone number to your profile
Change-Id: I8e536b4252256b4aae299b444511eab7771c3e11
Reviewed-on: https://gerrit.instructure.com/69825
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
test plan:
- ensure the "Moderate Grades" permission is available
- ensure the Moderated Grading assignment setting is available
and persists across course copy
- sanity check the Moderated Grading workflow to ensure all
the pieces are still there
fixes CNVS-25080
Change-Id: I490a837f93b5ca35e57469c4411e09f2eb6f411c
Reviewed-on: https://gerrit.instructure.com/69121
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
enable lti2 for everyone
fixes PLAT-1244 PLAT-1239
test plan:
LTI2 UI feature flag should be gone
Everyone should be able to register an LTI2 tool
the lti2 resource_link_id param should be unique for every lti launch
placment
the lti2 resource_link_id param should be the same on every launch for
the same placement
Change-Id: I41d11faecd43d3b2878deb5d31e5595e2828e69c
Reviewed-on: https://gerrit.instructure.com/68882
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
Fixes CNVS-25597
Test plan:
- Ensure that the two International SMS feature flags are now on
by default on all accounts
Change-Id: I05aa4dc467831b241814d16052d5b8837fe08753
Reviewed-on: https://gerrit.instructure.com/68357
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
hide the gradebook performance flag from
site-admins on production.
closes CNVS-25397
test plan:
- verify the feature flag is still visible
for a site-admin in development and beta
Change-Id: I1981b3f9c6d64e16bb8a749bb1a6dabb0da6378d
Reviewed-on: https://gerrit.instructure.com/67946
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
refs CNVS-24816
create the feature flag and expose it in
the Eportfolios controller
Add a consul docker container to docker-compose.yml,
and a class for consuming settings in consul.
Also, add the ability to init config values
into consul from the consul.yml file
TEST PLAN:
1) edit your consul.yml to look kinda like this:
development:
host: consul
port: 8500
ssl: false
init_values:
rich-content-service:
app-host: rce.docker
cdn-host: rce.docker
2) go to edit an eportfolio as a logged in user
3) check in js console "ENV.RICH_CONTENT_SERVICE_ENABLED"
4) should be "true" or "false" depending on the feature
flag state for that user's root account
5) with the feature flag on, refresh and check the env
6) should have values in the env for
RICH_CONTENT_APP_HOST and RICH_CONTENT_CDN_HOST
Change-Id: Ic138e24416b2aadd965ce4811d3c56538de391bc
Reviewed-on: https://gerrit.instructure.com/66614
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-24729
Test Plan:
- start canvas
- turn on feature flag at course level
- run `bundle exec script/delayed_job run` to start delayed jobs
- generate any notification
- notice it is processed by the service
Change-Id: I6b4258128c7ce815ec3dcd1fec5aca8771fb75ee
Reviewed-on: https://gerrit.instructure.com/67614
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan:
- moderated grading feature is 'on' in feature settings
(not settable)
closes CNVS-25062
Change-Id: I912a5ff13671883589414975c7e13732a9d48e1f
Reviewed-on: https://gerrit.instructure.com/67241
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- anonymous grading feature should be visible in
course feature settings without having been allowed by a
site admin or account admin
closes CNVS-25078
Change-Id: I0644d441ea887e3d2349840b8d4e959b6d20f6be
Reviewed-on: https://gerrit.instructure.com/67245
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-24650
note:
master = http://screencast.com/t/HicaJHIjGe
this commit = http://screencast.com/t/x971tQFPmWY
test plan:
- as a user navigate to the user settings
- scroll down to the "Feature Options" header
- the new experience has the "High Contrast UI" details expanded
by default so the user can see/read what turning on this
feature means
- the text has also been updated so the user understands that
enabling this feature will disable any institute customizations
Change-Id: Ifc6bd36fd1e8bfbed467d0a18f189880bc2d7156
Reviewed-on: https://gerrit.instructure.com/66823
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes CNVS-24733
Test plan:
- Set up config/twilio.yml
- Ensure that your Twilio account owns phone numbers in the U.S.
and phone numbers in at least one other country
- Enable both the "International SMS" and "International SMS -
Send from Recipient's Country" feature flags on the account
you'll be working with
- Add a phone number in the U.S. to your profile
- Cause a notification to be sent to this phone number
- Ensure that the text message you receive is from one of the
U.S. phone numbers
- Add a phone number in a country in which your Twilio account
owns outbound phone numbers to your profile
- Cause a notification to be sent to this phone number
- Ensure that the text message you receive is from one of the
phone numbers in this country
- Add a phone number in a country in which your Twilio account
does not own any outbound numbers
- Cause a notification to be sent to this phone number
- Ensure that the text message you receive is from one of the
U.S. phone numbers
- Disable the "International SMS - Send from Recipient's
Country" feature flag
- Repeat the above steps, but ensure that all text messages to
all phone numbers are sent from a U.S. phone number
Change-Id: I65b4a7c2e201f8afc5e6068ad80a3b4f9ce8710c
Reviewed-on: https://gerrit.instructure.com/66320
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
also lay foundation for new account user search
test plan:
* in development mode, enable the
"Course and User Search" feature flag
* should be able to view the "Search" tab on the
sidebar (may need to resave the account to
clear the sidebar cache)
(replaces the "Courses" and "Users" tabs)
* searching for courses on the account page
should work pretty good
(the people tab is still forthcoming)
closes #CNVS-24750
Change-Id: Id44d1b3c7c36e407339858d2c1657579d1128abc
Reviewed-on: https://gerrit.instructure.com/65268
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
closes CNVS-24685
test plan:
- ensure ePub Exporting is no longer a user level setting
- ePub Exporting should default to 'off' on account level in beta
- when off on account, option should not apepar on course level
- toggle ePub exporting to 'allowed' on account
- should now be able to set setting in course
- toggle ePub exporting to 'on' on account
- should now be locked to 'on' in course
Change-Id: I6a51bd47766edb73f9fa227d89953cea14a9c806
Reviewed-on: https://gerrit.instructure.com/66190
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Add grading period dropdowns on the 'grades' page,
and add a "Display Totals for 'All Grading Periods'"
feature flag. By default, the feature will be turned
'off'.
When the feature is 'off':
- Totals will not display in the gradebook
or the 'student grades' page when the 'All
Grading Periods' option is selected.
- The grading period dropdowns on the 'grades'
page will not have an 'All Grading Periods'
option.
When the feature is 'on':
- Totals will display in the gradebook and the
'student grades' page when the 'All Grading
Periods' option is selected.
- The grading period dropdowns on the 'grades'
page will have an 'All Grading Periods' option.
closes CNVS-23995
test plan:
1) as a teacher, enable the 'multiple grading
periods' feature (do not enable the 'display
totals for all grading periods' feature yet).
a) verify the gradebook does not show totals
when the 'All Grading Periods' option is
selected.
b) verify the 'student grades page'
(courses/4/grades/9#tab-assignments) does
not show totals, and the calculation of
'what-if' grades is disabled when the
'All Grading Periods' option is selected.
c) turn on the 'display totals for all
grading periods' feature. repeat steps
a & b and verify that the totals now
show up (and you can calculate what-if
grades on the student grades page when
'All Grading Periods is selected')
2) sign in as a student that is enrolled in
3 courses: 1 course with MGP disabled, 1
course with MGP enabled and 'display all
grading periods totals' (DAGPT) disabled,
and 1 course with MGP enabled and DAGPT
enabled. go the the 'grades' page (/grades).
a) verify there is a grading period dropdown
next to the totals for courses that have
MGP enabled. verify there is not a grading
period dropdown next to the total for the
course with MGP disabled.
b) verify that the current grading period is
selected by default, if one exists. if a
current grading period does not exist, then:
- the dropdown next to the total for the
course with DAGPT disabled should show
'Select a grading period' and the total
grade should show as '--'.
- the dropdown next to the total for the
course with DAGPT enabled should show
'All Grading Periods' and the total grade
should be displayed.
c) verify clicking a grading period in the
dropdown changes the total, and shows
the correct total for that grading period.
3) repeat steps 2a-c, but sign in as an observer that
is observing at least 3 students in 3 different
courses(1 course with MGP disabled, 1 with MGP
enabled and DAGPT disabled, and 1 course with
MGP enabled + DAGPT enabled).
4) verify that the grading period dropdowns that were
added are accessible.
Note: The 'grades' page (/grades) will _always_
display the total for 'All Grading Periods' when
signed in as a teacher. We are aware of this
existing bug and we're working on a solution.
Change-Id: If501b47aa57121d17d4e6629d1dcdbc8676971a2
Reviewed-on: https://gerrit.instructure.com/65847
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Reviewed-by: Dylan Ross <dross@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
refs: PLAT-1247
test plan:
the feature flag for reregistration should only show for site admins
at the root account level
the api for api/v1/#{context}s/:#{context}_id/lti_apps should have
reregistraation equal true for lti2 tools when the feature flag is enabled
Change-Id: I6a4c2f1deaa4ef8a2448dde374b93b79289ab96c
Reviewed-on: https://gerrit.instructure.com/65739
Tested-by: Jenkins
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
Fixes CNVS-24013
Test plan:
- Run Canvas under a production environment (i.e.
RAILS_ENV=production)
- Log in as a siteadmin
- Ensure that the international SMS feature flag shows up
Change-Id: If8103ec37a514486f9d15b85db1e9333c266bf84
Reviewed-on: https://gerrit.instructure.com/65141
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Scrolling performance was pretty horrendous. Now it's not.
Test plan:
This commit touched a lot of different parts of the react gradebook, so it
basically needs a regression test against how the gradebook was before. Some
examples include:
- Column ordering
- Search for a student functionality
- Filter by grading periods
- Adding new grades
- Editing old grades
fixes CNVS-23053
Change-Id: I0360704f9581775471fc1c0864b7ae863e7a1355
Reviewed-on: https://gerrit.instructure.com/63307
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Cody Poll <cpoll@instructure.com>
fixes CNVS-21793, CNVS-21794, CNVS-21795
- Adds EpubExport model to manage state of generated epubs.
- Adds controller to list, create & show epub exports.
- Adds a mini react app to manage UI for creating epub exports.
- Adds shared ApiProgressBar react comoponent to diplay a progress bar
that polls the progress API.
- Updates ContentExport to have a relationship with EpubExport.
test plan:
- Navigate to `/epub_exports`.
- Observe a list of courses that are active & user is enrolled in.
- Click on the Generate button.
- Observe that info about the state of the export and the timestamp are
added to the middle of the row.
- Observe that a progress bar is displayed while the export is in
progress.
- Observe that upon completion, the progress bar is replaced by two
button / links: Download & Regenerate.
- Observe that Download at the moment does nothing... this is because
the backend is not yet hooked up to generate the epub.
- Observe that the Regenerate button triggers the process all over
again.
Change-Id: I6cd844baa06db0c6648ad19389d235b89659919c
Reviewed-on: https://gerrit.instructure.com/62135
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
closes #CNVS-22745 #CNVS-22790
Change-Id: I7e3287c6e4a55d2f735004b2f58470ec62471e50
Reviewed-on: https://gerrit.instructure.com/62948
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-23267
Test plan:
- As an account admin who is not also a site admin, view the
account's feature flags and make sure that recurring calendar
events does not show up in the list
- As a site admin, view the feature flags again and make sure
that recurring calendar events shows up this time
Change-Id: I881632535e7d295b388c14d84d82246c4d8a38fa
Reviewed-on: https://gerrit.instructure.com/63398
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Fixes CNVS-20605
Test plan:
- Enable the international SMS feature flag
- You can do this from a console with this, assuming your root
account's id is 1:
Account.find(1).enable_feature!(:international_sms)
- As a test user, pull up your settings page
- Under "Other Contacts", click "Add Contact Method"
- Verify that you see two fields, "Country" and "Cell Number"
- Verify that the country names and country codes presented in the
"Country" dropdown are as given in the AC of CNVS-20605
- Click "Reigster SMS" and verify you get a popup saying that
"Country is required"
- Select "Belgium (+32)" from the dropdown
- Verify that no extra fields show up
- Click "Register SMS" and verify that you get a popup saying
that "Cell Number is required"
- Enter "12345", then click "Register SMS"
- Ensure that a box pops up saying that "We sent a four-character
confirmation code to +3212345".
- Close the dialog, then click "Add Contact Method" again
- This time, select "United States (+1)"
- Regression test this part of the dialog - it should work as
it always has
- Regression test adding email addresses via the "Email" tab as
well
- Disable the international SMS feature flag
- You can do this with:
Account.find(1).disable_feature!(:international_sms)
- Regression test both adding email addresses and adding phone
numbers and verify that they work as they did before, with
no mention of the ability to select different countries
Change-Id: I83982d1ee1fc3e22dced29fd28a714333e531899
Reviewed-on: https://gerrit.instructure.com/59811
Reviewed-by: Joel Hough <joel@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
merge the dev/react-gradebook dev branch into
master, and put it behind a feature flag.
closes CNVS-23056
test plan:
go to account settings, and verify the
gradebook performance feature is turned
off. verify no bugs have been introduced
on the current, non-react-gradebook.
Change-Id: Ia1723d14df8bb77f91ffd832b446b0df842ac56e
Reviewed-on: https://gerrit.instructure.com/62978
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
so much ambition; alas you never had a chance
Change-Id: I7b61cdf084d4fbb12b30f0c9ac9078ac5d85e516
Reviewed-on: https://gerrit.instructure.com/62458
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
make it so we can turn on this feature flag for everyone in
production. this means we have to remove the development flag.
closes CNVS-22780
test plan:
- make rails think it's on prod, and not a test cluster
- In the console: Account.site_admin.enable_feature!(:nc_or)
- nc or should be forced on everywhere
Change-Id: I2988b020d619a93052aa0df1e11639cc3d446191
Reviewed-on: https://gerrit.instructure.com/61977
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Willesen <jonw@instructure.com>
fixes CNVS-22005 CNVS-22033 (refs CNVS-19381)
test plan:
- With user calendar do
- a recurring calendar event with 1-90 repeats
- event with no repeats
- With a course calendar do
- repeats with all sections different dates
- repeats with all sections same dates
- all sections different dates no repeats
- all sections same dates no repeats
- regular calendar event with repeats
- regular calendar event with no repeats
- As a teacher, go to the Calendar
- Click the "+" (Create New Event) button
- Add some event details, then check the "Repeat"
checkbox
- Additional fields should appear regarding repeat
information
- Change the repeat fields, then save the event
- The event should create, then the calendar should
reload and show the duplicated events
Change-Id: If8c90870d5c4b885a60810dc18868190a5639a5c
Reviewed-on: https://gerrit.instructure.com/61209
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes CNVS-21535
For now this can just be a plain feature flag because feature
flags implement the "cascading state" functionality we want for
this setting. We can change the UI on this or convert it to a
new type of setting later if we think that's important enough.
test plan:
- Anonymous grading feature flag exists as a feature currently
under development (only visible to site admins until it is
turned on). Nothing else should be affected by this
flag's setting yet.
Change-Id: I5136265cd46af47ea48482b2ab5015112e079557
Reviewed-on: https://gerrit.instructure.com/60871
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
close CNVS-21955
Change-Id: I948446a0a9bf177dcd7fd4a2ce990a50955981de
Reviewed-on: https://gerrit.instructure.com/59396
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes: CNVS-21908
Because of the workflow and tooling some QA people
use, they could not test the new UI because they
had to run in "production" but their portals couldn't.
This also means that it is now visible by non site admins.
So schools can see it and turn it on on their own
Change-Id: Ib3a7a5d00ba3bc6a1680a1528898add81dc165f0
Reviewed-on: https://gerrit.instructure.com/56850
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Was hidden in prod, now hidden in beta.
Change-Id: Ie04bd5034faa1c7b37ce68f09d41d77d0870e7bf
Reviewed-on: https://gerrit.instructure.com/57448
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Minkevitch <dan@instructure.com>
closes CNVS-21036
Test Plan
- As admin go to Settings and find the new styles flag
- Instead of "Use New Styles" the label should now say "New UI"
- The dropdown description should say "This enables an updated
navigation, new dashboard and a simpler, more modern look and feel."
Change-Id: I92cc5a9a4f28bc23f638500cfbbc280550858b47
Reviewed-on: https://gerrit.instructure.com/57000
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
fixes CNVS-21139
Test Plan:
- Go to the feature flags
- Course Catalog should now be Public Course Index
Change-Id: Icdced7ef68a279f9d8e9fedd5ba3b9feb60f04ae
Reviewed-on: https://gerrit.instructure.com/57058
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Should I use BambooTree or not?
closes CNVS-21099
Test Plan:
- Not much to QA here.
Change-Id: Ice5769c119b0f533a51cf2712acef34a2727c41a
Reviewed-on: https://gerrit.instructure.com/56456
Tested-by: Jenkins
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
...so it is impossible to turn on in production.
With this set, you can only turn it on in
development / test / beta instances. Even though
it is already marked "beta", without this, a csm
could technically still turn it on for a customer
even though we clearly told them not to.
closes: CNVS-21233
Change-Id: Icb86594d052effde1abdc8d5e3732375b801cb27
Reviewed-on: https://gerrit.instructure.com/56433
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
also adds a feature flag for bulk sis grade export
test plan:
* enable the bulk sis grade export flag
* teachers should be able to mark assignments
as postable to SIS (same as if the
"Post Grades to SIS" flag is enabled)
* should be able to reach the API GET endpoint
(should be documented under the SIS Integration category)
/api/sis/grade_export/accounts/:account_id/assignments
* this should return a list of course and assignment ids
corresponding to the assignments with this checkbox marked
closes #SIS-1058
Change-Id: Ic1017d494ead63f1c9433f1cda93bc3c6ca4580c
Reviewed-on: https://gerrit.instructure.com/54418
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan: new files should be enabled everywhere
and should be locked in the feature settings UI
(can't be turned off)
closes CNVS-20656
Change-Id: I3a5b361deeb90780c899eaa3a84bf1eecfec2bbf
Reviewed-on: https://gerrit.instructure.com/55010
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes PLAT-1022
Test Plan
- Turn on the 'Don't move LTI query params to POST body' feature flag in the root account
- Launch a tool with a query string in the URL
- make sure the query params are not copied to the POST body
Change-Id: Ie3446086d5caa957558e0dafa1cec992934d48e8
Reviewed-on: https://gerrit.instructure.com/54399
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
test plan:
0. enable "better file browsing" and "usage rights required"
in a course
1. upload and expand a zip file and confirm the files are
unpublished initially
2. confirm that a file imported from an imscc package is
(a) unpublished in the new course if no usage rights
were set in the source course, regardless of whether
the file was published in the source course
(b) unpublished in the new course if it was unpublished
in the source course, regardless of whether usage
rights were set in the source course
(c) published in the new course if it was published in
the source course and had usage rights set.
3. repeat step 2, but with course copy instead
fixes CNVS-19620
Change-Id: I9a32adeafb94e4922ba95ad6466c72aca3fd3598
Reviewed-on: https://gerrit.instructure.com/52465
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
make the grading periods feature flag a course level flag, and also
'unlock' the account level grading periods. now, a teacher can edit
account level periods, but when they click 'save' it will create
a new course-level grading period instead of altering the original
account-level period. also added a link to the feature flag settings
page if there is only one grading period on the page. in addition,
if only template periods are being shown on the page and you're
logged in as a teacher, added a message that notifies the user
that the periods were created by an administrator for them.
closes CNVS-18741
closes CNVS-19692
test plan:
this commit makes substantial changes to the way grading periods are
being displayed, deleted, and saved on the
'accounts/:account_id/grading_standards' page and the
'courses/:course_id/grading_standards' page. users should still be able
to create/update/delete grading periods without problems on those pages.
in addition, this commit makes changes to the feature flag settings pages
for admins and teachers. make sure the feature flags are working correctly
(try setting the MGP flag to 'on', 'off', and 'allow' as an admin and see
how it affects the feature flag options for sub-accounts and teachers).
Change-Id: I0b442e708a8049180b55a86098e30a2c64673eda
Reviewed-on: https://gerrit.instructure.com/51594
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
closes CNVS-19377
test plan:
- verify that there is a new feature flag named "Quiz LTI plugin"
that must be allowed from the root account, but can be switched
on or off on the course
Change-Id: I42870d920f93667ef9f147a64b0e06990d5f3b90
Reviewed-on: https://gerrit.instructure.com/50592
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
- enable "Require Usage Rights" but disable "Better File Browsing"
and ensure files uploaded to the files page via the upload button,
drag/drop, and wiki sidebar are not locked by default
- enable both features and confirm that the usage rights requirement
is enforced before files can be published (whether they are
uploaded via files page upload button, drag/drop, or wiki sidebar)
fixes CNVS-18979
Change-Id: Iba09c672f6cb7b9e1518942ef95be14170d82fcb
Reviewed-on: https://gerrit.instructure.com/49799
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Ethan Vizitei