also made it use a token in the url instead of only
working for assignment launches
Testplan:
* Install the test lti app http://lti-tool-provider.herokuapp.com/
* launch it as a student and click the xapi link in the app
* the page view count for that student should increment in the
analytics UI
(note, that UI is heavily cached, you may need to clear redis
to see the latest number)
Change-Id: I4fd1ff8201a2a11c654d789bfcd61e7cf44f3c7f
Reviewed-on: https://gerrit.instructure.com/42818
Reviewed-by: Braden Anderson <braden@instructure.com>
Product-Review: Braden Anderson <braden@instructure.com>
QA-Review: Braden Anderson <braden@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
react-router wasn't correctly firing the
route handler in IE10, resulting in a blank
page. This fixes that by updating react-router
to the newest version. Note that some of the
functionality is currently broken in IE,
such as styles and the FolderTree. Let's
do a run through of IE now that it's rendering
and make tickets of whatever is left to be fixed.
fixes CNVS-15930
test plan:
* Enable "Better File Browsing" feature flag
* Navigate to any course's Files tab in IE10
* The FilesApp should render and be semi-functional
Change-Id: I52e4ca73ace6ca0dec6b26a76c1a3cfa51e5d128
Reviewed-on: https://gerrit.instructure.com/42453
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
test plan:
* play Minecraft
* look at your user's most recent page view and asset access
* verify that entries were added for the LTI tool
Change-Id: I422a188ed80cbedbaa8b4ecafcb3262c6f2d1e14
Reviewed-on: https://gerrit.instructure.com/42783
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Braden Anderson <braden@instructure.com>
test plan:
* create a course with a graded discussion with an
upcoming due date
* confirm that the gear menu on the index no longer
has an option to "Close for comments" (that didn't work)
* confirm that dragging the discussion into the
"Closed for Comments" group does not let you
drop it in
closes #CNVS-16029
Change-Id: I50c21fc528409c4d5e90344149d751ff25f86389
Reviewed-on: https://gerrit.instructure.com/42720
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
fixes CNVS-16263
this was causing database contention and deadlocks when many submissions for
a single assignment with several graders were updated at the same time.
test plan:
* with the rails cache enabled,
create a course with an assignment and a student
* submit an assignment as the student
* as the teacher for the course, make sure the
assignment shows up in the to-do list on the
dashboard page
* verify that grading the submission updates the
to-do list right away
Change-Id: I7ba30223d0099ce36007185008937fbb3ab498bd
Reviewed-on: https://gerrit.instructure.com/42735
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-16237
test plan:
* open calendar as a student
* verify that assignments you have submitted are marked
* open calendar as a grader
* verify that past due assignments with no ungraded submissions are marked
Change-Id: Ie84c436c49feab94d5c896ab0c79306013c75185
Reviewed-on: https://gerrit.instructure.com/42759
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
ruby 2.1 defaults to utf-8 for string literals, where 1.9 defaulted to
binary, so these tests need to explicitly force binary for 2.1
compatibility.
This change should only be necessary in the specs, the encoding of the
body strings coming from real data won't change with 2.1, since they
aren't string literals.
fixes CNVS-16261
Change-Id: Ifd127d077e47ab56b76620ef0974932563826cc2
Reviewed-on: https://gerrit.instructure.com/42734
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
as of https://gerrit.instructure.com/#/c/42692/ this is no longer used.
not having to support it makes i18nliner integration a tad easier.
test plan:
1. n/a, this is unused code. specs should pass
Change-Id: I2dea51f140b9c97d3b8b2418613539c967c3a868
Reviewed-on: https://gerrit.instructure.com/42693
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
refs CNVS-16237
test plan:
* open your browser console
* load the calendar
* open the type=assignment API request
* verify that each assignment returned has user_submitted
(on the inner assignment hash)
* verify that user_submitted corresponds to having a submission
Change-Id: I41f99d3239e040fd6775f13aea88f4ce50b3b33e
Reviewed-on: https://gerrit.instructure.com/42747
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Braden Anderson <braden@instructure.com>
closes CNVS-15879
Test Plan:
- Add a bunch of files of different types
- Go to file preview and look at the preview of these files
- More than just images should be displayed.
Change-Id: I31412c950214b87ddfe3b92f4f94e501315996d0
Reviewed-on: https://gerrit.instructure.com/42603
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
0. upload the following types of files into a course, and
note their IDs:
a) document of some type (such as Word, PDF)
b) image (such as JPEG, PNG, GIF)
c) media (such as MP3, MP4, MOV)
1. enable canvadocs and google docs previews in account
settings.
2. test the document preview by hitting the following
in a new browser tab:
/courses/X/files/Y/file_preview
(where X is the course ID and Y is the file ID
of the document file)
- You should see a Canvadocs preview of the document.
- There should be no Canvas chrome in the window, just
the document preview.
3. disable canvadocs but leave google doc previews
enabled.
4. hit the URL from step 2.
- you should see a Google preview of the document
5. disable Google docs previews.
6. hit the URL from step 2.
- you should see a message indicating that no preview is
available, with a link to download the file.
7. hit the URL from step 2, but substitute the file ID
with the ID of an image instead of a document.
- you should see the image (and nothing else).
8. hit the URL from step 2, but substitute the file ID
with the ID of a media file.
- You should see a functioning media player (or a message
indicating the media has not been converted yet)
9. add a document to a module, and set a "must view"
completion requirement
10. use this endpoint to preview the document, and confirm
that the module completion requirement is fulfilled
fixes CNVS-15827
Change-Id: Id0ecaa7f003248cb3d8f163e48c3b16631ee59cf
Reviewed-on: https://gerrit.instructure.com/42438
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Fixes QA-550
Double gets removed when we include mocha in spec_helper.rb
This was passing when run alone because it doesn't inclue spec_helper
itself. But when run in a group with other specs that do, this is
failing.
Test plan:
Ensure both of these commands pass:
`bundle exec rspec spec/models/group_categories/params_policy_spec.rb:19
spec/models/course_spec.rb:1159`
`bundle exec rspec
spec/models/group_categories/params_policy_spec.rb:19`
Change-Id: Ibff95506a3afd72b4f817567f801434d7f29f68a
Reviewed-on: https://gerrit.instructure.com/42656
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Shawn Meredith <shawn@instructure.com>
create_group_count was not being reset after a successful sync
Fixes CNVS-15204
Test Plan:
- I- n a course, open the new group set dialog
- Check allow self sign-up, enter a number for groups to create now
- Save the group set.
- Click the gear to edit the group set.
- Save the group set.
- Refresh the page.
- Note the duplicated groups in the set.
Change-Id: I493c1980dab4d15ce3a6a39b0c469e6c9bd39a28
Reviewed-on: https://gerrit.instructure.com/42582
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Braden Anderson