fixes: CNVS-34727
this will make webpack faster because it cuts down
the number of files it has to look for when
it looks a module up. right now, every time
someone asked for a app/jsx/whatever.jsx file
it had to do a stat for app/jsx/whatever.js first
and then look for app/jsx/whatever.jsx. it also
slows every lookup for handlebars/coffescript files
since it has to look for the jsx first
this was just the result of running this command:
find . -type f -name "*.jsx" | while read FNAME; do git mv "$FNAME" "${FNAME//.jsx/.js}"; done
test plan:
* automated specs should pass
* webpack build should run faster than the patchset
before this one
Change-Id: Ia15ded6dc2b09c10c4f9070edcee9305b5b429ad
Reviewed-on: https://gerrit.instructure.com/101005
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-31785
test plan:
all builds should pass
Change-Id: I2925934692a3d2f115f1289d7b50cb72d8cb907f
Reviewed-on: https://gerrit.instructure.com/104492
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes: CNVS-35496
Test plan:
cd client_apps/canvas_quizzes && script/test
should work
Change-Id: I860c1a459785db6d5a5e77d904083c9b02655b0a
Reviewed-on: https://gerrit.instructure.com/104545
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Closes: CNVS-35152
This changes all our tooling that used `npm` to
Run scripts to use `yarn`. `npm` will still work
for now but if you have yarn installed, it will use
that.
Cheat Sheet:
old command -> new command
npm install -> yarn install (or just `yarn`)
npm run webpack -> yarn run webpack
npm test -> yarn test
See more at https://yarnpkg.com
Test plan:
* all Jenkins builds should pass
* without yarn installed:
* run script/nuke_node.sh
* it should work and warn you about how `npm` is deprecated
* now install yarn, e.g.: `brew install yarn`
* run script/nuke_node.sh again
* it should work and you should see silly yarn emoji
in the output and it should be a lot faster
* the docker changes I made should work and docker should
build correctly and use yarn.
Change-Id: I4aa31eeae3ecc504634a7c72a1ea0d3396f445e3
Reviewed-on: https://gerrit.instructure.com/102969
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-31091
test plan:
- Create 10+ Sections in a course
- Create a Quiz and have a few students take the Quiz
- go to the Quiz Statistics and notice the "Section Filter"
- when selected it should show all the Sections in the course
Change-Id: I110f4449b28b79b32708c74293a2d6b48b16b87c
Reviewed-on: https://gerrit.instructure.com/101121
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
test plan:
run:
* compile assets
* node client_apps/canvas_quizzes/script/test
* it should work
Change-Id: I5cc90f124b688d1cc67ab8acc90138ca7a50fdf2
Reviewed-on: https://gerrit.instructure.com/102167
Reviewed-by: Han Yan <hyan@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-30123
test plan:
- message should hide after it is not focused
- message should look like other accessibility messages
- wording should be changed, as described in the ticket
Change-Id: I52d7146f9d1a2c7390263297c05b48e7a3fb6bfe
Reviewed-on: https://gerrit.instructure.com/100506
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Cemal Aktas <caktas@instructure.com>
Product-Review: John Corrigan <jcorrigan@instructure.com>
This is a combination of 3 commits.
The first commit's message is:
fix quiz log auditing build in webpack
fixes: CNVS-33125
test plan:
* webpack aux build & selenium should pass
* enable the quiz log auditing feature flag
* go to the quiz log audit page:
eg: http://c.dev/courses/1/quizzes/2/submissions/1/log
* make sure the page loads without any script errors
This is the 2nd commit message:
fix webpack build of ember screenreader gradebook
fixes: CNVS-33051
test plan:
* tests should pass, both in webpack and requireJS
* in both webpack and requireJS
* go to the the screenreader gradebook page
* it should load without errors
This is the 3rd commit message:
fix js tests in webpack
Change-Id: I75e2d3d8ec3c817d5ac7d4aade5204f9a6016c10
Reviewed-on: https://gerrit.instructure.com/94497
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
refs: CNVS-31785
test plan:
the client_apps should work when using webpack
Change-Id: I086bfb35bdc56c2677bd262112495429f57ac087
Reviewed-on: https://gerrit.instructure.com/93223
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-31787
the only things left in bower are things that
are just not avalable on npm because they are so old.
we'll have to continue using the bower versions of them,
but it's ok since they are mostly old ember stuff
that will be ripped out when we finish our react screenreader gradebook
also:
remove some ember stuff that wasn't being used anymore.
nothing was using this stuff
test plan:
this really does touch a lot of stuff. some things
to check out specifically in the prod/optimized requireJS build:
(load the page, click around to make sure things work)
the screenreader gradebook
client_apps:
quiz statistics
quiz event logging
creating a new student group
calendar, try all the views (month/agenda/etc)
gradebook 2
turn on the new course/user search feature for your account
and go to accounts/x and search for a user/course
the new react gradebook
use tinymce on a page, make sure that both the service
and local version of it work
Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8
Reviewed-on: https://gerrit.instructure.com/93102
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-32673
test plan:
- compile assets and click around
- enable high contrast
- it should all still work the same
Change-Id: I1bd0f100605d43330af57a4af966e37ec0a8a314
Reviewed-on: https://gerrit.instructure.com/92858
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-31803
test plan:
- take a quiz with several students
and get different scores
- go to the quiz statistics page
- with a screenreader go to the chart
showing the breakdown of scores
by percentile
- you get a description of the bars
in the screenreader (X students in
percentile Y)
Change-Id: I100577687058d27a9921773e81edc64b3cf1cb87
Reviewed-on: https://gerrit.instructure.com/90642
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
closes: CNVS-30472
since client_apps/canvas_quizzes is the only
thing that cares about our old version of
react and react-router, this moves them out
of canvas and into canvas_quizzes so it is the
only one that can use them. This simplifies
things in canvas so no one ever tries to
use them going forward.
test plan:
* inside of client_apps/canvas_quzzes
run: `script/build && grunt test`
* it should pass jenkins
* click around in the quiz stats and quiz log
auditing apps to make sure they still load
mv old_unsupported
Change-Id: I56eadedfe2417f32f2afb99ec76a21870871ad7e
WIP move "old_unsupported_react" to client_apps
Change-Id: I673321b51db9b197a298ccb831c417e902aaae28
Reviewed-on: https://gerrit.instructure.com/85483
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This keeps quiz_statistics using the underscore compatible
version of lodash 2.4.1 in which exists _.findWhere rather than
using the new 4.x version of lodash recently added.
closes CNVS-30750
Test Plan:
- Post-merge and silent patchset builds for selenium webpack pass
Change-Id: I4f63aa431e29b77dd46dad4a9828afe10e84ef85
Reviewed-on: https://gerrit.instructure.com/86007
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
closes: CNVS-30448
in order to get node 6 to build and run on jenkins,
we have to upgrade grunt-contrib-jasmine to work
around this bug: https://github.com/Medium/phantomjs/issues/430
and we have to upgrade gulp-sass so the node-sass
version it asks for is node-sass@3.8.0 to get it to
actually build on jenkins. as in, so there
is a precompiled binary for it that is compiled
against the v8 in node 6. (there are none for 0.9.3
against node 6, since node 6 didn't exist when 0.9.3
was released). This is necessary because
the gcc on jenkins is too old to compile node-sass
from source.
test plan:
* quzzes jenkins build should pass
* click around in quiz stats and quiz log auditing
to make sure things load
Change-Id: Ic56fae34c52aab5d9b7971fe871d04fcc0738206
Reviewed-on: https://gerrit.instructure.com/85389
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-30446
test plan:
canvas_quizzes build should pass in jenkins
if you want to test locally,
run `grunt test` inside the client_apps/canvas_quizzes folder
Change-Id: I9a34e2edf134074b29f3481e6413433e48e03b57
Reviewed-on: https://gerrit.instructure.com/85343
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-29785
the newest versions of node-sass do not allow
@import inside an @if
also, this:
@if something { $foo: 'bar'}
@else { $foo: 'baz'}
// on this line foo is not supposed to exist,
//but it erroneously did in old node-sass and we relied on it
this blocks us from upgrading to node 6 because the
gcc on the jenkins and job boxes is to old to compile
node-sass 3.4 from source against the v8 in node 6. but
there are prebuilt binaries it can use for node-sass
3.7+, so it doesn't need to compile from source
test plan
* check out this commit
* compile assets
* it should work
* the css it outputs should be exactly the same as before
Change-Id: I797ce68ecc82566401076771784c8be590233e27
Reviewed-on: https://gerrit.instructure.com/81513
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-28202
There weren't enough labels and descriptions for graphs and tabels on
the quiz stats page. This add's those things in.
Test Plan
Given you're using a screen reader
And you have a test that has been taken by someone in your class
And you're on the quiz stats page
ie: http://canvas.docker/courses/1/quizzes/3/statistics
When you navigate to the 'Question Breakdown' section
And you navigate over the correct answer table
Then you should be read the correct answer
And it should be followed by the words 'Corret answer'
When you navigate over an incorrect answer
Then it should read the incorrect answer
And it should be followed by the words 'Incorrect answer'
Change-Id: I47f7d8a1cf776ccc026b829b29b0c94d773f233b
Reviewed-on: https://gerrit.instructure.com/77293
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
fixes CNVS-25735
perviously when you navigated across the report buttons it was weird
for sighted users because there were tab indexes that forces focusing
on divs that shouldn't have had tab index on them. This commit does two
things
1. Removes tab indexes that are not needed so sighted users can easily
navigate the page.
2. Add a better screenreader only description that describes the
download button with other content. Using describedby was not the right
path here since its suppose to be used as a generate descriptor ie:
"buttons to download content" but thats redudent since the label
already implies that. The right path is to ensure the screnreader
content had the right information in it, which gets read by the
screenreader just fine.
Test Plan
Given I've created a course
And I'm using a screenreader
And I have access to the statistics page
(http://canvas.docker/courses/1/quizzes/1/statistics)
And I load the page
When I navigate over the 'Student Analysis' button
Then I hear text about downloading a report
And I should hear text about when the report was generated
When when I navigate over the 'Item Analysis' button
Then I hear text about downloading a report
And I should hear text about when the report was generated
Given I've created a course
And I'm NOT using a screenreader
And I'm only using the keyboard to navigate
And I have access to the statistics page
(http://canvas.docker/courses/1/quizzes/1/statistics)
And I load the page
When I navigate over the 'Student Analysis' button
Then I tab again
I should go to the next button immediately
Change-Id: I358783dbeae0981d8e70ed6e7e885603fa77c39e
Reviewed-on: https://gerrit.instructure.com/76778
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
This enables us to turn on the client_apps jenkins build for all canvas
commits and catch breaking changes a bit more often.
Closes CNVS-28262
Test Plan:
- Confirm that quiz log auditing and quiz statistics are fully
functional
Change-Id: I3b07679e7ce44191b672bc7f8a1220e69fc0d600
Reviewed-on: https://gerrit.instructure.com/75223
Tested-by: Jenkins
Reviewed-by: Chris Wang <cwang@instructure.com>
Product-Review: Chris Wang <cwang@instructure.com>
QA-Review: Chris Wang <cwang@instructure.com>
According to https://github.com/es-shims/es5-shim/issues/280
4.0.5 is almost identical and includes proper minified versions
that 4.0.3 should have included.
This isn't the best solution, but should unbreak our builds
for the time being. Ideally we should re-shrinkwrap this
with proper versions, but it seems there are some issues
doing that at this point. This should be a good stopgap.
fixes gh-791
Change-Id: Id56cff056a025ac8dbf69e6b6d216bc644ed73b6
Reviewed-on: https://gerrit.instructure.com/75059
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Cody Cutrer <cody@instructure.com>
This adds the ability to see the breakdown of grades for
essay/file-upload question types. They are broken up as the top 27%,
the bottom 27%, the middle 46%, and any ungraded answers, then displayed
in table format.
Refs CNVS-25737
Closes CNVS-26756
Test Plan:
- Check that essay+file_upload question type tables look good
- Buckets show themselves as "correct" if they contain a student
score >= to the question points possible
- Buckets can contain more students than 27% if the scores are
identical (All 100% scores show up in top bucket/middle bucket
even if 100% are 100% scores)
- New answer tables are accessible like other tables
- Buckets are explicitly ordered as top, middle, bottom, ungraded
Change-Id: I62798938b9176de97df2e498a2f9b3b02a81086c
Reviewed-on: https://gerrit.instructure.com/70907
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
This rearranges and redefines much of the user experience on this page.
The score distribution chart is now rendered in HTML from React. Other
charts on the page have been rearranged or tweaked to match the new UI
design.
The new table contains all the screenreader data required, there are no
longer tooltips to be rendered on each score column (now a horizontal bar).
The bar chart is not read to screenreaders.
The bar chart indicates correctness by more than color alone.
The donut chart contains "N% responded correctly" in the center
The donut chart is not read by screenreaders, other than a brief
explanatory message.
Closes CNVS-25737
Closes CNVS-25738
Test Plan:
- Full test of quiz stats for both a11y and basic functionality
- Confirm that webpack and require_js builds are working
- Make sure it looks good!
Change-Id: Ie3f1a2ae99e7b2eea56e97e1cb5b6d3f51b83792
Reviewed-on: https://gerrit.instructure.com/70164
Tested-by: Jenkins
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-25736
test plan:
- Go to quiz statistics page
- Access summary graph via keyboard
- Ensure that KO users do not have less functionality than other
users with the graph
- Ensure that y-axis correctly demonstrates the data presented
Change-Id: Ib971a9e4061f65562f21ef60796afdc046224b89
Reviewed-on: https://gerrit.instructure.com/70073
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-25739
test plan:
- Go to a quiz's stats page
- Try to access a question's "Learn More About Discrimination Index"
via the keyboard
- Test on all supported browsers (initially failed on IE)
Change-Id: Id18207cb85272ed3df05662285f2804a8f451624
Reviewed-on: https://gerrit.instructure.com/69817
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
refs CNVS-25916
remove dynamic requirements for env configs,
use separate jsx loader for client apps,
update client app plugin to use old react version,
rewrite selenium spec to be an integration test
rather than executing arbitrary javascript,
and MAJORLY refactor loading patterns of client apps
to avoid sharing code with differences delineated
by opaque require re-writes.
Also moved some code that was in "common" client
app but only used by one actual client app down
into the app that uses it (simplifies dependency
tracing).
TEST PLAN:
1) make sure quiz statistics still works ok under
require js build, no behavior should have changed
2) also make sure quiz log auding works under require-js
Change-Id: I0e5ee3eda9da16e0ad48cf858761735c71df801c
Reviewed-on: https://gerrit.instructure.com/69804
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-24633
test plan:
1. Statistics
- answer an anonymous survey as a student
- as a teacher go to the quiz statistics page and expand the questions
- ensure that none of the questions have the student's name on them
2. Submissions
- answer an anonymous survey as a student
- as a teacher go to:
/courses/:course_id/assignment/:assignment_id/submissions/:student_id
- should get "This student's responses are hidden because this
assignment is anonymous." message
Change-Id: I94e08d0ad1293240ac9722a94d3365ed53ca5f7d
Reviewed-on: https://gerrit.instructure.com/67629
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
in gerrit 58962 also added minor ui tweeks
Fixes: PFS-2226
Change-Id: I665deca873c2d5f5975a59f5551c1a449d138d2d
Testcase: Verify that tab order is still correct with the change.
Reviewed-on: https://gerrit.instructure.com/63912
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
Fixes: CNVS-23629
Test Plan:
- as an admin using the new or old UI
- ensure you have the "Quiz Log Auditing" feature allowed at the
highest account level under >Settings >Feature Options
- also ensure you have "Quiz Log Auditing" turned on for the
account the quiz will be conducted in
- navigate to a course with a quiz *or* create a short quiz
- once it has been taken/submitted/attempted you should see a
# Attempt so far / View Previous Attempts on the right-hand
area
- click the "View Previous Attempts" from this screen click the
"View Log" inspect the number with the dark background following
the Attempt label (it should now be filled with #333 vs the orig
#34444f)
Change-Id: Ia1072af666f399f2cf8d0995231ca7206e9ae829
Reviewed-on: https://gerrit.instructure.com/64124
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
test case:
1. Create a Quiz with a question for each type.
2. Add at a few users to the course.
3. Create student submissions for the quiz with varying responses
4. When you log in as a teacher navigate to that quizzes statistics,
and click on the expansion button for a question.
5. Click on the response ratio for that question and a modal will show
displaying all the users that have responded to that question.
Change-Id: I5e23b42f6982683902124d734c36eedb9c5da7f7
Fixes: PFS-2227
Reviewed-on: https://gerrit.instructure.com/59720
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
closes PFS-2226
Tests:
1. Create a course with two or more sections
2. Create a Quiz with submissions.
3. with student A submit a submission to the quiz in the first section
4. With Student B submit a submittion to the quiz in the second section
5. As a teacher navigate to the quiz statistics section and view the
results
6. By default all submission will show, once you select a section only
that sections results will show.
Change-Id: Ifd32bbfb67068008f008b8323a10b9ea18a67468
Reviewed-on: https://gerrit.instructure.com/58962
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
added these files included by timezone_core recently; apparently they
need to be whitelisted
Change-Id: I529975dc7da25a9e2cb5c3a9d095796e30d0f6c7
test-plan: `grunt test` works for canvas_quizzes
Reviewed-on: https://gerrit.instructure.com/61094
Reviewed-by: Kacey Roberts <kroberts@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Closes CNVS-21946
Test plan:
- Write a long essay into an essay quiz question. Never delete
anything, just keep writing and writing.
- Confirm that the quiz log audit shows a growing and growing answer
(when you've clicked on the "#1" question inspection button).
Change-Id: I3c3c854418921df61d7529d9c5b702eeda93ab56
Reviewed-on: https://gerrit.instructure.com/58732
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nick Nelson <nick@instructure.com>
fixes CNVS-21052
test plan:
- the event log page for a quiz submission
loads properly
- /courses/:c_id/quizzes/:q_id/submissions/:qs_id/log
Change-Id: I7605aaddcbe179841c44396f4839b901054fceb6
Reviewed-on: https://gerrit.instructure.com/56957
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
This helps with grep and some IDEs which can't handle infinite directory
structures.
Test Plan:
- Confirm that the quiz statistics and quiz event logs still work as
awesome as ever, nay awesomer.
Change-Id: Ibbcdafac17ffff3c06c82666b5edbc695760abca
Reviewed-on: https://gerrit.instructure.com/54385
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Test Plan:
- If it passed Jenkins, it is good.
Change-Id: I16d10300bf21a6d97f5520075230cdf66abcca4e
Reviewed-on: https://gerrit.instructure.com/57286
Tested-by: Jenkins
Product-Review: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Every time we add an event type, we get a blank bar on the event log.
This ticket defaults to ignoring events which we are explicitly
handling.
Closes CNVS-21195
Test Plan:
- View the QLA log view for any recently completed quiz submission
and see that there are no blanks anymore.
Change-Id: I11d3b2cb315fa6d884c12633ece10119802f3b83
Reviewed-on: https://gerrit.instructure.com/56833
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
Closes CNVS-21327
Test Plan:
- Passes Jenkins.
Change-Id: I6321723220904a77aad14fe3460dce3a3c429daf
Reviewed-on: https://gerrit.instructure.com/56793
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Ryan Taylor <rtaylor@instructure.com>
When viewing QLA for multiple attempts, the current attempt is no
longer a link.
Closes CNVS-18363
Test Plan:
- Confirm that screenreader now identifies the current attempt when
viewing a QLA recorded set of quiz attempts.
Change-Id: I9d68b2354447ea453c1513b07f6c082d32cfef0b
Reviewed-on: https://gerrit.instructure.com/49784
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
MultipleAnswersQuestions were being interrogated for participant counts
which counted each student mutliple times.
Closes CNVS-18499
Test Plan:
- Build a quiz with various question types
- Take the quiz 5 times
- Confirm that each question has 5 attempts.
Change-Id: I9c60d5c15f55b3519387e97a595ab659d2ac9d70
Reviewed-on: https://gerrit.instructure.com/49780
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Indicates both positive and negative with respect to the threshold and
now indicates + and - with respect to 0 (like numbers should)
independently.
Closes CNVS-18382
Test Plan:
- Create student responses for a quiz to create a discrimination index
of 0.25>x>0.0 and 0.0>x for two questions
- See that discrimination index shows red and positive, and red and
negative respectively, rather than being red and negative and red
and negative as was reported.
Change-Id: Iebd1eae671d2c7738069728714e934aea10aa717
Reviewed-on: https://gerrit.instructure.com/49384
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
fixes: CNVS-18615
This changes our $canvas- color variables to use the prefix $ic-brand
or $ic-color, based on whether it will be used in the theme editor
or not.
Variable Changes:
$canvas-primary --> $ic-brand-primary
$canvas-secondary --> $ic-brand-secondary
$canvas-success --> $ic-color-success
$canvas-neutral --> $ic-color-neutral
$canvas-action --> $ic-color-action
$canvas-danger --> $ic-color-danger
$canvas-alert --> $ic-color-alert
$canvas-light --> $ic-color-light
$canvas-dark --> $ic-color-dark
Test Plan:
- CSS should compile successfully
- on /styleguide under Styles > Colors, the first two colors in both
normal contrast and high contrast should now read, "Brand Primary"
and "Brand Secondary"
Change-Id: I3bce89f008db06232d9ff4bf49227aabf573b4a6
Reviewed-on: https://gerrit.instructure.com/48916
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
fixes: CNVS-18517
refs: CNVS-17332
This creates consistency in our naming schema on variables.
- base- and can- variables now have the prefix ic-
- where these variables were being used in our stylesheets has been
updated with the new name
- note: content doesn't change with this. just variable names.
Test Plan:
- CSS should compile successfully
- Front-end facing content doesn't change
Change-Id: Ie3f169be27b9cd4c4158ec467de7bec0cb2de680
Reviewed-on: https://gerrit.instructure.com/48757
Reviewed-by: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Fixes CNVS-18336
Test plan:
- Visit a quiz log page
- Navigate through the table via screen reader table navigation commands and
verify that each non-header cell is read together with its proper header.
Change-Id: I802d3e370b933cae87107678f5c8295b703f2a45
Reviewed-on: https://gerrit.instructure.com/48656
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
In QLA when a question has recorded a null answer, these events are
shown in the stream as if they were real answers. This prevents those
from showing.
Closes CNVS-17862
Test Plan:
- Attempt a quiz and leave many answers blank.
- Confirm that the only answers which are shown have valid answers
- Confirm that null answer events are still recorded in the individual
question records.
Change-Id: I5efafa1e5b7c39dbe4cbc97ad5c6be6470f4efd1
Reviewed-on: https://gerrit.instructure.com/48610
Tested-by: Jenkins
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Fixes header problems, and accessibility warnings for the inaccessible
table view.
Closes CNVS-18364, CNVS-18361
Test-Plan:
- Check heading levels
- Confirm the presence of a warning visible/audible next to the "View Table"
button.
Change-Id: I7c9cada26a62648b2fca52240b19a66492ad737f
Reviewed-on: https://gerrit.instructure.com/48756
QA-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
fixes: CNVS-18337
This edits the colors on toggle for attempts on the Quiz Log.
It should now be passing contrast.
Test Plan:
- Make sure Quiz Log Auditing feature is turned on
- Go to a quiz that has been completed by a student
- Go to Moderate Quiz
- Choose a student and then go to View Log
- The Attempts toggle should now be passing contrast ratio
requirements
Change-Id: Id2b1a1a6d7c61ed827d4f4bb7e1f5cd9ebfe8e0f
Reviewed-on: https://gerrit.instructure.com/48658
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Specs are failing, based on config problems.
The screen-reader only jump to content is broken due to the way that
react-router modifies the URL.
Closes CNVS-18335
Test-plan:
- Confirm that all QLA events pages/links are still functioning
properly
- Test screenreader "Skip to Content" button for proper functionality
Change-Id: I3f1c01297d4c960688be0ac3d803e437d10c838e
Reviewed-on: https://gerrit.instructure.com/48381
QA-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
closes: CNVS-18177
this commit just changes our bower version of react
and react-router to the latest and copies the
current versions we are using to
old_unsupported_dot_use_react.js ant
old_unsupported_dot_use_react-router.js
...and then points everyone's existing code to those
old versions, so that nothing actually changes.
but if you require 'react' or 'react-router' you will
now get the new version.
each team can now take the time to update their own code
to the new versions and when no one is using either
of these 2 old libraries we can delete them.
test plan:
poke around in newfiles, the course wizard,
the external_apps app, quiz-statistics and make
sure they still work. nothing should actually change
Change-Id: I99a3526a740ac82f350bb6dd1fd4f25e4fd92483
Reviewed-on: https://gerrit.instructure.com/47625
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Ryan Shaw